[GitHub] spark issue #20633: [SPARK-23455][ML] Default Params in ML should be saved s...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20633 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1308/

[GitHub] spark issue #20633: [SPARK-23455][ML] Default Params in ML should be saved s...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20633 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20633: [SPARK-23455][ML] Default Params in ML should be saved s...

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20633 **[Test build #87996 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87996/testReport)** for PR 20633 at commit

[GitHub] spark issue #20745: [SPARK-23288][SS] Fix output metrics with parquet sink

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20745 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87992/ Test PASSed. ---

[GitHub] spark issue #20745: [SPARK-23288][SS] Fix output metrics with parquet sink

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20745 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20745: [SPARK-23288][SS] Fix output metrics with parquet sink

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20745 **[Test build #87992 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87992/testReport)** for PR 20745 at commit

[GitHub] spark issue #20433: [SPARK-23264][SQL] Support interval values without INTER...

2018-03-05 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20433 You meant the HIVE jira? If so, no (I was going to check now). Any point I should know? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20659: [DNM] Try to update Hive to 2.3.2

2018-03-05 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/20659 Yes, I'm doing it --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20433: [SPARK-23264][SQL] Support interval values without INTER...

2018-03-05 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20433 ok, I'll update based on the comments soon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20433: [SPARK-23264][SQL] Support interval values without INTER...

2018-03-05 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20433 Could you create `interval.sql` by adding the test cases in https://issues.apache.org/jira/browse/HIVE-13557 ? --- - To

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r172427740 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -790,6 +796,16 @@ ASC: 'ASC'; DESC: 'DESC'; FOR:

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r172427617 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -790,6 +796,16 @@ ASC: 'ASC'; DESC: 'DESC'; FOR:

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-05 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r172427354 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -790,6 +796,16 @@ ASC: 'ASC'; DESC: 'DESC'; FOR:

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r172426790 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -790,6 +796,16 @@ ASC: 'ASC'; DESC: 'DESC'; FOR:

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Support interval values withou...

2018-03-05 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r172426643 --- Diff: sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 --- @@ -790,6 +796,16 @@ ASC: 'ASC'; DESC: 'DESC'; FOR:

[GitHub] spark issue #20746: [SPARK-23594][SQL] GetExternalRowField should support in...

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20746 **[Test build #87995 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87995/testReport)** for PR 20746 at commit

[GitHub] spark issue #20746: [SPARK-23594][SQL] GetExternalRowField should support in...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20746 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1307/

[GitHub] spark issue #20746: [SPARK-23594][SQL] GetExternalRowField should support in...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20746 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20746: [SPARK-23594][SQL] GetExternalRowField should sup...

2018-03-05 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/20746 [SPARK-23594][SQL] GetExternalRowField should support interpreted execution ## What changes were proposed in this pull request? This pr added interpreted execution for `GetExternalRowField`.

[GitHub] spark issue #20699: [SPARK-23544][SQL]Remove redundancy ShuffleExchange in t...

2018-03-05 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/20699 `EnsureRequirements `can eliminates unnecessary shuffles if child has same partitioning or compatible child partitionings that same expressions distribution. but when child has different

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #87994 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87994/testReport)** for PR 19222 at commit

[GitHub] spark issue #20716: [SPARK-23566][Minor][Doc] Argument name mismatch fixed

2018-03-05 Thread animenon
Github user animenon commented on the issue: https://github.com/apache/spark/pull/20716 @HyukjinKwon Its minor, so may not be required. Had tagged Gator just for a check. --- - To unsubscribe, e-mail:

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1306/

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-03-05 Thread kiszk
GitHub user kiszk reopened a pull request: https://github.com/apache/spark/pull/19222 [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks to choose several types of memory block ## What changes were proposed in this pull request? This PR allows us to use one of

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-03-05 Thread kiszk
Github user kiszk closed the pull request at: https://github.com/apache/spark/pull/19222 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-05 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/19222 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-03-05 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r172421399 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java --- @@ -57,20 +59,20 @@ // The data stored

[GitHub] spark pull request #20633: [SPARK-23455][ML] Default Params in ML should be ...

2018-03-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20633#discussion_r172420910 --- Diff: mllib/src/main/scala/org/apache/spark/ml/util/ReadWrite.scala --- @@ -351,17 +359,21 @@ private[ml] object DefaultParamsReader {

[GitHub] spark issue #20472: [SPARK-22751][ML]Improve ML RandomForest shuffle perform...

2018-03-05 Thread lucio-yz
Github user lucio-yz commented on the issue: https://github.com/apache/spark/pull/20472 @srowen Any other problems? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87989/ Test FAILed. ---

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #87989 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87989/testReport)** for PR 19222 at commit

[GitHub] spark issue #20633: [SPARK-23455][ML] Default Params in ML should be saved s...

2018-03-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20633 @WeichenXu123 I've added unit test in `DefaultReadWriteSuite/DefaultReadWriteTest` to test if this can read old metadata back. Sounds like the backward compatibility test you suggested

[GitHub] spark pull request #20449: [SPARK-23040][CORE]: Returns interruptible iterat...

2018-03-05 Thread advancedxy
Github user advancedxy commented on a diff in the pull request: https://github.com/apache/spark/pull/20449#discussion_r172416019 --- Diff: core/src/main/scala/org/apache/spark/shuffle/BlockStoreShuffleReader.scala --- @@ -104,9 +104,16 @@ private[spark] class

[GitHub] spark issue #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to handle...

2018-03-05 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20345 ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-05 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r172415192 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/NormalizerSuite.scala --- @@ -17,94 +17,72 @@ package

[GitHub] spark issue #20433: [SPARK-23264][SQL] Support interval values without INTER...

2018-03-05 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20433 ping --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20449: [SPARK-23040][CORE]: Returns interruptible iterat...

2018-03-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20449#discussion_r172414393 --- Diff: core/src/main/scala/org/apache/spark/shuffle/BlockStoreShuffleReader.scala --- @@ -104,9 +104,16 @@ private[spark] class

[GitHub] spark issue #20742: [SPARK-23572][docs] Bring "security.md" up to date.

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20742 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #18610: [SPARK-21386] ML LinearRegression supports warm start fr...

2018-03-05 Thread JohnHBrock
Github user JohnHBrock commented on the issue: https://github.com/apache/spark/pull/18610 What else needs to be done before this can be merged? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20464: [SPARK-23291][SQL][R] R's substr should not reduce start...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20464 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20742: [SPARK-23572][docs] Bring "security.md" up to date.

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20742 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87987/ Test PASSed. ---

[GitHub] spark issue #20464: [SPARK-23291][SQL][R] R's substr should not reduce start...

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20464 **[Test build #87993 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87993/testReport)** for PR 20464 at commit

[GitHub] spark issue #20464: [SPARK-23291][SQL][R] R's substr should not reduce start...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20464 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87993/ Test PASSed. ---

[GitHub] spark issue #20742: [SPARK-23572][docs] Bring "security.md" up to date.

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20742 **[Test build #87987 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87987/testReport)** for PR 20742 at commit

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-03-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r172413460 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java --- @@ -57,20 +59,20 @@ // The data

[GitHub] spark issue #19381: [SPARK-10884][ML] Support prediction on single instance ...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19381 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19381: [SPARK-10884][ML] Support prediction on single instance ...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19381 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87991/ Test PASSed. ---

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-03-05 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r172412911 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java --- @@ -57,20 +59,20 @@ // The data stored

[GitHub] spark issue #19381: [SPARK-10884][ML] Support prediction on single instance ...

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19381 **[Test build #87991 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87991/testReport)** for PR 19381 at commit

[GitHub] spark issue #20659: [DNM] Try to update Hive to 2.3.2

2018-03-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/20659 Nice try! Could you fix the remaining failure? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20449: [SPARK-23040][CORE]: Returns interruptible iterator for ...

2018-03-05 Thread advancedxy
Github user advancedxy commented on the issue: https://github.com/apache/spark/pull/20449 @cloud-fan is it possible that we also merge this into branch-2.3, so this fix could be released in the Spark-2.3.1? --- -

[GitHub] spark issue #20464: [SPARK-23291][SQL][R] R's substr should not reduce start...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20464 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1305/

[GitHub] spark issue #20464: [SPARK-23291][SQL][R] R's substr should not reduce start...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20464 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-03-05 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r172410077 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/OffHeapColumnVector.java --- @@ -57,20 +59,20 @@ // The data

[GitHub] spark issue #20464: [SPARK-23291][SQL][R] R's substr should not reduce start...

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20464 **[Test build #87993 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87993/testReport)** for PR 20464 at commit

[GitHub] spark pull request #20464: [SPARK-23291][SQL][R] R's substr should not reduc...

2018-03-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20464#discussion_r172409837 --- Diff: R/pkg/R/column.R --- @@ -169,7 +169,7 @@ setMethod("alias", #' @note substr since 1.4.0 setMethod("substr", signature(x = "Column"),

[GitHub] spark pull request #20742: [SPARK-23572][docs] Bring "security.md" up to dat...

2018-03-05 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20742#discussion_r172409490 --- Diff: R/pkg/DESCRIPTION --- @@ -57,6 +57,6 @@ Collate: 'types.R' 'utils.R' 'window.R' -RoxygenNote: 5.0.1

[GitHub] spark issue #20699: [SPARK-23544][SQL]Remove redundancy ShuffleExchange in t...

2018-03-05 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20699 Sorry I should make the question more specific: `EnsureRequirement#apply` has a hack to eliminate unnecessary shuffles, do we still need that? ---

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-05 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r172408255 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala --- @@ -313,13 +306,14 @@ class RFormulaSuite extends MLTest with

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-05 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r172408009 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/QuantileDiscretizerSuite.scala --- @@ -324,19 +352,46 @@ class QuantileDiscretizerSuite

[GitHub] spark pull request #20647: [SPARK-23303][SQL] improve the explain result for...

2018-03-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20647 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20295: [SPARK-23011] Support alternative function form with gro...

2018-03-05 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20295 @icexelloss Could you annotate `[SQL][PYTHON]` in the pr title please? --- - To unsubscribe, e-mail:

[GitHub] spark issue #20647: [SPARK-23303][SQL] improve the explain result for data s...

2018-03-05 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20647 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #16006: [SPARK-18580] [DStreams] [external/kafka-0-10] Use spark...

2018-03-05 Thread koeninger
Github user koeninger commented on the issue: https://github.com/apache/spark/pull/16006 @omuravskiy can you comment on https://github.com/apache/spark/pull/19431 since it appears to be based on your PR ---

[GitHub] spark issue #20745: [SPARK-23288][SS] Fix output metrics with parquet sink

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20745 **[Test build #87992 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87992/testReport)** for PR 20745 at commit

[GitHub] spark pull request #20464: [SPARK-23291][SQL][R] R's substr should not reduc...

2018-03-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20464#discussion_r172406939 --- Diff: R/pkg/R/column.R --- @@ -169,7 +169,7 @@ setMethod("alias", #' @note substr since 1.4.0 setMethod("substr", signature(x = "Column"),

[GitHub] spark issue #20745: [SPARK-23288][SS] Fix output metrics with parquet sink

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20745 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20745: [SPARK-23288][SS] Fix output metrics with parquet...

2018-03-05 Thread gaborgsomogyi
GitHub user gaborgsomogyi opened a pull request: https://github.com/apache/spark/pull/20745 [SPARK-23288][SS] Fix output metrics with parquet sink ## What changes were proposed in this pull request? Output metrics were not filled when parquet sink used. This PR

[GitHub] spark issue #20639: [SPARK-23288][SS] Fix output metrics with parquet sink

2018-03-05 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/20639 God, seems like stuck somehow. I'll re-create the PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #20639: [SPARK-23288][SS] Fix output metrics with parquet...

2018-03-05 Thread gaborgsomogyi
Github user gaborgsomogyi closed the pull request at: https://github.com/apache/spark/pull/20639 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19381: [SPARK-10884][ML] Support prediction on single instance ...

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19381 **[Test build #87991 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87991/testReport)** for PR 19381 at commit

[GitHub] spark issue #19381: [SPARK-10884][ML] Support prediction on single instance ...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19381 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19381: [SPARK-10884][ML] Support prediction on single instance ...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19381 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1304/

[GitHub] spark issue #20295: [SPARK-23011] Support alternative function form with gro...

2018-03-05 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/20295 LGTM except for @BryanCutler's suggestion (https://github.com/apache/spark/pull/20295#discussion_r172374978). Thanks! --- - To

[GitHub] spark issue #20743: [SPARK-23020][CORE][branch-2.3] Fix another race in the ...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20743 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20743: [SPARK-23020][CORE][branch-2.3] Fix another race in the ...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20743 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87985/ Test PASSed. ---

[GitHub] spark issue #20743: [SPARK-23020][CORE][branch-2.3] Fix another race in the ...

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20743 **[Test build #87985 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87985/testReport)** for PR 20743 at commit

[GitHub] spark issue #19381: [SPARK-10884][ML] Support prediction on single instance ...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19381 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1303/

[GitHub] spark issue #19381: [SPARK-10884][ML] Support prediction on single instance ...

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19381 **[Test build #87990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87990/testReport)** for PR 19381 at commit

[GitHub] spark issue #19381: [SPARK-10884][ML] Support prediction on single instance ...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19381 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20706: [SPARK-23550][core] Cleanup `Utils`.

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20706 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87984/ Test PASSed. ---

[GitHub] spark issue #20706: [SPARK-23550][core] Cleanup `Utils`.

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20706 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #16006: [SPARK-18580] [DStreams] [external/kafka-0-10] Use spark...

2018-03-05 Thread koeninger
Github user koeninger commented on the issue: https://github.com/apache/spark/pull/16006 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20706: [SPARK-23550][core] Cleanup `Utils`.

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20706 **[Test build #87984 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87984/testReport)** for PR 20706 at commit

[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...

2018-03-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20726 Btw, I think the title should be `[SQL]` instead of `[CORE]`. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #20726: [SPARK-23574][CORE] Report SinglePartition in DataSource...

2018-03-05 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20726 LGTM with one trivial doc point. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20726: [SPARK-23574][CORE] Report SinglePartition in Dat...

2018-03-05 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20726#discussion_r172403479 --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/reader/SupportsReportPartitioning.java --- @@ -23,6 +23,10 @@ /** * A mix in

[GitHub] spark issue #20649: [SPARK-23462][SQL] improve missing field error message i...

2018-03-05 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20649 I usually leave open it for few more days in case other reviewers have some more review comments. --- - To unsubscribe,

[GitHub] spark issue #20702: [SPARK-23547][SQL]Cleanup the .pipeout file when the Hiv...

2018-03-05 Thread zuotingbing
Github user zuotingbing commented on the issue: https://github.com/apache/spark/pull/20702 Jenkins, ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20657: [SPARK-23361][yarn] Allow AM to restart after initial to...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20657 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87983/ Test PASSed. ---

[GitHub] spark issue #20657: [SPARK-23361][yarn] Allow AM to restart after initial to...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20657 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20657: [SPARK-23361][yarn] Allow AM to restart after initial to...

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20657 **[Test build #87983 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87983/testReport)** for PR 20657 at commit

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19222 **[Test build #87989 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87989/testReport)** for PR 19222 at commit

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #19222: [SPARK-10399][CORE][SQL] Introduce multiple MemoryBlocks...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19222 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1302/

[GitHub] spark pull request #19222: [SPARK-10399][CORE][SQL] Introduce multiple Memor...

2018-03-05 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/19222#discussion_r172395871 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/memory/OnHeapMemoryBlock.java --- @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache

[GitHub] spark issue #16770: [SPARK-15009][PYTHON][ML] Construct CountVectorizerModel...

2018-03-05 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/16770 **[Test build #87988 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87988/testReport)** for PR 16770 at commit

[GitHub] spark issue #16770: [SPARK-15009][PYTHON][ML] Construct CountVectorizerModel...

2018-03-05 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16770 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87988/ Test PASSed. ---

  1   2   3   4   5   6   >