[GitHub] spark pull request #20767: [SPARK-23623] [SS] Avoid concurrent use of cached...

2018-03-08 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20767#discussion_r173338056 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala --- @@ -342,80 +401,65 @@ private[kafka010] object

[GitHub] spark pull request #20777: [SPARK-23615][ML][PYSPARK]Add maxDF Parameter to ...

2018-03-08 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20777#discussion_r173336643 --- Diff: python/pyspark/ml/feature.py --- @@ -465,26 +522,26 @@ class CountVectorizer(JavaEstimator, HasInputCol, HasOutputCol, JavaMLReadable,

[GitHub] spark pull request #20777: [SPARK-23615][ML][PYSPARK]Add maxDF Parameter to ...

2018-03-08 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20777#discussion_r173336451 --- Diff: python/pyspark/ml/feature.py --- @@ -455,6 +506,12 @@ class CountVectorizer(JavaEstimator, HasInputCol, HasOutputCol, JavaMLReadable,

[GitHub] spark pull request #20777: [SPARK-23615][ML][PYSPARK]Add maxDF Parameter to ...

2018-03-08 Thread BryanCutler
Github user BryanCutler commented on a diff in the pull request: https://github.com/apache/spark/pull/20777#discussion_r173335895 --- Diff: python/pyspark/ml/feature.py --- @@ -408,35 +408,86 @@ class CountVectorizer(JavaEstimator, HasInputCol, HasOutputCol, JavaMLReadable,

[GitHub] spark issue #20705: [SPARK-23553][TESTS] Tests should not assume the default...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20705 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20705: [SPARK-23553][TESTS] Tests should not assume the default...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20705 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88103/ Test PASSed. ---

[GitHub] spark issue #20778: [SPARK-23584][SQL] NewInstance should support interprete...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20778 **[Test build #88108 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88108/testReport)** for PR 20778 at commit

[GitHub] spark issue #20778: [SPARK-23584][SQL] NewInstance should support interprete...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20778 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1413/

[GitHub] spark issue #20705: [SPARK-23553][TESTS] Tests should not assume the default...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20705 **[Test build #88103 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88103/testReport)** for PR 20705 at commit

[GitHub] spark issue #20778: [SPARK-23584][SQL] NewInstance should support interprete...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20778 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20778: [SPARK-23584][SQL] NewInstance should support int...

2018-03-08 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/20778 [SPARK-23584][SQL] NewInstance should support interpreted execution ## What changes were proposed in this pull request? This pr supported interpreted mode for `NewInstance`. ## How was

[GitHub] spark issue #20757: [SPARK-23595][SQL] ValidateExternalType should support i...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20757 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1412/

[GitHub] spark issue #20757: [SPARK-23595][SQL] ValidateExternalType should support i...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20757 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20757: [SPARK-23595][SQL] ValidateExternalType should support i...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20757 **[Test build #88107 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88107/testReport)** for PR 20757 at commit

[GitHub] spark pull request #20757: [SPARK-23595][SQL] ValidateExternalType should su...

2018-03-08 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20757#discussion_r173332356 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -121,6 +121,19 @@ object ScalaReflection extends

[GitHub] spark pull request #20767: [SPARK-23623] [SS] Avoid concurrent use of cached...

2018-03-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20767#discussion_r173332248 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaDataConsumerSuite.scala --- @@ -0,0 +1,111 @@ +/* + * Licensed

[GitHub] spark pull request #20767: [SPARK-23623] [SS] Avoid concurrent use of cached...

2018-03-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20767#discussion_r173331304 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala --- @@ -342,80 +401,65 @@ private[kafka010] object

[GitHub] spark pull request #20767: [SPARK-23623] [SS] Avoid concurrent use of cached...

2018-03-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20767#discussion_r173332030 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala --- @@ -342,80 +401,65 @@ private[kafka010] object

[GitHub] spark pull request #20767: [SPARK-23623] [SS] Avoid concurrent use of cached...

2018-03-08 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20767#discussion_r173330725 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala --- @@ -342,80 +401,65 @@ private[kafka010] object

[GitHub] spark issue #20766: [BackPort][SPARK-23490][SQL] Check storage.locationUri w...

2018-03-08 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20766 Thanks! Merged to 2.3. Could you close it? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20687: [SPARK-23500][SQL] Fix complex type simplificatio...

2018-03-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20687#discussion_r173331455 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/complexTypesSuite.scala --- @@ -331,4 +330,31 @@ class ComplexTypesSuite

[GitHub] spark pull request #20753: [SPARK-23582][SQL] StaticInvoke should support in...

2018-03-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20753#discussion_r173327074 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala --- @@ -127,6 +128,52 @@ object

[GitHub] spark pull request #20753: [SPARK-23582][SQL] StaticInvoke should support in...

2018-03-08 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20753#discussion_r173326718 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -188,8 +189,30 @@ case class StaticInvoke(

[GitHub] spark issue #20525: [SPARK-23271[SQL] Parquet output contains only _SUCCESS ...

2018-03-08 Thread dilipbiswal
Github user dilipbiswal commented on the issue: https://github.com/apache/spark/pull/20525 @cloud-fan @jiangxb1987 Thank you very much !! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20772: [SPARK-23628][SQL] calculateParamLength should not retur...

2018-03-08 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20772 Good catch! Thanks! @mgaido91 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20687: [SPARK-23500][SQL] Fix complex type simplificatio...

2018-03-08 Thread henryr
Github user henryr commented on a diff in the pull request: https://github.com/apache/spark/pull/20687#discussion_r173323846 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/complexTypesSuite.scala --- @@ -331,4 +330,31 @@ class ComplexTypesSuite

[GitHub] spark pull request #20525: [SPARK-23271[SQL] Parquet output contains only _S...

2018-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20525 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20777: [SPARK-23615][ML][PYSPARK]Add maxDF Parameter to Python ...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20777 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88106/ Test PASSed. ---

[GitHub] spark issue #20777: [SPARK-23615][ML][PYSPARK]Add maxDF Parameter to Python ...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20777 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20777: [SPARK-23615][ML][PYSPARK]Add maxDF Parameter to Python ...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20777 **[Test build #88106 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88106/testReport)** for PR 20777 at commit

[GitHub] spark issue #20525: [SPARK-23271[SQL] Parquet output contains only _SUCCESS ...

2018-03-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20525 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20687: [SPARK-23500][SQL] Fix complex type simplificatio...

2018-03-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20687#discussion_r173270388 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/complexTypesSuite.scala --- @@ -331,4 +330,31 @@ class ComplexTypesSuite

[GitHub] spark issue #20777: [SPARK-23615][ML][PYSPARK]Add maxDF Parameter to Python ...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20777 **[Test build #88106 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88106/testReport)** for PR 20777 at commit

[GitHub] spark issue #20777: [SPARK-23615][ML][PYSPARK]Add maxDF Parameter to Python ...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20777 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1411/

[GitHub] spark issue #20777: [SPARK-23615][ML][PYSPARK]Add maxDF Parameter to Python ...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20777 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20777: [SPARK-23615][ML][PYSPARK]Add maxDF Parameter to ...

2018-03-08 Thread huaxingao
GitHub user huaxingao opened a pull request: https://github.com/apache/spark/pull/20777 [SPARK-23615][ML][PYSPARK]Add maxDF Parameter to Python CountVectorizer ## What changes were proposed in this pull request? The maxDF parameter is for filtering out frequently occurring

[GitHub] spark issue #20295: [SPARK-23011][SQL][PYTHON] Support alternative function ...

2018-03-08 Thread icexelloss
Github user icexelloss commented on the issue: https://github.com/apache/spark/pull/20295 Sounds good. Let's track in https://issues.apache.org/jira/browse/SPARK-23633 --- - To unsubscribe, e-mail:

[GitHub] spark issue #20295: [SPARK-23011][SQL][PYTHON] Support alternative function ...

2018-03-08 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20295 Yup. Maybe we could do that when we are close to 2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20773: [SPARK-23602][SQL] PrintToStderr prints value also in in...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20773 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88102/ Test PASSed. ---

[GitHub] spark issue #20773: [SPARK-23602][SQL] PrintToStderr prints value also in in...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20773 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20773: [SPARK-23602][SQL] PrintToStderr prints value also in in...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20773 **[Test build #88102 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88102/testReport)** for PR 20773 at commit

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20774 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20774 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88101/ Test PASSed. ---

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20774 **[Test build #88101 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88101/testReport)** for PR 20774 at commit

[GitHub] spark issue #20744: [SPARK-23608][CORE][WebUI] Add synchronization in SHS be...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20744 **[Test build #88105 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88105/testReport)** for PR 20744 at commit

[GitHub] spark issue #20744: [SPARK-23608][CORE][WebUI] Add synchronization in SHS be...

2018-03-08 Thread zhouyejoe
Github user zhouyejoe commented on the issue: https://github.com/apache/spark/pull/20744 Updated. Please help trigger the jenkins again. Thanks. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20742: [SPARK-23572][docs] Bring "security.md" up to date.

2018-03-08 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20742 Any takers for reviewing this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20776: [SPARK-23630][yarn] Allow user's hadoop conf customizati...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20776 **[Test build #88104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88104/testReport)** for PR 20776 at commit

[GitHub] spark issue #20776: [SPARK-23630][yarn] Allow user's hadoop conf customizati...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20776 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20776: [SPARK-23630][yarn] Allow user's hadoop conf customizati...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20776 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1410/

[GitHub] spark pull request #20776: [SPARK-23630][yarn] Allow user's hadoop conf cust...

2018-03-08 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/20776 [SPARK-23630][yarn] Allow user's hadoop conf customizations to take effect. This change restores functionality that was inadvertently removed as part of the fix for SPARK-22372. Also

[GitHub] spark pull request #20756: [SPARK-23593][SQL] Add interpreted execution for ...

2018-03-08 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20756#discussion_r173291374 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -1261,8 +1261,42 @@ case class

[GitHub] spark pull request #20773: [SPARK-23602][SQL] PrintToStderr prints value als...

2018-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20773 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20753 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88100/ Test PASSed. ---

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20753 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20753 **[Test build #88100 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88100/testReport)** for PR 20753 at commit

[GitHub] spark issue #20773: [SPARK-23602][SQL] PrintToStderr prints value also in in...

2018-03-08 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20773 Merging to master. Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20705: [SPARK-23553][TESTS] Tests should not assume the default...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20705 **[Test build #88103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88103/testReport)** for PR 20705 at commit

[GitHub] spark issue #20705: [SPARK-23553][TESTS] Tests should not assume the default...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20705 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20705: [SPARK-23553][TESTS] Tests should not assume the default...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20705 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1409/

[GitHub] spark pull request #20705: [SPARK-23553][TESTS] Tests should not assume the ...

2018-03-08 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20705#discussion_r173281238 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2476,7 +2477,7 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark issue #20773: [SPARK-23602][SQL] PrintToStderr prints value also in in...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20773 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88098/ Test PASSed. ---

[GitHub] spark issue #20773: [SPARK-23602][SQL] PrintToStderr prints value also in in...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20773 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20773: [SPARK-23602][SQL] PrintToStderr prints value also in in...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20773 **[Test build #88098 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88098/testReport)** for PR 20773 at commit

[GitHub] spark issue #20772: [SPARK-23628][SQL] calculateParamLength should not retur...

2018-03-08 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/20772 Thanks @cloud-fan @hvanhovell, I'll create a backport for 2.3 tomorrow morning CEST :) --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20705: [SPARK-23553][TESTS] Tests should not assume the ...

2018-03-08 Thread bersprockets
Github user bersprockets commented on a diff in the pull request: https://github.com/apache/spark/pull/20705#discussion_r173275865 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2476,7 +2477,7 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark issue #20525: [SPARK-23271[SQL] Parquet output contains only _SUCCESS ...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20525 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88099/ Test PASSed. ---

[GitHub] spark issue #20525: [SPARK-23271[SQL] Parquet output contains only _SUCCESS ...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20525 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20525: [SPARK-23271[SQL] Parquet output contains only _SUCCESS ...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20525 **[Test build #88099 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88099/testReport)** for PR 20525 at commit

[GitHub] spark issue #20773: [SPARK-23602][SQL] PrintToStderr prints value also in in...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20773 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88096/ Test PASSed. ---

[GitHub] spark issue #20773: [SPARK-23602][SQL] PrintToStderr prints value also in in...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20773 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20773: [SPARK-23602][SQL] PrintToStderr prints value also in in...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20773 **[Test build #88096 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88096/testReport)** for PR 20773 at commit

[GitHub] spark issue #20775: Changes input variable to not conflict with built-in fun...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20775 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20775: Changes input variable to not conflict with built-in fun...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20775 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20775: Changes input variable to not conflict with built...

2018-03-08 Thread DylanGuedes
GitHub user DylanGuedes opened a pull request: https://github.com/apache/spark/pull/20775 Changes input variable to not conflict with built-in function Signed-off-by: DylanGuedes ## What changes were proposed in this pull request? Changes

[GitHub] spark issue #20772: [SPARK-23628][SQL] calculateParamLength should not retur...

2018-03-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20772 haha, 1 minute before you :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20717: [SPARK-23564][SQL] Add isNotNull check for left a...

2018-03-08 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20717#discussion_r173269537 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -675,6 +676,22 @@ object

[GitHub] spark pull request #20687: [SPARK-23500][SQL] Fix complex type simplificatio...

2018-03-08 Thread henryr
Github user henryr commented on a diff in the pull request: https://github.com/apache/spark/pull/20687#discussion_r173268999 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/complexTypesSuite.scala --- @@ -331,4 +330,31 @@ class ComplexTypesSuite

[GitHub] spark issue #20772: [SPARK-23628][SQL] calculateParamLength should not retur...

2018-03-08 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20772 @cloud-fan you beat me to it :) --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20772: [SPARK-23628][SQL] calculateParamLength should no...

2018-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20772 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20772: [SPARK-23628][SQL] calculateParamLength should not retur...

2018-03-08 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20772 @mgaido91 this is good catch! LGTM. Merging to master/2.3. Thanks! --- - To unsubscribe, e-mail:

[GitHub] spark issue #17466: [SPARK-14681][ML] Added getter for impurityStats

2018-03-08 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/17466 @shaynativ Sorry for the inactivity here. Btw, for the JIRA & PR title question above, I'd recommend checking out http://spark.apache.org/contributing.html Since @WeichenXu123 opened a

[GitHub] spark issue #20772: [SPARK-23628][SQL] calculateParamLength should not retur...

2018-03-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20772 @mgaido91 do you mind to open a new PR for 2.3? it conflicts. thanks! --- - To unsubscribe, e-mail:

[GitHub] spark issue #20772: [SPARK-23628][SQL] calculateParamLength should not retur...

2018-03-08 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20772 good catch! merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20773: [SPARK-23602][SQL] PrintToStderr prints value also in in...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20773 **[Test build #88102 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88102/testReport)** for PR 20773 at commit

[GitHub] spark issue #20773: [SPARK-23602][SQL] PrintToStderr prints value also in in...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20773 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1408/

[GitHub] spark issue #20773: [SPARK-23602][SQL] PrintToStderr prints value also in in...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20773 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20773: [SPARK-23602][SQL] PrintToStderr prints value also in in...

2018-03-08 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/20773 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20770: [SPARK-23626][CORE] DAGScheduler blocked due to JobSubmi...

2018-03-08 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/20770 @AjithShetty2489 I'm not sure just changing these two maps is sufficient ? For example createResultStage could in turn create all the parent stages and the parents stages could be ShuffleMapStage

[GitHub] spark issue #20770: [SPARK-23626][CORE] DAGScheduler blocked due to JobSubmi...

2018-03-08 Thread shivaram
Github user shivaram commented on the issue: https://github.com/apache/spark/pull/20770 cc @kayousterhout @markhamstra --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-08 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20774 **[Test build #88101 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88101/testReport)** for PR 20774 at commit

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20774 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1407/

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20774 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20774: [SPARK-23549][SQL] Cast to timestamp when comparing time...

2018-03-08 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20774 If this approach is fine, I will create tests for `.sql`. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #20774: [SPARK-23549][SQL] Cast to timestamp when compari...

2018-03-08 Thread kiszk
GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/20774 [SPARK-23549][SQL] Cast to timestamp when comparing timestamp with date ## What changes were proposed in this pull request? This PR fixes an incorrect comparison in SQL between timestamp and

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to v0.4.3

2018-03-08 Thread rgbkrk
Github user rgbkrk commented on the issue: https://github.com/apache/spark/pull/20373 Woohoo! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20657: [SPARK-23361][yarn] Allow AM to restart after ini...

2018-03-08 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20657#discussion_r173236591 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/security/AMCredentialRenewer.scala --- @@ -18,221 +18,160 @@ package

[GitHub] spark issue #20373: [SPARK-23159][PYTHON] Update cloudpickle to v0.4.3

2018-03-08 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/20373 Thanks @HyukjinKwon @holdenk and @rgbkrk ! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20771: [SPARK-23587][SQL] Add interpreted execution for ...

2018-03-08 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20771#discussion_r173231736 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -599,8 +610,71 @@ case class MapObjects

[GitHub] spark pull request #20771: [SPARK-23587][SQL] Add interpreted execution for ...

2018-03-08 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20771#discussion_r173231610 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -599,8 +610,71 @@ case class MapObjects

<    1   2   3   4   5   >