[GitHub] spark pull request #20767: [SPARK-23623] [SS] Avoid concurrent use of cached...

2018-03-09 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20767#discussion_r173614986 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala --- @@ -342,80 +415,103 @@ private[kafka010] object

[GitHub] spark issue #20779: [SPARK-23598][SQL] Make methods in BufferedRowIterator p...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20779 **[Test build #88145 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88145/testReport)** for PR 20779 at commit

[GitHub] spark issue #20779: [SPARK-23598][SQL] Make methods in BufferedRowIterator p...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20779 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1442/

[GitHub] spark issue #20779: [SPARK-23598][SQL] Make methods in BufferedRowIterator p...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20779 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20784: [SPARK-23639][SQL]Obtain token before init metastore cli...

2018-03-09 Thread yaooqinn
Github user yaooqinn commented on the issue: https://github.com/apache/spark/pull/20784 yarn @vanzin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20779: [SPARK-23598][SQL] Make methods in BufferedRowIte...

2018-03-09 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20779#discussion_r173613316 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala --- @@ -307,4 +309,47 @@ class WholeStageCodegenSuite extends

[GitHub] spark issue #20791: [SPARK-23618][BUILD] Initialize BUILD_ARGS in docker-ima...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20791 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20791: [SPARK-23618][BUILD] Initialize BUILD_ARGS in doc...

2018-03-09 Thread jooseong
GitHub user jooseong opened a pull request: https://github.com/apache/spark/pull/20791 [SPARK-23618][BUILD] Initialize BUILD_ARGS in docker-image-tool.sh ## What changes were proposed in this pull request? This change initializes BUILD_ARGS to an empty array when

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20763 **[Test build #88144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88144/testReport)** for PR 20763 at commit

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20763 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20763 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1441/

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20763 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20788: [WIP][SPARK-21030][PYTHON][SQL] Adds more types f...

2018-03-09 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/20788#discussion_r173612651 --- Diff: python/pyspark/sql/dataframe.py --- @@ -437,10 +437,11 @@ def hint(self, name, *parameters): if not isinstance(name, str):

[GitHub] spark issue #20754: [SPARK-23287][CORE] Spark scheduler does not remove init...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20754 **[Test build #88143 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88143/testReport)** for PR 20754 at commit

[GitHub] spark issue #20754: [SPARK-23287][CORE] Spark scheduler does not remove init...

2018-03-09 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/20754 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20327 **[Test build #88142 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88142/testReport)** for PR 20327 at commit

[GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-09 Thread gerashegalov
Github user gerashegalov commented on a diff in the pull request: https://github.com/apache/spark/pull/20327#discussion_r173611826 --- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala --- @@ -126,7 +126,11 @@ private[spark] abstract class WebUI( def bind(): Unit = {

[GitHub] spark pull request #20327: [SPARK-12963][CORE] NM host for driver end points

2018-03-09 Thread gerashegalov
Github user gerashegalov commented on a diff in the pull request: https://github.com/apache/spark/pull/20327#discussion_r173611565 --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala --- @@ -342,13 +342,13 @@ private[spark] object JettyUtils extends Logging {

[GitHub] spark pull request #20742: [SPARK-23572][docs] Bring "security.md" up to dat...

2018-03-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/20742#discussion_r173609711 --- Diff: docs/security.md --- @@ -182,54 +580,70 @@ configure those ports. -### HTTP Security Headers -Apache Spark can

[GitHub] spark pull request #20742: [SPARK-23572][docs] Bring "security.md" up to dat...

2018-03-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/20742#discussion_r173609118 --- Diff: docs/security.md --- @@ -3,47 +3,290 @@ layout: global displayTitle: Spark Security title: Security --- +* This will become a

[GitHub] spark pull request #20742: [SPARK-23572][docs] Bring "security.md" up to dat...

2018-03-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/20742#discussion_r173610240 --- Diff: docs/security.md --- @@ -182,54 +580,70 @@ configure those ports. -### HTTP Security Headers -Apache Spark can

[GitHub] spark pull request #20742: [SPARK-23572][docs] Bring "security.md" up to dat...

2018-03-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/20742#discussion_r173609032 --- Diff: docs/security.md --- @@ -3,47 +3,290 @@ layout: global displayTitle: Spark Security title: Security --- +* This will become a

[GitHub] spark pull request #20742: [SPARK-23572][docs] Bring "security.md" up to dat...

2018-03-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/20742#discussion_r173608978 --- Diff: docs/running-on-yarn.md --- @@ -2,6 +2,8 @@ layout: global title: Running Spark on YARN --- +* This will become a table of

[GitHub] spark pull request #20742: [SPARK-23572][docs] Bring "security.md" up to dat...

2018-03-09 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/20742#discussion_r173609465 --- Diff: docs/security.md --- @@ -58,49 +301,204 @@ component-specific configuration namespaces used to override the default setting

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20763 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20763 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88141/ Test FAILed. ---

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20763 **[Test build #88141 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88141/testReport)** for PR 20763 at commit

[GitHub] spark pull request #20767: [SPARK-23623] [SS] Avoid concurrent use of cached...

2018-03-09 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20767#discussion_r173602790 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala --- @@ -342,80 +415,103 @@ private[kafka010] object

[GitHub] spark pull request #20767: [SPARK-23623] [SS] Avoid concurrent use of cached...

2018-03-09 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20767#discussion_r173602735 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala --- @@ -342,80 +415,103 @@ private[kafka010] object

[GitHub] spark pull request #20767: [SPARK-23623] [SS] Avoid concurrent use of cached...

2018-03-09 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20767#discussion_r173602480 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala --- @@ -342,80 +415,103 @@ private[kafka010] object

[GitHub] spark pull request #20767: [SPARK-23623] [SS] Avoid concurrent use of cached...

2018-03-09 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/20767#discussion_r173602442 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala --- @@ -27,30 +27,73 @@ import

[GitHub] spark issue #20687: [SPARK-23500][SQL] Fix complex type simplification rules...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20687 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20687: [SPARK-23500][SQL] Fix complex type simplification rules...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20687 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88135/ Test PASSed. ---

[GitHub] spark issue #20687: [SPARK-23500][SQL] Fix complex type simplification rules...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20687 **[Test build #88135 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88135/testReport)** for PR 20687 at commit

[GitHub] spark pull request #20767: [SPARK-23623] [SS] Avoid concurrent use of cached...

2018-03-09 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20767#discussion_r173599723 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala --- @@ -27,30 +27,73 @@ import

[GitHub] spark pull request #20767: [SPARK-23623] [SS] Avoid concurrent use of cached...

2018-03-09 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20767#discussion_r173600808 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala --- @@ -342,80 +415,103 @@ private[kafka010] object

[GitHub] spark pull request #20767: [SPARK-23623] [SS] Avoid concurrent use of cached...

2018-03-09 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20767#discussion_r173600530 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala --- @@ -342,80 +415,103 @@ private[kafka010] object

[GitHub] spark pull request #20767: [SPARK-23623] [SS] Avoid concurrent use of cached...

2018-03-09 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/20767#discussion_r173600386 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaDataConsumer.scala --- @@ -342,80 +415,103 @@ private[kafka010] object

[GitHub] spark pull request #20789: [SPARK-23510][SQL][FOLLOW-UP] Support Hive 2.2 an...

2018-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20789 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20763 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1440/

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20763 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20789: [SPARK-23510][SQL][FOLLOW-UP] Support Hive 2.2 and Hive ...

2018-03-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20789 LGTM, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20763 **[Test build #88141 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88141/testReport)** for PR 20763 at commit

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20763 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20742: [SPARK-23572][docs] Bring "security.md" up to date.

2018-03-09 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20742 No volunteers, so I'll volunteer @squito , @jerryshao , @tgravescs --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20769: [SPARK-23624][SQL]Revise doc of method pushFilter...

2018-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20769 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20613: [SPARK-23368][SQL] Avoid unnecessary Exchange or Sort af...

2018-03-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20613 @dongjoon-hyun Try to review this PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20763 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20763 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88136/ Test FAILed. ---

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20763 **[Test build #88136 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88136/testReport)** for PR 20763 at commit

[GitHub] spark issue #20789: [SPARK-23510][SQL][FOLLOW-UP] Support Hive 2.2 and Hive ...

2018-03-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20789 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml.featur...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20686 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88139/ Test PASSed. ---

[GitHub] spark issue #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml.featur...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20686 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml.featur...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20686 **[Test build #88139 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88139/testReport)** for PR 20686 at commit

[GitHub] spark issue #20767: [SPARK-23623] [SS] Avoid concurrent use of cached consum...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20767 **[Test build #88140 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88140/testReport)** for PR 20767 at commit

[GitHub] spark issue #20767: [SPARK-23623] [SS] Avoid concurrent use of cached consum...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20767 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88140/ Test PASSed. ---

[GitHub] spark issue #20767: [SPARK-23623] [SS] Avoid concurrent use of cached consum...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20767 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml.featur...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20686 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88137/ Test PASSed. ---

[GitHub] spark issue #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml.featur...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20686 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml.featur...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20686 **[Test build #88137 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88137/testReport)** for PR 20686 at commit

[GitHub] spark pull request #20717: [SPARK-23564][SQL] Add isNotNull check for left a...

2018-03-09 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20717#discussion_r173587545 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -675,6 +676,22 @@ object

[GitHub] spark issue #20767: [SPARK-23623] [SS] Avoid concurrent use of cached consum...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20767 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1439/

[GitHub] spark issue #20767: [SPARK-23623] [SS] Avoid concurrent use of cached consum...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20767 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20767: [SPARK-23623] [SS] Avoid concurrent use of cached consum...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20767 **[Test build #88140 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88140/testReport)** for PR 20767 at commit

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20763 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20694: [SPARK-23173][SQL] Avoid creating corrupt parquet...

2018-03-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20694 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20789: [SPARK-23510][SQL][FOLLOW-UP] Support Hive 2.2 and Hive ...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20789 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20789: [SPARK-23510][SQL][FOLLOW-UP] Support Hive 2.2 and Hive ...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20789 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88138/ Test PASSed. ---

[GitHub] spark issue #20789: [SPARK-23510][SQL][FOLLOW-UP] Support Hive 2.2 and Hive ...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20789 **[Test build #88138 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88138/testReport)** for PR 20789 at commit

[GitHub] spark issue #20694: [SPARK-23173][SQL] Avoid creating corrupt parquet files ...

2018-03-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20694 Thanks! Merged to master/2.3 I resolved the style issues when I merged the code --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20694: [SPARK-23173][SQL] Avoid creating corrupt parquet...

2018-03-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20694#discussion_r173584456 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetIOSuite.scala --- @@ -780,6 +781,25 @@ class ParquetIOSuite

[GitHub] spark pull request #20694: [SPARK-23173][SQL] Avoid creating corrupt parquet...

2018-03-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20694#discussion_r173584348 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala --- @@ -680,4 +682,31 @@ class

[GitHub] spark pull request #20694: [SPARK-23173][SQL] Avoid creating corrupt parquet...

2018-03-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20694#discussion_r173584330 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala --- @@ -680,4 +682,31 @@ class

[GitHub] spark issue #20790: AccumulatorV2 subclass isZero scaladoc fix

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20790 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml.featur...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20686 **[Test build #88139 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88139/testReport)** for PR 20686 at commit

[GitHub] spark issue #20790: AccumulatorV2 subclass isZero scaladoc fix

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20790 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20687: [SPARK-23500][SQL] Fix complex type simplificatio...

2018-03-09 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20687#discussion_r173583729 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ComplexTypes.scala --- @@ -22,54 +22,34 @@ import

[GitHub] spark pull request #20790: AccumulatorV2 subclass isZero scaladoc fix

2018-03-09 Thread smallory
GitHub user smallory opened a pull request: https://github.com/apache/spark/pull/20790 AccumulatorV2 subclass isZero scaladoc fix Added/corrected scaladoc for isZero on the DoubleAccumulator, CollectionAccumulator, and LongAccumulator subclasses of AccumulatorV2, particularly

[GitHub] spark issue #20789: [SPARK-23510][SQL][FOLLOW-UP] Support Hive 2.2 and Hive ...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20789 **[Test build #88138 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88138/testReport)** for PR 20789 at commit

[GitHub] spark issue #20789: [SPARK-23510][SQL][FOLLOW-UP] Support Hive 2.2 and Hive ...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20789 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20789: [SPARK-23510][SQL][FOLLOW-UP] Support Hive 2.2 and Hive ...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20789 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1438/

[GitHub] spark pull request #20789: [SPARK-23510][SQL][FOLLOW-UP] Support Hive 2.2 an...

2018-03-09 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/20789 [SPARK-23510][SQL][FOLLOW-UP] Support Hive 2.2 and Hive 2.3 metastore ## What changes were proposed in this pull request? In the PR https://github.com/apache/spark/pull/20671, I forgot to

[GitHub] spark issue #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml.featur...

2018-03-09 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/20686 I'll do a complete review now! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-09 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r173582018 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/OneHotEncoderSuite.scala --- @@ -90,23 +96,29 @@ class OneHotEncoderSuite val encoder

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-09 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r173581428 --- Diff: mllib/src/test/scala/org/apache/spark/ml/util/MLTest.scala --- @@ -108,5 +111,29 @@ trait MLTest extends StreamTest with TempDirectory {

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-09 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r173580629 --- Diff: mllib/src/test/scala/org/apache/spark/ml/util/MLTest.scala --- @@ -108,5 +111,29 @@ trait MLTest extends StreamTest with TempDirectory { self:

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-09 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r173580016 --- Diff: mllib/src/test/scala/org/apache/spark/ml/util/MLTest.scala --- @@ -108,5 +111,29 @@ trait MLTest extends StreamTest with TempDirectory { self:

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20763 cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20783: [SPARK-23628][SQL][BACKPORT-2.3] calculateParamLength sh...

2018-03-09 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20783 thanks, merging to 2.3! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-09 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r173575838 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/NormalizerSuite.scala --- @@ -17,94 +17,72 @@ package org.apache.spark.ml.feature

[GitHub] spark pull request #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml...

2018-03-09 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/20686#discussion_r173575794 --- Diff: mllib/src/test/scala/org/apache/spark/ml/feature/NGramSuite.scala --- @@ -19,61 +19,59 @@ package org.apache.spark.ml.feature

[GitHub] spark issue #20686: [SPARK-22915][MLlib] Streaming tests for spark.ml.featur...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20686 **[Test build #88137 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88137/testReport)** for PR 20686 at commit

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20763 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20763 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1437/

[GitHub] spark issue #20752: [SPARK-23559][SS] Create StreamingDataWriterFactory for ...

2018-03-09 Thread jose-torres
Github user jose-torres commented on the issue: https://github.com/apache/spark/pull/20752 Doc sent to the dev list: https://docs.google.com/document/d/1PJYfb68s2AG7joRWbhrgpEWhrsPqbhyRwUVl9V1wPOE --- - To

[GitHub] spark issue #20754: [SPARK-23287][CORE] Spark scheduler does not remove init...

2018-03-09 Thread devaraj-kavali
Github user devaraj-kavali commented on the issue: https://github.com/apache/spark/pull/20754 @felixcheung Thanks for looking into this. This error doesn't seem to be related to the PR, can you trigger the test again? `This patch fails due to an unknown error code, -9.`

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20763 **[Test build #88136 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88136/testReport)** for PR 20763 at commit

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20763 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20763 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1436/

[GitHub] spark issue #20763: [SPARK-23523] [SQL] [BACKPORT-2.3] Fix the incorrect res...

2018-03-09 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20763 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

  1   2   3   >