[GitHub] spark issue #20965: [SPARK-21870][SQL] Split aggregation code into small fun...

2018-04-02 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20965 Since SPARK-23791 gave me a heads-up, I submitted again for reviews. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20965: [SPARK-21870][SQL] Split aggregation code into sm...

2018-04-02 Thread maropu
GitHub user maropu opened a pull request: https://github.com/apache/spark/pull/20965 [SPARK-21870][SQL] Split aggregation code into small functions ## What changes were proposed in this pull request? This pr proposes to split aggregation code into pieces in `HashAggregateExec`.

[GitHub] spark pull request #19082: [SPARK-21870][SQL] Split aggregation code into sm...

2018-04-02 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/19082#discussion_r178716133 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala --- @@ -825,52 +924,92 @@ case class HashAggregateExec(

[GitHub] spark issue #20909: [SPARK-23776][python][test] Check for needed components/...

2018-04-02 Thread bersprockets
Github user bersprockets commented on the issue: https://github.com/apache/spark/pull/20909 > can you investigate and try to explicitly skip some doctests conditionally? @HyukjinKwon I will take a look to see how that can be done. ---

[GitHub] spark issue #20858: [SPARK-23736][SQL] Extending the concat function to supp...

2018-04-02 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20858 Also, can you put the gen'd code of concat arrays here for reviews? --- - To unsubscribe, e-mail:

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-02 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178711505 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +289,152 @@ case class

[GitHub] spark issue #20909: [SPARK-23776][python][test] Check for needed components/...

2018-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20909 Yea, I know the hidden output in the console and I believe that's a known issue. In my case, I made such change before - https://github.com/apache/spark/pull/20487. Also see the discussion in

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-02 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178710167 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -700,3 +700,88 @@ abstract class TernaryExpression

[GitHub] spark issue #20886: [SPARK-19724][SQL]create a managed table with an existed...

2018-04-02 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/20886 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20928: Fix small typo in configuration doc

2018-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20928 Seems there's some problems with Jenkins. Will make the tests run and merge it later. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20928: Fix small typo in configuration doc

2018-04-02 Thread dsakuma
Github user dsakuma commented on the issue: https://github.com/apache/spark/pull/20928 @HyukjinKwon I think that's it! Please let me know if there's anything else I can do. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20909: [SPARK-23776][python][test] Check for needed components/...

2018-04-02 Thread bersprockets
Github user bersprockets commented on the issue: https://github.com/apache/spark/pull/20909 @HyukjinKwon That makes sense. Note that when the tests are run using python/run-tests, run-tests.py steals stdout and stderr. I would need to make a small change to run-tests.py to

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-02 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178708207 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala --- @@ -699,3 +699,88 @@ abstract class TernaryExpression

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20938 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20938 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88836/ Test FAILed. ---

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20938 **[Test build #88836 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88836/testReport)** for PR 20938 at commit

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-02 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178701403 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala --- @@ -408,6 +407,7 @@ object FunctionRegistry {

[GitHub] spark issue #20858: [SPARK-23736][SQL] Extending the concat function to supp...

2018-04-02 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20858 Can you add type coercion tests in `sql/core/src/test/resources/sql-tests/inputs/typeCoercion/native/concat.sql`? e.g., the case to concat different array types like concat(array[int],

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-02 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178700701 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -287,3 +289,166 @@ case class

[GitHub] spark pull request #20858: [SPARK-23736][SQL] Extending the concat function ...

2018-04-02 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/20858#discussion_r178700550 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3046,6 +3036,16 @@ object functions { ArrayContains(column.expr,

[GitHub] spark issue #20909: [SPARK-23776][python][test] Check for needed components/...

2018-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20909 @holdenk, I just saw https://issues.apache.org/jira/browse/SPARK-23853. I think this PR could fix it together if I understood correctly :-). ---

[GitHub] spark issue #20951: [SPARK-23099][SS] Migrate foreach sink to DataSourceV2

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20951 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88832/ Test PASSed. ---

[GitHub] spark issue #20951: [SPARK-23099][SS] Migrate foreach sink to DataSourceV2

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20951 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20951: [SPARK-23099][SS] Migrate foreach sink to DataSourceV2

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20951 **[Test build #88832 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88832/testReport)** for PR 20951 at commit

[GitHub] spark issue #20937: [SPARK-23723][SPARK-23724][SQL] Support custom encoding ...

2018-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20937 I am asking this only because I don't feel strong on this (but am okay). So, I just want to check other committers like this one ahead. ---

[GitHub] spark issue #20928: Fix small typo in configuration doc

2018-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20928 test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20897: [MINOR][DOC] Fix a few markdown typos

2018-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20897 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20909: [SPARK-23776][python][test] Check for needed components/...

2018-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20909 Yes, I feel sure that's more consistent and correct. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20928: Fix small typo in configuration doc

2018-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20928 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20897: [MINOR][DOC] Fix a few markdown typos

2018-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20897 Merged to master and branch-2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20916: [SPARK-19964][core] Avoid reading from remote rep...

2018-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20916 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20916: [SPARK-19964][core] Avoid reading from remote repos in S...

2018-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20916 Merged to master and branch-2.3. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, as...

2018-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20962#discussion_r178692018 --- Diff: python/pyspark/sql/column.py --- @@ -454,6 +454,32 @@ def isin(self, *cols): >>> df.select(df.name).orderBy(df.name.asc()).collect()

[GitHub] spark pull request #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, as...

2018-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20962#discussion_r178691892 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -1083,10 +1083,10 @@ class Column(val expr: Expression) extends Logging {

[GitHub] spark pull request #20963: [SPARK-23849][SQL] Tests for the samplingRatio op...

2018-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/20963#discussion_r178691639 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala --- @@ -2127,4 +2127,39 @@ class JsonSuite extends

[GitHub] spark issue #20959: [SPARK-23846][SQL] The samplingRatio option for CSV data...

2018-04-02 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20959 _if I remember this correctly_, there was a discussion about it a lone ago and, @rxin was not sure how much it improves the perf and if it's worth, which I ended up with agreeing with. @rxin,

[GitHub] spark pull request #20862: [SPARK-23744][CORE]Fix memory leak in ReadableCha...

2018-04-02 Thread 10110346
Github user 10110346 closed the pull request at: https://github.com/apache/spark/pull/20862 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20862: [SPARK-23744][CORE]Fix memory leak in ReadableCha...

2018-04-02 Thread 10110346
Github user 10110346 commented on a diff in the pull request: https://github.com/apache/spark/pull/20862#discussion_r178688855 --- Diff: core/src/main/scala/org/apache/spark/storage/DiskStore.scala --- @@ -301,7 +301,10 @@ private class ReadableChannelFileRegion(source:

[GitHub] spark issue #20958: [SPARK-23844][SS] Fix socket source honors recovered off...

2018-04-02 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/20958 Thanks @tdas for your comments. I agree that socket source should only be used in testing. But it doesn't mean that it can throw weird exception in testing env. For example, if we're dumping

[GitHub] spark issue #20886: [SPARK-19724][SQL]create a managed table with an existed...

2018-04-02 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/20886 Jenkins, retest this please. (Test passed, but jenkins failed to notify github) --- - To unsubscribe, e-mail:

[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20961 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88831/ Test PASSed. ---

[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20961 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20961: [SPARK-23823][SQL] Keep origin in transformExpression

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20961 **[Test build #88831 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88831/testReport)** for PR 20961 at commit

[GitHub] spark issue #20951: [SPARK-23099][SS] Migrate foreach sink to DataSourceV2

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20951 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88833/ Test FAILed. ---

[GitHub] spark issue #20951: [SPARK-23099][SS] Migrate foreach sink to DataSourceV2

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20951 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20955: [SPARK-23838][WEBUI] Running SQL query is display...

2018-04-02 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/20955#discussion_r178681925 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala --- @@ -39,7 +39,7 @@ private[ui] class

[GitHub] spark issue #20951: [SPARK-23099][SS] Migrate foreach sink to DataSourceV2

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20951 **[Test build #88833 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88833/testReport)** for PR 20951 at commit

[GitHub] spark issue #20964: [SPARK-22883] ML test for StructuredStreaming: spark.ml....

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20964 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20964: [SPARK-22883] ML test for StructuredStreaming: spark.ml....

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20964 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1913/

[GitHub] spark issue #20964: [SPARK-22883] ML test for StructuredStreaming: spark.ml....

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20964 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20964: [SPARK-22883] ML test for StructuredStreaming: spark.ml....

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20964 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88838/ Test FAILed. ---

[GitHub] spark issue #20909: [SPARK-23776][python][test] Check for needed components/...

2018-04-02 Thread bersprockets
Github user bersprockets commented on the issue: https://github.com/apache/spark/pull/20909 > actually have been thinking about skipping and proceeding the tests in pyspark/streaming/tests.py with an explicit message as well. Can we skip and continue the tests? Hi

[GitHub] spark pull request #20829: [SPARK-23690][ML] Add handleinvalid to VectorAsse...

2018-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20829 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20829: [SPARK-23690][ML] Add handleinvalid to VectorAssembler

2018-04-02 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/20829 LGTM Merging with master Thanks @yogeshg for the PR and @WeichenXu123 for taking a look! --- - To unsubscribe, e-mail:

[GitHub] spark issue #20945: [SPARK-23790][Mesos] fix metastore connection issue

2018-04-02 Thread susanxhuynh
Github user susanxhuynh commented on the issue: https://github.com/apache/spark/pull/20945 @skonto Basic question: in your example above, which user does the "krb5cc_65534" ticket cache belong to? The superuser or the proxy-user ("nobody")? ---

[GitHub] spark pull request #20964: [SPARK-22883] ML test for StructuredStreaming: sp...

2018-04-02 Thread jkbradley
GitHub user jkbradley opened a pull request: https://github.com/apache/spark/pull/20964 [SPARK-22883] ML test for StructuredStreaming: spark.ml.feature, I-M ## What changes were proposed in this pull request? Adds structured streaming tests using testTransformer for these

[GitHub] spark pull request #20955: [SPARK-23838][WEBUI] Running SQL query is display...

2018-04-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20955#discussion_r178677153 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/AllExecutionsPage.scala --- @@ -39,7 +39,7 @@ private[ui] class

[GitHub] spark pull request #20829: [SPARK-23690][ML] Add handleinvalid to VectorAsse...

2018-04-02 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/20829#discussion_r178676396 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/VectorAssembler.scala --- @@ -136,34 +181,106 @@ class VectorAssembler @Since("1.4.0")

[GitHub] spark pull request #20945: [SPARK-23790][Mesos] fix metastore connection iss...

2018-04-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20945#discussion_r178674129 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkHadoopUtil.scala --- @@ -123,7 +123,9 @@ class SparkHadoopUtil extends Logging { */

[GitHub] spark pull request #20945: [SPARK-23790][Mesos] fix metastore connection iss...

2018-04-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20945#discussion_r178675596 --- Diff: resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala --- @@ -506,6 +506,10 @@

[GitHub] spark pull request #20945: [SPARK-23790][Mesos] fix metastore connection iss...

2018-04-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20945#discussion_r178674293 --- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala --- @@ -197,6 +197,7 @@ class HadoopRDD[K, V]( val jobConf = getJobConf()

[GitHub] spark issue #20829: [SPARK-23690][ML] Add handleinvalid to VectorAssembler

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20829 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20829: [SPARK-23690][ML] Add handleinvalid to VectorAssembler

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20829 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88835/ Test PASSed. ---

[GitHub] spark issue #20829: [SPARK-23690][ML] Add handleinvalid to VectorAssembler

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20829 **[Test build #88835 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88835/testReport)** for PR 20829 at commit

[GitHub] spark issue #20781: [SPARK-23637][YARN]Yarn might allocate more resource if ...

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20781 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20781: [SPARK-23637][YARN]Yarn might allocate more resource if ...

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20781 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88837/ Test PASSed. ---

[GitHub] spark issue #20781: [SPARK-23637][YARN]Yarn might allocate more resource if ...

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20781 **[Test build #88837 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88837/testReport)** for PR 20781 at commit

[GitHub] spark pull request #20797: [SPARK-23583][SQL] Invoke should support interpre...

2018-04-02 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20797#discussion_r178670249 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala --- @@ -263,11 +295,21 @@ case class Invoke(

[GitHub] spark issue #20829: [SPARK-23690][ML] Add handleinvalid to VectorAssembler

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20829 **[Test build #88834 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88834/testReport)** for PR 20829 at commit

[GitHub] spark issue #20829: [SPARK-23690][ML] Add handleinvalid to VectorAssembler

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20829 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20829: [SPARK-23690][ML] Add handleinvalid to VectorAssembler

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20829 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88834/ Test PASSed. ---

[GitHub] spark issue #20781: [SPARK-23637][YARN]Yarn might allocate more resource if ...

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20781 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20781: [SPARK-23637][YARN]Yarn might allocate more resource if ...

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20781 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1912/

[GitHub] spark issue #20781: [SPARK-23637][YARN]Yarn might allocate more resource if ...

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20781 **[Test build #88837 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88837/testReport)** for PR 20781 at commit

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20938 **[Test build #88836 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88836/testReport)** for PR 20938 at commit

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-02 Thread mn-mikke
Github user mn-mikke commented on the issue: https://github.com/apache/spark/pull/20938 Rewrote test cases. @gatorsmile Please let me know if it's OK. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20963: [SPARK-23849][SQL] Tests for the samplingRatio option of...

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20963 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20963: [SPARK-23849][SQL] Tests for the samplingRatio option of...

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88828/ Test PASSed. ---

[GitHub] spark issue #20963: [SPARK-23849][SQL] Tests for the samplingRatio option of...

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20963 **[Test build #88828 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88828/testReport)** for PR 20963 at commit

[GitHub] spark issue #20781: [SPARK-23637][YARN]Yarn might allocate more resource if ...

2018-04-02 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20781 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20753 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20753 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88822/ Test PASSed. ---

[GitHub] spark issue #20753: [SPARK-23582][SQL] StaticInvoke should support interpret...

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20753 **[Test build #88822 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88822/testReport)** for PR 20753 at commit

[GitHub] spark pull request #20916: [SPARK-19964][core] Avoid reading from remote rep...

2018-04-02 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/20916#discussion_r178660701 --- Diff: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala --- @@ -106,6 +106,9 @@ class SparkSubmitSuite // Necessary to make

[GitHub] spark issue #20797: [SPARK-23583][SQL] Invoke should support interpreted exe...

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20797 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20797: [SPARK-23583][SQL] Invoke should support interpreted exe...

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20797 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88821/ Test PASSed. ---

[GitHub] spark issue #20797: [SPARK-23583][SQL] Invoke should support interpreted exe...

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20797 **[Test build #88821 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88821/testReport)** for PR 20797 at commit

[GitHub] spark issue #20829: [SPARK-23690][ML] Add handleinvalid to VectorAssembler

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20829 **[Test build #88835 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88835/testReport)** for PR 20829 at commit

[GitHub] spark pull request #20950: [SPARK-23834][test] Wait for connection before di...

2018-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20950 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, asc_nulls...

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20962 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88825/ Test PASSed. ---

[GitHub] spark issue #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, asc_nulls...

2018-04-02 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20962 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20962: [SPARK-23847][PYTHON][SQL]Add asc_nulls_first, asc_nulls...

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20962 **[Test build #88825 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88825/testReport)** for PR 20962 at commit

[GitHub] spark issue #20893: [SPARK-23785][LAUNCHER] LauncherBackend doesn't check st...

2018-04-02 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20893 Sure. Although I'm not sure why other committers who review PRs don't just merge them too... --- - To unsubscribe, e-mail:

[GitHub] spark issue #20893: [SPARK-23785][LAUNCHER] LauncherBackend doesn't check st...

2018-04-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20893 I see. Could you merge that PR? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20893: [SPARK-23785][LAUNCHER] LauncherBackend doesn't check st...

2018-04-02 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/20893 The test is fixed by #20950. Just push that one instead. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20893: [SPARK-23785][LAUNCHER] LauncherBackend doesn't check st...

2018-04-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20893 Let me revert this PR from the master. Please resubmit the PR after addressing the flaky tests. Thanks! --- - To

[GitHub] spark issue #20893: [SPARK-23785][LAUNCHER] LauncherBackend doesn't check st...

2018-04-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20893 cc @vanzin @sahilTakiar @jiangxb1987 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20893: [SPARK-23785][LAUNCHER] LauncherBackend doesn't check st...

2018-04-02 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/20893 Could we revert the PR from the master brach too?

[GitHub] spark issue #20829: [SPARK-23690][ML] Add handleinvalid to VectorAssembler

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20829 **[Test build #88834 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88834/testReport)** for PR 20829 at commit

[GitHub] spark issue #20951: [SPARK-23099][SS] Migrate foreach sink to DataSourceV2

2018-04-02 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20951 **[Test build #88833 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88833/testReport)** for PR 20951 at commit

  1   2   3   >