[GitHub] spark issue #21011: [SPARK-23916][SQL] Add array_join function

2018-04-10 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21011 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff test Pyth...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20904 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff test Pyth...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20904 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89102/ Test PASSed. ---

[GitHub] spark issue #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff test Pyth...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20904 **[Test build #89102 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89102/testReport)** for PR 20904 at commit

[GitHub] spark issue #21023: [SPARK-23949] makes && supports the function of predicat...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21023 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21023: [SPARK-23949] makes && supports the function of p...

2018-04-10 Thread httfighter
GitHub user httfighter opened a pull request: https://github.com/apache/spark/pull/21023 [SPARK-23949] makes && supports the function of predicate operator and [https://issues.apache.org/jira/browse/SPARK-23949](https://issues.apache.org/jira/browse/SPARK-23949) [SPARK-23949]

[GitHub] spark issue #21023: [SPARK-23949] makes && supports the function of predicat...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21023 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for Arr...

2018-04-10 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20984#discussion_r180364984 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala --- @@ -164,3 +167,46 @@ abstract class ArrayData extends

[GitHub] spark issue #20913: [SPARK-23799] FilterEstimation.evaluateInSet produces de...

2018-04-10 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20913 @mshtelma You shouldn't merge the changes and you need to rebase your pr. So, I think it's easy to close this pr and open a new pr as @jiangxb1987 suggested above. ---

[GitHub] spark pull request #19627: [SPARK-21088][ML][WIP] CrossValidator, TrainValid...

2018-04-10 Thread WeichenXu123
Github user WeichenXu123 closed the pull request at: https://github.com/apache/spark/pull/19627 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19627: [SPARK-21088][ML][WIP] CrossValidator, TrainValidationSp...

2018-04-10 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/19627 Because of codebase changing, I will create new PR to replace this one. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20984 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20984 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2136/

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20984 **[Test build #89105 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89105/testReport)** for PR 20984 at commit

[GitHub] spark pull request #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for Arr...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20984#discussion_r180361913 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala --- @@ -164,3 +167,40 @@ abstract class ArrayData extends

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20938 **[Test build #89104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89104/testReport)** for PR 20938 at commit

[GitHub] spark issue #21011: [SPARK-23916][SQL] Add array_join function

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21011 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89094/ Test FAILed. ---

[GitHub] spark issue #21011: [SPARK-23916][SQL] Add array_join function

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21011 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21011: [SPARK-23916][SQL] Add array_join function

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21011 **[Test build #89094 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89094/testReport)** for PR 21011 at commit

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/20938 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for Arr...

2018-04-10 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/20984#discussion_r180360146 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala --- @@ -164,3 +167,40 @@ abstract class ArrayData extends

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20984 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2135/

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20984 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20984 **[Test build #89103 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89103/testReport)** for PR 20984 at commit

[GitHub] spark pull request #20260: [SPARK-23039][SQL] Finish TODO work in alter tabl...

2018-04-10 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/spark/pull/20260#discussion_r180359425 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala --- @@ -787,7 +787,7 @@ private[spark] class

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20984 Thanks @kiszk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20964: [SPARK-22883] ML test for StructuredStreaming: spark.ml....

2018-04-10 Thread WeichenXu123
Github user WeichenXu123 commented on the issue: https://github.com/apache/spark/pull/20964 LGTM. 👍 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for Arr...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20984#discussion_r180358272 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/ArrayDataIndexedSeqSuite.scala --- @@ -0,0 +1,69 @@ +/* + * Licensed to

[GitHub] spark pull request #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for Arr...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20984#discussion_r180357829 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala --- @@ -164,3 +167,37 @@ abstract class ArrayData extends

[GitHub] spark pull request #20981: [SPARK-23873][SQL] Use accessors in interpreted L...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20981#discussion_r180356541 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala --- @@ -119,4 +119,26 @@ object InternalRow { case v: MapData

[GitHub] spark pull request #20981: [SPARK-23873][SQL] Use accessors in interpreted L...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20981#discussion_r180356241 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala --- @@ -119,4 +119,26 @@ object InternalRow { case v: MapData

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20938 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89093/ Test FAILed. ---

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20938 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21022: Fpga acc

2018-04-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21022 @gczsjdy is this mistakenly open? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20938 **[Test build #89093 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89093/testReport)** for PR 20938 at commit

[GitHub] spark issue #21022: Fpga acc

2018-04-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21022 @gczsjdy seems mistakenly open ... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff test Pyth...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20904 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff test Pyth...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20904 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2134/

[GitHub] spark issue #20984: [SPARK-23875][SQL] Add IndexedSeq wrapper for ArrayData

2018-04-10 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/20984 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20981: [SPARK-23873][SQL] Use accessors in interpreted LambdaVa...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20981 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20981: [SPARK-23873][SQL] Use accessors in interpreted LambdaVa...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20981 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2133/

[GitHub] spark issue #20904: [SPARK-23751][ML][PySpark] Kolmogorov-Smirnoff test Pyth...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20904 **[Test build #89102 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89102/testReport)** for PR 20904 at commit

[GitHub] spark issue #20981: [SPARK-23873][SQL] Use accessors in interpreted LambdaVa...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20981 **[Test build #89101 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89101/testReport)** for PR 20981 at commit

[GitHub] spark issue #20998: [SPARK-23888][CORE] speculative task should not run on a...

2018-04-10 Thread Ngone51
Github user Ngone51 commented on the issue: https://github.com/apache/spark/pull/20998 Hi, @mridulm, thank for your comment. Actually, I have the same worry with you. May be we can make this change as a second choice for `hasAttemptOnHost `, in case of there's really no other hosts

[GitHub] spark pull request #20996: [SPARK-23884][CORE] hasLaunchedTask should be tru...

2018-04-10 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/20996#discussion_r180347526 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -370,12 +370,10 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark issue #21007: [SPARK-23942][PYTHON][SQL] Makes collect in PySpark as a...

2018-04-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21007 Will address the comments together soon. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-04-10 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r180345994 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -84,19 +84,50 @@ object ReorderJoin extends

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-04-10 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r180346211 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala --- @@ -84,19 +84,49 @@ object ReorderJoin extends

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-04-10 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r180327289 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala --- @@ -172,17 +174,20 @@ object ExtractFiltersAndInnerJoins

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-04-10 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r180344569 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -59,12 +75,7 @@ class JoinOptimizationSuite

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-04-10 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r180328615 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -145,4 +161,55 @@ class

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-04-10 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r180344118 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -116,7 +127,12 @@ class

[GitHub] spark pull request #20345: [SPARK-23172][SQL] Expand the ReorderJoin rule to...

2018-04-10 Thread wzhfy
Github user wzhfy commented on a diff in the pull request: https://github.com/apache/spark/pull/20345#discussion_r180340667 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/JoinOptimizationSuite.scala --- @@ -46,6 +48,20 @@ class JoinOptimizationSuite

[GitHub] spark pull request #20913: [SPARK-23799] FilterEstimation.evaluateInSet prod...

2018-04-10 Thread mshtelma
Github user mshtelma commented on a diff in the pull request: https://github.com/apache/spark/pull/20913#discussion_r180343432 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/FilterEstimation.scala --- @@ -427,7 +427,11 @@ case

[GitHub] spark pull request #20996: [SPARK-23884][CORE] hasLaunchedTask should be tru...

2018-04-10 Thread jiangxb1987
Github user jiangxb1987 commented on a diff in the pull request: https://github.com/apache/spark/pull/20996#discussion_r180341726 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -370,12 +370,10 @@ private[spark] class TaskSchedulerImpl(

[GitHub] spark issue #20046: [SPARK-22362][SQL] Add unit test for Window Aggregate Fu...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20046 **[Test build #89100 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89100/testReport)** for PR 20046 at commit

[GitHub] spark pull request #21007: [SPARK-23942][PYTHON][SQL] Makes collect in PySpa...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21007#discussion_r180337840 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3312,10 +3313,15 @@ class Dataset[T] private[sql]( /** Convert to

[GitHub] spark pull request #21007: [SPARK-23942][PYTHON][SQL] Makes collect in PySpa...

2018-04-10 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21007#discussion_r180333465 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3189,10 +3189,10 @@ class Dataset[T] private[sql]( private[sql] def

[GitHub] spark issue #20913: [SPARK-23799] FilterEstimation.evaluateInSet produces de...

2018-04-10 Thread mshtelma
Github user mshtelma commented on the issue: https://github.com/apache/spark/pull/20913 @jiangxb1987 @wzhfy Done. I have merged the latest changes from master. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21022: Fpga acc

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21022 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20977: [SPARK-23867][Scheduler] use droppedCount in logWarning

2018-04-10 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20977 Also cc @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21022: Fpga acc

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21022 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21022: Fpga acc

2018-04-10 Thread gczsjdy
GitHub user gczsjdy opened a pull request: https://github.com/apache/spark/pull/21022 Fpga acc You can merge this pull request into a Git repository by running: $ git pull https://github.com/gczsjdy/spark fpga_acc Alternatively you can review and apply these changes as the

[GitHub] spark issue #20913: [SPARK-23799] FilterEstimation.evaluateInSet produces de...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20913 **[Test build #89099 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89099/testReport)** for PR 20913 at commit

[GitHub] spark issue #21014: [SPARK-23941][Mesos] Mesos task failed on specific spark...

2018-04-10 Thread tiboun
Github user tiboun commented on the issue: https://github.com/apache/spark/pull/21014 IMO, mainClass doesn't need the same because space is not allowed but pyFiles may have the same fix because it's a path. Do you want me to apply the shellEscape as well for pyFiles? ---

[GitHub] spark issue #20535: [SPARK-23341][SQL] define some standard options for data...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20535 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20535: [SPARK-23341][SQL] define some standard options for data...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20535 **[Test build #89098 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89098/testReport)** for PR 20535 at commit

[GitHub] spark issue #20535: [SPARK-23341][SQL] define some standard options for data...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20535 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2132/

[GitHub] spark issue #21017: [SPARK-23748][SS] Fix SS continuous process doesn't supp...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21017 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2131/

[GitHub] spark issue #21017: [SPARK-23748][SS] Fix SS continuous process doesn't supp...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21017 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21019: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21019 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2130/

[GitHub] spark issue #21019: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21019 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21019: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21019 **[Test build #89097 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89097/testReport)** for PR 21019 at commit

[GitHub] spark issue #21019: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-10 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/21019 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21017: [SPARK-23748][SS] Fix SS continuous process doesn't supp...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21017 **[Test build #89096 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89096/testReport)** for PR 21017 at commit

[GitHub] spark issue #21017: [SPARK-23748][SS] Fix SS continuous process doesn't supp...

2018-04-10 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/21017 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2129/

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21021 **[Test build #89095 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89095/testReport)** for PR 21021 at commit

[GitHub] spark issue #21007: [SPARK-23942][PYTHON][SQL] Makes collect in PySpark as a...

2018-04-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21007 Will give a shot first for the Python one to show how it looks like. I have an incomplete one in my local. --- - To

[GitHub] spark issue #21011: [SPARK-23916][SQL] Add array_join function

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21011 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2128/

[GitHub] spark issue #21011: [SPARK-23916][SQL] Add array_join function

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21011 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21011: [SPARK-23916][SQL] Add array_join function

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21011 **[Test build #89094 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89094/testReport)** for PR 21011 at commit

[GitHub] spark issue #20983: [SPARK-23747][Structured Streaming] Add EpochCoordinator...

2018-04-10 Thread efimpoberezkin
Github user efimpoberezkin commented on the issue: https://github.com/apache/spark/pull/20983 @jose-torres --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21007: [SPARK-23942][PYTHON][SQL] Makes collect in PySpark as a...

2018-04-10 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21007 got it. sorry I missed the last sentence. maybe a jvm only test? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21013: [WIP][SPARK-23874][SQL][PYTHON] Upgrade Arrow and pyarro...

2018-04-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21013 I think it should work for 0.8.0+ too in perspective of Python and I think it should be best to have at least minimum combination for those versions ... Wait wait .. this PR doesn't

[GitHub] spark issue #16578: [SPARK-4502][SQL] Parquet nested column pruning

2018-04-10 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/16578 hi - where are we on this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21006: [SPARK-22256][MESOS] - Introduce spark.mesos.driver.memo...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21006 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89091/ Test PASSed. ---

[GitHub] spark issue #21006: [SPARK-22256][MESOS] - Introduce spark.mesos.driver.memo...

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21006 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21006: [SPARK-22256][MESOS] - Introduce spark.mesos.driver.memo...

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21006 **[Test build #89091 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89091/testReport)** for PR 21006 at commit

[GitHub] spark issue #21008: [SPARK-23902][SQL] Add roundOff flag to months_between

2018-04-10 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21008 thanks @gatorsmile. I updated the comment. Any more comments? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21013: [WIP][SPARK-23874][SQL][PYTHON] Upgrade Arrow and pyarro...

2018-04-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21013 Yea ... I think that's actually the most tricky one in this issue. We have a similar issue about it in R IIRC. --- - To

[GitHub] spark issue #21007: [SPARK-23942][PYTHON][SQL] Makes collect in PySpark as a...

2018-04-10 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21007 Yup, will add. I was just hesitant because It needs some complexity for testing out (as described in the PR description) whereas the fix could be quite straightforward. ---

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2127/

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20913: [SPARK-23799] FilterEstimation.evaluateInSet produces de...

2018-04-10 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/20913 @mshtelma You can close this PR and open a new one instead. --- - To unsubscribe, e-mail:

[GitHub] spark issue #20360: [SPARK-23177][SQL][PySpark] Extract zero-parameter UDFs ...

2018-04-10 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20360 @hankim maybe like: ``` import pyspark.sql.functions as f import uuid df = spark.createDataFrame([(1,2), (3,4)]) f_udf = f.udf(lambda: str(uuid.uuid4())) df2 =

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20938 **[Test build #89093 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89093/testReport)** for PR 20938 at commit

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-04-10 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21021 **[Test build #89092 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89092/testReport)** for PR 21021 at commit

[GitHub] spark issue #21013: [WIP][SPARK-23874][SQL][PYTHON] Upgrade Arrow and pyarro...

2018-04-10 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21013 hmm, btw, if we upgrade arrow on Jenkins, how does it affect other branches like 2.3? --- - To unsubscribe, e-mail:

<    2   3   4   5   6   7   8   >