[GitHub] spark issue #19881: [SPARK-22683][CORE] Add a fullExecutorAllocationDivisor ...

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/19881 **[Test build #89467 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89467/testReport)** for PR 19881 at commit

[GitHub] spark issue #21061: [SPARK-23914][SQL] Add array_union function

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21061 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2401/

[GitHub] spark issue #21061: [SPARK-23914][SQL] Add array_union function

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21061 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20938 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89453/ Test PASSed. ---

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20938 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21070: [SPARK-23972][BUILD][SQL] Update Parquet to 1.10....

2018-04-17 Thread scottcarey
Github user scottcarey commented on a diff in the pull request: https://github.com/apache/spark/pull/21070#discussion_r182161734 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedPlainValuesReader.java --- @@ -63,115 +59,159 @@ public

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20938 **[Test build #89453 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89453/testReport)** for PR 20938 at commit

[GitHub] spark issue #21074: [SPARK-21811][SQL] Fix the inconsistency behavior when f...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21074 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89463/ Test FAILed. ---

[GitHub] spark issue #21074: [SPARK-21811][SQL] Fix the inconsistency behavior when f...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21074 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21061: [SPARK-23914][SQL] Add array_union function

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21061 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2400/

[GitHub] spark issue #21074: [SPARK-21811][SQL] Fix the inconsistency behavior when f...

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21074 **[Test build #89463 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89463/testReport)** for PR 21074 at commit

[GitHub] spark issue #20319: [SPARK-22884][ML][TESTS] ML test for StructuredStreaming...

2018-04-17 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/20319 Reviewing now! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21061: [SPARK-23914][SQL] Add array_union function

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21061 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21061: [SPARK-23914][SQL] Add array_union function

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21061 **[Test build #89466 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89466/testReport)** for PR 21061 at commit

[GitHub] spark issue #21085: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21085 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89457/ Test FAILed. ---

[GitHub] spark issue #21085: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21085 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #20695: [SPARK-21741][ML][PySpark] Python API for DataFra...

2018-04-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20695 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21085: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21085 **[Test build #89457 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89457/testReport)** for PR 21085 at commit

[GitHub] spark issue #20695: [SPARK-21741][ML][PySpark] Python API for DataFrame-base...

2018-04-17 Thread jkbradley
Github user jkbradley commented on the issue: https://github.com/apache/spark/pull/20695 LGTM Thanks for the PR! Merging with master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21087: [SPARK-23997][SQL] Configurable maximum number of bucket...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21087 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21087: [SPARK-23997][SQL] Configurable maximum number of bucket...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21087 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21087: [SPARK-23997][SQL] Configurable maximum number of...

2018-04-17 Thread ferdonline
GitHub user ferdonline opened a pull request: https://github.com/apache/spark/pull/21087 [SPARK-23997][SQL] Configurable maximum number of buckets ## What changes were proposed in this pull request? This PR implements the possibility of the user to override the maximum number

[GitHub] spark issue #21068: [SPARK-16630][YARN] Blacklist a node if executors won't ...

2018-04-17 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/21068 > actually the only other thing I need to make sure is there aren't any delays if we now send the information from yarn allocator back to scheduler and then I assume it would need to get it back

[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

2018-04-17 Thread aviv-ebates
Github user aviv-ebates commented on the issue: https://github.com/apache/spark/pull/21057 If you're not clear about what I've done here, ask away. I don't wish to create a jira account in addition; Feel free to create whatever tickets you think are required. I've already paid my

[GitHub] spark pull request #21080: [SPARK-23986][SQL] freshName can generate non-uni...

2018-04-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21080 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21080: [SPARK-23986][SQL] freshName can generate non-unique nam...

2018-04-17 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21080 thanks, merging to master/2.3! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21019: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-17 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/21019 I guess I rely entirely on the merge script, but in these simple cases I should just do the push directly ... --- - To

[GitHub] spark issue #21080: [SPARK-23986][SQL] freshName can generate non-unique nam...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21080 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89455/ Test PASSed. ---

[GitHub] spark issue #21080: [SPARK-23986][SQL] freshName can generate non-unique nam...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21080 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21080: [SPARK-23986][SQL] freshName can generate non-unique nam...

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21080 **[Test build #89455 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89455/testReport)** for PR 21080 at commit

[GitHub] spark issue #21019: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-17 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/21019 > I don't see a way to do that without another PR. git cherry-pick -x -s && git push --- - To unsubscribe, e-mail:

[GitHub] spark issue #20787: [MINOR][DOCS] Documenting months_between direction

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20787 **[Test build #89465 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89465/testReport)** for PR 20787 at commit

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20938 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89454/ Test FAILed. ---

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20938 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20938: [SPARK-23821][SQL] Collection function: flatten

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20938 **[Test build #89454 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89454/testReport)** for PR 20938 at commit

[GitHub] spark issue #21086: [SPARK-24002] [SQL] Task not serializable caused by org....

2018-04-17 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21086 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21086: [SPARK-24002] [SQL] Task not serializable caused by org....

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21086 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2399/

[GitHub] spark issue #21086: [SPARK-24002] [SQL] Task not serializable caused by org....

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21086 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21086: [SPARK-24002] [SQL] Task not serializable caused by org....

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21086 **[Test build #89464 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89464/testReport)** for PR 21086 at commit

[GitHub] spark issue #20997: [SPARK-19185] [DSTREAMS] Avoid concurrent use of cached ...

2018-04-17 Thread koeninger
Github user koeninger commented on the issue: https://github.com/apache/spark/pull/20997 I think if we can't come up with a pool design now that solves most of the issues, we should switch back to the one cached consumer approach that the SQL code is using. On Mon, Apr

[GitHub] spark issue #21086: [SPARK-24002] [SQL] Task not serializable caused by org....

2018-04-17 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21086 cc @cloud-fan @zsxwing --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21086: [SPARK-24002] [SQL] Task not serializable caused ...

2018-04-17 Thread gatorsmile
GitHub user gatorsmile opened a pull request: https://github.com/apache/spark/pull/21086 [SPARK-24002] [SQL] Task not serializable caused by org.apache.parquet.io.api.Binary$ByteBufferBackedBinary.getBytes ## What changes were proposed in this pull request? ```

[GitHub] spark issue #21068: [SPARK-16630][YARN] Blacklist a node if executors won't ...

2018-04-17 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/21068 actually the only other thing I need to make sure is there aren't any delays if we now send the information from yarn allocator back to scheduler and then I assume it would need to get it back

[GitHub] spark issue #21011: [SPARK-23916][SQL] Add array_join function

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21011 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89451/ Test PASSed. ---

[GitHub] spark issue #21011: [SPARK-23916][SQL] Add array_join function

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21011 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21011: [SPARK-23916][SQL] Add array_join function

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21011 **[Test build #89451 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89451/testReport)** for PR 21011 at commit

[GitHub] spark issue #21074: [SPARK-21811][SQL] Fix the inconsistency behavior when f...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21074 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2398/

[GitHub] spark issue #21074: [SPARK-21811][SQL] Fix the inconsistency behavior when f...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21074 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21074: [SPARK-21811][SQL] Fix the inconsistency behavior when f...

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21074 **[Test build #89463 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89463/testReport)** for PR 21074 at commit

[GitHub] spark issue #21082: [SPARK-22239][SQL][Python][WIP] Enable grouped aggregate...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21082 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21082: [SPARK-22239][SQL][Python][WIP] Enable grouped aggregate...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21082 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2397/

[GitHub] spark issue #21082: [SPARK-22239][SQL][Python][WIP] Enable grouped aggregate...

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21082 **[Test build #89462 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89462/testReport)** for PR 21082 at commit

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21029 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21029 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2396/

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21029 **[Test build #89461 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89461/testReport)** for PR 21029 at commit

[GitHub] spark issue #21072: [SPARK-23973][SQL] Remove consecutive Sorts

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21072 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21072: [SPARK-23973][SQL] Remove consecutive Sorts

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21072 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89449/ Test PASSed. ---

[GitHub] spark issue #21085: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-17 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21085 LGTM! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21072: [SPARK-23973][SQL] Remove consecutive Sorts

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21072 **[Test build #89449 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89449/testReport)** for PR 21072 at commit

[GitHub] spark issue #20998: [SPARK-23888][CORE] correct the comment of hasAttemptOnH...

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20998 **[Test build #89460 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89460/testReport)** for PR 20998 at commit

[GitHub] spark pull request #21074: [SPARK-21811][SQL] Fix the inconsistency behavior...

2018-04-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21074#discussion_r182100748 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -176,16 +176,16 @@ object TypeCoercion { }

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89450/ Test PASSed. ---

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21028 **[Test build #89450 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89450/testReport)** for PR 21028 at commit

[GitHub] spark issue #20998: [SPARK-23888][CORE] speculative task should not run on a...

2018-04-17 Thread Ngone51
Github user Ngone51 commented on the issue: https://github.com/apache/spark/pull/20998 Will do, and it's okay. My view limited in the source code yet, but you guys have more practical experience. So I learned from your points. It's beneficial. ---

[GitHub] spark issue #21074: [SPARK-21811][SQL] Fix the inconsistency behavior when f...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21074 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21074: [SPARK-21811][SQL] Fix the inconsistency behavior when f...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21074 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2395/

[GitHub] spark issue #21074: [SPARK-21811][SQL] Fix the inconsistency behavior when f...

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21074 **[Test build #89459 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89459/testReport)** for PR 21074 at commit

[GitHub] spark issue #21057: [MINOR][PYTHON] 2 Improvements to Pyspark docs

2018-04-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21057 It would be helpful if you open a JIRA and describe the issue. It could help other guys think a better way to test or would give clearer ideas to see if it's really difficult to add a test.

[GitHub] spark issue #21076: Creating KafkaStreamToCassandra

2018-04-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21076 Yea, I think we should better leave this closed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21029 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21029 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89458/ Test FAILed. ---

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21029 **[Test build #89458 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89458/testReport)** for PR 21029 at commit

[GitHub] spark pull request #21068: [SPARK-16630][YARN] Blacklist a node if executors...

2018-04-17 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/21068#discussion_r181880503 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala --- @@ -328,4 +328,26 @@ package object config {

[GitHub] spark pull request #21068: [SPARK-16630][YARN] Blacklist a node if executors...

2018-04-17 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/21068#discussion_r181881863 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala --- @@ -328,4 +328,26 @@ package object config {

[GitHub] spark issue #20604: [SPARK-23365][CORE] Do not adjust num executors when kil...

2018-04-17 Thread Ngone51
Github user Ngone51 commented on the issue: https://github.com/apache/spark/pull/20604 > I'd go even further and suggest that with this fix in, we can actually remove SPARK-21834, as its no longer necessary. Yes, otherwise, this PR's work is meaningless. ---

[GitHub] spark pull request #21068: [SPARK-16630][YARN] Blacklist a node if executors...

2018-04-17 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/21068#discussion_r181814472 --- Diff: core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala --- @@ -216,6 +216,10 @@ private[scheduler] class BlacklistTracker (

[GitHub] spark pull request #21068: [SPARK-16630][YARN] Blacklist a node if executors...

2018-04-17 Thread tgravescs
Github user tgravescs commented on a diff in the pull request: https://github.com/apache/spark/pull/21068#discussion_r181882445 --- Diff: resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala --- @@ -328,4 +328,26 @@ package object config {

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21029 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21029 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2394/

[GitHub] spark pull request #20604: [SPARK-23365][CORE] Do not adjust num executors w...

2018-04-17 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/20604#discussion_r182086337 --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala --- @@ -1643,7 +1646,10 @@ class SparkContext(config: SparkConf) extends Logging {

[GitHub] spark issue #21085: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21085 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21085: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21085 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2393/

[GitHub] spark issue #21029: [SPARK-23952] remove type parameter in DataReaderFactory

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21029 **[Test build #89458 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89458/testReport)** for PR 21029 at commit

[GitHub] spark issue #21085: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21085 **[Test build #89457 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89457/testReport)** for PR 21085 at commit

[GitHub] spark issue #21085: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-17 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/21085 clean cherry-pick of https://github.com/apache/spark/pull/21019, I just forgot to merge back to 2.3 --- - To unsubscribe,

[GitHub] spark issue #21019: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-17 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/21019 a few minutes after merging this I realized I should have also merged to branch 2.3. I don't see a way to do that without another PR. oops. I opened this, its a clean cherry-pick

[GitHub] spark pull request #21085: [SPARK-23948] Trigger mapstage's job listener in ...

2018-04-17 Thread squito
GitHub user squito opened a pull request: https://github.com/apache/spark/pull/21085 [SPARK-23948] Trigger mapstage's job listener in submitMissingTasks ## What changes were proposed in this pull request? SparkContext submitted a map stage from `submitMapStage` to

[GitHub] spark issue #20998: [SPARK-23888][CORE] speculative task should not run on a...

2018-04-17 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/20998 @Ngone51 can you instead leave the behavior as is, and just update the comment? Sorry that its going to be a small change in the end, and all the extra work the bad comments led you to do,

[GitHub] spark pull request #21019: [SPARK-23948] Trigger mapstage's job listener in ...

2018-04-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21019 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21019: [SPARK-23948] Trigger mapstage's job listener in submitM...

2018-04-17 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/21019 merged to master, thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #19868: [SPARK-22676] Avoid iterating all partition paths...

2018-04-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/19868 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #19868: [SPARK-22676] Avoid iterating all partition paths when s...

2018-04-17 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19868 thanks, merging to master! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-17 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/20976 ah, a late LGTM. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #19868: [SPARK-22676] Avoid iterating all partition paths when s...

2018-04-17 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/19868 nvm, the new test follows the existing code style in this file. Feel free to address them in followup PR. --- - To

[GitHub] spark pull request #20976: [SPARK-23835][SQL] Add not-null check to Tuples' ...

2018-04-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20976 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20976: [SPARK-23835][SQL] Add not-null check to Tuples' argumen...

2018-04-17 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20976 thanks, merging to master/2.3! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #19868: [SPARK-22676] Avoid iterating all partition paths...

2018-04-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19868#discussion_r182077103 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala --- @@ -70,6 +71,45 @@ class QueryPartitionSuite extends QueryTest

[GitHub] spark pull request #19868: [SPARK-22676] Avoid iterating all partition paths...

2018-04-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19868#discussion_r182075854 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala --- @@ -70,6 +71,45 @@ class QueryPartitionSuite extends QueryTest

[GitHub] spark pull request #19868: [SPARK-22676] Avoid iterating all partition paths...

2018-04-17 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/19868#discussion_r182075379 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/QueryPartitionSuite.scala --- @@ -70,6 +71,45 @@ class QueryPartitionSuite extends QueryTest

<    1   2   3   4   5   >