Github user adyatlov commented on a diff in the pull request:
https://github.com/apache/spark/pull/20641#discussion_r182013144
--- Diff:
resource-managers/mesos/src/test/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterSchedulerSuite.scala
---
@@ -199,6 +199,38 @@ class
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21072
@henryr thanks, I added the test cases you suggested :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21072
**[Test build #89445 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89445/testReport)**
for PR 21072 at commit
Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/20888#discussion_r182011978
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameRangeSuite.scala ---
@@ -156,43 +156,52 @@ class DataFrameRangeSuite extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/21084
@eatoncys what issue are you trying to solve?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20976
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2384/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20976
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20976
**[Test build #89444 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89444/testReport)**
for PR 20976 at commit
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17086#discussion_r182004759
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/evaluation/MulticlassMetrics.scala
---
@@ -27,10 +27,11 @@ import
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17086#discussion_r182002432
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/MulticlassClassificationEvaluator.scala
---
@@ -67,6 +68,10 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20984
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20984
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2383/
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17086#discussion_r182003965
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/evaluation/MulticlassClassificationEvaluator.scala
---
@@ -75,11 +80,16 @@ class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20984
**[Test build #89443 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89443/testReport)**
for PR 20984 at commit
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21083
@cloud-fan the approach itself seems OK to me. Indeed, I prefer this one
over the previous status where we had `constraints` enforced on the output and
`allConstraints` containing also the others:
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20984
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20938
**[Test build #89442 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89442/testReport)**
for PR 20938 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20984
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89434/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20984
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20984
**[Test build #89434 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89434/testReport)**
for PR 20984 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17461
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21080
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21080
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2382/
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21080
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21080
**[Test build #89441 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89441/testReport)**
for PR 21080 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20828
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21025
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/20828
LGTM. Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21025
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21078
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21078
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2381/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21084
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2380/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21084
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21078
**[Test build #89440 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89440/testReport)**
for PR 21078 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21084
**[Test build #89439 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89439/testReport)**
for PR 21084 at commit
GitHub user eatoncys opened a pull request:
https://github.com/apache/spark/pull/21084
[SPARK-23998][Core]It may be better to add @transient to field
'taskMemoryManager' in class Task, for it is only be set and used in executor
side
Add @transient to field 'taskMemoryManager' in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19868
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19868
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2379/
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/20976
LGTM, can you add an end-to-end test case in `DatasetSuite`?
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19868
**[Test build #89438 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89438/testReport)**
for PR 19868 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21019
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2378/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21019
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19868
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21019
**[Test build #89437 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89437/testReport)**
for PR 21019 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21083
It's a totally different approach to do additional filters inference from
constraints for join, and I'm not sure if it works until I finished this PR.
That's the main reason I didn't post my
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/21019
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/21019
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2377/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21029
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21083
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21083
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2376/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21029
**[Test build #89436 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89436/testReport)**
for PR 21029 at commit
Github user guoxiaolongzte commented on the issue:
https://github.com/apache/spark/pull/21036
Thank you for your comments, I will close this PR, thanks.
---
-
To unsubscribe, e-mail:
Github user guoxiaolongzte closed the pull request at:
https://github.com/apache/spark/pull/21036
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21083
**[Test build #89435 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89435/testReport)**
for PR 21083 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20984
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2375/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20984
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20787#discussion_r181971230
--- Diff: R/pkg/R/functions.R ---
@@ -1957,8 +1958,11 @@ setMethod("levenshtein", signature(y = "Column"),
})
#' @details
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20984
**[Test build #89434 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89434/testReport)**
for PR 20984 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/20984
retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20984
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19868
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21019
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89426/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20984
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20984
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89429/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20984
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89428/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19868
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89424/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21019
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21083
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21083
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21083
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89431/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21083
**[Test build #89431 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89431/testReport)**
for PR 21083 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21019
**[Test build #89426 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89426/testReport)**
for PR 21019 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21083
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89432/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20984
**[Test build #89428 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89428/testReport)**
for PR 20984 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19868
**[Test build #89424 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89424/testReport)**
for PR 19868 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21083
**[Test build #89432 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89432/testReport)**
for PR 21083 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20984
**[Test build #89429 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89429/testReport)**
for PR 20984 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21079
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2374/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21079
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21079
**[Test build #89433 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89433/testReport)**
for PR 21079 at commit
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21083
cc @mgaido91 @maryannxue @KaiXinXiaoLei @gatorsmile @jiangxb1987
@gengliangwang: I do not think this is the right way to do things, @cloud-fan.
Looks like you have been aware of my and others'
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21080#discussion_r181966326
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -575,7 +575,7 @@ class CodegenContext
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21083
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2373/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21083
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21083
**[Test build #89432 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89432/testReport)**
for PR 21083 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21083
**[Test build #89431 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89431/testReport)**
for PR 21083 at commit
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/21083
cc @mgaido91 @maryannxue @KaiXinXiaoLei @gatorsmile @jiangxb1987
@gengliangwang
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20984
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89425/
Test PASSed.
---
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/21083
[SPARK-21479][SPARK-23564][SQL] infer additional filters from constraints
for join's children
## What changes were proposed in this pull request?
The existing query constraints
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20984
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20984
**[Test build #89425 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89425/testReport)**
for PR 20984 at commit
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21036#discussion_r181963024
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -323,7 +323,7 @@ package object config {
.internal()
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21036
nope it's a radical change that affects many of integrations. I wouldn't
enable it by default for now. here is non-critical path. It's fine to loop
twice if it's more readable.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21029
**[Test build #89430 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/89430/testReport)**
for PR 21029 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21029
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89430/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21029
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21029
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21029
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2372/
401 - 499 of 499 matches
Mail list logo
