[GitHub] spark issue #21214: [SPARK-23775][TEST] Make DataFrameRangeSuite not flaky

2018-05-03 Thread jiangxb1987
Github user jiangxb1987 commented on the issue: https://github.com/apache/spark/pull/21214 > but the thread killing left the shared SparkContext sometimes in a state where further jobs can't be submitted. Just curious how this happened? ---

[GitHub] spark issue #21224: [SPARK-24167][SQL] ParquetFilters should not access SQLC...

2018-05-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21224 @cloud-fan, the change seems fine but would there be any clever trick to test this? Seems we could very likely do the similar thing by mistake. ---

[GitHub] spark pull request #21219: [SPARK-24160] ShuffleBlockFetcherIterator should ...

2018-05-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21219#discussion_r185788654 --- Diff: core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala --- @@ -407,6 +407,25 @@ final class

[GitHub] spark pull request #21227: Backport [SPARK-24133][SQL] Check for integer ove...

2018-05-03 Thread ala
Github user ala commented on a diff in the pull request: https://github.com/apache/spark/pull/21227#discussion_r185787003 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java --- @@ -81,7 +81,9 @@ public void close() { }

[GitHub] spark issue #21228: [SPARK-24171] Adding a note for non-deterministic functi...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21228 **[Test build #90124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90124/testReport)** for PR 21228 at commit

[GitHub] spark issue #21215: [SPARK-24148][SQL] Overloading array function to support...

2018-05-03 Thread lokm01
Github user lokm01 commented on the issue: https://github.com/apache/spark/pull/21215 @maropu Thanks! Didn't know about creating a literal this way. Don't you feel that the suggested change is way more elegant? ---

[GitHub] spark issue #21228: [SPARK-24171] Adding a note for non-deterministic functi...

2018-05-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21228 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21228: [SPARK-24171] Adding a note for non-deterministic functi...

2018-05-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21228 add to whitelist --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21228: [SPARK-24171] Adding a note for non-deterministic...

2018-05-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21228#discussion_r185783283 --- Diff: python/pyspark/sql/functions.py --- @@ -151,13 +151,15 @@ def _(): _collect_list_doc = """ Aggregate function: returns a

[GitHub] spark pull request #21228: [SPARK-24171] Adding a note for non-deterministic...

2018-05-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21228#discussion_r185783224 --- Diff: R/pkg/R/functions.R --- @@ -818,6 +818,7 @@ setMethod("factorial", #' first(df$c, TRUE) #' } #' @note first(characterOrColumn)

[GitHub] spark pull request #21228: [SPARK-24171] Adding a note for non-deterministic...

2018-05-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21228#discussion_r185783395 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -115,15 +115,15 @@ case class CurrentDatabase()

[GitHub] spark pull request #21228: [SPARK-24171] Adding a note for non-deterministic...

2018-05-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21228#discussion_r185784205 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala --- @@ -94,9 +94,10 @@ object Rand { }

[GitHub] spark pull request #21228: [SPARK-24171] Adding a note for non-deterministic...

2018-05-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21228#discussion_r185784148 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -561,6 +571,7 @@ object functions { * The function by default

[GitHub] spark pull request #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21054#discussion_r185783983 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala --- @@ -36,6 +36,8 @@ case class Fact(date: Int, hour: Int, minute:

[GitHub] spark pull request #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21054#discussion_r185783832 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala --- @@ -686,4 +687,72 @@ class DataFrameAggregateSuite extends

[GitHub] spark pull request #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-05-03 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21028#discussion_r185783290 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -19,14 +19,41 @@ package

[GitHub] spark issue #21215: [SPARK-24148][SQL] Overloading array function to support...

2018-05-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21215 Like this? ``` scala> val structTy = StructType.fromDDL("a ARRAY") structTy: org.apache.spark.sql.types.StructType =

[GitHub] spark issue #21228: [SPARK-24171] Adding a note for non-deterministic functi...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21228 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-05-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21028#discussion_r185781375 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -378,6 +405,127 @@ case class

[GitHub] spark issue #21228: [SPARK-24171] Adding a note for non-deterministic functi...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21228 **[Test build #90123 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90123/testReport)** for PR 21228 at commit

[GitHub] spark issue #21228: [SPARK-24171] Adding a note for non-deterministic functi...

2018-05-03 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/21228 @juliuszsompolski please, look at it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21228: [SPARK-24171] Adding a note for non-deterministic...

2018-05-03 Thread MaxGekk
GitHub user MaxGekk opened a pull request: https://github.com/apache/spark/pull/21228 [SPARK-24171] Adding a note for non-deterministic functions ## What changes were proposed in this pull request? I propose to add a clear statement for functions like `collect_list()`

[GitHub] spark pull request #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-05-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21028#discussion_r185780243 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -19,14 +19,41 @@ package

[GitHub] spark issue #21215: [SPARK-24148][SQL] Overloading array function to support...

2018-05-03 Thread lokm01
Github user lokm01 commented on the issue: https://github.com/apache/spark/pull/21215 @maropu That would work if you had scala case classes for all the types. In our case, we're working on a generic framework, where we only have Spark schemas (and I'd rather not generate case classes

[GitHub] spark issue #20947: [SPARK-23705][SQL]Handle non-distinct columns in DataSet...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20947 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2865/

[GitHub] spark issue #21223: [SPARK-24166][SQL] InMemoryTableScanExec should not acce...

2018-05-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21223 thanks, merging to master/2.3! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20947: [SPARK-23705][SQL]Handle non-distinct columns in DataSet...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20947 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21214: [SPARK-23775][TEST] Make DataFrameRangeSuite not flaky

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21214 **[Test build #90122 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90122/testReport)** for PR 21214 at commit

[GitHub] spark issue #21070: [SPARK-23972][BUILD][SQL] Update Parquet to 1.10.0.

2018-05-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21070 Simple scan benchmarks: code: https://github.com/apache/spark/compare/master...maropu:DataSourceReadBenchmark master: https://gist.github.com/maropu/a767d21ed1dd047ec2bdca92915dc5c5 this

[GitHub] spark issue #21214: [SPARK-23775][TEST] Make DataFrameRangeSuite not flaky

2018-05-03 Thread gaborgsomogyi
Github user gaborgsomogyi commented on the issue: https://github.com/apache/spark/pull/21214 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21223: [SPARK-24166][SQL] InMemoryTableScanExec should n...

2018-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21223 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21054 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21054 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2864/

[GitHub] spark issue #21054: [SPARK-23907][SQL] Add regr_* functions

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21054 **[Test build #90121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90121/testReport)** for PR 21054 at commit

[GitHub] spark pull request #21182: [SPARK-24068] Propagating DataFrameReader's optio...

2018-05-03 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/21182#discussion_r185773095 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -136,4 +138,6 @@ private[sql] class JSONOptions(

[GitHub] spark issue #21219: [SPARK-24160] ShuffleBlockFetcherIterator should fail if...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21219 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90112/ Test PASSed. ---

[GitHub] spark issue #21219: [SPARK-24160] ShuffleBlockFetcherIterator should fail if...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21219 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21219: [SPARK-24160] ShuffleBlockFetcherIterator should fail if...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21219 **[Test build #90112 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90112/testReport)** for PR 21219 at commit

[GitHub] spark pull request #20940: [SPARK-23429][CORE] Add executor memory metrics t...

2018-05-03 Thread edwinalu
Github user edwinalu closed the pull request at: https://github.com/apache/spark/pull/20940 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21227: [SPARK-24133][SQL] Check for integer overflows wh...

2018-05-03 Thread adrian-wang
Github user adrian-wang commented on a diff in the pull request: https://github.com/apache/spark/pull/21227#discussion_r185768453 --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java --- @@ -81,7 +81,9 @@ public void close() {

[GitHub] spark pull request #21169: [SPARK-23715][SQL] the input of to/from_utc_times...

2018-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21169 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #20973: [SPARK-20114][ML] spark.ml parity for sequential pattern...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20973 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20973: [SPARK-20114][ML] spark.ml parity for sequential pattern...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20973 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90116/ Test PASSed. ---

[GitHub] spark issue #20973: [SPARK-20114][ML] spark.ml parity for sequential pattern...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20973 **[Test build #90116 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90116/testReport)** for PR 20973 at commit

[GitHub] spark issue #21169: [SPARK-23715][SQL] the input of to/from_utc_timestamp ca...

2018-05-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21169 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21163: [SPARK-24097][ML] Instrumentation improvements - RandomF...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21163 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90115/ Test PASSed. ---

[GitHub] spark issue #21163: [SPARK-24097][ML] Instrumentation improvements - RandomF...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21163 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21193: [SPARK-24121][SQL][WIP] Add API for handling expression ...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21193 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21193: [SPARK-24121][SQL][WIP] Add API for handling expression ...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21193 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2863/

[GitHub] spark issue #21163: [SPARK-24097][ML] Instrumentation improvements - RandomF...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21163 **[Test build #90115 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90115/testReport)** for PR 21163 at commit

[GitHub] spark issue #21169: [SPARK-23715][SQL] the input of to/from_utc_timestamp ca...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21169 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21169: [SPARK-23715][SQL] the input of to/from_utc_timestamp ca...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21169 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90108/ Test PASSed. ---

[GitHub] spark issue #21169: [SPARK-23715][SQL] the input of to/from_utc_timestamp ca...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21169 **[Test build #90108 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90108/testReport)** for PR 21169 at commit

[GitHub] spark issue #21227: [SPARK-24133][SQL] Check for integer overflows when resi...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21227 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2862/

[GitHub] spark issue #21227: [SPARK-24133][SQL] Check for integer overflows when resi...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21227 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21222: [SPARK-24161][SS] Enable debug package feature on struct...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21222 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21193: [SPARK-24121][SQL][WIP] Add API for handling expression ...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21193 **[Test build #90120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90120/testReport)** for PR 21193 at commit

[GitHub] spark issue #21222: [SPARK-24161][SS] Enable debug package feature on struct...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21222 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90111/ Test PASSed. ---

[GitHub] spark issue #21227: [SPARK-24133][SQL] Check for integer overflows when resi...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21227 **[Test build #90119 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90119/testReport)** for PR 21227 at commit

[GitHub] spark issue #21169: [SPARK-23715][SQL] the input of to/from_utc_timestamp ca...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21169 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90105/ Test PASSed. ---

[GitHub] spark issue #21222: [SPARK-24161][SS] Enable debug package feature on struct...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21222 **[Test build #90111 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90111/testReport)** for PR 21222 at commit

[GitHub] spark issue #21169: [SPARK-23715][SQL] the input of to/from_utc_timestamp ca...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21169 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21227: [SPARK-24133][SQL] Check for integer overflows when resi...

2018-05-03 Thread ala
Github user ala commented on the issue: https://github.com/apache/spark/pull/21227 @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21169: [SPARK-23715][SQL] the input of to/from_utc_timestamp ca...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21169 **[Test build #90105 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90105/testReport)** for PR 21169 at commit

[GitHub] spark pull request #21227: [SPARK-24133][SQL] Check for integer overflows wh...

2018-05-03 Thread ala
GitHub user ala opened a pull request: https://github.com/apache/spark/pull/21227 [SPARK-24133][SQL] Check for integer overflows when resizing WritableColumnVectors `ColumnVector`s store string data in one big byte array. Since the array size is capped at just under

[GitHub] spark issue #21201: [SPARK-24128][SQL] Mention configuration option in impli...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21201 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90109/ Test PASSed. ---

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21201: [SPARK-24128][SQL] Mention configuration option in impli...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21201 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21021 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2861/

[GitHub] spark issue #21201: [SPARK-24128][SQL] Mention configuration option in impli...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21201 **[Test build #90109 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90109/testReport)** for PR 21201 at commit

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21021 **[Test build #90118 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90118/testReport)** for PR 21021 at commit

[GitHub] spark issue #21223: [SPARK-24166][SQL] InMemoryTableScanExec should not acce...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21223 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21223: [SPARK-24166][SQL] InMemoryTableScanExec should not acce...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21223 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90107/ Test PASSed. ---

[GitHub] spark issue #21224: [SPARK-24167][SQL] ParquetFilters should not access SQLC...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21224 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90110/ Test PASSed. ---

[GitHub] spark issue #21224: [SPARK-24167][SQL] ParquetFilters should not access SQLC...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21224 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21223: [SPARK-24166][SQL] InMemoryTableScanExec should not acce...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21223 **[Test build #90107 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90107/testReport)** for PR 21223 at commit

[GitHub] spark issue #21224: [SPARK-24167][SQL] ParquetFilters should not access SQLC...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21224 **[Test build #90110 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90110/testReport)** for PR 21224 at commit

[GitHub] spark issue #21021: [SPARK-23921][SQL] Add array_sort function

2018-05-03 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21021 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21193: [SPARK-24121][SQL][WIP] Add API for handling expr...

2018-05-03 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21193#discussion_r185761453 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -120,13 +216,15 @@ object JavaCode {

[GitHub] spark pull request #21193: [SPARK-24121][SQL][WIP] Add API for handling expr...

2018-05-03 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21193#discussion_r185761604 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -112,6 +112,102 @@ object JavaCode {

[GitHub] spark pull request #21193: [SPARK-24121][SQL][WIP] Add API for handling expr...

2018-05-03 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21193#discussion_r185763081 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -112,6 +112,102 @@ object JavaCode {

[GitHub] spark pull request #21193: [SPARK-24121][SQL][WIP] Add API for handling expr...

2018-05-03 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21193#discussion_r185762835 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala --- @@ -112,6 +112,102 @@ object JavaCode {

[GitHub] spark issue #21193: [SPARK-24121][SQL][WIP] Add API for handling expression ...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21193 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21193: [SPARK-24121][SQL][WIP] Add API for handling expression ...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21193 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90104/ Test PASSed. ---

[GitHub] spark issue #21193: [SPARK-24121][SQL][WIP] Add API for handling expression ...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21193 **[Test build #90104 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90104/testReport)** for PR 21193 at commit

[GitHub] spark pull request #21182: [SPARK-24068] Propagating DataFrameReader's optio...

2018-05-03 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/21182#discussion_r185757247 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -136,4 +138,6 @@ private[sql] class JSONOptions(

[GitHub] spark pull request #21218: [SPARK-24155][ML] Instrumentation improvements fo...

2018-05-03 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/21218#discussion_r185756220 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala --- @@ -378,6 +378,7 @@ class KMeans @Since("1.5.0") (

[GitHub] spark pull request #21218: [SPARK-24155][ML] Instrumentation improvements fo...

2018-05-03 Thread WeichenXu123
Github user WeichenXu123 commented on a diff in the pull request: https://github.com/apache/spark/pull/21218#discussion_r185756193 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/GaussianMixture.scala --- @@ -423,6 +423,8 @@ class GaussianMixture @Since("2.0.0") (

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2860/

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21028 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20973: [SPARK-20114][ML] spark.ml parity for sequential pattern...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20973 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2859/

[GitHub] spark issue #20973: [SPARK-20114][ML] spark.ml parity for sequential pattern...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20973 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21215: [SPARK-24148][SQL] Overloading array function to support...

2018-05-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21215 How about this? ``` scala> val df = Seq(Outer(Seq.empty[Inner]), Outer(Seq.empty[Inner])).toDF("a") df: org.apache.spark.sql.DataFrame = [a: array>]

[GitHub] spark issue #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21028 **[Test build #90117 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90117/testReport)** for PR 21028 at commit

[GitHub] spark issue #21216: [SPARK-24149][YARN] Retrieve all federated namespaces to...

2018-05-03 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21216 @vanzin yes, in the example I am providing the hdfs URI, without using ViewFS. Actually viewFS was not even configured in that case. In my cluster test there were just two different namespaces and

[GitHub] spark issue #21163: [SPARK-24097][ML] Instrumentation improvements - RandomF...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21163 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21163: [SPARK-24097][ML] Instrumentation improvements - RandomF...

2018-05-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21163 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2858/

[GitHub] spark pull request #21028: [SPARK-23922][SQL] Add arrays_overlap function

2018-05-03 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21028#discussion_r185753083 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -378,6 +405,125 @@ case class

[GitHub] spark issue #20973: [SPARK-20114][ML] spark.ml parity for sequential pattern...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20973 **[Test build #90116 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90116/testReport)** for PR 20973 at commit

[GitHub] spark issue #21163: [SPARK-24097][ML] Instrumentation improvements - RandomF...

2018-05-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21163 **[Test build #90115 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90115/testReport)** for PR 21163 at commit

<    1   2   3   4   5   6   7   8   >