Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r187858372
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1468,3 +1468,149 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r187856067
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1468,3 +1468,149 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r187856418
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1468,3 +1468,149 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r187856635
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1468,3 +1468,149 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21208#discussion_r187857608
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1468,3 +1468,149 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21311#discussion_r187857950
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -568,13 +568,16 @@ private[execution] final class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21311#discussion_r187857852
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
---
@@ -568,13 +568,16 @@ private[execution] final class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21318#discussion_r187857692
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -39,7 +39,21 @@ import org.apache.spark.util.Utils
/**
-
Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21311
cc @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21290
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21290
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3189/
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21290
**[Test build #90569 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90569/testReport)**
for PR 21290 at commit
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21236#discussion_r187852992
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -118,6 +119,161 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21236#discussion_r187853879
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -118,6 +119,162 @@ case class
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21236#discussion_r187854341
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -118,6 +119,162 @@ case class
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21290#discussion_r187852287
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -180,6 +180,25 @@ class SparkSubmitSuite
appArgs.toString
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21290#discussion_r187852160
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -76,6 +75,7 @@ private[deploy] class SparkSubmitArguments(args:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21299
**[Test build #90568 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90568/testReport)**
for PR 21299 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21299
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90568/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21299
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user yaooqinn commented on a diff in the pull request:
https://github.com/apache/spark/pull/21290#discussion_r187851318
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -76,6 +75,7 @@ private[deploy] class SparkSubmitArguments(args:
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21199
I was thinking if it is too overkill to receive data in the driver side and
publish them to the executors via RPC? This might give user a wrong impression
that data should be received in the
Github user HeartSaVioR commented on the issue:
https://github.com/apache/spark/pull/21222
Kindly ping. I guess debugging last batch might not be attractive that
much, but printing codegen would be helpful to someone who want to investigate
or debug in detail.
---
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21290
LGTM, just some minor comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21290#discussion_r187847736
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -76,6 +75,7 @@ private[deploy] class SparkSubmitArguments(args:
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21290#discussion_r187847656
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -180,6 +180,25 @@ class SparkSubmitSuite
appArgs.toString
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/21312
Thanks for catching this @viirya! Looks good from a first glance, but my
only concern is that `clear()` will release the vector buffers, where `reset()`
just zeros them out. Let me look into
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21318
@rxin, should we maybe we mention that SQL functions are usually added to
match other DBMSs (unlike functions.scala)?
---
-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21318#discussion_r187843889
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -39,7 +39,21 @@ import org.apache.spark.util.Utils
/**
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21318#discussion_r187843283
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -39,7 +39,21 @@ import org.apache.spark.util.Utils
/**
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21318#discussion_r187843125
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -39,7 +39,21 @@ import org.apache.spark.util.Utils
/**
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21299
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3188/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21299
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21299
**[Test build #90568 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90568/testReport)**
for PR 21299 at commit
501 - 534 of 534 matches
Mail list logo
