[GitHub] spark pull request #21369: [SPARK-22713][CORE] ExternalAppendOnlyMap leaks w...

2018-05-19 Thread JerryLead
Github user JerryLead commented on a diff in the pull request: https://github.com/apache/spark/pull/21369#discussion_r189451809 --- Diff: core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala --- @@ -585,17 +592,15 @@ class ExternalAppendOnlyMap[K, V,

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21342 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3380/

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21342 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21342 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90847/ Test FAILed. ---

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21342 **[Test build #90847 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90847/testReport)** for PR 21342 at commit

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21342 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-19 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/21342 @kiszk @cloud-fan Thanks a lot for comments. I tested manually and found that the bug exists in all fatal throwable. In current change, I catch all fatal throwable and wrap in

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-19 Thread jinxing64
Github user jinxing64 commented on the issue: https://github.com/apache/spark/pull/21342 I will update the pr title if the change is on the right direction. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21342 **[Test build #90847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90847/testReport)** for PR 21342 at commit

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21342 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21342 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90846/ Test FAILed. ---

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21342 **[Test build #90846 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90846/testReport)** for PR 21342 at commit

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21342 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3379/

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21342 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21342: [SPARK-24294] Throw SparkException when OOM in Broadcast...

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21342 **[Test build #90846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90846/testReport)** for PR 21342 at commit

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error and flaky...

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21371 **[Test build #90845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90845/testReport)** for PR 21371 at commit

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error and flaky...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21371 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error and flaky...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21371 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3378/

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error and flaky...

2018-05-19 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21371 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error and flaky...

2018-05-19 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21371 retest this please. On Sun, May 20, 2018, 12:24 PM Apache Spark QA wrote: > *Test build #90844 has finished >

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error and flaky...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21371 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90844/ Test FAILed. ---

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error and flaky...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21371 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error and flaky...

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21371 **[Test build #90844 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90844/testReport)** for PR 21371 at commit

[GitHub] spark pull request #20761: [SPARK-20327][CORE][YARN] Add CLI support for YAR...

2018-05-19 Thread galv
Github user galv commented on a diff in the pull request: https://github.com/apache/spark/pull/20761#discussion_r189449133 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceTypeHelperSuite.scala --- @@ -0,0 +1,153 @@ +/* + * Licensed to

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21374 @dongjoon-hyun thank you, l will kick this later. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error and flaky...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21371 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error and flaky...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21371 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3377/

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21371 @hvanhovell the test is flaky and I propose a fixing for it now. Please take a look if you have time. Thanks. --- - To

[GitHub] spark pull request #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by...

2018-05-19 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21371#discussion_r189448749 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonInferSchema.scala --- @@ -66,8 +69,12 @@ private[sql] object

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21371 **[Test build #90844 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90844/testReport)** for PR 21371 at commit

[GitHub] spark issue #21294: [SPARK-24197][SparkR][SQL] Adding array_sort function to...

2018-05-19 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21294 looked into a bit not sure why.. - no related changes to testthat - nothing in the R releases around this - no config about default type of NA etc. - tested this out but not

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21371 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21371 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90840/ Test PASSed. ---

[GitHub] spark pull request #21375: [HOT-FIX][SQL] Fix: SQLConf.scala:1757: not found...

2018-05-19 Thread wangyum
Github user wangyum closed the pull request at: https://github.com/apache/spark/pull/21375 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21371 **[Test build #90840 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90840/testReport)** for PR 21371 at commit

[GitHub] spark pull request #21375: [HOT-FIX][SQL] Fix: SQLConf.scala:1757: not found...

2018-05-19 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/21375 [HOT-FIX][SQL] Fix: SQLConf.scala:1757: not found: value Utils ## What changes were proposed in this pull request? Fix: `SQLConf.scala:1757: not found: value Utils` ## How was

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21371 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90841/ Test FAILed. ---

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21371 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21374 Hi, @kiszk and @felixcheung . Unfortunately, the master branch build is broken by https://github.com/apache/spark/pull/21299 . ---

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21371 **[Test build #90841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90841/testReport)** for PR 21371 at commit

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement _repr_html_ for ...

2018-05-19 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r189447446 --- Diff: python/pyspark/sql/dataframe.py --- @@ -78,6 +78,12 @@ def __init__(self, jdf, sql_ctx): self.is_cached = False

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement _repr_html_ for ...

2018-05-19 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r189447423 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -3056,7 +3059,6 @@ class Dataset[T] private[sql]( * view, e.g.

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement _repr_html_ for ...

2018-05-19 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r189447465 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -237,9 +236,13 @@ class Dataset[T] private[sql]( * @param truncate

[GitHub] spark pull request #21370: [SPARK-24215][PySpark] Implement _repr_html_ for ...

2018-05-19 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21370#discussion_r189447477 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -237,9 +236,13 @@ class Dataset[T] private[sql]( * @param truncate

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21374 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3376/

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21374 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21374 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21374 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90843/ Test FAILed. ---

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21374 **[Test build #90843 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90843/testReport)** for PR 21374 at commit

[GitHub] spark issue #21370: [SPARK-24215][PySpark] Implement _repr_html_ for datafra...

2018-05-19 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21370 we will wait for the tests to be fixed first. @xuanyuanking could you update the PR description to clarify which is "before" which is "after"? ---

[GitHub] spark issue #21370: [SPARK-24215][PySpark] Implement _repr_html_ for datafra...

2018-05-19 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21370 @HyukjinKwon @holdenk @ueshin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21374 **[Test build #90843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90843/testReport)** for PR 21374 at commit

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21374 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21374 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21374 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3375/

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21374 **[Test build #90842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90842/testReport)** for PR 21374 at commit

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21374 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90842/ Test FAILed. ---

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21374 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21374 **[Test build #90842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90842/testReport)** for PR 21374 at commit

[GitHub] spark pull request #21374: [SPARK-24323][SQL] Fix lint-java errors

2018-05-19 Thread kiszk
GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/21374 [SPARK-24323][SQL] Fix lint-java errors ## What changes were proposed in this pull request? This PR fixes the following errors reported by `lint-java` ``` % dev/lint-java Using

[GitHub] spark pull request #21367: [SPARK-24321][SQL] Extract common code from Divid...

2018-05-19 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21367#discussion_r189446823 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala --- @@ -297,13 +279,39 @@ case class Divide(left:

[GitHub] spark issue #21367: [SPARK-24321][SQL] Extract common code from Divide/Remai...

2018-05-19 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21367 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21373: [SPARK-24250][SQL][FOLLOWUP] Fix build failure

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21373 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90839/ Test FAILed. ---

[GitHub] spark issue #21373: [SPARK-24250][SQL][FOLLOWUP] Fix build failure

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21373 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21373: [SPARK-24250][SQL][FOLLOWUP] Fix build failure

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21373 **[Test build #90839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90839/testReport)** for PR 21373 at commit

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21371 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21371 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3374/

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21371 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by...

2018-05-19 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21371#discussion_r189446146 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/internal/ExecutorSideSQLConfSuite.scala --- @@ -59,7 +59,8 @@ class ExecutorSideSQLConfSuite extends

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21371 **[Test build #90841 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90841/testReport)** for PR 21371 at commit

[GitHub] spark issue #21373: [SPARK-24250][SQL][FOLLOWUP] Fix build failure

2018-05-19 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21373 @viirya sorry, I haven't seen it. Thanks for fixing it. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #21373: [SPARK-24250][SQL][FOLLOWUP] Fix build failure

2018-05-19 Thread mgaido91
Github user mgaido91 closed the pull request at: https://github.com/apache/spark/pull/21373 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21371 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21371 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3373/

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21371 **[Test build #90840 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90840/testReport)** for PR 21371 at commit

[GitHub] spark issue #21299: [SPARK-24250][SQL] support accessing SQLConf inside task...

2018-05-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21299 @viirya and @mgaido91 are working on the build failure, but there seem to be test failures, too. Maybe, we had better revert this first to unblock all the PRs. ---

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21371 @hvanhovell I ran locally and seems no such test failure? Checking. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21371: [SPARK-24250][SQL][FollowUp] Fix compile error by adding...

2018-05-19 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21371 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21373: [SPARK-24250][SQL][FOLLOWUP] Fix build failure

2018-05-19 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21373 @mgaido91 ah, I've fired one earlier #21371. But seems there still a test failure needed to be addressed. I'm looking into it. ---

[GitHub] spark issue #21373: [SPARK-24250][SQL][FOLLOWUP] Fix build failure

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21373 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21373: [SPARK-24250][SQL][FOLLOWUP] Fix build failure

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21373 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3372/

[GitHub] spark issue #21373: [SPARK-24250][SQL][FOLLOWUP] Fix build failure

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21373 **[Test build #90839 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90839/testReport)** for PR 21373 at commit

[GitHub] spark issue #21373: [SPARK-24250][SQL][FOLLOWUP] Fix build failure

2018-05-19 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21373 cc @cloud-fan @dongjoon-hyun @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21373: [SPARK-24250][SQL][FOLLOWUP] Fix build failure

2018-05-19 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/21373 [SPARK-24250][SQL][FOLLOWUP] Fix build failure ## What changes were proposed in this pull request? SPARK-24250 is causing a build failure because it removed an import which was not used

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21372 The master branch failure is due to https://github.com/apache/spark/pull/21299 . --- - To unsubscribe, e-mail:

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21372 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21372 **[Test build #90838 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90838/testReport)** for PR 21372 at commit

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21372 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90838/ Test FAILed. ---

[GitHub] spark issue #21299: [SPARK-24250][SQL] support accessing SQLConf inside task...

2018-05-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21299 Hi, @cloud-fan. This seems to cause a build failure. Could you take a look? cc @gatorsmile --- - To

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21372 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3371/

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21372 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21372 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3370/

[GitHub] spark issue #16171: [SPARK-18739][ML][PYSPARK] Classification and regression...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16171 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #16171: [SPARK-18739][ML][PYSPARK] Classification and regression...

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/16171 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3369/

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21372 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21372 **[Test build #90838 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90838/testReport)** for PR 21372 at commit

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-19 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/21372 Retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21372 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/90837/ Test FAILed. ---

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-19 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21372 **[Test build #90837 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/90837/testReport)** for PR 21372 at commit

[GitHub] spark issue #21372: [SPARK-24322][BUILD] Upgrade Apache ORC to 1.4.4

2018-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21372 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

  1   2   >