Github user icexelloss commented on the issue:
https://github.com/apache/spark/pull/21427
@gatorsmile @ueshin Thanks for joining the discussion!
I wonder if you agree that at least for case (1) here
https://github.com/apache/spark/pull/21427#issuecomment-392070950, we should
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21454
**[Test build #91316 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91316/testReport)**
for PR 21454 at commit
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/21427
Here are some examples that currently work, but would no longer work under
the proposed fix. These are all cases where columns are named with strings, but
the names do not match the schema (let
Github user liyinan926 commented on the issue:
https://github.com/apache/spark/pull/21260
Will review this asap.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/21427
Thanks @ueshin and @gatorsmile for taking a look, I agree the proposed fix
changes some behavior, but I think that behavior is either error-prone or
doesn't make much sense. Let me put up some
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r191948799
--- Diff: docs/running-on-kubernetes.md ---
@@ -121,8 +121,8 @@ This URI is the location of the example jar that is
already in the Docker image.
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191944805
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -448,6 +473,22 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191944797
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -448,6 +473,22 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191945182
--- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala ---
@@ -339,6 +340,38 @@ class SparkConfSuite extends SparkFunSuite with
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21454
**[Test build #91315 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91315/testReport)**
for PR 21454 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21331
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21362
Will do more investigation. Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21331
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191941962
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/StreamData.java
---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191941503
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/server/RpcHandler.java
---
@@ -38,15 +38,24 @@
*
* This method
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191940304
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the
Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r191940083
--- Diff: docs/running-on-kubernetes.md ---
@@ -121,8 +121,8 @@ This URI is the location of the example jar that is
already in the Docker image.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21464
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21464
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3711/
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191939431
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/protocol/UploadStream.java
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21464
**[Test build #91314 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91314/testReport)**
for PR 21464 at commit
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191938203
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java
---
@@ -141,26 +141,14 @@ public void fetchChunk(
Github user ejono commented on the issue:
https://github.com/apache/spark/pull/21452
Seems like the test build failed for an unrelated reason, right? This is my
first contribution in a long time; have the tests been flaky lately?
---
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r191936265
--- Diff: docs/running-on-kubernetes.md ---
@@ -121,8 +121,8 @@ This URI is the location of the example jar that is
already in the Docker image.
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21346#discussion_r191935821
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/client/StreamInterceptor.java
---
@@ -50,16 +52,22 @@
@Override
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/21346
I'm going to be starting a more detailed review pass on this now and will
be getting caught back up with the discussion that's happened so far.
One high-level point I'd like to keep in
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21464
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3710/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21464
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user varuvish commented on the issue:
https://github.com/apache/spark/pull/19456
Can you guarantee that your users share an even workload? With this setup
you could potentially have a user with a high workload using 1/#users
resources. Wouldn't using the queue feature be
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21462#discussion_r191930265
--- Diff: docs/running-on-kubernetes.md ---
@@ -121,8 +121,8 @@ This URI is the location of the example jar that is
already in the Docker image.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21464#discussion_r191933176
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -206,7 +206,9 @@ private[ui] class AllJobsPage(parent: JobsTab, store:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21464
**[Test build #91313 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91313/testReport)**
for PR 21464 at commit
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21459
@rxin Mostly for Java 9+.
[ASM 6.x](https://mvnrepository.com/artifact/org.ow2.asm/asm/6.0/usages)
has been proven in many projects such as FB Presto, Google Guice Core Library,
CGLIB,
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/21464
[WEBUI] Avoid possibility of script in query param keys
As discussed separately, this avoids the possibility of XSS on certain
request param keys.
CC @vanzin
You can merge this pull
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21462
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/3576/
---
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21450#discussion_r191929581
--- Diff:
launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java
---
@@ -190,6 +194,23 @@ public void testSparkRShell()
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21462
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/3576/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21462
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3709/
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21462
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21450#discussion_r191928359
--- Diff:
launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java
---
@@ -190,6 +194,23 @@ public void testSparkRShell()
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21462
**[Test build #91312 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91312/testReport)**
for PR 21462 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21462
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21462
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91312/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21462
**[Test build #91312 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91312/testReport)**
for PR 21462 at commit
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/21400
LGTM other than the one comment. Sorry it took me so long to get to this.
---
-
To unsubscribe, e-mail:
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/21400#discussion_r191278428
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/ContinuousSuite.scala
---
@@ -34,7 +34,8 @@ class ContinuousSuiteBase
Github user foxish commented on the issue:
https://github.com/apache/spark/pull/21462
jenkins, ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user jose-torres commented on a diff in the pull request:
https://github.com/apache/spark/pull/21400#discussion_r191278390
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/ContinuousSuite.scala
---
@@ -225,6 +226,40 @@ class ContinuousSuite
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21331
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21331
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91309/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21331
**[Test build #91309 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91309/testReport)**
for PR 21331 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/21462
@foxish pls review.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191919610
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,120 @@
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19691
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91308/
Test PASSed.
---
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191918908
--- Diff: pom.xml ---
@@ -760,6 +760,12 @@
1.10.19
test
+
--- End diff --
I don't think this
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19691
**[Test build #91308 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91308/testReport)**
for PR 19691 at commit
Github user varuvish commented on the issue:
https://github.com/apache/spark/pull/21333
Nice change! I tested this out as well and verified that the shuffle
doesn't happen. I did notice that this change wasn't reflected in the dataset
API. Is that something that should be addressed
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191914872
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191914601
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsEventQueue.scala
---
@@ -0,0 +1,29 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191914114
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,120 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191913958
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +154,24 @@ private[spark] object Config
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21068
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91307/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21068
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21068
**[Test build #91307 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91307/testReport)**
for PR 21068 at commit
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191883353
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -448,6 +473,20 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21454#discussion_r191899959
--- Diff: core/src/test/scala/org/apache/spark/SparkConfSuite.scala ---
@@ -339,6 +341,38 @@ class SparkConfSuite extends SparkFunSuite with
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21362
@mn-mikke Actually, yes. But unfortunately I'm not familiar with R and the
environment I heard about it, so I'm not able to figure out the reason for now.
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21362
We havenât seen it fail?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user mn-mikke commented on the issue:
https://github.com/apache/spark/pull/21362
@ueshin Have you experienced the same problem with the failing tests?
---
-
To unsubscribe, e-mail:
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21437#discussion_r191881226
--- Diff: python/pyspark/taskcontext.py ---
@@ -88,3 +89,9 @@ def taskAttemptId(self):
TaskAttemptID.
"""
return
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/21437
@HyukjinKwon @BryanCutler @JoshRosen @ueshin is this good to go?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/21437#discussion_r191879730
--- Diff: python/pyspark/taskcontext.py ---
@@ -88,3 +89,9 @@ def taskAttemptId(self):
TaskAttemptID.
"""
return
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/21437#discussion_r191877900
--- Diff: python/pyspark/taskcontext.py ---
@@ -88,3 +89,9 @@ def taskAttemptId(self):
TaskAttemptID.
"""
return
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21448
I'd only move abs and nothing else.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21362
Hi, any updates on this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19959
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91311/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19959
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19959
**[Test build #91311 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91311/testReport)**
for PR 19959 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19959
**[Test build #91311 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91311/testReport)**
for PR 19959 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21246
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191865387
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -154,6 +154,24 @@ private[spark] object Config
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191868513
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsEventQueue.scala
---
@@ -0,0 +1,29 @@
+/*
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191866216
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,120 @@
+/*
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191869618
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleEventHandler.scala
---
@@ -0,0
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191871593
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,120 @@
+/*
Github user foxish commented on a diff in the pull request:
https://github.com/apache/spark/pull/21366#discussion_r191865834
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala
---
@@ -0,0 +1,120 @@
+/*
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/21246
Thanks! merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user huaxingao commented on the issue:
https://github.com/apache/spark/pull/21413
Thanks a lot @BryanCutler for your help!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21370#discussion_r191870129
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -351,8 +352,62 @@ def show(self, n=20, truncate=True, vertical=False):
else:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21370#discussion_r191869090
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -351,8 +352,62 @@ def show(self, n=20, truncate=True, vertical=False):
else:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21370#discussion_r191854612
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -351,8 +352,70 @@ def show(self, n=20, truncate=True, vertical=False):
else:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21370#discussion_r191854114
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -351,8 +352,70 @@ def show(self, n=20, truncate=True, vertical=False):
else:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21370#discussion_r191854703
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -351,8 +352,70 @@ def show(self, n=20, truncate=True, vertical=False):
else:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21370#discussion_r191854585
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -351,8 +352,70 @@ def show(self, n=20, truncate=True, vertical=False):
else:
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21370#discussion_r191853613
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -291,37 +289,57 @@ class Dataset[T] private[sql](
}
}
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21413
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/21413
merged to master, thanks @huaxingao !
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/21448
If itâs ok Iâll take a quick look at this on Friday as discussed with
Jacek.
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20697
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-spark-integration/3575/
---
101 - 200 of 438 matches
Mail list logo
