[GitHub] spark issue #21501: [SPARK-15064][ML] Locale support in StopWordsRemover

2018-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21501 **[Test build #91652 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91652/testReport)** for PR 21501 at commit

[GitHub] spark pull request #21505: [SPARK-24457][SQL] Improving performance of strin...

2018-06-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21505#discussion_r194325153 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -111,6 +113,23 @@ object DateTimeUtils {

[GitHub] spark pull request #20887: [SPARK-23774][SQL] `Cast` to CHAR/VARCHAR should ...

2018-06-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/20887#discussion_r194321737 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2792,4 +2793,40 @@ class SQLQuerySuite extends QueryTest with

[GitHub] spark pull request #21505: [SPARK-24457][SQL] Improving performance of strin...

2018-06-11 Thread ssonker
Github user ssonker commented on a diff in the pull request: https://github.com/apache/spark/pull/21505#discussion_r194319491 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -111,6 +113,23 @@ object DateTimeUtils {

[GitHub] spark issue #20208: [SPARK-23007][SQL][TEST] Add schema evolution test suite...

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20208 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20208: [SPARK-23007][SQL][TEST] Add schema evolution test suite...

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20208 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3890/

[GitHub] spark issue #21495: [SPARK-24418][Build] Upgrade Scala to 2.11.12 and 2.12.6

2018-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21495 **[Test build #91653 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91653/testReport)** for PR 21495 at commit

[GitHub] spark issue #20208: [SPARK-23007][SQL][TEST] Add schema evolution test suite...

2018-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20208 **[Test build #91654 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91654/testReport)** for PR 20208 at commit

[GitHub] spark issue #21501: [SPARK-15064][ML] Locale support in StopWordsRemover

2018-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21501 **[Test build #91652 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91652/testReport)** for PR 21501 at commit

[GitHub] spark issue #21495: [SPARK-24418][Build] Upgrade Scala to 2.11.12 and 2.12.6

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21495 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21495: [SPARK-24418][Build] Upgrade Scala to 2.11.12 and 2.12.6

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21495 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3889/

[GitHub] spark issue #21495: [SPARK-24418][Build] Upgrade Scala to 2.11.12 and 2.12.6

2018-06-11 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/21495 retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21506: [SPARK-24485][SS] Measure and log elapsed time for files...

2018-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21506 **[Test build #91651 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91651/testReport)** for PR 21506 at commit

[GitHub] spark issue #21506: [SPARK-24485][SS] Measure and log elapsed time for files...

2018-06-11 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/spark/pull/21506 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21505: [SPARK-24457][SQL] Improving performance of strin...

2018-06-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21505#discussion_r194309823 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -111,6 +113,23 @@ object DateTimeUtils {

[GitHub] spark pull request #21510: [SPARK-24490][WebUI] Use WebUI.addStaticHandler i...

2018-06-11 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/21510#discussion_r194309780 --- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala --- @@ -101,12 +101,12 @@ private[spark] abstract class WebUI( } /**

[GitHub] spark pull request #21514: [SPARK-22860] [Core] - hide key password from lin...

2018-06-11 Thread jerryshao
Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/21514#discussion_r194308977 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/StandaloneSchedulerBackend.scala --- @@ -100,7 +100,7 @@ private[spark] class

[GitHub] spark issue #21495: [SPARK-24418][Build] Upgrade Scala to 2.11.12 and 2.12.6

2018-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21495 **[Test build #91650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91650/testReport)** for PR 21495 at commit

[GitHub] spark issue #21506: [SPARK-24485][SS] Measure and log elapsed time for files...

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21506 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91649/ Test FAILed. ---

[GitHub] spark issue #21495: [SPARK-24418][Build] Upgrade Scala to 2.11.12 and 2.12.6

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21495 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91650/ Test FAILed. ---

[GitHub] spark issue #21506: [SPARK-24485][SS] Measure and log elapsed time for files...

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21506 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21495: [SPARK-24418][Build] Upgrade Scala to 2.11.12 and 2.12.6

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21495 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21506: [SPARK-24485][SS] Measure and log elapsed time for files...

2018-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21506 **[Test build #91649 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91649/testReport)** for PR 21506 at commit

[GitHub] spark issue #21427: [SPARK-24324][PYTHON] Pandas Grouped Map UDF should assi...

2018-06-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21427 How about we just start to have configurations classified for each version if it sounds better to have configurations for each behaviour change? For example, we could have postfix like spark_23

[GitHub] spark issue #21523: [SPARK-24506][UI] Add UI filters also to thriftserver ta...

2018-06-11 Thread jerryshao
Github user jerryshao commented on the issue: https://github.com/apache/spark/pull/21523 I think here the problem is that `filters` are only added for those handler who added before server starts. This may not be the only problem for `ThriftserverTab`, I guess `SQLTable` or

[GitHub] spark pull request #21505: [SPARK-24457][SQL] Improving performance of strin...

2018-06-11 Thread ssonker
Github user ssonker commented on a diff in the pull request: https://github.com/apache/spark/pull/21505#discussion_r194305723 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -111,6 +113,23 @@ object DateTimeUtils {

[GitHub] spark issue #21427: [SPARK-24324][PYTHON] Pandas Grouped Map UDF should assi...

2018-06-11 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21427 @icexelloss @HyukjinKwon It is always simple to deprecate the confs in the release of Spark 3.0. Let us make it configurable in the next release which is Spark 2.4. ---

[GitHub] spark issue #21202: [SPARK-24129] [K8S] Add option to pass --build-arg's to ...

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21202 Build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #21202: [SPARK-24129] [K8S] Add option to pass --build-arg's to ...

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21202 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91647/ Test FAILed. ---

[GitHub] spark issue #21202: [SPARK-24129] [K8S] Add option to pass --build-arg's to ...

2018-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21202 **[Test build #91647 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91647/testReport)** for PR 21202 at commit

[GitHub] spark issue #21495: [SPARK-24418][Build] Upgrade Scala to 2.11.12 and 2.12.6

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21495 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3888/

[GitHub] spark issue #21495: [SPARK-24418][Build] Upgrade Scala to 2.11.12 and 2.12.6

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21495 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21495: [SPARK-24418][Build] Upgrade Scala to 2.11.12 and 2.12.6

2018-06-11 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/21495 I decided to remove the hack I put to get the Spark UI consistent since this hack will bring into more problems. @som-snytt Is it possible to move the `printWelcome` and `splash.start()`

[GitHub] spark issue #21495: [SPARK-24418][Build] Upgrade Scala to 2.11.12 and 2.12.6

2018-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21495 **[Test build #91650 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91650/testReport)** for PR 21495 at commit

[GitHub] spark issue #21504: [SPARK-24479][SS] Added config for registering streaming...

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21504 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21504: [SPARK-24479][SS] Added config for registering streaming...

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21504 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91645/ Test PASSed. ---

[GitHub] spark issue #21504: [SPARK-24479][SS] Added config for registering streaming...

2018-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21504 **[Test build #91645 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91645/testReport)** for PR 21504 at commit

[GitHub] spark pull request #21505: [SPARK-24457][SQL] Improving performance of strin...

2018-06-11 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21505#discussion_r194299485 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala --- @@ -111,6 +113,23 @@ object DateTimeUtils {

[GitHub] spark issue #21497: [SPARK-24466][SS] Fix TextSocketMicroBatchReader to be c...

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21497 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91646/ Test PASSed. ---

[GitHub] spark issue #21497: [SPARK-24466][SS] Fix TextSocketMicroBatchReader to be c...

2018-06-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21497 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21505: [SPARK-24457][SQL] Improving performance of stringToTime...

2018-06-11 Thread ssonker
Github user ssonker commented on the issue: https://github.com/apache/spark/pull/21505 @kiszk I've added a benchmark according to your recommendation, please review. --- - To unsubscribe, e-mail:

[GitHub] spark issue #21497: [SPARK-24466][SS] Fix TextSocketMicroBatchReader to be c...

2018-06-11 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21497 **[Test build #91646 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91646/testReport)** for PR 21497 at commit

[GitHub] spark issue #21520: [SPARK-24505][SQL] Forbidding string interpolation in Co...

2018-06-11 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21520 For 1, I agree with you that it is not good to introduce many APIs at first. On the other hand, it would be good to prepare only a few APIs that are frequently used, not to prepare many APIs. It make

[GitHub] spark pull request #21501: [SPARK-15064][ML] Locale support in StopWordsRemo...

2018-06-11 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21501#discussion_r194298446 --- Diff: python/pyspark/ml/feature.py --- @@ -2610,6 +2610,9 @@ def setParams(self, inputCol=None, outputCol=None, stopWords=None, caseSensitive

<    1   2   3   4   5   6