[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21596 **[Test build #92246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92246/testReport)** for PR 21596 at commit

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 > I will first fix the tests, and then assert the performance if you agree. Changing the annotations might impact the performance. Ah, yea sure. ---

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread Fokko
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/21596 I will first fix the tests, and then assert the performance if you agree. Changing the annotations might impact the performance. Regarding the difference between `NON_NULL`, `NON_ABSENT`,

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21618 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21618 **[Test build #92245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92245/testReport)** for PR 21618 at commit

[GitHub] spark issue #21618: [SPARK-20408][SQL] Get the glob path in parallel to redu...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21618 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/432/

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 re: https://github.com/apache/spark/pull/21596#issuecomment-399639768 can we keep the previous behaviour although it's by kind of a bug in Jackson? BTW, I thought we should use

[GitHub] spark issue #21614: Branch 2.3

2018-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21614 @larry88, looks mistakenly open. Mind closing this please? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 BTW, I believe it's okay to use Jenkins resource if that's a faster way to resolve this issue in any event. --- - To

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21596 @Fokko, btw, I believe https://github.com/apache/spark/pull/21596#issuecomment-399160931 is a valid comment. I think it would be nicer if we execute this benchmark and update the results in

[GitHub] spark issue #21617: [SPARK-24634][SS] Add a new metric regarding number of r...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21617 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92239/ Test PASSed. ---

[GitHub] spark issue #21617: [SPARK-24634][SS] Add a new metric regarding number of r...

2018-06-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21617 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread Fokko
Github user Fokko commented on the issue: https://github.com/apache/spark/pull/21596 When looking at the history server, we have a similar issue. From at the list command

[GitHub] spark issue #21617: [SPARK-24634][SS] Add a new metric regarding number of r...

2018-06-23 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21617 **[Test build #92239 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92239/testReport)** for PR 21617 at commit

[GitHub] spark pull request #21596: [SPARK-24601] Bump Jackson version

2018-06-23 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21596#discussion_r197604227 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/JsonExpressionsSuite.scala --- @@ -244,6 +244,13 @@ class

<    1   2   3