[GitHub] spark issue #21652: [SPARK-24551][K8S] Add integration tests for secrets

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21652 **[Test build #93228 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93228/testReport)** for PR 21652 at commit

[GitHub] spark pull request #21102: [SPARK-23913][SQL] Add array_intersect function

2018-07-18 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21102#discussion_r203318288 --- Diff: core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala --- @@ -85,9 +85,13 @@ class OpenHashSet[@specialized(Long, Int) T:

[GitHub] spark issue #21774: [SPARK-24811][SQL]Avro: add new function from_avro and t...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21774 **[Test build #93230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93230/testReport)** for PR 21774 at commit

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-18 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/21589 I am not seeing the utility of these two methods. `defaultParallelism` already captures the current number of cores. For monitoring usecases, existing events fired via listener can be

[GitHub] spark issue #20949: [SPARK-19018][SQL] Add support for custom encoding on cs...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20949 **[Test build #93229 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93229/testReport)** for PR 20949 at commit

[GitHub] spark issue #21652: [SPARK-24551][K8S] Add integration tests for secrets

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21652 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/1091/ ---

[GitHub] spark pull request #21102: [SPARK-23913][SQL] Add array_intersect function

2018-07-18 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/21102#discussion_r203315417 --- Diff: core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala --- @@ -114,6 +118,21 @@ class OpenHashSet[@specialized(Long, Int) T:

[GitHub] spark pull request #21795: [SPARK-24840][SQL] do not use dummy filter to swi...

2018-07-18 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21795#discussion_r203315415 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -2336,46 +2336,40 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request #21102: [SPARK-23913][SQL] Add array_intersect function

2018-07-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/21102#discussion_r203311755 --- Diff: core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala --- @@ -85,9 +85,13 @@ class OpenHashSet[@specialized(Long, Int) T:

[GitHub] spark pull request #21102: [SPARK-23913][SQL] Add array_intersect function

2018-07-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/21102#discussion_r203314045 --- Diff: core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala --- @@ -163,7 +187,7 @@ class OpenHashSet[@specialized(Long, Int) T:

[GitHub] spark pull request #21102: [SPARK-23913][SQL] Add array_intersect function

2018-07-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/21102#discussion_r203311109 --- Diff: core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala --- @@ -85,9 +85,13 @@ class OpenHashSet[@specialized(Long, Int) T:

[GitHub] spark issue #21652: [SPARK-24551][K8S] Add integration tests for secrets

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21652 **[Test build #93228 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93228/testReport)** for PR 21652 at commit

[GitHub] spark pull request #21652: [SPARK-24551][K8S] Add integration tests for secr...

2018-07-18 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21652#discussion_r203313358 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/TestConstants.scala --- @@ -16,7 +16,7

[GitHub] spark issue #21652: [SPARK-24551][K8S] Add integration tests for secrets

2018-07-18 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/21652 @shaneknapp thanks, @srowen @foxish gentle ping. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20949: [SPARK-19018][SQL] Add support for custom encoding on cs...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20949 **[Test build #93227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93227/testReport)** for PR 20949 at commit

[GitHub] spark issue #20949: [SPARK-19018][SQL] Add support for custom encoding on cs...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20949 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93227/ Test FAILed. ---

[GitHub] spark issue #20949: [SPARK-19018][SQL] Add support for custom encoding on cs...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20949 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20949: [SPARK-19018][SQL] Add support for custom encoding on cs...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20949 **[Test build #93227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93227/testReport)** for PR 20949 at commit

[GitHub] spark pull request #20949: [SPARK-19018][SQL] Add support for custom encodin...

2018-07-18 Thread crafty-coder
Github user crafty-coder commented on a diff in the pull request: https://github.com/apache/spark/pull/20949#discussion_r203306174 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -512,6 +513,43 @@ class CSVSuite extends

[GitHub] spark issue #20949: [SPARK-19018][SQL] Add support for custom encoding on cs...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20949 **[Test build #93226 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93226/testReport)** for PR 20949 at commit

[GitHub] spark pull request #21795: [SPARK-24840][SQL] do not use dummy filter to swi...

2018-07-18 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/21795#discussion_r203305670 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -2336,46 +2336,40 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark issue #21795: [SPARK-24840][SQL] do not use dummy filter to switch cod...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21795 **[Test build #93225 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93225/testReport)** for PR 21795 at commit

[GitHub] spark issue #21795: [SPARK-24840][SQL] do not use dummy filter to switch cod...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21795 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21795: [SPARK-24840][SQL] do not use dummy filter to switch cod...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21795 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #21652: [SPARK-24551][K8S] Add integration tests for secr...

2018-07-18 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/21652#discussion_r203303708 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala --- @@ -29,25

[GitHub] spark issue #21795: [SPARK-24840][SQL] do not use dummy filter to switch cod...

2018-07-18 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21795 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21102: [SPARK-23913][SQL] Add array_intersect function

2018-07-18 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21102#discussion_r203299689 --- Diff: core/src/main/scala/org/apache/spark/util/collection/OpenHashSet.scala --- @@ -114,6 +118,21 @@ class OpenHashSet[@specialized(Long, Int) T:

[GitHub] spark issue #21469: [SPARK-24441][SS] Expose total estimated size of states ...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21469 **[Test build #93224 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93224/testReport)** for PR 21469 at commit

[GitHub] spark pull request #20949: [SPARK-19018][SQL] Add support for custom encodin...

2018-07-18 Thread crafty-coder
Github user crafty-coder commented on a diff in the pull request: https://github.com/apache/spark/pull/20949#discussion_r203286908 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -512,6 +513,43 @@ class CSVSuite extends

[GitHub] spark issue #21784: [SPARK-24182][YARN][FOLLOW-UP] Turn off noisy log output

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21784 OK, but you can set sc.setLogLevel in the shell. For instance, if I run `spark.range(10).show()` with INFO, I got something like this: ``` scala> 18/07/18 07:58:47 INFO yarn.Client:

[GitHub] spark issue #21795: [SPARK-24840][SQL] do not use dummy filter to switch cod...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21795 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93219/ Test FAILed. ---

[GitHub] spark issue #21795: [SPARK-24840][SQL] do not use dummy filter to switch cod...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21795 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21795: [SPARK-24840][SQL] do not use dummy filter to switch cod...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21795 **[Test build #93219 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93219/testReport)** for PR 21795 at commit

[GitHub] spark issue #21589: [SPARK-24591][CORE] Number of cores and executors in the...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21589 **[Test build #93223 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93223/testReport)** for PR 21589 at commit

[GitHub] spark issue #21733: [SPARK-24763][SS] Remove redundant key data from value i...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21733 **[Test build #93222 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93222/testReport)** for PR 21733 at commit

[GitHub] spark pull request #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21764#discussion_r203278576 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -175,6 +182,44 @@ abstract class

[GitHub] spark pull request #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21764#discussion_r203278443 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -175,6 +182,44 @@ abstract class

[GitHub] spark pull request #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21764#discussion_r203277729 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -160,6 +160,13 @@ abstract class

[GitHub] spark issue #21733: [SPARK-24763][SS] Remove redundant key data from value i...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21733 **[Test build #93221 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93221/testReport)** for PR 21733 at commit

[GitHub] spark pull request #21192: [SPARK-24118][SQL] Flexible format for the lineSe...

2018-07-18 Thread MaxGekk
Github user MaxGekk closed the pull request at: https://github.com/apache/spark/pull/21192 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21440: [SPARK-24307][CORE] Support reading remote cached partit...

2018-07-18 Thread mridulm
Github user mridulm commented on the issue: https://github.com/apache/spark/pull/21440 LGTM, thanks for working on this @squito ! Since there are other ongoing reviews, I will defer to them to merge. --- - To

[GitHub] spark pull request #21440: [SPARK-24307][CORE] Support reading remote cached...

2018-07-18 Thread mridulm
Github user mridulm commented on a diff in the pull request: https://github.com/apache/spark/pull/21440#discussion_r203273344 --- Diff: core/src/main/scala/org/apache/spark/util/io/ChunkedByteBuffer.scala --- @@ -166,6 +170,34 @@ private[spark] class ChunkedByteBuffer(var chunks:

[GitHub] spark issue #21795: [SPARK-24840][SQL] do not use dummy filter to switch cod...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21795 **[Test build #93219 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93219/testReport)** for PR 21795 at commit

[GitHub] spark issue #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21764 **[Test build #93220 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93220/testReport)** for PR 21764 at commit

[GitHub] spark issue #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21764 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21764 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-jav...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21801 **[Test build #93218 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93218/testReport)** for PR 21801 at commit

[GitHub] spark issue #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-jav...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21801 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21795: [SPARK-24840][SQL] do not use dummy filter to switch cod...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21795 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-jav...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21801 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21795: [SPARK-24840][SQL] do not use dummy filter to switch cod...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21795 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21795: [SPARK-24840][SQL] do not use dummy filter to switch cod...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21795 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21764 btw, I feel the title is a little obscure and how about `[SPARK-24802][SQL] Add a new config for Optimization Rule Exclusion`? ---

[GitHub] spark issue #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-jav...

2018-07-18 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21801 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21764 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-jav...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21801 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93216/ Test FAILed. ---

[GitHub] spark issue #21795: [SPARK-24840][SQL] do not use dummy filter to switch cod...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21795 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93215/ Test FAILed. ---

[GitHub] spark issue #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21764 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93217/ Test FAILed. ---

[GitHub] spark issue #21795: [SPARK-24840][SQL] do not use dummy filter to switch cod...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21795 **[Test build #93215 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93215/testReport)** for PR 21795 at commit

[GitHub] spark issue #21795: [SPARK-24840][SQL] do not use dummy filter to switch cod...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21795 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-jav...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21801 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21764#discussion_r203270277 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -127,6 +127,14 @@ object SQLConf { } } +

[GitHub] spark issue #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21764 **[Test build #93217 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93217/testReport)** for PR 21764 at commit

[GitHub] spark issue #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21764 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-jav...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21801 **[Test build #93216 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93216/testReport)** for PR 21801 at commit

[GitHub] spark issue #20821: [SPARK-23678][GraphX] a more efficient partition strateg...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20821 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21582: [SPARK-24576][BUILD] Upgrade Apache ORC to 1.5.2

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21582 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #18544: [SPARK-21318][SQL]Improve exception message thrown by `l...

2018-07-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/18544 @stanzhai Could we just fix it by changing `failFunctionLookup`? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21582: [SPARK-24576][BUILD] Upgrade Apache ORC to 1.5.2

2018-07-18 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/21582 Thanks! Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

2018-07-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r203265365 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala --- @@ -47,15 +48,27 @@ object CommandUtils extends Logging {

[GitHub] spark pull request #21608: [SPARK-24626] [SQL] Improve location size calcula...

2018-07-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21608#discussion_r203264804 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala --- @@ -148,6 +148,19 @@ class StatisticsSuite extends

[GitHub] spark issue #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21764 **[Test build #93217 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93217/testReport)** for PR 21764 at commit

[GitHub] spark issue #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-jav...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21801 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21764 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21764: [SPARK-24802] Optimization Rule Exclusion

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21764 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-jav...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21801 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21698: [SPARK-23243][Core] Fix RDD.repartition() data correctne...

2018-07-18 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/21698 Ah I see, then we need to change DAGScheduler a lot to fix it, which may not worth. I still insist that `repartition` should be treated as a bug, but it's not easy to hit(when the input

[GitHub] spark issue #21770: [SPARK-24806][SQL] Brush up generated code so that JDK c...

2018-07-18 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21770 yea, if we get the consensus to implement #21777, it sounds ok to me. --- - To unsubscribe, e-mail:

[GitHub] spark pull request #21770: [SPARK-24806][SQL] Brush up generated code so tha...

2018-07-18 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/21770#discussion_r203261248 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -318,7 +318,8 @@ case class SampleExec( v

[GitHub] spark issue #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-jav...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21801 **[Test build #93216 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93216/testReport)** for PR 21801 at commit

[GitHub] spark issue #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-jav...

2018-07-18 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/21801 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21777: [WIP][SPARK-24498][SQL] Add JDK compiler for runtime cod...

2018-07-18 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/21777 Yea, as you said, the JDK compiler generates different bytecode though, I couldn't get obvious performance gains for TPCDS as compared to the janino one. So, I couldn't find the strong reason to

[GitHub] spark issue #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-jav...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21801 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-jav...

2018-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21801 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93214/ Test FAILed. ---

[GitHub] spark issue #21801: [SPARK-24386][SPARK-24768][BUILD][FOLLOWUP] Fix lint-jav...

2018-07-18 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21801 **[Test build #93214 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93214/testReport)** for PR 21801 at commit

<    1   2   3   4   5   6