Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21852
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21848#discussion_r204524410
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -390,6 +390,7 @@ object SimplifyConditionals
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/21852
[SPARK-24893] [SQL] Remove the entire CaseWhen if all the outputs are
semantic equivalence
## What changes were proposed in this pull request?
Similar to SPARK-24890, if all the outputs of
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21811
**[Test build #4221 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4221/testReport)**
for PR 21811 at commit
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21848
This is a good point.
On Mon, Jul 23, 2018, 12:03 PM Dongjoon Hyun
wrote:
> Since this skips the evaluation of if condition, this will cause the
> following difference.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20699
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20699
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93449/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20699
**[Test build #93449 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93449/testReport)**
for PR 20699 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21851
**[Test build #93459 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93459/testReport)**
for PR 21851 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21851
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21851
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user maryannxue opened a pull request:
https://github.com/apache/spark/pull/21851
[SPARK-24891][SQL] Fix HandleNullInputsForUDF rule
## What changes were proposed in this pull request?
The HandleNullInputsForUDF would always add a new `If` node every time it
is
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/21848
Since this skips the evaluation of `if` condition, this will cause the
following difference.
**This PR**
```
scala> sql("select * from t").show
++
| a|
Github user c-horn commented on the issue:
https://github.com/apache/spark/pull/21676
Hi @tdas sorry for delay.
My email for github account: chorn4...@gmail.com
This looks fine to me, we can close this PR (and jira ticket) when yours is
merged.
---
Github user bomeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/21638#discussion_r204517923
--- Diff:
core/src/main/scala/org/apache/spark/input/PortableDataStream.scala ---
@@ -47,7 +47,7 @@ private[spark] abstract class StreamFileInputFormat[T]
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/21848#discussion_r204516658
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -390,6 +390,7 @@ object SimplifyConditionals extends
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/21848#discussion_r204515560
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -390,6 +390,7 @@ object SimplifyConditionals extends
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21847
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21847
**[Test build #93457 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93457/testReport)**
for PR 21847 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21847
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93457/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21809
**[Test build #93458 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93458/testReport)**
for PR 21809 at commit
Github user pgandhi999 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21809#discussion_r204514740
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -94,6 +94,13 @@ private[spark] class AppStatusStore(
Github user pgandhi999 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21809#discussion_r204514110
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
@@ -182,6 +184,12 @@ private[ui] class StagePage(parent: StagesTab, store:
Github user pgandhi999 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21809#discussion_r204513701
--- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala
---
@@ -94,6 +94,13 @@ private[spark] class AppStatusStore(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21848#discussion_r204513622
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -390,6 +390,7 @@ object SimplifyConditionals
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21850
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21850
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21850
**[Test build #93456 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93456/testReport)**
for PR 21850 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21847
**[Test build #93457 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93457/testReport)**
for PR 21847 at commit
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/21850
[SPARK-24892] [SQL] Simplify `CaseWhen` to `If` when there is only one
branch
## What changes were proposed in this pull request?
After the rule of removing the unreachable branches, it
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21848#discussion_r204510291
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -403,14 +404,14 @@ object
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/21848#discussion_r204509378
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -403,14 +404,14 @@ object SimplifyConditionals
Github user dbtsai commented on a diff in the pull request:
https://github.com/apache/spark/pull/21848#discussion_r204508986
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -651,6 +652,7 @@ object
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/21848
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21848#discussion_r204507068
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -651,6 +652,7 @@ object
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21848#discussion_r204506437
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -403,14 +404,14 @@ object
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21758#discussion_r204504127
--- Diff: core/src/main/scala/org/apache/spark/BarrierTaskInfo.scala ---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21653
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93447/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21653
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21653
**[Test build #93447 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93447/testReport)**
for PR 21653 at commit
Github user c-horn commented on the issue:
https://github.com/apache/spark/pull/21752
Do I need to change anything else with this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21546
**[Test build #93455 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93455/testReport)**
for PR 21546 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21546
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21546
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user mn-mikke commented on the issue:
https://github.com/apache/spark/pull/21102
Sure. Also cc @gatorsmile, who created the Jira ticket.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21848
**[Test build #93454 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93454/testReport)**
for PR 21848 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21849
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21848
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user sahilTakiar commented on the issue:
https://github.com/apache/spark/pull/21849
@vanzin could you take a look? I'm not sure if the same race conditions
present in the other unit tests apply to the new ones since no `SparkContext`
is being created. For now I didn't add any
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21848
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21849
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21849
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user Achuth17 commented on the issue:
https://github.com/apache/spark/pull/21608
@gatorsmile @maropu ping.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
GitHub user sahilTakiar opened a pull request:
https://github.com/apache/spark/pull/21849
[SPARK-24243][CORE] Expose exceptions from InProcessAppHandle
## What changes were proposed in this pull request?
Adds a new method to `SparkAppHandle` called `getError` which returns
GitHub user dbtsai opened a pull request:
https://github.com/apache/spark/pull/21848
[SPARK-24890] [SQ] Short circuiting the `if` condition when `trueValue` and
`falseValue` are the same
## What changes were proposed in this pull request?
When `trueValue` and `falseValue`
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21847
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21847
**[Test build #93453 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93453/testReport)**
for PR 21847 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21847
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93453/
Test FAILed.
---
Github user susanxhuynh commented on the issue:
https://github.com/apache/spark/pull/21006
cc @skonto @samvantran
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21847
**[Test build #93453 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93453/testReport)**
for PR 21847 at commit
Github user dbtsai commented on the issue:
https://github.com/apache/spark/pull/21847
add to whitelist
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21758
**[Test build #93452 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93452/testReport)**
for PR 21758 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r204484728
--- Diff: python/pyspark/serializers.py ---
@@ -184,27 +184,67 @@ def loads(self, obj):
raise NotImplementedError
-class
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21758
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21650
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21650
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93446/
Test FAILed.
---
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21823#discussion_r204482993
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SameResultSuite.scala ---
@@ -58,4 +61,16 @@ class SameResultSuite extends QueryTest
Github user icexelloss commented on a diff in the pull request:
https://github.com/apache/spark/pull/21650#discussion_r204482591
--- Diff: python/pyspark/sql/tests.py ---
@@ -5060,6 +5049,144 @@ def test_type_annotation(self):
df =
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21758
**[Test build #93446 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93446/testReport)**
for PR 21758 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93445/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21758
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21650
**[Test build #93451 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93451/testReport)**
for PR 21650 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21758
**[Test build #93445 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93445/testReport)**
for PR 21758 at commit
Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21118
@cloud-fan, any update on merging this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21845
of course i am as usual. I actually already have been being taking care of
it. Thing is the tests are just being added even if they are duplicated of
something. I feel like it's a bit excessive
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21805
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/21546#discussion_r204479024
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -2095,9 +2095,11 @@ def toPandas(self):
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21805
LGTM
Thanks! Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21840#discussion_r204476440
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -3858,3 +3858,29 @@ object ArrayUnion
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21826
No we can't because you can still use string concat in filters, e.g.
colA || colB == "ab"
What is "||" here?
---
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21821
I just ran a test with once-strategy check and found out that a few
batches/rules do not stop, e.g. AggregatePushDown, "Convert to Spark client
exec", PartitionPruning. I believe most of them
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/21845
This helps, but it is not sustainable to keep increasing the threshold.
What we need to do is to look at test time distribution and figure out what
test suites are unnecessarily long and actually cut
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21805
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93444/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21805
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21805
**[Test build #93444 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93444/testReport)**
for PR 21805 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21847
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21847
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21847
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user lindblombr opened a pull request:
https://github.com/apache/spark/pull/21847
[SPARK-24855][SQL][EXTERNAL][WIP]: Built-in AVRO support should support
specified schema on write
## What changes were proposed in this pull request?
Allows `avroSchema` option to be
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21650
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21650
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21650
**[Test build #93450 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93450/testReport)**
for PR 21650 at commit
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/17174
@tanejagagan Can you update?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/19434
@CrazyJacky Can you close this for now cuz it's not active for a long time?
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21839
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21805
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93443/
Test PASSed.
---
201 - 300 of 484 matches
Mail list logo
