Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21942
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user sujithjay commented on the issue:
https://github.com/apache/spark/pull/21942
@holdenk Could you also please take a look at this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21942
Can one of the admins verify this patch?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user holdensmagicalunicorn commented on the issue:
https://github.com/apache/spark/pull/21942
@sujithjay, thanks! I am a bot who has found some folks who might be able
to help with the review:@mengxr, @jkbradley and @MLnick
---
GitHub user sujithjay opened a pull request:
https://github.com/apache/spark/pull/21942
[SPARK-24283][ML] Make ml.StandardScaler skip conversion of Sparâ¦
â¦k ml vectors to mllib vectors
## What changes were proposed in this pull request?
Currently, ml.StandardScaler
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21941
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21941
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93871/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21941
**[Test build #93871 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93871/testReport)**
for PR 21941 at commit
Github user vackosar commented on the issue:
https://github.com/apache/spark/pull/21919
@tdas @zsxwing @jose-torres @jerryshao @arunmahadevan @HyukjinKwon, please
help with the review and merge.
---
-
To
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21895
@jerryshao that can be done but I see mainly 2 problems IIUC:
- your suggestion about blacklisting has the same "caching" and "memory
leakage" problems of the solution proposed here, ie. if
Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21699#discussion_r206802439
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -339,29 +400,30 @@ class RelationalGroupedDataset
Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/21909
@HyukjinKwon @maropu Any objections to the PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21546
Yea.. I hope so. only one comment left.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206790470
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/MemoryStateStore.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93869/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21469
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206791736
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala
---
@@ -0,0 +1,137 @@
+/*
+ *
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206784385
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/statefulOperators.scala
---
@@ -201,33 +200,37 @@ object WatermarkSupport {
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206791325
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StatefulOperatorsHelperSuite.scala
---
@@ -0,0 +1,121 @@
+/*
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206786014
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala
---
@@ -53,7 +53,35 @@ class
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206780521
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala
---
@@ -0,0 +1,137 @@
+/*
+ *
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206779898
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala
---
@@ -0,0 +1,137 @@
+/*
+ *
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21469
**[Test build #93869 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93869/testReport)**
for PR 21469 at commit
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206781209
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala
---
@@ -0,0 +1,137 @@
+/*
+ *
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206790358
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/MemoryStateStore.scala
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206778127
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala
---
@@ -0,0 +1,137 @@
+/*
+ *
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206780754
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala
---
@@ -0,0 +1,137 @@
+/*
+ *
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206778355
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala
---
@@ -0,0 +1,137 @@
+/*
+ *
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206790505
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StatefulOperatorsHelperSuite.scala
---
@@ -0,0 +1,121 @@
+/*
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206788634
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StatefulOperatorsHelperSuite.scala
---
@@ -0,0 +1,121 @@
+/*
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206778971
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala
---
@@ -0,0 +1,137 @@
+/*
+ *
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206778077
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulOperatorsHelper.scala
---
@@ -0,0 +1,137 @@
+/*
+ *
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206775357
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -871,6 +871,16 @@ object SQLConf {
.intConf
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206776398
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -871,6 +871,16 @@ object SQLConf {
.intConf
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21883
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21883
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93868/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21883
**[Test build #93868 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93868/testReport)**
for PR 21883 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20958
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20958
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user deveshk0 commented on the issue:
https://github.com/apache/spark/pull/20272
I have built spark with the same changes for thrift server. It is running
fine for me.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21933
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21639
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21933
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93867/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21933
**[Test build #93867 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93867/testReport)**
for PR 21933 at commit
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21546
so... can we still target this for 2.4? sounds like very good to have and
complimentary to hydrogen
---
-
To unsubscribe,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21516
**[Test build #93875 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93875/testReport)**
for PR 21516 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21639
Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21516
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21923
this https://github.com/squito/spark-memory
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21895
My current thinking is to revert SPARK-20172 and improve the logging when
exception is met during the actual read.
---
-
To
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21895#discussion_r206780805
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -973,6 +978,42 @@ private[history] object FsHistoryProvider {
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21909
got it
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21639
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21639
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93861/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21639
**[Test build #93861 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93861/testReport)**
for PR 21639 at commit
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21895#discussion_r206779479
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -973,6 +978,42 @@ private[history] object FsHistoryProvider {
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21938
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21938
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user maryannxue commented on the issue:
https://github.com/apache/spark/pull/21699
Thank you for the change, @MaxGekk!
@HyukjinKwon my idea was actually that the overloaded versions of pivot
would be `pivot(column: Column, values, Seq[Column])`, so that we can construct
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21938
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93862/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21622
**[Test build #93874 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93874/testReport)**
for PR 21622 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21938
**[Test build #93862 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93862/testReport)**
for PR 21938 at commit
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21622
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21661
**[Test build #93873 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93873/testReport)**
for PR 21661 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21661
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21661
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/21661
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/21930
I think that's binary-incompatible breaking API change, right?
ex.
https://github.com/apache/spark/pull/21930/files#diff-2b8f0f66fe5397b169d0f754e99da8d5R64
---
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21936#discussion_r206769869
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -571,7 +571,12 @@ class SparkContext(config: SparkConf) extends Logging {
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21936#discussion_r206770131
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -571,7 +571,12 @@ class SparkContext(config: SparkConf) extends Logging {
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21661
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21661
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93860/
Test FAILed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21661
**[Test build #93860 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93860/testReport)**
for PR 21661 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21941
**[Test build #93872 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93872/testReport)**
for PR 21941 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21941
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21941
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21941#discussion_r206768063
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1451,6 +1451,15 @@ object SQLConf {
.intConf
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/spark/pull/21622#discussion_r206766835
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MetricsReporter.scala
---
@@ -39,6 +42,23 @@ class MetricsReporter(
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93856/
Test PASSed.
---
Github user jbax commented on the issue:
https://github.com/apache/spark/pull/21892
Thanks @MaxGekk I've fixed the error and also made the parser run faster
than before when processing fields that were not selected in general.
Can you please retest with the latest SNAPSHOT
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21756
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21756
**[Test build #93856 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/93856/testReport)**
for PR 21756 at commit
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21941#discussion_r206764090
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -535,14 +535,14 @@ abstract class SparkStrategies extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21941#discussion_r206764069
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -535,14 +535,14 @@ abstract class SparkStrategies extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21941#discussion_r206764004
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -165,9 +165,9 @@ object
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21941#discussion_r206763936
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1451,6 +1451,15 @@ object SQLConf {
.intConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21941#discussion_r206763732
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1451,6 +1451,15 @@ object SQLConf {
.intConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21941#discussion_r206763501
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/PlanParserSuite.scala
---
@@ -676,4 +677,42 @@ class PlanParserSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21941#discussion_r206763358
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -17,6 +17,12 @@
grammar SqlBase;
@members
Github user zhengruifeng closed the pull request at:
https://github.com/apache/spark/pull/19084
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
801 - 890 of 890 matches
Mail list logo
