[GitHub] spark pull request #22110: [SPARK-25122][SQL] Deduplication of supports equa...

2018-08-16 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22110#discussion_r210593726 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala --- @@ -73,4 +73,15 @@ object TypeUtils { }

[GitHub] spark issue #22110: [SPARK-25122][SQL] Deduplication of supports equals code

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22110 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94847/ Test PASSed. ---

[GitHub] spark issue #22110: [SPARK-25122][SQL] Deduplication of supports equals code

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22110 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22110: [SPARK-25122][SQL] Deduplication of supports equals code

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22110 **[Test build #94847 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94847/testReport)** for PR 22110 at commit

[GitHub] spark issue #22119: [WIP][SPARK-25129][SQL] Revert mapping com.databricks.sp...

2018-08-16 Thread tgravescs
Github user tgravescs commented on the issue: https://github.com/apache/spark/pull/22119 Sorry I'm a bit confused by what is going on here. It looks like you just reverted the change. I thought we were simply adding a config so its configurable as to whether its in the mapping table

[GitHub] spark issue #22120: [SPARK-25131]Event logs missing applicationAttemptId for...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22120 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22120: [SPARK-25131]Event logs missing applicationAttemptId for...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22120 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22120: [SPARK-25131]Event logs missing applicationAttemptId for...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22120 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22120: [SPARK-25131]Event logs missing applicationAttemp...

2018-08-16 Thread ajithme
GitHub user ajithme opened a pull request: https://github.com/apache/spark/pull/22120 [SPARK-25131]Event logs missing applicationAttemptId for SparkListenerApplicationStart When master=yarn and deploy-mode=client, event logs do not contain applicationAttemptId for

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-08-16 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22029 @cloud-fan @gatorsmile any thoughts on this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22031 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22031 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94846/ Test PASSed. ---

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22031 **[Test build #94846 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94846/testReport)** for PR 22031 at commit

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22031 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94845/ Test PASSed. ---

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22031 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22031 **[Test build #94845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94845/testReport)** for PR 22031 at commit

[GitHub] spark pull request #22110: [SPARK-25122][SQL] Deduplication of supports equa...

2018-08-16 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/22110#discussion_r210563516 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala --- @@ -73,4 +73,14 @@ object TypeUtils { }

[GitHub] spark pull request #22110: [SPARK-25122][SQL] Deduplication of supports equa...

2018-08-16 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22110#discussion_r210561778 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala --- @@ -73,4 +73,14 @@ object TypeUtils { }

[GitHub] spark pull request #22045: [SPARK-23940][SQL] Add transform_values SQL funct...

2018-08-16 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/22045#discussion_r210561102 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala --- @@ -497,6 +497,53 @@ case class

[GitHub] spark issue #21537: [SPARK-24505][SQL] Convert strings in codegen to blocks:...

2018-08-16 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/21537 Thanks for all involving in this discussion! Sorry that I was on a long flight and feels too tired to reply now. I just want to say for now, no matter what decision we made, to continue to

[GitHub] spark issue #21860: [SPARK-24901][SQL]Merge the codegen of RegularHashMap an...

2018-08-16 Thread heary-cao
Github user heary-cao commented on the issue: https://github.com/apache/spark/pull/21860 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21221: [SPARK-23429][CORE] Add executor memory metrics to heart...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21221 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21221: [SPARK-23429][CORE] Add executor memory metrics to heart...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21221 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94842/ Test FAILed. ---

[GitHub] spark issue #21221: [SPARK-23429][CORE] Add executor memory metrics to heart...

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21221 **[Test build #94842 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94842/testReport)** for PR 21221 at commit

[GitHub] spark issue #22045: [SPARK-23940][SQL] Add transform_values SQL function

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22045 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94843/ Test FAILed. ---

[GitHub] spark issue #22045: [SPARK-23940][SQL] Add transform_values SQL function

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22045 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22045: [SPARK-23940][SQL] Add transform_values SQL function

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22045 **[Test build #94843 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94843/testReport)** for PR 22045 at commit

[GitHub] spark pull request #21912: [SPARK-24962][SQL] Refactor CodeGenerator.createU...

2018-08-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21912#discussion_r210543909 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala --- @@ -34,6 +36,32 @@ object ArrayData { case a:

[GitHub] spark pull request #21912: [SPARK-24962][SQL] Refactor CodeGenerator.createU...

2018-08-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21912#discussion_r210543965 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala --- @@ -34,6 +36,32 @@ object ArrayData { case a:

[GitHub] spark issue #21889: [SPARK-4502][SQL] Parquet nested column pruning - founda...

2018-08-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21889 > I've only taken it as a based to make stylistic changes based on the code review to help move things along. This PR doesn't only include stylistic changes. Since stylistic changes do

[GitHub] spark issue #21909: [SPARK-24959][SQL] Speed up count() for JSON and CSV

2018-08-16 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/21909 @cloud-fan @gatorsmile May I ask you to look at the PR again. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #21912: [SPARK-24962][SQL] Refactor CodeGenerator.createU...

2018-08-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21912#discussion_r210539389 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -735,70 +735,92 @@ class CodegenContext

[GitHub] spark pull request #21912: [SPARK-24962][SQL] Refactor CodeGenerator.createU...

2018-08-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21912#discussion_r210539249 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -735,70 +735,92 @@ class CodegenContext

[GitHub] spark pull request #21912: [SPARK-24962][SQL] Refactor CodeGenerator.createU...

2018-08-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21912#discussion_r210533929 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -385,53 +385,81 @@ case class

[GitHub] spark pull request #21912: [SPARK-24962][SQL] Refactor CodeGenerator.createU...

2018-08-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21912#discussion_r210531207 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -735,70 +735,92 @@ class CodegenContext

[GitHub] spark pull request #21912: [SPARK-24962][SQL] Refactor CodeGenerator.createU...

2018-08-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21912#discussion_r210530380 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -735,70 +735,98 @@ class CodegenContext

[GitHub] spark pull request #21912: [SPARK-24962][SQL] Refactor CodeGenerator.createU...

2018-08-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21912#discussion_r210529856 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayData.scala --- @@ -34,6 +36,32 @@ object ArrayData { case a:

[GitHub] spark pull request #21912: [SPARK-24962][SQL] Refactor CodeGenerator.createU...

2018-08-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/21912#discussion_r210533651 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala --- @@ -385,53 +385,81 @@ case class

[GitHub] spark issue #22110: [SPARK-25122][SQL] Deduplication of supports equals code

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22110 **[Test build #94847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94847/testReport)** for PR 22110 at commit

[GitHub] spark issue #21087: [SPARK-23997][SQL] Configurable maximum number of bucket...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21087 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #21120: [SPARK-22448][ML] Added sum function to Summerize...

2018-08-16 Thread dedunumax
Github user dedunumax closed the pull request at: https://github.com/apache/spark/pull/21120 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22031 LGTM pending Jenkins. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22013: [SPARK-23939][SQL] Add transform_keys function

2018-08-16 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22013#discussion_r210527183 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala --- @@ -497,6 +497,59 @@ case class

[GitHub] spark pull request #22110: [SPARK-25122][SQL] Deduplication of supports equa...

2018-08-16 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22110#discussion_r210525593 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala --- @@ -73,4 +73,14 @@ object TypeUtils { }

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22031 **[Test build #94846 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94846/testReport)** for PR 22031 at commit

[GitHub] spark pull request #22013: [SPARK-23939][SQL] Add transform_keys function

2018-08-16 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22013#discussion_r210524076 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala --- @@ -497,6 +497,59 @@ case class

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22031 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22031 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22111: [SPARK-25123][SQL] Use Block to track code in SimpleExpr...

2018-08-16 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22111 @gatorsmile yes, sure, thanks. I created this before the related discussion on the other PR. We can keep this as a suggestion while preparing the design doc I think. I am closing this for the

[GitHub] spark pull request #22111: [SPARK-25123][SQL] Use Block to track code in Sim...

2018-08-16 Thread mgaido91
Github user mgaido91 closed the pull request at: https://github.com/apache/spark/pull/22111 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #21537: [SPARK-24505][SQL] Convert strings in codegen to blocks:...

2018-08-16 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/21537 Thanks everyone for this discussion. I think we all agree that what we need as a first thing is a design doc and we can move the discussion there. @kiszk thank you for your comments. I

[GitHub] spark issue #20206: [SPARK-19256][SQL] Remove ordering enforcement from `Fil...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20206 Build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20206: [SPARK-19256][SQL] Remove ordering enforcement from `Fil...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20206 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22107: [SPARK-25117][R] Add EXEPT ALL and INTERSECT ALL support...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22107 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22107: [SPARK-25117][R] Add EXEPT ALL and INTERSECT ALL support...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22107 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94844/ Test PASSed. ---

[GitHub] spark issue #22107: [SPARK-25117][R] Add EXEPT ALL and INTERSECT ALL support...

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22107 **[Test build #94844 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94844/testReport)** for PR 22107 at commit

[GitHub] spark issue #22119: [WIP][SPARK-25129][SQL] Revert mapping com.databricks.sp...

2018-08-16 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22119 I am not sure how useful the configuration for AVRO is. For the hive table example @dongjoon-hyun mentioned in

[GitHub] spark pull request #22013: [SPARK-23939][SQL] Add transform_keys function

2018-08-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22013 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22031 @techaddict Could you fix the conflicts please? Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22045: [SPARK-23940][SQL] Add transform_values SQL function

2018-08-16 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22045 @codeatri Could you fix the conflicts please? Thanks! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22013: [SPARK-23939][SQL] Add transform_keys function

2018-08-16 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22013 I'd merge this now. @mn-mikke @mgaido91 If you have any other comments, let's have a follow-up pr. --- - To unsubscribe,

[GitHub] spark issue #22013: [SPARK-23939][SQL] Add transform_keys function

2018-08-16 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22013 Thanks! merging to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22031 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22031 **[Test build #94845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94845/testReport)** for PR 22031 at commit

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22031 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22031 Jenkins, retest this please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21919: [SPARK-24933][SS] Report numOutputRows in SinkProgress

2018-08-16 Thread vackosar
Github user vackosar commented on the issue: https://github.com/apache/spark/pull/21919 @cloud-fan happy to merge? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22085: [SPARK-25095][PySpark] Python support for BarrierTaskCon...

2018-08-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22085 Thank you so much @mengxr and @jiangxb1987. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #21819: [SPARK-24863][SS] Report Kafka offset lag as a cu...

2018-08-16 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21819#discussion_r210500530 --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/JsonUtils.scala --- @@ -95,4 +95,20 @@ private object JsonUtils {

[GitHub] spark issue #22107: [SPARK-25117][R] Add EXEPT ALL and INTERSECT ALL support...

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22107 **[Test build #94844 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94844/testReport)** for PR 22107 at commit

[GitHub] spark issue #22107: [SPARK-25117][R] Add EXEPT ALL and INTERSECT ALL support...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22107 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22107: [SPARK-25117][R] Add EXEPT ALL and INTERSECT ALL support...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22107 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22045: [SPARK-23940][SQL] Add transform_values SQL function

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22045 **[Test build #94843 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94843/testReport)** for PR 22045 at commit

[GitHub] spark pull request #22119: [WIP][SPARK-25129][SQL] Revert mapping com.databr...

2018-08-16 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22119#discussion_r210495678 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -503,7 +495,7 @@ class AvroSuite extends QueryTest with

[GitHub] spark issue #21537: [SPARK-24505][SQL] Convert strings in codegen to blocks:...

2018-08-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21537 Sounds cool, let's move both to JIRAs or mailing lists. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #22119: [WIP][SPARK-25129][SQL] Revert mapping com.databricks.sp...

2018-08-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22119 This particular inconsistency could confuse users because CSV's one has existed for a long time. I think configuration makes this safer since both sides make sense I believe. ---

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22031 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94839/ Test FAILed. ---

[GitHub] spark issue #22117: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22117 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22117: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22117 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94840/ Test FAILed. ---

[GitHub] spark issue #22117: [SPARK-23654][BUILD] remove jets3t as a dependency of sp...

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22117 **[Test build #94840 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94840/testReport)** for PR 22117 at commit

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22031 **[Test build #94839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94839/testReport)** for PR 22031 at commit

[GitHub] spark issue #22031: [SPARK-23932][SQL] Higher order function zip_with

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22031 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21889: [SPARK-4502][SQL] Parquet nested column pruning - founda...

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21889 **[Test build #4278 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4278/testReport)** for PR 21889 at commit

[GitHub] spark issue #21320: [SPARK-4502][SQL] Parquet nested column pruning - founda...

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21320 **[Test build #4277 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4277/testReport)** for PR 21320 at commit

[GitHub] spark pull request #21868: [SPARK-24906][SQL] Adaptively enlarge split / par...

2018-08-16 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21868#discussion_r210494497 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala --- @@ -425,12 +426,44 @@ case class FileSourceScanExec(

[GitHub] spark issue #21221: [SPARK-23429][CORE] Add executor memory metrics to heart...

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21221 **[Test build #94842 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94842/testReport)** for PR 21221 at commit

[GitHub] spark issue #22119: [WIP][SPARK-25129][SQL] Revert mapping com.databricks.sp...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22119 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22119: [WIP][SPARK-25129][SQL] Revert mapping com.databricks.sp...

2018-08-16 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22119 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94841/ Test FAILed. ---

[GitHub] spark issue #22119: [WIP][SPARK-25129][SQL] Revert mapping com.databricks.sp...

2018-08-16 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22119 **[Test build #94841 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94841/testReport)** for PR 22119 at commit

[GitHub] spark issue #21221: [SPARK-23429][CORE] Add executor memory metrics to heart...

2018-08-16 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/21221 Jenkins, retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-08-16 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r210492311 --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala --- @@ -216,8 +217,7 @@ private[spark] class Executor( def stop():

[GitHub] spark pull request #21221: [SPARK-23429][CORE] Add executor memory metrics t...

2018-08-16 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21221#discussion_r210492513 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -69,6 +69,11 @@ package object config {

[GitHub] spark pull request #22110: [SPARK-25122][SQL] Deduplication of supports equa...

2018-08-16 Thread mn-mikke
Github user mn-mikke commented on a diff in the pull request: https://github.com/apache/spark/pull/22110#discussion_r210493260 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala --- @@ -73,4 +73,14 @@ object TypeUtils { }

[GitHub] spark issue #21537: [SPARK-24505][SQL] Convert strings in codegen to blocks:...

2018-08-16 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/21537 For 2. and 3., it is harder to say my opinion in the comment. Let me say short comments at first. For 2., if I remember correctly, @viirya once wrote the API document in a JIRA entry. it

[GitHub] spark issue #22119: [WIP][SPARK-25129][SQL] Revert mapping com.databricks.sp...

2018-08-16 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22119 CSV is loaded by default, while AVRO is not. So having a backward compatibility mapping in CSV only still makes sense. Let's remove the mapping for CSV in 3.0. ---

[GitHub] spark issue #21537: [SPARK-24505][SQL] Convert strings in codegen to blocks:...

2018-08-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21537 If there's a bug, then let's fix in another JIRA. If that's impossible to fix or sounds super risky and there's something I missed, let's revert. ---

[GitHub] spark issue #21537: [SPARK-24505][SQL] Convert strings in codegen to blocks:...

2018-08-16 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/21537 I wouldn't revert this unless there are specific concerns about this. Do you see any bug by a mixture of representation `s""` and `code""`? ---

[GitHub] spark issue #22119: [WIP][SPARK-25129][SQL] Revert mapping com.databricks.sp...

2018-08-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22119 For details, see the discussion in the JIRA https://issues.apache.org/jira/browse/SPARK-24924 --- - To unsubscribe, e-mail:

[GitHub] spark issue #22119: [WIP][SPARK-25129][SQL] Revert mapping com.databricks.sp...

2018-08-16 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22119 If we all agree this databricks mapping is not reasonable, I think it's ok to have this inconsistency and remove the mapping for CSV in 3.0. It's weird to make the same mistake just to

[GitHub] spark issue #22111: [SPARK-25123][SQL] Use Block to track code in SimpleExpr...

2018-08-16 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/22111 Let us hold these codegen PRs until we see the design doc for building IR for the codegen? --- - To unsubscribe, e-mail:

<    1   2   3   4   5   >