[GitHub] spark issue #22518: [SPARK-25482][SQL] ReuseSubquery can be useless when the...

2018-09-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22518 **[Test build #96472 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96472/testReport)** for PR 22518 at commit

[GitHub] spark issue #22525: [SPARK-25503] Total task message in stage page is ambigu...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22525 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22525: [SPARK-25503] Total task message in stage page is ambigu...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22525 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22525: [SPARK-25503] Total task message in stage page is...

2018-09-22 Thread shahidki31
GitHub user shahidki31 opened a pull request: https://github.com/apache/spark/pull/22525 [SPARK-25503] Total task message in stage page is ambiguous ## What changes were proposed in this pull request? Test steps : 1) bin/spark-shell --conf spark.ui.retainedTasks=10

[GitHub] spark issue #22525: [SPARK-25503] Total task message in stage page is ambigu...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22525 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22492: [SPARK-25321][ML] Revert SPARK-14681 to avoid API breaki...

2018-09-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22492 The next version is very likely to be 2.5.0... --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22522: [SPARK-25510][TEST] Create new trait replace BenchmarkWi...

2018-09-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22522 I think this change is necessary, but I'd like to migrate one benchmark to use this new trait as an example. We can migrate others in follow up PRs. ---

[GitHub] spark pull request #22522: [SPARK-25510][TEST] Create new trait replace Benc...

2018-09-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22522#discussion_r219672131 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/RunBenchmarkWithCodegen.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed

[GitHub] spark pull request #22522: [SPARK-25510][TEST] Create new trait replace Benc...

2018-09-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22522#discussion_r219672121 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/RunBenchmarkWithCodegen.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed

[GitHub] spark issue #22407: [SPARK-25416][SQL] ArrayPosition function may return inc...

2018-09-22 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22407 LGTM except one comment --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22407: [SPARK-25416][SQL] ArrayPosition function may ret...

2018-09-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22407#discussion_r219672065 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala --- @@ -1045,6 +1045,36 @@ class DataFrameFunctionsSuite extends

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22524 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96471/ Test FAILed. ---

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22524 **[Test build #96471 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96471/testReport)** for PR 22524 at commit

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22524 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22379 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96470/ Test PASSed. ---

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22379 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-09-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22379 **[Test build #96470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96470/testReport)** for PR 22379 at commit

[GitHub] spark pull request #22458: [SPARK-25459] Add viewOriginalText back to Catalo...

2018-09-22 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22458#discussion_r219670142 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala --- @@ -2348,4 +2348,17 @@ class HiveDDLSuite }

[GitHub] spark pull request #22458: [SPARK-25459] Add viewOriginalText back to Catalo...

2018-09-22 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22458#discussion_r219670109 --- Diff: sql/core/src/test/resources/sql-tests/results/higher-order-functions.sql.out --- @@ -201,6 +201,7 @@ struct<> -- !query 20 output

[GitHub] spark pull request #22458: [SPARK-25459] Add viewOriginalText back to Catalo...

2018-09-22 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22458#discussion_r219669978 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -331,6 +332,7 @@ case class CatalogTable(

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22419 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22419 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96469/ Test PASSed. ---

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22419 **[Test build #96469 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96469/testReport)** for PR 22419 at commit

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22491 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96468/ Test PASSed. ---

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22491 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-09-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22491 **[Test build #96468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96468/testReport)** for PR 22491 at commit

[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-22 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22519#discussion_r219667782 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -554,8 +554,11 @@ class Analyzer(

[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-22 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22519#discussion_r219667780 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -554,8 +554,11 @@ class Analyzer(

[GitHub] spark pull request #22524: [SPARK-25497][SQL] Limit operation within whole s...

2018-09-22 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22524#discussion_r219667461 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala --- @@ -84,9 +84,10 @@ trait BaseLimitExec extends UnaryExecNode with

[GitHub] spark pull request #22524: [SPARK-25497][SQL] Limit operation within whole s...

2018-09-22 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22524#discussion_r219667410 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -465,13 +465,18 @@ case class RangeExec(range:

[GitHub] spark issue #22518: [SPARK-25482][SQL] ReuseSubquery can be useless when the...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22518 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22518: [SPARK-25482][SQL] ReuseSubquery can be useless when the...

2018-09-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22518 **[Test build #96472 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96472/testReport)** for PR 22518 at commit

[GitHub] spark issue #22518: [SPARK-25482][SQL] ReuseSubquery can be useless when the...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22518 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22524 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22524 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22518: [SPARK-25482][SQL] ReuseSubquery can be useless when the...

2018-09-22 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22518 cc @cloud-fan @dongjoon-hyun @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22518: [SPARK-25482][SQL] ReuseSubquery can be useless w...

2018-09-22 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22518#discussion_r219667342 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala --- @@ -166,7 +168,7 @@ case class ReuseSubquery(conf: SQLConf) extends

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22524 **[Test build #96471 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96471/testReport)** for PR 22524 at commit

[GitHub] spark pull request #22524: [SPARK-25497][SQL] Limit operation within whole s...

2018-09-22 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/22524 [SPARK-25497][SQL] Limit operation within whole stage codegen should not consume all the inputs ## What changes were proposed in this pull request? This issue was discovered during

[GitHub] spark issue #22480: [SPARK-25473][PYTHON][SS][TEST] ForeachWriter tests fail...

2018-09-22 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22480 Nope I don't know but I guessed someone like me is looking into this because Python 3.6 + Mac is pretty common dev env to me. Let me take that out if that bothers :). I don't think it's a

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-09-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22379 **[Test build #96470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96470/testReport)** for PR 22379 at commit

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22491 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22491 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-09-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22491 **[Test build #96468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96468/testReport)** for PR 22491 at commit

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22419 **[Test build #96469 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96469/testReport)** for PR 22419 at commit

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22419 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-09-22 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22491 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22419 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-22 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22419 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22420: [SPARK-25429][SQL]Use Set improve SparkListenerBus effic...

2018-09-22 Thread wangyum
Github user wangyum commented on the issue: https://github.com/apache/spark/pull/22420 @hellodengfei Could you change the PR against `master` branch? This change LGTM. I did a benchmark about `Set` and `Array`: ```scala def benchmark(func: () => Unit): Long = { val

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22491 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22491 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96467/ Test FAILed. ---

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22419 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96466/ Test FAILed. ---

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22419 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22491: [SPARK-25483][TEST] Refactor UnsafeArrayDataBenchmark to...

2018-09-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22491 **[Test build #96467 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96467/testReport)** for PR 22491 at commit

[GitHub] spark issue #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(number)

2018-09-22 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22419 **[Test build #96466 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96466/testReport)** for PR 22419 at commit

[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-22 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22516 @Adamyuanyuan Thanks for the update! +1 for the option 1 :) --- - To unsubscribe, e-mail:

[GitHub] spark issue #22516: [SPARK-25468]Highlight current page index in the history...

2018-09-22 Thread Adamyuanyuan
Github user Adamyuanyuan commented on the issue: https://github.com/apache/spark/pull/22516 @gengliangwang Thanks for reminder, I also think this color is not good looking. I tried to change the background color before, but I'm not sure which is better, please give me some opinion to

<    1   2