[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22545 **[Test build #96550 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96550/testReport)** for PR 22545 at commit

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22545 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96550/ Test PASSed. ---

[GitHub] spark issue #22541: [SPARK-23907][SQL] Revert regr_* functions entirely

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22541 Merged to master and branch-2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22545 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22545 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22543: [SPARK-23715][SQL] improve document for from/to_utc_time...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22543 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96541/ Test PASSed. ---

[GitHub] spark issue #22543: [SPARK-23715][SQL] improve document for from/to_utc_time...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22543 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22429: [SPARK-25440][SQL] Dumping query execution info to a fil...

2018-09-25 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22429 > Could you also try to remove the default value? I have removed the default value `None` but still keep type as `Option[Int]`. @zsxwing Is it ok? >

[GitHub] spark issue #22543: [SPARK-23715][SQL] improve document for from/to_utc_time...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22543 **[Test build #96541 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96541/testReport)** for PR 22543 at commit

[GitHub] spark issue #22429: [SPARK-25440][SQL] Dumping query execution info to a fil...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22429 **[Test build #96551 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96551/testReport)** for PR 22429 at commit

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22545 **[Test build #96550 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96550/testReport)** for PR 22545 at commit

[GitHub] spark pull request #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf fo...

2018-09-25 Thread ueshin
GitHub user ueshin opened a pull request: https://github.com/apache/spark/pull/22545 [SPARK-25525][SQL][PYSPARK] Do not update conf for existing SparkContext in SparkSession.getOrCreate. ## What changes were proposed in this pull request? In

[GitHub] spark issue #22521: [SPARK-24519][CORE] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIG...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22521 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96538/ Test FAILed. ---

[GitHub] spark issue #22521: [SPARK-24519][CORE] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIG...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22521 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22521: [SPARK-24519][CORE] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIG...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22521 **[Test build #96538 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96538/testReport)** for PR 22521 at commit

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22326 **[Test build #96549 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96549/testReport)** for PR 22326 at commit

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22541: [SPARK-23907][SQL] Revert regr_* functions entirely

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22541 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96537/ Test PASSed. ---

[GitHub] spark issue #22541: [SPARK-23907][SQL] Revert regr_* functions entirely

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22541 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22541: [SPARK-23907][SQL] Revert regr_* functions entirely

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22541 **[Test build #96537 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96537/testReport)** for PR 22541 at commit

[GitHub] spark issue #22494: [SPARK-25454][SQL] add a new config for picking minimum ...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22494 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22494: [SPARK-25454][SQL] add a new config for picking minimum ...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22494 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96539/ Test PASSed. ---

[GitHub] spark issue #22494: [SPARK-25454][SQL] add a new config for picking minimum ...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22494 **[Test build #96539 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96539/testReport)** for PR 22494 at commit

[GitHub] spark issue #22361: Revert [SPARK-10399] [SPARK-23879] [SPARK-23762] [SPARK-...

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22361 It would be great if the information requested https://github.com/apache/spark/pull/22361#issuecomment-419607024 is shared so that other people can check it as well. ---

[GitHub] spark pull request #22544: [SPARK-25522][SQL] Improve type promotion for inp...

2018-09-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22544#discussion_r220140660 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -971,9 +971,36 @@ object TypeCoercion {

[GitHub] spark pull request #22544: [SPARK-25522][SQL] Improve type promotion for inp...

2018-09-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22544#discussion_r220140252 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -971,9 +971,36 @@ object TypeCoercion {

[GitHub] spark pull request #22544: [SPARK-25522][SQL] Improve type promotion for inp...

2018-09-25 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22544#discussion_r220147139 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -971,9 +971,36 @@ object TypeCoercion {

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96548/ Test FAILed. ---

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22326 **[Test build #96548 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96548/testReport)** for PR 22326 at commit

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22485: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22485 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22485: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22485 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96547/ Test PASSed. ---

[GitHub] spark issue #22485: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22485 **[Test build #96547 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96547/testReport)** for PR 22485 at commit

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22326 **[Test build #96548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96548/testReport)** for PR 22326 at commit

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-25 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22544 @dilipbiswal The two examples shown in the PR description are allowed in current and this proposes to disallow them? I'm a bit confused by the description. ---

[GitHub] spark issue #22485: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...

2018-09-25 Thread mareksimunek
Github user mareksimunek commented on the issue: https://github.com/apache/spark/pull/22485 test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22485: [SPARK-18364][YARN] Expose metrics for YarnShuffl...

2018-09-25 Thread mareksimunek
Github user mareksimunek commented on a diff in the pull request: https://github.com/apache/spark/pull/22485#discussion_r220137477 --- Diff: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java --- @@ -0,0 +1,133 @@ +/* + *

[GitHub] spark pull request #22485: [SPARK-18364][YARN] Expose metrics for YarnShuffl...

2018-09-25 Thread mareksimunek
Github user mareksimunek commented on a diff in the pull request: https://github.com/apache/spark/pull/22485#discussion_r220137523 --- Diff: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java --- @@ -0,0 +1,133 @@ +/* + *

[GitHub] spark pull request #22485: [SPARK-18364][YARN] Expose metrics for YarnShuffl...

2018-09-25 Thread mareksimunek
Github user mareksimunek commented on a diff in the pull request: https://github.com/apache/spark/pull/22485#discussion_r220137502 --- Diff: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java --- @@ -0,0 +1,133 @@ +/* + *

[GitHub] spark pull request #22485: [SPARK-18364][YARN] Expose metrics for YarnShuffl...

2018-09-25 Thread mareksimunek
Github user mareksimunek commented on a diff in the pull request: https://github.com/apache/spark/pull/22485#discussion_r220137410 --- Diff: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java --- @@ -0,0 +1,133 @@ +/* + *

[GitHub] spark pull request #22485: [SPARK-18364][YARN] Expose metrics for YarnShuffl...

2018-09-25 Thread mareksimunek
Github user mareksimunek commented on a diff in the pull request: https://github.com/apache/spark/pull/22485#discussion_r220137451 --- Diff: common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java --- @@ -56,7 +56,7 @@ public void

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22524 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22485: [SPARK-18364][YARN] Expose metrics for YarnShuffleServic...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22485 **[Test build #96547 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96547/testReport)** for PR 22485 at commit

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22524 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22524: [SPARK-25497][SQL] Limit operation within whole stage co...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22524 **[Test build #96546 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96546/testReport)** for PR 22524 at commit

[GitHub] spark issue #22540: [SPARK-24324] [PYTHON] [FOLLOW-UP] Rename the Conf to sp...

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22540 @gatorsmile, should be good to go after pushing https://github.com/gatorsmile/spark/pull/4 in --- - To unsubscribe, e-mail:

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220128279 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1234,6 +1237,59 @@ object

[GitHub] spark pull request #22533: [SPARK-18818][PYTHON] Add 'ascending' parameter t...

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22533#discussion_r220122281 --- Diff: python/pyspark/sql/window.py --- @@ -76,12 +79,37 @@ def partitionBy(*cols): @staticmethod @since(1.4) -def

[GitHub] spark issue #22518: [SPARK-25482][SQL] ReuseSubquery can be useless when the...

2018-09-25 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22518 @gengliangwang no, let me cite and explain the PR description. I am not sure how to improve it, but if you have suggestions I am happy to. The main point of the PR is to address an issue which

[GitHub] spark pull request #22492: [SPARK-25321][ML] Revert SPARK-14681 to avoid API...

2018-09-25 Thread WeichenXu123
Github user WeichenXu123 closed the pull request at: https://github.com/apache/spark/pull/22492 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22543: [SPARK-23715][SQL] improve document for from/to_u...

2018-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22543#discussion_r220114639 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1018,9 +1018,20 @@ case class

[GitHub] spark issue #22534: [SPARK-25514][SQL] Generating pretty JSON by to_json

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22534 **[Test build #96545 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96545/testReport)** for PR 22534 at commit

[GitHub] spark pull request #22543: [SPARK-23715][SQL] improve document for from/to_u...

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22543#discussion_r220112968 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala --- @@ -1018,9 +1018,20 @@ case class

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96544 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96544/testReport)** for PR 22544 at commit

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220111919 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1234,6 +1237,59 @@ object

[GitHub] spark pull request #22540: [SPARK-24324] [PYTHON] [FOLLOW-UP] Rename the Con...

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22540#discussion_r220111680 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1295,15 +1295,15 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #22540: [SPARK-24324] [PYTHON] [FOLLOW-UP] Rename the Con...

2018-09-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22540#discussion_r220111468 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowUtils.scala --- @@ -131,11 +131,8 @@ object ArrowUtils { } else {

[GitHub] spark pull request #22544: [SPARK-25522] Improve type promotion for input ar...

2018-09-25 Thread dilipbiswal
GitHub user dilipbiswal opened a pull request: https://github.com/apache/spark/pull/22544 [SPARK-25522] Improve type promotion for input arguments of elementAt function ## What changes were proposed in this pull request? In ElementAt, when first argument is MapType, we should

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220110490 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1234,6 +1237,59 @@ object PushPredicateThroughJoin

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220109700 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1234,6 +1237,59 @@ object PushPredicateThroughJoin

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220109689 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1234,6 +1237,59 @@ object

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220108380 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala --- @@ -1234,6 +1237,59 @@ object PushPredicateThroughJoin

[GitHub] spark pull request #22534: [SPARK-25514][SQL] Generating pretty JSON by to_j...

2018-09-25 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22534#discussion_r220104540 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala --- @@ -113,6 +113,11 @@ private[sql] class JSONOptions(

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96543/ Test FAILed. ---

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22326 **[Test build #96543 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96543/testReport)** for PR 22326 at commit

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22326 **[Test build #96543 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96543/testReport)** for PR 22326 at commit

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-25 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220102842 --- Diff: python/pyspark/sql/tests.py --- @@ -547,6 +547,92 @@ def test_udf_in_filter_on_top_of_join(self): df =

[GitHub] spark issue #22518: [SPARK-25482][SQL] ReuseSubquery can be useless when the...

2018-09-25 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22518 @mgaido91 Sorry but can you have a more detailed explanation in the PR description? With the code changes, the predicate with subquery result can be push down into data source. Is this

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96542/ Test FAILed. ---

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22326 **[Test build #96542 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96542/testReport)** for PR 22326 at commit

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22326 **[Test build #96542 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96542/testReport)** for PR 22326 at commit

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22198 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96540/ Test FAILed. ---

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22198 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22198 **[Test build #96540 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96540/testReport)** for PR 22198 at commit

[GitHub] spark pull request #22533: [SPARK-18818][PYTHON] Add 'ascending' parameter t...

2018-09-25 Thread annamolchanova
Github user annamolchanova commented on a diff in the pull request: https://github.com/apache/spark/pull/22533#discussion_r220089447 --- Diff: python/pyspark/sql/window.py --- @@ -76,12 +79,37 @@ def partitionBy(*cols): @staticmethod @since(1.4) -def

[GitHub] spark issue #22543: [SPARK-23715][SQL] improve document for from/to_utc_time...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22543 **[Test build #96541 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96541/testReport)** for PR 22543 at commit

[GitHub] spark issue #22543: [SPARK-23715][SQL] improve document for from/to_utc_time...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22543 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22543: [SPARK-23715][SQL] improve document for from/to_utc_time...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22543 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22543: [SPARK-23715][SQL] improve document for from/to_utc_time...

2018-09-25 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22543 cc @rxin @gatorsmile --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22543: [SPARK-23715][SQL] improve document for from/to_u...

2018-09-25 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/22543 [SPARK-23715][SQL] improve document for from/to_utc_timestamp ## What changes were proposed in this pull request? We have an agreement that the behavior of `from/to_utc_timestamp` is

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22198 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22494: [SPARK-25454][SQL] add a new config for picking minimum ...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22494 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22198 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22494: [SPARK-25454][SQL] add a new config for picking minimum ...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22494 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22521: [SPARK-24519][CORE] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIG...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22521 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22521: [SPARK-24519][CORE] Compute SHUFFLE_MIN_NUM_PARTS_TO_HIG...

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22521 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22541: [SPARK-23907][SQL] Revert regr_* functions entirely

2018-09-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22541 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22198: [SPARK-25121][SQL] Supports multi-part table names for b...

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22198 **[Test build #96540 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96540/testReport)** for PR 22198 at commit

[GitHub] spark issue #22541: [SPARK-23907][SQL] Revert regr_* functions entirely

2018-09-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22541 **[Test build #96537 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96537/testReport)** for PR 22541 at commit

<    1   2   3   4   5   6   7   >