[GitHub] spark issue #22484: [SPARK-25476][SPARK-25510][TEST] Refactor AggregateBench...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22484 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22484: [SPARK-25476][SPARK-25510][TEST] Refactor AggregateBench...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22484 **[Test build #9 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/9/testReport)** for PR 22484 at commit

[GitHub] spark issue #22558: [SPARK-25546][core] Don't cache value of EVENT_LOG_CALLS...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22558 **[Test build #96648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96648/testReport)** for PR 22558 at commit

[GitHub] spark issue #22558: [SPARK-25546][core] Don't cache value of EVENT_LOG_CALLS...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22558 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22558: [SPARK-25546][core] Don't cache value of EVENT_LOG_CALLS...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22558 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96648/ Test FAILed. ---

[GitHub] spark issue #22484: [SPARK-25476][SPARK-25510][TEST] Refactor AggregateBench...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22484 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22484: [SPARK-25476][SPARK-25510][TEST] Refactor Aggrega...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22484#discussion_r220800365 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala --- @@ -34,621 +34,539 @@ import

[GitHub] spark pull request #22484: [SPARK-25476][SPARK-25510][TEST] Refactor Aggrega...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22484#discussion_r220800434 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala --- @@ -34,621 +34,539 @@ import

[GitHub] spark issue #22010: [SPARK-21436][CORE] Take advantage of known partitioner ...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22010 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96652/ Test FAILed. ---

[GitHub] spark issue #22010: [SPARK-21436][CORE] Take advantage of known partitioner ...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22010 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22484: [SPARK-25476][SPARK-25510][TEST] Refactor Aggrega...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22484#discussion_r220799981 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/AggregateBenchmark.scala --- @@ -34,621 +34,539 @@ import

[GitHub] spark issue #22010: [SPARK-21436][CORE] Take advantage of known partitioner ...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22010 **[Test build #96652 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96652/testReport)** for PR 22010 at commit

[GitHub] spark issue #22484: [SPARK-25476][SPARK-25510][TEST] Refactor AggregateBench...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22484 @wangyum Could you review and merge https://github.com/wangyum/spark/pull/12 , too? --- - To unsubscribe, e-mail:

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21669 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21669 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96650/ Test PASSed. ---

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21669 **[Test build #96650 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96650/testReport)** for PR 21669 at commit

[GitHub] spark issue #22555: [SPARK-25536][CORE]metric value for METRIC_OUTPUT_RECORD...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22555 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96649/ Test PASSed. ---

[GitHub] spark issue #22555: [SPARK-25536][CORE]metric value for METRIC_OUTPUT_RECORD...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22555 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22555: [SPARK-25536][CORE]metric value for METRIC_OUTPUT_RECORD...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22555 **[Test build #96649 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96649/testReport)** for PR 22555 at commit

[GitHub] spark pull request #22466: [SPARK-25464][SQL]On dropping the Database it wil...

2018-09-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22466#discussion_r220795973 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -66,6 +66,19 @@ case class CreateDatabaseCommand(

[GitHub] spark pull request #22466: [SPARK-25464][SQL]On dropping the Database it wil...

2018-09-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22466#discussion_r220795446 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -66,6 +66,19 @@ case class CreateDatabaseCommand(

[GitHub] spark issue #22493: [SPARK-25485][SQL][TEST] Refactor UnsafeProjectionBenchm...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22493 **[Test build #96665 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96665/testReport)** for PR 22493 at commit

[GitHub] spark pull request #22466: [SPARK-25464][SQL]On dropping the Database it wil...

2018-09-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22466#discussion_r220795176 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala --- @@ -66,6 +66,19 @@ case class CreateDatabaseCommand(

[GitHub] spark issue #19041: [SPARK-21097][CORE] Add option to recover cached data

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/19041 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22493: [SPARK-25485][SQL][TEST] Refactor UnsafeProjectionBenchm...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22493 @yucai . Could you review and merge https://github.com/yucai/spark/pull/4 ? --- - To unsubscribe, e-mail:

[GitHub] spark pull request #22516: [SPARK-25468][WEBUI] Highlight current page index...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22516 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22516: [SPARK-25468][WEBUI] Highlight current page index in the...

2018-09-26 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22516 Merged to master/2.4 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22561: [SPARK-25548][SQL]In the PruneFileSourcePartitions optim...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22561 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22561: [SPARK-25548][SQL]In the PruneFileSourcePartitions optim...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22561 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96654/ Test FAILed. ---

[GitHub] spark issue #22561: [SPARK-25548][SQL]In the PruneFileSourcePartitions optim...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22561 **[Test build #96654 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96654/testReport)** for PR 22561 at commit

[GitHub] spark pull request #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22237#discussion_r220793666 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -554,18 +554,30 @@ case class

[GitHub] spark issue #21588: [SPARK-24590][BUILD] Make Jenkins tests passed with hado...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21588 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22555: [SPARK-25536][CORE]metric value for METRIC_OUTPUT_RECORD...

2018-09-26 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/22555 Thank you @dongjoon-hyun for merging --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21588: [SPARK-24590][BUILD] Make Jenkins tests passed with hado...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21588 **[Test build #96664 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96664/testReport)** for PR 21588 at commit

[GitHub] spark issue #21588: [SPARK-24590][BUILD] Make Jenkins tests passed with hado...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21588 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22545 SGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf fo...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22545 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread ueshin
Github user ueshin commented on the issue: https://github.com/apache/spark/pull/22545 I'm okay with merging this only into master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22545 Anyway, merged to master. Let me take #22552 out of branch-2.4 for now but please feel free to get this and that into branch-2.4 (without checking along with me) if you guys feel

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22545 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96663/ Test PASSed. ---

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22545 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22545 **[Test build #96663 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96663/testReport)** for PR 22545 at commit

[GitHub] spark issue #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_json

2018-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22237 Seems okay. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_...

2018-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22237#discussion_r220789449 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/FailureSafeParser.scala --- @@ -15,50 +15,51 @@ * limitations under the

[GitHub] spark issue #22555: [SPARK-25536][CORE]metric value for METRIC_OUTPUT_RECORD...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22555 Thank you, @shahidki31 , @cloud-fan , @wangyum . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #22555: [SPARK-25536][CORE]metric value for METRIC_OUTPUT...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22555 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22237: [SPARK-25243][SQL] Use FailureSafeParser in from_...

2018-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22237#discussion_r220788994 --- Diff: docs/sql-programming-guide.md --- @@ -1879,6 +1879,10 @@ working with timestamps in `pandas_udf`s to get the best performance, see

[GitHub] spark issue #22555: [SPARK-25536][CORE]metric value for METRIC_OUTPUT_RECORD...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22555 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22555: [SPARK-25536][CORE]metric value for METRIC_OUTPUT_RECORD...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22555 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22555: [SPARK-25536][CORE]metric value for METRIC_OUTPUT_RECORD...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22555 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96646/ Test PASSed. ---

[GitHub] spark issue #22555: [SPARK-25536][CORE]metric value for METRIC_OUTPUT_RECORD...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22555 **[Test build #96646 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96646/testReport)** for PR 22555 at commit

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22545 I think the session support is kind of partially implemented in Python side, and not being very well tested. There are some inconsistency between Python and Scala side (for instance see

[GitHub] spark pull request #22295: [SPARK-25255][PYTHON]Add getActiveSession to Spar...

2018-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22295#discussion_r220787563 --- Diff: python/pyspark/sql/session.py --- @@ -252,6 +253,22 @@ def newSession(self): """ return self.__class__(self._sc,

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22545 The scala side change is already in 2.3.0. If we are ok with the behavior inconsistency between python and scala, it's fine to merge it to master only (and revert #22552 from 2.4 as well). ---

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22545 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22545 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22545 **[Test build #96663 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96663/testReport)** for PR 22545 at commit

[GitHub] spark issue #17086: [SPARK-24101][ML][MLLIB] ML Evaluators should use weight...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17086 **[Test build #96658 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96658/testReport)** for PR 17086 at commit

[GitHub] spark issue #17086: [SPARK-24101][ML][MLLIB] ML Evaluators should use weight...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17086 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96658/ Test PASSed. ---

[GitHub] spark issue #17086: [SPARK-24101][ML][MLLIB] ML Evaluators should use weight...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/17086 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22490: [SPARK-25481][SQL][TEST] Refactor ColumnarBatchBe...

2018-09-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22490 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22545 @cloud-fan, do we target this 2.4? Looks it might break an existing app, in particular, when a Python shell creates a session and another shell (like Zeppelin) or another session depends on a

[GitHub] spark issue #22490: [SPARK-25481][SQL][TEST] Refactor ColumnarBatchBenchmark...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22490 Thank you, @yucai . --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22490: [SPARK-25481][SQL][TEST] Refactor ColumnarBatchBenchmark...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22490 Merged to master. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22490: [SPARK-25481][SQL][TEST] Refactor ColumnarBatchBenchmark...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22490 This passes the test already and the last merge is due to updating `ColumnarBatchBenchmark-results.txt` only. --- - To

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22455 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96645/ Test PASSed. ---

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22455 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22455 **[Test build #96645 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96645/testReport)** for PR 22455 at commit

[GitHub] spark pull request #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf fo...

2018-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22545#discussion_r220784330 --- Diff: python/pyspark/sql/session.py --- @@ -181,17 +181,11 @@ def getOrCreate(self): sparkConf.set(key, value)

[GitHub] spark issue #22563: [SPARK-24341][SQL][followup] remove duplicated error che...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22563 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22563: [SPARK-24341][SQL][followup] remove duplicated error che...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22563 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22563: [SPARK-24341][SQL][followup] remove duplicated error che...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22563 cc @mgaido91 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22563: [SPARK-24341][SQL][followup] remove duplicated er...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22563#discussion_r220783617 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala --- @@ -155,37 +155,35 @@ case class InSubquery(values:

[GitHub] spark issue #22563: [SPARK-24341][SQL][followup] remove duplicated error che...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22563 **[Test build #96662 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96662/testReport)** for PR 22563 at commit

[GitHub] spark pull request #22563: [SPARK-24341][SQL][followup] remove duplicated er...

2018-09-26 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/22563 [SPARK-24341][SQL][followup] remove duplicated error checking ## What changes were proposed in this pull request? There are 2 places we check for problematic `InSubquery`: the rule

[GitHub] spark issue #22562: [SPARK-25541][SQL][FOLLOWUP] Remove overriding filterKey...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22562 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22552: [SPARK-25540][SQL][PYSPARK] Make HiveContext in PySpark ...

2018-09-26 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22552 This is part of the bug fix PR: #22545 . I asked @ueshin to separate it since this one is self-contained. --- - To

[GitHub] spark issue #22552: [SPARK-25540][SQL][PYSPARK] Make HiveContext in PySpark ...

2018-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22552 hm, why did we merge this into 2.4 btw? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22562: [SPARK-25541][SQL][FOLLOWUP] Remove overriding filterKey...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22562 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22562: [SPARK-25541][SQL][FOLLOWUP] Remove overriding filterKey...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22562 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96644/ Test PASSed. ---

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96644 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96644/testReport)** for PR 22544 at commit

[GitHub] spark issue #22562: [SPARK-25541][SQL][FOLLOWUP] Remove overriding filterKey...

2018-09-26 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22562 @zsxwing @cloud-fan --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22562: [SPARK-25541][SQL][FOLLOWUP] Remove overriding fi...

2018-09-26 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/22562 [SPARK-25541][SQL][FOLLOWUP] Remove overriding filterKeys in CaseInsensitiveMap ## What changes were proposed in this pull request? As per the discussion in

[GitHub] spark issue #22562: [SPARK-25541][SQL][FOLLOWUP] Remove overriding filterKey...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22562 **[Test build #96661 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96661/testReport)** for PR 22562 at commit

[GitHub] spark issue #22528: [SPARK-25513][SQL] Read zipped CSV and JSON

2018-09-26 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22528 The limitation is quite clear - multi line mode only and single file. We don't have to rush about this - looks @MaxGekk has a clear idea on this. Another concern here is, we have another place

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22545 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22545 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96655/ Test PASSed. ---

[GitHub] spark issue #22545: [SPARK-25525][SQL][PYSPARK] Do not update conf for exist...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22545 **[Test build #96655 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96655/testReport)** for PR 22545 at commit

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22544 **[Test build #96660 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96660/testReport)** for PR 22544 at commit

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22544: [SPARK-25522][SQL] Improve type promotion for input argu...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22544 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22087: [SPARK-25097][ML] Support prediction on single in...

2018-09-26 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/22087#discussion_r220779540 --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/GaussianMixtureSuite.scala --- @@ -268,6 +268,13 @@ class GaussianMixtureSuite extends

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22326 **[Test build #96659 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96659/testReport)** for PR 22326 at commit

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-26 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220777535 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/python/BatchEvalPythonExecSuite.scala --- @@ -100,6 +105,29 @@ class

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22326: [SPARK-25314][SQL] Fix Python UDF accessing attributes f...

2018-09-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22326 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22326: [SPARK-25314][SQL] Fix Python UDF accessing attri...

2018-09-26 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/22326#discussion_r220777383 --- Diff: python/pyspark/sql/tests.py --- @@ -552,6 +552,96 @@ def test_udf_in_filter_on_top_of_join(self): df =

[GitHub] spark issue #17086: [SPARK-24101][ML][MLLIB] ML Evaluators should use weight...

2018-09-26 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/17086 **[Test build #96658 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96658/testReport)** for PR 17086 at commit

  1   2   3   4   5   6   7   >