[GitHub] spark issue #22572: [SPARK-25521][SQL]Job id showing null in the logs when i...

2018-10-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22572 ok to test --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22572: [SPARK-25521][SQL]Job id showing null in the logs when i...

2018-10-03 Thread sujith71955
Github user sujith71955 commented on the issue: https://github.com/apache/spark/pull/22572 > > Can we update the PR to use `description.uuid` first? > > Updated FileFormatWriter with description.uuid, attaching the verification snapshot . >

[GitHub] spark issue #22572: [SPARK-25521][SQL]Job id showing null in the logs when i...

2018-10-03 Thread sujith71955
Github user sujith71955 commented on the issue: https://github.com/apache/spark/pull/22572 > Can we update the PR to use `description.uuid` first? Updated FileFormatWriter with description.uuid, attaching the verification snapshot .

[GitHub] spark pull request #20433: [SPARK-23264][SQL] Make INTERVAL keyword optional...

2018-10-03 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/20433#discussion_r222544245 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -335,6 +335,12 @@ object SQLConf { .booleanConf

[GitHub] spark issue #22468: [SPARK-25374][SQL] SafeProjection supports fallback to a...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22468 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22468: [SPARK-25374][SQL] SafeProjection supports fallback to a...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22468 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96918/ Test PASSed. ---

[GitHub] spark issue #22468: [SPARK-25374][SQL] SafeProjection supports fallback to a...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22468 **[Test build #96918 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96918/testReport)** for PR 22468 at commit

[GitHub] spark issue #20433: [SPARK-23264][SQL] Make INTERVAL keyword optional in INT...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20433 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20433: [SPARK-23264][SQL] Make INTERVAL keyword optional in INT...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20433 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96919/ Test PASSed. ---

[GitHub] spark issue #20433: [SPARK-23264][SQL] Make INTERVAL keyword optional in INT...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20433 **[Test build #96919 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96919/testReport)** for PR 20433 at commit

[GitHub] spark pull request #22419: [SPARK-23906][SQL] Add built-in UDF TRUNCATE(numb...

2018-10-03 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22419#discussion_r222539741 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala --- @@ -1245,3 +1245,27 @@ case class BRound(child:

[GitHub] spark issue #22621: [SPARK-25602][SQL] SparkPlan.getByteArrayRdd should not ...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22621 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22414: [SPARK-25424][SQL] Window duration and slide duration wi...

2018-10-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22414 @raghavgautam Can you update this pr based on my patch? (sorry, but I have no time to take this over...) --- - To unsubscribe,

[GitHub] spark issue #22621: [SPARK-25602][SQL] SparkPlan.getByteArrayRdd should not ...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22621 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22621: [SPARK-25602][SQL] SparkPlan.getByteArrayRdd should not ...

2018-10-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22621 I simplified this PR to focus on `SparkPlan.getByteArrayRdd` only. Will submit PR to fix range later. --- - To unsubscribe,

[GitHub] spark pull request #22622: [SPARK-25635][SQL][BUILD] Support selective direc...

2018-10-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22622#discussion_r222535553 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala --- @@ -115,6 +116,71 @@ abstract class OrcSuite

[GitHub] spark issue #22621: [SPARK-25602][SQL] SparkPlan.getByteArrayRdd should not ...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22621 **[Test build #96924 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96924/testReport)** for PR 22621 at commit

[GitHub] spark pull request #22622: [SPARK-25635][SQL][BUILD] Support selective direc...

2018-10-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22622#discussion_r222535182 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala --- @@ -115,6 +116,71 @@ abstract class OrcSuite

[GitHub] spark issue #22141: [SPARK-25154][SQL] Support NOT IN sub-queries inside nes...

2018-10-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22141 @dilipbiswal Can we resume this for v3.0? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22622: [SPARK-25635][SQL][BUILD] Support selective direc...

2018-10-03 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22622#discussion_r222535254 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala --- @@ -284,4 +350,8 @@ class OrcSourceSuite

[GitHub] spark issue #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite failures w...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22512 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite failures w...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22512 **[Test build #96923 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96923/testReport)** for PR 22512 at commit

[GitHub] spark issue #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite failures w...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22512 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite fai...

2018-10-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22512#discussion_r222534352 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala --- @@ -162,6 +163,14 @@ object Literal {

[GitHub] spark pull request #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite fai...

2018-10-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22512#discussion_r222533960 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedMutableProjection.scala --- @@ -53,6 +55,47 @@ class

[GitHub] spark issue #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite failures w...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22512 **[Test build #96922 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96922/testReport)** for PR 22512 at commit

[GitHub] spark issue #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite failures w...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22512 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite failures w...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22512 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite fai...

2018-10-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22512#discussion_r222533632 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala --- @@ -238,7 +262,9 @@ object DecimalLiteral { /**

[GitHub] spark pull request #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite fai...

2018-10-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22512#discussion_r222533085 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala --- @@ -238,7 +262,9 @@ object DecimalLiteral { /**

[GitHub] spark pull request #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite fai...

2018-10-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22512#discussion_r222532952 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedMutableProjection.scala --- @@ -53,6 +55,47 @@ class

[GitHub] spark issue #22624: [SPARK-23781][CORE] Add base class for token renewal fun...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22624 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96915/ Test PASSed. ---

[GitHub] spark issue #22624: [SPARK-23781][CORE] Add base class for token renewal fun...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22624 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22624: [SPARK-23781][CORE] Add base class for token renewal fun...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22624 **[Test build #96915 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96915/testReport)** for PR 22624 at commit

[GitHub] spark pull request #22512: [SPARK-25498][SQL][WIP] Fix SQLQueryTestSuite fai...

2018-10-03 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22512#discussion_r222530205 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala --- @@ -238,7 +262,9 @@ object DecimalLiteral { /**

[GitHub] spark issue #22624: [SPARK-23781][CORE] Add base class for token renewal fun...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22624 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22624: [SPARK-23781][CORE] Add base class for token renewal fun...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22624 **[Test build #96913 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96913/testReport)** for PR 22624 at commit

[GitHub] spark issue #22624: [SPARK-23781][CORE] Add base class for token renewal fun...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22624 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96913/ Test PASSed. ---

[GitHub] spark issue #22612: [SPARK-24958] Add executors' process tree total memory i...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22612 **[Test build #96921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96921/testReport)** for PR 22612 at commit

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-10-03 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r222528022 --- Diff: core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala --- @@ -84,6 +122,8 @@ case object MappedPoolMemory extends

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-10-03 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r222527353 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #22612: [SPARK-24958] Add executors' process tree total memory i...

2018-10-03 Thread rezasafi
Github user rezasafi commented on the issue: https://github.com/apache/spark/pull/22612 The test failure isn't related to this change and it is most likely flaky. I will push another patch shortly, but it will not address all the comments, but most of them. ---

[GitHub] spark pull request #22612: [SPARK-24958] Add executors' process tree total m...

2018-10-03 Thread rezasafi
Github user rezasafi commented on a diff in the pull request: https://github.com/apache/spark/pull/22612#discussion_r222527340 --- Diff: core/src/main/scala/org/apache/spark/executor/ProcfsBasedSystems.scala --- @@ -0,0 +1,274 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #22612: [SPARK-24958] Add executors' process tree total memory i...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22612 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96914/ Test FAILed. ---

[GitHub] spark issue #22612: [SPARK-24958] Add executors' process tree total memory i...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22612 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22612: [SPARK-24958] Add executors' process tree total memory i...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22612 **[Test build #96914 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96914/testReport)** for PR 22612 at commit

[GitHub] spark issue #22572: [SPARK-25521][SQL]Job id showing null in the logs when i...

2018-10-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22572 Can we update the PR to use `description.uuid` first? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #20433: [SPARK-23264][SQL] Make INTERVAL keyword optional in INT...

2018-10-03 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/20433 do we have an umbrella JIRA to track all the breaking changes that make Spark ANSI SQL compatible? --- - To unsubscribe,

[GitHub] spark issue #22621: [SPARK-25602][SQL] range metrics can be wrong if the res...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22621 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22621: [SPARK-25602][SQL] range metrics can be wrong if the res...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22621 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22621: [SPARK-25602][SQL] range metrics can be wrong if the res...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22621 **[Test build #96920 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96920/testReport)** for PR 22621 at commit

[GitHub] spark pull request #22527: [SPARK-17952][SQL] Nested Java beans support in c...

2018-10-03 Thread ueshin
Github user ueshin commented on a diff in the pull request: https://github.com/apache/spark/pull/22527#discussion_r222520022 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala --- @@ -1098,16 +1098,26 @@ object SQLContext { data: Iterator[_],

[GitHub] spark issue #22060: [DO NOT MERGE][TEST ONLY] Add once-policy rule check

2018-10-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22060 @maryannxue ah, I see. Do you still keep working on this? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

2018-10-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222520483 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -453,45 +453,89 @@ case class RangeExec(range:

[GitHub] spark issue #22622: [SPARK-25635][SQL][BUILD] Support selective direct encod...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22622 **[Test build #96907 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96907/testReport)** for PR 22622 at commit

[GitHub] spark issue #22622: [SPARK-25635][SQL][BUILD] Support selective direct encod...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22622 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96907/ Test PASSed. ---

[GitHub] spark issue #22622: [SPARK-25635][SQL][BUILD] Support selective direct encod...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22622 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20303: [SPARK-23128][SQL] A new approach to do adaptive executi...

2018-10-03 Thread aaron-aa
Github user aaron-aa commented on the issue: https://github.com/apache/spark/pull/20303 @carsonwang what's your plan to merge this fix into master or some release? thanks a lot! --- - To unsubscribe, e-mail:

[GitHub] spark issue #21688: [SPARK-21809] : Change Stage Page to use datatables to s...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21688 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96912/ Test FAILed. ---

[GitHub] spark issue #22593: [Streaming][DOC] Fix typo & format in DataStreamWriter.s...

2018-10-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22593 ping @niofire --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #21688: [SPARK-21809] : Change Stage Page to use datatables to s...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/21688 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21688: [SPARK-21809] : Change Stage Page to use datatables to s...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21688 **[Test build #96912 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96912/testReport)** for PR 21688 at commit

[GitHub] spark issue #22610: [WIP][SPARK-25461][PySpark][SQL] Print warning when retu...

2018-10-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22610 One clear thing looks adding some documentation .. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #22620: [SPARK-25601][PYTHON] Register Grouped aggregate ...

2018-10-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22620 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22468: [SPARK-25374][SQL] SafeProjection supports fallback to a...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22468 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22468: [SPARK-25374][SQL] SafeProjection supports fallback to a...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22468 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22620: [SPARK-25601][PYTHON] Register Grouped aggregate UDF Vec...

2018-10-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22620 Thank you @icexelloss, @gatorsmile, @BryanCutler and @viirya. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22620: [SPARK-25601][PYTHON] Register Grouped aggregate UDF Vec...

2018-10-03 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/22620 Merged to master and branch-2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #20433: [SPARK-23264][SQL] Make INTERVAL keyword optional in INT...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/20433 **[Test build #96919 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96919/testReport)** for PR 20433 at commit

[GitHub] spark issue #20433: [SPARK-23264][SQL] Make INTERVAL keyword optional in INT...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20433 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22468: [SPARK-25374][SQL] SafeProjection supports fallback to a...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22468 **[Test build #96918 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96918/testReport)** for PR 22468 at commit

[GitHub] spark issue #20433: [SPARK-23264][SQL] Make INTERVAL keyword optional in INT...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/20433 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22468: [SPARK-25374][SQL] SafeProjection supports fallback to a...

2018-10-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/22468 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22500: [SPARK-25488][TEST] Refactor MiscBenchmark to use main m...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22500 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #20433: [SPARK-23264][SQL] Make INTERVAL keyword optional in INT...

2018-10-03 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/20433 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22500: [SPARK-25488][TEST] Refactor MiscBenchmark to use main m...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22500 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96910/ Test PASSed. ---

[GitHub] spark issue #22500: [SPARK-25488][TEST] Refactor MiscBenchmark to use main m...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22500 **[Test build #96910 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96910/testReport)** for PR 22500 at commit

[GitHub] spark issue #22610: [WIP][SPARK-25461][PySpark][SQL] Print warning when retu...

2018-10-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22610 Btw, I checked our `_minimum_pyarrow_version` is 0.8.0, so seems like even there is next upgrade available, for users with pyarrow versions before 0.11.0, this is still an potential issue. Isn't?

[GitHub] spark issue #22620: [SPARK-25601][PYTHON] Register Grouped aggregate UDF Vec...

2018-10-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22620 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

2018-10-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222510592 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala --- @@ -453,45 +453,89 @@ case class RangeExec(range:

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22455 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22455 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96906/ Test PASSed. ---

[GitHub] spark issue #22455: [SPARK-24572][SPARKR] "eager execution" for R shell, IDE

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22455 **[Test build #96906 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96906/testReport)** for PR 22455 at commit

[GitHub] spark pull request #22621: [SPARK-25602][SQL] range metrics can be wrong if ...

2018-10-03 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22621#discussion_r222510006 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala --- @@ -517,4 +517,93 @@ class SQLMetricsSuite extends

[GitHub] spark issue #22620: [SPARK-25601][PYTHON] Register Grouped aggregate UDF Vec...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22620 **[Test build #96917 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96917/testReport)** for PR 22620 at commit

[GitHub] spark issue #22620: [SPARK-25601][PYTHON] Register Grouped aggregate UDF Vec...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22620 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96917/ Test PASSed. ---

[GitHub] spark issue #22620: [SPARK-25601][PYTHON] Register Grouped aggregate UDF Vec...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22620 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22610: [WIP][SPARK-25461][PySpark][SQL] Print warning when retu...

2018-10-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22610 I think it is more reasonable to use the option when converting from Pandas to raise an error for unsafe casts. It should be better than to display warning message. Not sure how long before

[GitHub] spark issue #22620: [SPARK-25601][PYTHON] Register Grouped aggregate UDF Vec...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22620 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96916/ Test PASSed. ---

[GitHub] spark issue #22620: [SPARK-25601][PYTHON] Register Grouped aggregate UDF Vec...

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22620 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22620: [SPARK-25601][PYTHON] Register Grouped aggregate UDF Vec...

2018-10-03 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22620 **[Test build #96916 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/96916/testReport)** for PR 22620 at commit

[GitHub] spark issue #22610: [WIP][SPARK-25461][PySpark][SQL] Print warning when retu...

2018-10-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22610 > Yeah, it's part of pyarrow.Array now, but will only be in the 0.11.0 release so we would have to do it after the next upgrade. Then I think we can wait for next upgrade to use this feature

[GitHub] spark issue #22610: [WIP][SPARK-25461][PySpark][SQL] Print warning when retu...

2018-10-03 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/22610 > It is pretty new one, is it said we need to upgrade to latest PyArrow in order to use it? Since it is an option at Table.from_pandas, is it possible to extend it to pyarrow.Array?

[GitHub] spark issue #22610: [WIP][SPARK-25461][PySpark][SQL] Print warning when retu...

2018-10-03 Thread BryanCutler
Github user BryanCutler commented on the issue: https://github.com/apache/spark/pull/22610 > Thanks, @BryanCutler. WDYT about documenting the type map thing? I think that would help in the cases of dates/times because those can get a little confusing. For primitives, I think

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-10-03 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r222506222 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadoopsteps/HadoopKerberosLogin.scala --- @@ -0,0 +1,79 @@

[GitHub] spark issue #22610: [WIP][SPARK-25461][PySpark][SQL] Print warning when retu...

2018-10-03 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22610 Thanks @BryanCutler! Looks like an useful option. It is pretty new one, is it said we need to upgrade to latest PyArrow in order to use it? Since it is an option at `Table.from_pandas`, is it

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-10-03 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r222506086 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadoopsteps/HadoopBootstrapUtil.scala --- @@ -0,0 +1,182

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-10-03 Thread mccheah
Github user mccheah commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r222505884 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/HadoopSparkUserExecutorFeatureStep.scala --- @@ -0,0 +1,45

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22379 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/96904/ Test PASSed. ---

[GitHub] spark issue #22379: [SPARK-25393][SQL] Adding new function from_csv()

2018-10-03 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22379 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

  1   2   3   4   5   >