[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22829 **[Test build #98031 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98031/testReport)** for PR 22829 at commit

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 **[Test build #98050 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98050/testReport)** for PR 22838 at commit

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22838 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22838 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4503/ ---

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 **[Test build #98049 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98049/testReport)** for PR 22838 at commit

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4503/ ---

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-25 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22838 @srowen I think now we are aligned. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...

2018-10-25 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22829 ok seems this to be closed. I will copy it to the other PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] Propagate the detected SCALA_VERSION

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 **[Test build #98048 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98048/testReport)** for PR 22838 at commit

[GitHub] spark issue #22838: [SPARK-25835][K8s] Propagate the detected SCALA_VERSION

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22838 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22838: [SPARK-25835][K8s] Propagate the detected SCALA_VERSION

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22838 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98048/ Test PASSed. ---

[GitHub] spark issue #22838: [SPARK-25835][K8s] Propagate the detected SCALA_VERSION

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4502/ ---

[GitHub] spark pull request #22820: [SPARK-25828][K8S][BUILD] Bumping Kubernetes-Clie...

2018-10-25 Thread erikerlandson
Github user erikerlandson commented on a diff in the pull request: https://github.com/apache/spark/pull/22820#discussion_r228321586 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala --- @@ -157,7 +157,10 @@ private[spark]

[GitHub] spark issue #22838: [SPARK-25835][K8s] Propagate the detected SCALA_VERSION

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22838 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22838: [SPARK-25835][K8s] Propagate the detected SCALA_VERSION

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22838 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22820: [SPARK-25828][K8S][BUILD] Bumping Kubernetes-Clie...

2018-10-25 Thread erikerlandson
Github user erikerlandson commented on a diff in the pull request: https://github.com/apache/spark/pull/22820#discussion_r228321407 --- Diff: docs/running-on-kubernetes.md --- @@ -45,7 +45,8 @@ logs and remains in "completed" state in the Kubernetes API until it's eventuall

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-10-25 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r228321793 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenManager.scala --- @@ -66,7 +66,8 @@ private[spark] class

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22029 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22029 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98027/ Test PASSed. ---

[GitHub] spark issue #22029: [SPARK-24395][SQL] IN operator should return NULL when c...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22029 **[Test build #98027 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98027/testReport)** for PR 22029 at commit

[GitHub] spark issue #22839: [SPARK-25656][SQL][DOC][EXAMPLE][BRANCH-2.4] Add a doc a...

2018-10-25 Thread dbtsai
Github user dbtsai commented on the issue: https://github.com/apache/spark/pull/22839 Thanks @dongjoon-hyun This LGTM! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-10-25 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r228320944 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -647,4 +647,42 @@ package object config { .stringConf

[GitHub] spark pull request #22752: [SPARK-24787][CORE] Revert hsync in EventLoggingL...

2018-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22752 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22752: [SPARK-24787][CORE] Revert hsync in EventLoggingListener...

2018-10-25 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22752 Merging to master / 2.4 (will run a couple of tests on 2.4 before merging there). --- - To unsubscribe, e-mail:

[GitHub] spark issue #22827: [SPARK-25832][SQL] Revert newly added map related functi...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22827 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98029/ Test FAILed. ---

[GitHub] spark issue #22827: [SPARK-25832][SQL] Revert newly added map related functi...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22827 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 **[Test build #98048 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98048/testReport)** for PR 22838 at commit

[GitHub] spark issue #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integration T...

2018-10-25 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22608 @vanzin as per our conversation offline, that is exactly what my current refactor is doing. I will push an update really soon. Thanks for the recommendation! ---

[GitHub] spark issue #22827: [SPARK-25832][SQL] Revert newly added map related functi...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22827 **[Test build #98029 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98029/testReport)** for PR 22827 at commit

[GitHub] spark issue #22838: [SPARK-25835][K8s] Create kubernetes-tests profile and u...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4502/ ---

[GitHub] spark issue #22804: [SPARK-25665][SQL][TEST] Refactor ObjectHashAggregateExe...

2018-10-25 Thread peter-toth
Github user peter-toth commented on the issue: https://github.com/apache/spark/pull/22804 Thanks @dongjoon-hyun , @wangyum for the review. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

2018-10-25 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228318094 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core +

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

2018-10-25 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228317925 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core +

[GitHub] spark issue #22839: [SPARK-25656][SQL][DOC][EXAMPLE][BRANCH-2.4] Add a doc a...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22839 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98046/ Test PASSed. ---

[GitHub] spark issue #22839: [SPARK-25656][SQL][DOC][EXAMPLE][BRANCH-2.4] Add a doc a...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22839 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22839: [SPARK-25656][SQL][DOC][EXAMPLE][BRANCH-2.4] Add a doc a...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22839 **[Test build #98046 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98046/testReport)** for PR 22839 at commit

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

2018-10-25 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228316721 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core +

[GitHub] spark pull request #22829: [SPARK-25836][BUILD][K8S] For now disable kuberne...

2018-10-25 Thread srowen
Github user srowen closed the pull request at: https://github.com/apache/spark/pull/22829 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

2018-10-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228311880 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core +

[GitHub] spark pull request #22838: [SPARK-25835][K8s] Create kubernetes-tests profil...

2018-10-25 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228316418 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core +

[GitHub] spark pull request #22798: [SPARK-25803][K8S] Fix docker-image-tool.sh -n op...

2018-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22798 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22798: [SPARK-25803][K8S] Fix docker-image-tool.sh -n option

2018-10-25 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22798 Merging to master / 2.4. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228314627 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core +

[GitHub] spark issue #22839: [SPARK-25656][SQL][DOC][EXAMPLE][BRANCH-2.4] Add a doc a...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22839 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22839: [SPARK-25656][SQL][DOC][EXAMPLE][BRANCH-2.4] Add a doc a...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22839 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4500/ ---

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22838 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22838 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22608: [SPARK-25750][K8S][TESTS] Kerberos Support Integration T...

2018-10-25 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22608 I haven't reviewed this (and I do have concerns about using an external image in the long term), just wanted to perhaps give some ideas for the future. Livy does integration tests using some

[GitHub] spark issue #22812: [SPARK-25817][SQL] Dataset encoder should support combin...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22812 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22812: [SPARK-25817][SQL] Dataset encoder should support combin...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22812 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98026/ Test PASSed. ---

[GitHub] spark pull request #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22838#discussion_r228313490 --- Diff: pom.xml --- @@ -2654,6 +2654,16 @@ kubernetes + +resource-managers/kubernetes/core +

[GitHub] spark issue #22812: [SPARK-25817][SQL] Dataset encoder should support combin...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22812 **[Test build #98026 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98026/testReport)** for PR 22812 at commit

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4500/ ---

[GitHub] spark pull request #22804: [SPARK-25665][SQL][TEST] Refactor ObjectHashAggre...

2018-10-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22804 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread erikerlandson
Github user erikerlandson commented on the issue: https://github.com/apache/spark/pull/22838 LGTM - the k8s integration tests are off by default, can be run via `-P...`, and are passwing via Jenkins --- - To

[GitHub] spark issue #22818: [SPARK-25827][CORE] Allocate arrays smaller than Int.Max...

2018-10-25 Thread squito
Github user squito commented on the issue: https://github.com/apache/spark/pull/22818 Actually there are quite a few more uses, even of `Int.MaxValue`, which I find suspicious, but for the moment I only wanted to touch the cases I understood better. For example,

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 **[Test build #98047 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98047/testReport)** for PR 22838 at commit

[GitHub] spark issue #22839: [SPARK-25656][SQL][DOC][EXAMPLE][BRANCH-2.4] Add a doc a...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22839 **[Test build #98046 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98046/testReport)** for PR 22839 at commit

[GitHub] spark pull request #22839: [SPARK-25656][SQL][DOC][EXAMPLE][BRANCH-2.4] Add ...

2018-10-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22839#discussion_r228307486 --- Diff: docs/sql-data-sources-load-save-functions.md --- @@ -82,6 +82,49 @@ To load a CSV file you can use: +The extra options

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4499/ ---

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22838 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22838 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #22839: [SPARK-25656][SQL][DOC][EXAMPLE][BRANCH-2.4] Add ...

2018-10-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22839#discussion_r228307138 --- Diff: examples/src/main/r/RSparkSQLExample.R --- @@ -114,10 +114,14 @@ write.df(namesAndAges, "namesAndAges.parquet", "parquet")

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4499/ ---

[GitHub] spark pull request #22839: [SPARK-25656][SQL][DOC][EXAMPLE][BRANCH-2.4] Add ...

2018-10-25 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/22839 [SPARK-25656][SQL][DOC][EXAMPLE][BRANCH-2.4] Add a doc and examples about extra data source options ## What changes were proposed in this pull request? Our current doc does not

[GitHub] spark issue #22815: [SPARK-25821][SQL] Remove SQLContext methods deprecated ...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22815 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22815: [SPARK-25821][SQL] Remove SQLContext methods deprecated ...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22815 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98025/ Test PASSed. ---

[GitHub] spark issue #22815: [SPARK-25821][SQL] Remove SQLContext methods deprecated ...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22815 **[Test build #98025 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98025/testReport)** for PR 22815 at commit

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 **[Test build #98045 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98045/testReport)** for PR 22838 at commit

[GitHub] spark issue #22824: [SPARK-25834] [Structured Streaming]Update Mode should n...

2018-10-25 Thread arunmahadevan
Github user arunmahadevan commented on the issue: https://github.com/apache/spark/pull/22824 It may be enough to do the check just once than repeating similar checks for inner, leftOuter and rightOuter. For example have a single check before the `joinType match {` clause. ---

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22838 **[Test build #98044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98044/testReport)** for PR 22838 at commit

[GitHub] spark issue #22752: [SPARK-24787][CORE] Revert hsync in EventLoggingListener...

2018-10-25 Thread devaraj-kavali
Github user devaraj-kavali commented on the issue: https://github.com/apache/spark/pull/22752 @vanzin can you check the updated changes, thanks --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark issue #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread skonto
Github user skonto commented on the issue: https://github.com/apache/spark/pull/22838 @srowen pls review. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22838: [SPARK-25835][K8s] fix issues with k8s tests

2018-10-25 Thread skonto
GitHub user skonto opened a pull request: https://github.com/apache/spark/pull/22838 [SPARK-25835][K8s] fix issues with k8s tests ## What changes were proposed in this pull request? - Fixes the scala version propagation issue. - Disables the tests under the k8s profile,

[GitHub] spark issue #22837: [MINOR][TEST][BRANCH-2.4] Regenerate golden file `dateti...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22837 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22837: [MINOR][TEST][BRANCH-2.4] Regenerate golden file `dateti...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22837 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22829 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22829 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4497/ ---

[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22829 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22829 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4497/ ---

[GitHub] spark issue #22790: [SPARK-25793][ML]call SaveLoadV2_0.load for classNameV2_...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22790 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98036/ Test PASSed. ---

[GitHub] spark issue #22790: [SPARK-25793][ML]call SaveLoadV2_0.load for classNameV2_...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22790 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22790: [SPARK-25793][ML]call SaveLoadV2_0.load for classNameV2_...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22790 **[Test build #98036 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98036/testReport)** for PR 22790 at commit

[GitHub] spark pull request #22823: [SPARK-25676][SQL][TEST] Refactor BenchmarkWideTa...

2018-10-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22823#discussion_r228295120 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -910,12 +910,14 @@ class

[GitHub] spark issue #22837: [MINOR][TEST][BRANCH-2.4] Regenerate golden file `dateti...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22837 **[Test build #98043 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98043/testReport)** for PR 22837 at commit

[GitHub] spark issue #22827: [SPARK-25832][SQL] Revert newly added map related functi...

2018-10-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22827 @gatorsmile . Could you put `[BRANCH-2.4]` into PR title? --- - To unsubscribe, e-mail:

[GitHub] spark issue #22820: [SPARK-25828][K8S][BUILD] Bumping Kubernetes-Client vers...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22820 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22820: [SPARK-25828][K8S][BUILD] Bumping Kubernetes-Client vers...

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22820 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22820: [SPARK-25828][K8S][BUILD] Bumping Kubernetes-Client vers...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22820 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4496/ ---

[GitHub] spark pull request #22837: [MINOR][TEST] Regenerate golden file `datetime.sq...

2018-10-25 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22837#discussion_r228293689 --- Diff: sql/core/src/test/resources/sql-tests/results/datetime.sql.out --- @@ -82,9 +82,10 @@ struct 1 2 2 3 + -- !query

[GitHub] spark pull request #22837: [MINOR][TEST] Fix datetime.sql.out

2018-10-25 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/22837 [MINOR][TEST] Fix datetime.sql.out ## What changes were proposed in this pull request? `datetime.sql.out` is a generated golden file, but it's a little bit broken during manual

[GitHub] spark issue #22820: [SPARK-25828][K8S][BUILD] Bumping Kubernetes-Client vers...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22820 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4496/ ---

[GitHub] spark issue #21816: [SPARK-24794][CORE] Driver launched through rest should ...

2018-10-25 Thread bsikander
Github user bsikander commented on the issue: https://github.com/apache/spark/pull/21816 Thank you. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22817: [SPARK-25816][SQL] Fix attribute resolution in nested ex...

2018-10-25 Thread peter-toth
Github user peter-toth commented on the issue: https://github.com/apache/spark/pull/22817 @gatorsmile , I looked into this and it seems if we use `mapChildren` in `ResolveReferences` then `UnresolvedExtractValue` should define 2 children. ---

[GitHub] spark issue #22829: [SPARK-25836][BUILD][K8S] For now disable kubernetes-int...

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22829 **[Test build #98042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98042/testReport)** for PR 22829 at commit

[GitHub] spark pull request #22817: [SPARK-25816][SQL] Fix attribute resolution in ne...

2018-10-25 Thread peter-toth
Github user peter-toth commented on a diff in the pull request: https://github.com/apache/spark/pull/22817#discussion_r228285647 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -407,7 +407,10 @@ case class

[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable

2018-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22830 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22830: [SPARK-25838][ML] Remove formatVersion from Saveable

2018-10-25 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22830 **[Test build #98039 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98039/testReport)** for PR 22830 at commit

<    1   2   3   4   5   6   7   8   >