[GitHub] spark issue #22880: [SPARK-25407][SQL] Ensure we pass a compatible pruned sc...

2018-11-07 Thread mallman
Github user mallman commented on the issue: https://github.com/apache/spark/pull/22880 Can someone with Jenkins retest privileges please kick off a retest? --- - To unsubscribe, e-mail:

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22944 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22944 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98558/ Test PASSed. ---

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22944 **[Test build #98558 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98558/testReport)** for PR 22944 at commit

[GitHub] spark issue #22880: [SPARK-25407][SQL] Ensure we pass a compatible pruned sc...

2018-11-07 Thread mallman
Github user mallman commented on the issue: https://github.com/apache/spark/pull/22880 Jenkins retest please. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22951: [SPARK-25945][SQL] Support locale while parsing date/tim...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22951 **[Test build #98567 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98567/testReport)** for PR 22951 at commit

[GitHub] spark issue #22960: [SPARK-25955][TEST] Porting JSON tests for CSV functions

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22960 **[Test build #98566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98566/testReport)** for PR 22960 at commit

[GitHub] spark pull request #8355: [SPARK-10152] [SQL] Support Init script for hive-t...

2018-11-07 Thread vincentye38
Github user vincentye38 commented on a diff in the pull request: https://github.com/apache/spark/pull/8355#discussion_r231648528 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala --- @@ -67,6 +68,46 @@ object

[GitHub] spark pull request #22951: [SPARK-25945][SQL] Support locale while parsing d...

2018-11-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22951#discussion_r231646713 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CsvExpressionsSuite.scala --- @@ -209,4 +210,20 @@ class

[GitHub] spark pull request #22951: [SPARK-25945][SQL] Support locale while parsing d...

2018-11-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22951#discussion_r231641960 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala --- @@ -578,4 +581,20 @@ class JsonFunctionsSuite extends QueryTest

[GitHub] spark pull request #22951: [SPARK-25945][SQL] Support locale while parsing d...

2018-11-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22951#discussion_r231640870 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CsvFunctionsSuite.scala --- @@ -117,4 +120,20 @@ class CsvFunctionsSuite extends QueryTest

[GitHub] spark issue #22938: [SPARK-25935][SQL] Prevent null rows from JSON parser

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22938 **[Test build #98565 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98565/testReport)** for PR 22938 at commit

[GitHub] spark issue #22957: [SPARK-25951][SQL] Ignore aliases for distributions and ...

2018-11-07 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/22957 i didn't look at your new code, but is your old code safe? e.g. a project that depends on the new alias. --- - To unsubscribe,

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22944 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98557/ Test FAILed. ---

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22944 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22944 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98556/ Test FAILed. ---

[GitHub] spark pull request #22952: [SPARK-20568][SS] Rename files which are complete...

2018-11-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22952#discussion_r231634109 --- Diff: docs/structured-streaming-programming-guide.md --- @@ -530,6 +530,8 @@ Here are the details of all the sources in Spark.

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22944 **[Test build #98557 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98557/testReport)** for PR 22944 at commit

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22944 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22944 **[Test build #98556 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98556/testReport)** for PR 22944 at commit

[GitHub] spark issue #22938: [SPARK-25935][SQL] Prevent null rows from JSON parser

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22938 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98555/ Test FAILed. ---

[GitHub] spark issue #22938: [SPARK-25935][SQL] Prevent null rows from JSON parser

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22938 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22938: [SPARK-25935][SQL] Prevent null rows from JSON parser

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22938 **[Test build #98555 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98555/testReport)** for PR 22938 at commit

[GitHub] spark issue #22932: [SPARK-25102][SQL] Write Spark version to ORC/Parquet fi...

2018-11-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22932 @felixcheung . If the question is about writer versions, Spark/Hive works on top of ORC/Parquet library. ORC/Parquet library already writes its specific version for that purpose. For me, it

[GitHub] spark issue #22965: [SPARK-25964][SQL][Minor] Revise OrcReadBenchmark/DataSo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22965 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22965: [SPARK-25964][SQL][Minor] Revise OrcReadBenchmark/DataSo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22965 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98553/ Test PASSed. ---

[GitHub] spark issue #22965: [SPARK-25964][SQL][Minor] Revise OrcReadBenchmark/DataSo...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22965 **[Test build #98553 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98553/testReport)** for PR 22965 at commit

[GitHub] spark issue #22504: [SPARK-25118][Submit] Persist Driver Logs in Client mode...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22504 **[Test build #98564 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98564/testReport)** for PR 22504 at commit

[GitHub] spark issue #22957: [SPARK-25951][SQL] Ignore aliases for distributions and ...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22957 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98552/ Test PASSed. ---

[GitHub] spark issue #22957: [SPARK-25951][SQL] Ignore aliases for distributions and ...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22957 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22957: [SPARK-25951][SQL] Ignore aliases for distributions and ...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22957 **[Test build #98552 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98552/testReport)** for PR 22957 at commit

[GitHub] spark issue #22921: [SPARK-25908][CORE][SQL] Remove old deprecated items in ...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22921 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22921: [SPARK-25908][CORE][SQL] Remove old deprecated items in ...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22921 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98551/ Test PASSed. ---

[GitHub] spark issue #22921: [SPARK-25908][CORE][SQL] Remove old deprecated items in ...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22921 **[Test build #98551 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98551/testReport)** for PR 22921 at commit

[GitHub] spark issue #22959: [SPARK-25876][k8s] Simplify kubernetes configuration typ...

2018-11-07 Thread rvesse
Github user rvesse commented on the issue: https://github.com/apache/spark/pull/22959 First glance this looks like a lot of nice simplification, will take a proper look over this tomorrow --- - To unsubscribe,

[GitHub] spark pull request #22965: [SPARK-25964][SQL][Minor] Revise OrcReadBenchmark...

2018-11-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22965#discussion_r231610295 --- Diff: sql/core/benchmarks/DataSourceReadBenchmark-results.txt --- @@ -2,268 +2,268 @@ SQL Single Numeric Column Scan

[GitHub] spark pull request #22965: [SPARK-25964][SQL][Minor] Revise OrcReadBenchmark...

2018-11-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22965#discussion_r231608634 --- Diff: sql/core/benchmarks/DataSourceReadBenchmark-results.txt --- @@ -2,268 +2,268 @@ SQL Single Numeric Column Scan

[GitHub] spark issue #22932: [SPARK-25102][SQL] Write Spark version to ORC/Parquet fi...

2018-11-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/22932 Thank you for review, @felixcheung . Could you elaborate a little bit more? Here, three writers are used: new native ORC writer, old Hive ORC writer, and native Parquet writer. > a prop

[GitHub] spark issue #21688: [SPARK-21809] : Change Stage Page to use datatables to s...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/21688 **[Test build #98563 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98563/testReport)** for PR 21688 at commit

[GitHub] spark pull request #21688: [SPARK-21809] : Change Stage Page to use datatabl...

2018-11-07 Thread pgandhi999
Github user pgandhi999 commented on a diff in the pull request: https://github.com/apache/spark/pull/21688#discussion_r231605935 --- Diff: core/src/main/resources/org/apache/spark/ui/static/stagepage.js --- @@ -0,0 +1,965 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #21688: [SPARK-21809] : Change Stage Page to use datatabl...

2018-11-07 Thread pgandhi999
Github user pgandhi999 commented on a diff in the pull request: https://github.com/apache/spark/pull/21688#discussion_r231605818 --- Diff: core/src/main/resources/org/apache/spark/ui/static/stagepage.js --- @@ -0,0 +1,965 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request #21688: [SPARK-21809] : Change Stage Page to use datatabl...

2018-11-07 Thread pgandhi999
Github user pgandhi999 commented on a diff in the pull request: https://github.com/apache/spark/pull/21688#discussion_r231605894 --- Diff: core/src/main/resources/org/apache/spark/ui/static/stagepage.js --- @@ -0,0 +1,965 @@ +/* + * Licensed to the Apache Software

[GitHub] spark issue #22921: [SPARK-25908][CORE][SQL] Remove old deprecated items in ...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22921 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22921: [SPARK-25908][CORE][SQL] Remove old deprecated items in ...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22921 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22504: [SPARK-25118][Submit] Persist Driver Logs in Client mode...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22504 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98562/ Test FAILed. ---

[GitHub] spark issue #22947: [SPARK-24913][SQL] Make AssertNotNull and AssertTrue non...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22947 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22947: [SPARK-24913][SQL] Make AssertNotNull and AssertTrue non...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22947 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22504: [SPARK-25118][Submit] Persist Driver Logs in Client mode...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22504 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22504: [SPARK-25118][Submit] Persist Driver Logs in Client mode...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22504 **[Test build #98562 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98562/testReport)** for PR 22504 at commit

[GitHub] spark issue #22909: [SPARK-25897][k8s] Hook up k8s integration tests to sbt ...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22909 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4821/ ---

[GitHub] spark issue #22909: [SPARK-25897][k8s] Hook up k8s integration tests to sbt ...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22909 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22909: [SPARK-25897][k8s] Hook up k8s integration tests to sbt ...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22909 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request #22947: [SPARK-24913][SQL] Make AssertNotNull and AssertT...

2018-11-07 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22947#discussion_r231600766 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala --- @@ -66,6 +66,8 @@ case class AssertTrue(child: Expression)

[GitHub] spark issue #22921: [SPARK-25908][CORE][SQL] Remove old deprecated items in ...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22921 **[Test build #98561 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98561/testReport)** for PR 22921 at commit

[GitHub] spark issue #22909: [SPARK-25897][k8s] Hook up k8s integration tests to sbt ...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22909 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/4821/ ---

[GitHub] spark issue #22964: [SPARK-25963] Optimize generate followed by window

2018-11-07 Thread uzadude
Github user uzadude commented on the issue: https://github.com/apache/spark/pull/22964 this is the original query. we can see the explode followed by the shuffle: ``` import org.apache.spark.sql.functions._ import org.apache.spark.sql.expressions._ val N = 1

[GitHub] spark pull request #22948: [SPARK-25944][R][BUILD] AppVeyor change to latest...

2018-11-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22948#discussion_r231598045 --- Diff: dev/appveyor-install-dependencies.ps1 --- @@ -115,7 +115,7 @@ $env:Path += ";$env:HADOOP_HOME\bin" Pop-Location #

[GitHub] spark issue #22937: [SPARK-25934] [Mesos] Don't propagate SPARK_CONF_DIR fro...

2018-11-07 Thread mpmolek
Github user mpmolek commented on the issue: https://github.com/apache/spark/pull/22937 @felixcheung SPARK_HOME has been getting filtered out since #10329 --- - To unsubscribe, e-mail:

[GitHub] spark issue #22947: [SPARK-24913][SQL] Make AssertNotNull and AssertTrue non...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22947 **[Test build #98560 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98560/testReport)** for PR 22947 at commit

[GitHub] spark pull request #22921: [SPARK-25908][CORE][SQL] Remove old deprecated it...

2018-11-07 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22921#discussion_r231596680 --- Diff: R/pkg/R/functions.R --- @@ -1663,9 +1692,24 @@ setMethod("toDegrees", #' @aliases toRadians toRadians,Column-method #' @note

[GitHub] spark issue #22909: [SPARK-25897][k8s] Hook up k8s integration tests to sbt ...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22909 **[Test build #98559 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98559/testReport)** for PR 22909 at commit

[GitHub] spark issue #22909: [SPARK-25897][k8s] Hook up k8s integration tests to sbt ...

2018-11-07 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/spark/pull/22909 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22598: [SPARK-25501][SS] Add kafka delegation token supp...

2018-11-07 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r231591033 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/KafkaDelegationTokenProvider.scala --- @@ -0,0 +1,65 @@ +/* + * Licensed to the

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22944 **[Test build #98558 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98558/testReport)** for PR 22944 at commit

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22944 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22944 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/22944 @cloud-fan I have a simpler fix for this issue. Can you take another look? Thanks. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22944 **[Test build #98557 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98557/testReport)** for PR 22944 at commit

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22944 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22944 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22944: [SPARK-25942][SQL] Fix Dataset.groupByKey to make it wor...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22944 **[Test build #98556 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98556/testReport)** for PR 22944 at commit

[GitHub] spark issue #22938: [SPARK-25935][SQL] Prevent null rows from JSON parser

2018-11-07 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/22938 I made a fix for broken array and map in `JsonToStructs` because inside of `FailureSafeParser` is not clear from where the call came. I am still not sure that wrapping actual type by `StructType`

[GitHub] spark issue #22087: [SPARK-25097][ML] Support prediction on single instance ...

2018-11-07 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22087 I'd escalate to dev@ for more visibility. It has some longer-term consequences, and I'd like to hear current thinking on how much these APIs should change, etc. ---

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22938: [SPARK-25935][SQL] Prevent null rows from JSON parser

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22938 **[Test build #98555 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98555/testReport)** for PR 22938 at commit

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22963 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98549/ Test PASSed. ---

[GitHub] spark issue #22963: [SPARK-25962][BUILD][PYTHON] Specify minimum versions fo...

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22963 **[Test build #98549 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98549/testReport)** for PR 22963 at commit

[GitHub] spark pull request #22855: [SPARK-25839] [Core] Implement use of KryoPool in...

2018-11-07 Thread patrickbrownsync
Github user patrickbrownsync commented on a diff in the pull request: https://github.com/apache/spark/pull/22855#discussion_r231558355 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -214,8 +230,14 @@ class KryoSerializer(conf: SparkConf)

[GitHub] spark issue #22087: [SPARK-25097][ML] Support prediction on single instance ...

2018-11-07 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22087 @srowen I think it would not be a big deal if we would change the return type of these to Double, since they are now private. If that is the only change needed we may be able to reuse the

[GitHub] spark pull request #22893: [SPARK-25868][MLlib] One part of Spark MLlib Kmea...

2018-11-07 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22893#discussion_r23159 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala --- @@ -521,19 +521,21 @@ object MLUtils extends Logging { * The bound

[GitHub] spark issue #22818: [SPARK-25904][CORE] Allocate arrays smaller than Int.Max...

2018-11-07 Thread cloud-fan
Github user cloud-fan commented on the issue: https://github.com/apache/spark/pull/22818 since this is a bug fix, shall we also backport it? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For

[GitHub] spark pull request #22855: [SPARK-25839] [Core] Implement use of KryoPool in...

2018-11-07 Thread patrickbrownsync
Github user patrickbrownsync commented on a diff in the pull request: https://github.com/apache/spark/pull/22855#discussion_r231554649 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -92,6 +94,20 @@ class KryoSerializer(conf: SparkConf)

[GitHub] spark pull request #22921: [SPARK-25908][CORE][SQL] Remove old deprecated it...

2018-11-07 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22921#discussion_r231554470 --- Diff: R/pkg/R/functions.R --- @@ -319,6 +319,27 @@ setMethod("acos", column(jc) }) +#' @details +#'

[GitHub] spark issue #22966: [PARK-25965][SQL] Add avro read benchmark

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22966 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98554/ Test PASSed. ---

[GitHub] spark issue #22966: [PARK-25965][SQL] Add avro read benchmark

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22966 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22966: [PARK-25965][SQL] Add avro read benchmark

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22966 **[Test build #98554 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98554/testReport)** for PR 22966 at commit

[GitHub] spark issue #22087: [SPARK-25097][ML] Support prediction on single instance ...

2018-11-07 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22087 Aha. On the one hand, I suppose they can't extend that class because of the signature difference, and indeed it says it's the superclass of regression and classification models. I can imagine that

[GitHub] spark issue #22964: [SPARK-25963] Optimize generate followed by window

2018-11-07 Thread uzadude
Github user uzadude commented on the issue: https://github.com/apache/spark/pull/22964 The whole idea is that we'll get one shuffle and it will be before the explode as the window's partition is contained in the repartition. I'll show the physical plan. ---

[GitHub] spark issue #22965: [SPARK-25964][SQL][Minor] Revise OrcReadBenchmark/DataSo...

2018-11-07 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22965 @dongjoon-hyun @yucai --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #22966: [PARK-25965][SQL] Add avro read benchmark

2018-11-07 Thread gengliangwang
Github user gengliangwang commented on the issue: https://github.com/apache/spark/pull/22966 @dongjoon-hyun --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22965: [SPARK-25964][SQL][Minor] Revise OrcReadBenchmark...

2018-11-07 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22965#discussion_r231549251 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/OrcReadBenchmark.scala --- @@ -32,9 +32,11 @@ import org.apache.spark.sql.types._

[GitHub] spark issue #22966: [PARK-25965][SQL] Add avro read benchmark

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22966 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #22966: [PARK-25965][SQL] Add avro read benchmark

2018-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/22966 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22087: [SPARK-25097][ML] Support prediction on single instance ...

2018-11-07 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22087 @erikerlandson @srowen actually we already have a `PredictionModel` for this. am not sure why clustering algorithms are not extending it though, but in that class the method returns a `Double`,

[GitHub] spark issue #22966: [PARK-25965][SQL] Add avro read benchmark

2018-11-07 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/22966 **[Test build #98554 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98554/testReport)** for PR 22966 at commit

[GitHub] spark pull request #22966: [PARK-25965][SQL] Add avro read benchmark

2018-11-07 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/22966 [PARK-25965][SQL] Add avro read benchmark ## What changes were proposed in this pull request? Add read benchmark for Avro, which is missing for a period. The benchmark is similar

[GitHub] spark issue #22964: [SPARK-25963] Optimize generate followed by window

2018-11-07 Thread hvanhovell
Github user hvanhovell commented on the issue: https://github.com/apache/spark/pull/22964 @uzadude where is this relevant? You will end up with two shuffles if you do this. --- - To unsubscribe, e-mail:

[GitHub] spark issue #22955: [SPARK-25949][SQL] Add test for PullOutPythonUDFInJoinCo...

2018-11-07 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/spark/pull/22955 shall we also remove the end-to-end tests which are now not needed anymore? --- - To unsubscribe, e-mail:

[GitHub] spark pull request #22894: [SPARK-25885][Core][Minor] HighlyCompressedMapSta...

2018-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22894 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark issue #22087: [SPARK-25097][ML] Support prediction on single instance ...

2018-11-07 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22087 Yeah it's a good point and I wonder if @jkbradley or @mengxr or @MLnick want to weigh in. If this superclass method existed, I think it would be `predict(Vector):Int` anyway, so seems pretty

<    1   2   3   4   5   >