[GitHub] spark pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-11-17 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23072#discussion_r234432181 --- Diff: R/pkg/R/mllib_clustering.R --- @@ -610,3 +616,57 @@ setMethod("write.ml", signature(object = "LDAModel", path = "character"),

[GitHub] spark pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-11-17 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23072#discussion_r234432019 --- Diff: R/pkg/R/mllib_clustering.R --- @@ -610,3 +616,57 @@ setMethod("write.ml", signature(object = "LDAModel", path = "character"),

[GitHub] spark pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-11-17 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23072#discussion_r234432049 --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd --- @@ -968,6 +970,17 @@ predicted <- predict(model, df) head(predicted) ``` +

[GitHub] spark pull request #23073: [SPARK-26104] expose pci info to task scheduler

2018-11-17 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/23073#discussion_r234431864 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/ExecutorData.scala --- @@ -27,12 +27,14 @@ import org.apache.spark.rpc.{RpcAddress,

[GitHub] spark issue #23073: [SPARK-26104] expose pci info to task scheduler

2018-11-17 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/23073 please put ^ comment into PR description (because comment is not included in commit message once the PR is merged) --- - To

[GitHub] spark pull request #23042: [SPARK-26070][SQL] add rule for implicit type coe...

2018-11-17 Thread uzadude
Github user uzadude commented on a diff in the pull request: https://github.com/apache/spark/pull/23042#discussion_r234431689 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala --- @@ -138,6 +138,11 @@ object TypeCoercion {

[GitHub] spark issue #23076: [SPARK-26103][SQL] Added maxDepth to limit the length of...

2018-11-17 Thread DaveDeCaprio
Github user DaveDeCaprio commented on the issue: https://github.com/apache/spark/pull/23076 This contribution is my original work and I license the work to the project under the project’s open source license. ---

[GitHub] spark issue #23076: [SPARK-26103][SQL] Added maxDepth to limit the length of...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23076 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23076: [SPARK-26103][SQL] Added maxDepth to limit the length of...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23076 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23076: [SPARK-26103][SQL] Added maxDepth to limit the length of...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23076 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #23076: [SPARK-26103][SQL] Added maxDepth to limit the le...

2018-11-17 Thread DaveDeCaprio
GitHub user DaveDeCaprio opened a pull request: https://github.com/apache/spark/pull/23076 [SPARK-26103][SQL] Added maxDepth to limit the length of text plans Nested query plans can get extremely large (hundreds of megabytes). ## What changes were proposed in this pull

[GitHub] spark issue #23069: [SPARK-26026][BUILD] Published Scaladoc jars missing fro...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23069 **[Test build #4432 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4432/testReport)** for PR 23069 at commit

[GitHub] spark issue #23065: [SPARK-26090][CORE][SQL][ML] Resolve most miscellaneous ...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23065 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98972/ Test FAILed. ---

[GitHub] spark issue #23065: [SPARK-26090][CORE][SQL][ML] Resolve most miscellaneous ...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23065 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23065: [SPARK-26090][CORE][SQL][ML] Resolve most miscellaneous ...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23065 **[Test build #98972 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98972/testReport)** for PR 23065 at commit

[GitHub] spark issue #23054: [SPARK-26085][SQL] Key attribute of primitive type under...

2018-11-17 Thread viirya
Github user viirya commented on the issue: https://github.com/apache/spark/pull/23054 Ok. I will add a flag. Thanks @rxin --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands,

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23075 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23075 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpression....

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23075 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #23075: [SPARK-26084][SQL] Fixes unresolved AggregateExpr...

2018-11-17 Thread ssimeonov
GitHub user ssimeonov opened a pull request: https://github.com/apache/spark/pull/23075 [SPARK-26084][SQL] Fixes unresolved AggregateExpression.references exception ## What changes were proposed in this pull request? This PR fixes an exception in

[GitHub] spark issue #23069: [SPARK-26026][BUILD] Published Scaladoc jars missing fro...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23069 **[Test build #4432 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4432/testReport)** for PR 23069 at commit

[GitHub] spark issue #23065: [SPARK-26090][CORE][SQL][ML] Resolve most miscellaneous ...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23065 **[Test build #98972 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98972/testReport)** for PR 23065 at commit

[GitHub] spark issue #23065: [SPARK-26090][CORE][SQL][ML] Resolve most miscellaneous ...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23065 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23065: [SPARK-26090][CORE][SQL][ML] Resolve most miscellaneous ...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23065 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23074: [SPARK-19798] Refresh table does not have effect on othe...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23074 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23074: [SPARK-19798] Refresh table does not have effect on othe...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23074 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23074: [SPARK-19798] Refresh table does not have effect on othe...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23074 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #23074: [SPARK-19798] Refresh table does not have effect ...

2018-11-17 Thread gbloisi
GitHub user gbloisi opened a pull request: https://github.com/apache/spark/pull/23074 [SPARK-19798] Refresh table does not have effect on other sessions than the issuing one ## What changes were proposed in this pull request? Refresh table command does not have effect on other

[GitHub] spark issue #23073: [SPARK-26104] expose pci info to task scheduler

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23073 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23072 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23073: [SPARK-26104] expose pci info to task scheduler

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23073 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #23073: [SPARK-26104] expose pci info to task scheduler

2018-11-17 Thread chenqin
GitHub user chenqin opened a pull request: https://github.com/apache/spark/pull/23073 [SPARK-26104] expose pci info to task scheduler ## What changes were proposed in this pull request? (Please fill in changes proposed in this fix) ## How was this patch tested?

[GitHub] spark issue #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23072 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98971/ Test PASSed. ---

[GitHub] spark issue #23073: [SPARK-26104] expose pci info to task scheduler

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23073 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23072 **[Test build #98971 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98971/testReport)** for PR 23072 at commit

[GitHub] spark issue #23071: [SPARK-26102][SQL][TEST] Extracting common CSV/JSON func...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23071 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23071: [SPARK-26102][SQL][TEST] Extracting common CSV/JSON func...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23071 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98970/ Test PASSed. ---

[GitHub] spark issue #23071: [SPARK-26102][SQL][TEST] Extracting common CSV/JSON func...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23071 **[Test build #98970 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98970/testReport)** for PR 23071 at commit

[GitHub] spark issue #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23072 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23072 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23072 **[Test build #98971 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98971/testReport)** for PR 23072 at commit

[GitHub] spark pull request #23072: [SPARK-19827][R]spark.ml R API for PIC

2018-11-17 Thread huaxingao
GitHub user huaxingao opened a pull request: https://github.com/apache/spark/pull/23072 [SPARK-19827][R]spark.ml R API for PIC ## What changes were proposed in this pull request? Add PowerIterationCluster (PIC) in R ## How was this patch tested? Add test case You

[GitHub] spark issue #23066: [SPARK-26043][CORE] Make SparkHadoopUtil private to Spar...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23066 **[Test build #4431 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4431/testReport)** for PR 23066 at commit

[GitHub] spark issue #23071: [SPARK-26102][SQL][TEST] Extracting common CSV/JSON func...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23071 Can one of the admins verify this patch? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23057 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark pull request #23071: [SPARK-26102][SQL][TEST] Extracting common CSV/JS...

2018-11-17 Thread MaxGekk
GitHub user MaxGekk opened a pull request: https://github.com/apache/spark/pull/23071 [SPARK-26102][SQL][TEST] Extracting common CSV/JSON functions tests ## What changes were proposed in this pull request? Extracted common tests from `CsvFunctionsSuite` and

[GitHub] spark issue #23071: [SPARK-26102][SQL][TEST] Extracting common CSV/JSON func...

2018-11-17 Thread MaxGekk
Github user MaxGekk commented on the issue: https://github.com/apache/spark/pull/23071 @dongjoon-hyun May I ask you to review the PR. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23071: [SPARK-26102][SQL][TEST] Extracting common CSV/JSON func...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23071 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23071: [SPARK-26102][SQL][TEST] Extracting common CSV/JSON func...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23071 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23057 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98969/ Test PASSed. ---

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23057 **[Test build #98969 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98969/testReport)** for PR 23057 at commit

[GitHub] spark issue #23071: [SPARK-26102][SQL][TEST] Extracting common CSV/JSON func...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23071 **[Test build #98970 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98970/testReport)** for PR 23071 at commit

[GitHub] spark issue #23038: [SPARK-25451][SPARK-26100][CORE]Aggregated metrics table...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23038 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23038: [SPARK-25451][SPARK-26100][CORE]Aggregated metrics table...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23038 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98966/ Test PASSed. ---

[GitHub] spark issue #23038: [SPARK-25451][SPARK-26100][CORE]Aggregated metrics table...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23038 **[Test build #98966 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98966/testReport)** for PR 23038 at commit

[GitHub] spark issue #23054: [SPARK-26085][SQL] Key attribute of primitive type under...

2018-11-17 Thread rxin
Github user rxin commented on the issue: https://github.com/apache/spark/pull/23054 We should add a “legacy” flag in case somebody’s workload gets broken by this. We can remove the legacy flag in a future release. ---

[GitHub] spark issue #23038: [SPARK-25451][SPARK-26100][CORE]Aggregated metrics table...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23038 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98967/ Test PASSed. ---

[GitHub] spark issue #23038: [SPARK-25451][SPARK-26100][CORE]Aggregated metrics table...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23038 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23038: [SPARK-25451][SPARK-26100][CORE]Aggregated metrics table...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23038 **[Test build #98967 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98967/testReport)** for PR 23038 at commit

[GitHub] spark issue #23038: [SPARK-25451][SPARK-26100][CORE]Aggregated metrics table...

2018-11-17 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/23038 It is random failure --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23070: [SPARK-26099][SQL] Verification of the corrupt column in...

2018-11-17 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue: https://github.com/apache/spark/pull/23070 L9oks good to me. I or someone else should take a closer look tho. --- - To unsubscribe, e-mail:

[GitHub] spark issue #23043: [SPARK-26021][SQL] replace minus zero with zero in Unsaf...

2018-11-17 Thread adoron
Github user adoron commented on the issue: https://github.com/apache/spark/pull/23043 @cloud-fan changing writeDouble/writeFloat in UnsafeWriter indeed do the trick! I'll fix the PR. I was thinking about making the change in `Platform::putDouble` so all accesses get affected, in

[GitHub] spark issue #23038: [SPARK-25451][SPARK-26100][CORE]Aggregated metrics table...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23038 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98968/ Test FAILed. ---

[GitHub] spark issue #23038: [SPARK-25451][SPARK-26100][CORE]Aggregated metrics table...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23038 Merged build finished. Test FAILed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23038: [SPARK-25451][SPARK-26100][CORE]Aggregated metrics table...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23038 **[Test build #98968 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98968/testReport)** for PR 23038 at commit

[GitHub] spark issue #23070: [SPARK-26099][SQL] Verification of the corrupt column in...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23070 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23070: [SPARK-26099][SQL] Verification of the corrupt column in...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23070 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98965/ Test PASSed. ---

[GitHub] spark issue #23070: [SPARK-26099][SQL] Verification of the corrupt column in...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23070 **[Test build #98965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98965/testReport)** for PR 23070 at commit

[GitHub] spark issue #23069: [SPARK-26026][BUILD] Published Scaladoc jars missing fro...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23069 **[Test build #4430 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4430/testReport)** for PR 23069 at commit

[GitHub] spark issue #23016: [SPARK-26006][mllib] unpersist 'dataInternalRepr' in the...

2018-11-17 Thread shahidki31
Github user shahidki31 commented on the issue: https://github.com/apache/spark/pull/23016 Thank you @srowen --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #23057: [SPARK-26078][SQL] Dedup self-join attributes on ...

2018-11-17 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/23057#discussion_r234412635 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala --- @@ -119,7 +139,7 @@ object RewritePredicateSubquery

[GitHub] spark issue #23065: [SPARK-26090][CORE][SQL][ML] Resolve most miscellaneous ...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23065 **[Test build #4429 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4429/testReport)** for PR 23065 at commit

[GitHub] spark pull request #22986: [SPARK-25959][ML] GBTClassifier picks wrong impur...

2018-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22986 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22986: [SPARK-25959][ML] GBTClassifier picks wrong impur...

2018-11-17 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22986#discussion_r234412241 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala --- @@ -258,11 +258,7 @@ private[ml] object TreeClassifierParams {

[GitHub] spark pull request #23016: [SPARK-26006][mllib] unpersist 'dataInternalRepr'...

2018-11-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23016 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22986: [SPARK-25959][ML] GBTClassifier picks wrong impur...

2018-11-17 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22986#discussion_r234412163 --- Diff: mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala --- @@ -258,11 +258,7 @@ private[ml] object TreeClassifierParams { private[ml]

[GitHub] spark issue #22986: [SPARK-25959][ML] GBTClassifier picks wrong impurity sta...

2018-11-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/22986 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23016: [SPARK-26006][mllib] unpersist 'dataInternalRepr' in the...

2018-11-17 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/23016 Merged to master --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark issue #23066: [SPARK-26043][CORE] Make SparkHadoopUtil private to Spar...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23066 **[Test build #4431 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4431/testReport)** for PR 23066 at commit

[GitHub] spark issue #23070: [SPARK-26099][SQL] Verification of the corrupt column in...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23070 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98963/ Test PASSed. ---

[GitHub] spark issue #23070: [SPARK-26099][SQL] Verification of the corrupt column in...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23070 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23070: [SPARK-26099][SQL] Verification of the corrupt column in...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23070 **[Test build #98963 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98963/testReport)** for PR 23070 at commit

[GitHub] spark issue #23055: [SPARK-26080][PYTHON] Disable 'spark.executor.pyspark.me...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23055 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23055: [SPARK-26080][PYTHON] Disable 'spark.executor.pyspark.me...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23055 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98962/ Test PASSed. ---

[GitHub] spark issue #23055: [SPARK-26080][PYTHON] Disable 'spark.executor.pyspark.me...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23055 **[Test build #98962 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98962/testReport)** for PR 23055 at commit

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23057 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23057 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subq...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23057 **[Test build #98969 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98969/testReport)** for PR 23057 at commit

[GitHub] spark pull request #23057: [SPARK-26078][SQL] Dedup self-join attributes on ...

2018-11-17 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/23057#discussion_r234410124 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala --- @@ -119,7 +139,7 @@ object RewritePredicateSubquery

[GitHub] spark issue #23066: [SPARK-26043][CORE] Make SparkHadoopUtil private to Spar...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23066 **[Test build #4428 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4428/testReport)** for PR 23066 at commit

[GitHub] spark issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job pa...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23068 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job pa...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23068 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98960/ Test PASSed. ---

[GitHub] spark pull request #23057: [SPARK-26078][SQL] Dedup self-join attributes on ...

2018-11-17 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/23057#discussion_r234409196 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala --- @@ -119,7 +139,7 @@ object RewritePredicateSubquery

[GitHub] spark issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job pa...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23068 **[Test build #98960 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98960/testReport)** for PR 23068 at commit

[GitHub] spark pull request #23057: [SPARK-26078][SQL] Dedup self-join attributes on ...

2018-11-17 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/23057#discussion_r234409212 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala --- @@ -1280,4 +1281,34 @@ class SubquerySuite extends QueryTest with

[GitHub] spark pull request #23057: [SPARK-26078][SQL] Dedup self-join attributes on ...

2018-11-17 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/23057#discussion_r234409158 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala --- @@ -70,6 +67,27 @@ object RewritePredicateSubquery extends

[GitHub] spark issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job pa...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23068 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/98959/ Test PASSed. ---

[GitHub] spark issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job pa...

2018-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/23068 Merged build finished. Test PASSed. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #23068: [SPARK-26098][WebUI] Show associated SQL query in Job pa...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23068 **[Test build #98959 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98959/testReport)** for PR 23068 at commit

[GitHub] spark issue #23038: [SPARK-25451][SPARK-26100][CORE]Aggregated metrics table...

2018-11-17 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/23038 **[Test build #98968 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/98968/testReport)** for PR 23038 at commit

  1   2   >