Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23037
I thought there was already one for that Hive suite failing... SPARK-23622?
---
-
To unsubscribe, e-mail:
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/22904#discussion_r238484145
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -67,8 +66,16 @@
Github user AzureQ commented on the issue:
https://github.com/apache/spark/pull/23037
> ok, I give up on flaky tests.
>
> Merging to master.
Thanks!
---
-
To unsubscribe, e-mail:
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/23037
@vanzin Could you create a JIRA for this flaky test?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user rvesse commented on a diff in the pull request:
https://github.com/apache/spark/pull/22904#discussion_r238483901
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -67,8 +66,16 @@
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22899#discussion_r238483571
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -880,21 +880,38 @@ class Analyzer(
}
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23174
**[Test build #99634 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99634/testReport)**
for PR 23174 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22899
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22899
**[Test build #99633 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99633/testReport)**
for PR 22899 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22899
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99633/
Test FAILed.
---
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23174
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23174
I looked at the test failure, but the logs weren't super useful. This
passed locally, but let me retrigger here.
---
-
To
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
Ok that's fine. Will merge to master if there are no further comments in
the near future.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23163
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23163
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99624/
Test FAILed.
---
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23174
> It matters because we're discussing direction
I'm not, you guys are. I'm adding a missing feature with one particular
implementation. If you want to add other implementations that enable
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23169
**[Test build #99632 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99632/testReport)**
for PR 23169 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22899
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22899
**[Test build #99633 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99633/testReport)**
for PR 22899 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23163
**[Test build #99624 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99624/testReport)**
for PR 23163 at commit
Github user DaveDeCaprio commented on the issue:
https://github.com/apache/spark/pull/23169
Ok, I've updated this PR so that the default behavior does not change -
full plan strings are always printed.
This should be fully backwards compatible. Plan strings will only be
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23037
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/22899
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
It matters because we're discussing direction - that is, what opinion Spark
wants to take regarding how to set up security on K8s. It's not obvious from
our discussion on SPARK-26239 that we agree
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23037
ok, I give up on flaky tests.
Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23037
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99623/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23037
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23169
Build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands,
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23037
**[Test build #99623 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99623/testReport)**
for PR 23037 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23174
> with the caveat that we merge the subsequent optionality soon
Again, and sorry for pounding on that key, but why does that matter? It has
zero effect on the feature being added here. If
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23169
**[Test build #99631 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99631/testReport)**
for PR 23169 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23174
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23174
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23174
Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5687/
---
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
Ok that's fine, with the caveat that we merge the subsequent optionality
soon. I'll work on the file-based secret authentication and encryption this
week. I'm very concerned that we'll ship with
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23174
I don't understand what you want.
Without this change, auth does not work, period.
With this, users at least have one choice.
If you want to add another choice, you're free
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
It's just to have the assurance that we will have some way to bypass this
for auth at least for 3.x. I'd like to concretely determine this before merging
if possible. But I hope that the suggestion
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23108
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23108
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99622/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23108
**[Test build #99622 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99622/testReport)**
for PR 23108 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23174
As I suggested before, any alternative method can be added later. I don't
see why does it need to block this PR.
---
-
To
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22911
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5686/
---
Github user mccheah commented on the issue:
https://github.com/apache/spark/pull/23174
I think as long as we have one alternate mechanism proposed in SPARK-26239
this is ok to merge. I proposed one in [this
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23191
Merging to 2.4. Please close the PR manually.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23174
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5687/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22911
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5686/
---
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23209
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23210#discussion_r238471660
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -1647,6 +1647,15 @@ class DatasetSuite extends QueryTest with
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23209
Actually I forgot 2.4... there's also a conflict. Seems trivial, so I'll do
it manually and fix the conflict (and run some local tests).
---
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23209
Merging to master / 2.4.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23174
**[Test build #99629 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99629/testReport)**
for PR 23174 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23174
So, can we move forward with this and let any future new feature be handled
in SPARK-26239?
---
-
To unsubscribe, e-mail:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22911
**[Test build #99630 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99630/testReport)**
for PR 22911 at commit
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22911
on a non-testing not, any further feedback here?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22911
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23108#discussion_r238469695
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -186,6 +186,54 @@ abstract class OrcSuite
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/22911
there was a seemingly corrupt xml file in the jenkins worker, I removed it
and will retest.
---
-
To unsubscribe, e-mail:
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22911
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5684/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22911
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5684/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23211
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23211
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23211
**[Test build #99628 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99628/testReport)**
for PR 23211 at commit
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/23211
[SPARK-19712][SQL] Move PullupCorrelatedPredicates and
RewritePredicateSubquery after OptimizeSubqueries
Currently predicate subqueries (IN/EXISTS) are converted to Joins at the
end of
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22911
**[Test build #99627 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99627/testReport)**
for PR 22911 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99627/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22911
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22911
**[Test build #99627 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99627/testReport)**
for PR 22911 at commit
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22957#discussion_r238460901
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
---
@@ -145,9 +145,14 @@ case class
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22957#discussion_r238459238
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
---
@@ -145,9 +145,14 @@ case class
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23207
**[Test build #99617 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99617/testReport)**
for PR 23207 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23207
Merged build finished. Test FAILed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23207
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99617/
Test FAILed.
---
Github user BryanCutler commented on the issue:
https://github.com/apache/spark/pull/23200
merged to master, thanks @HyukjinKwon
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23200
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/23200#discussion_r238454041
--- Diff: python/pyspark/mllib/tests/test_linalg.py ---
@@ -22,33 +22,18 @@
from numpy import array, array_equal, zeros, arange, tile, ones, inf
Github user vanzin closed the pull request at:
https://github.com/apache/spark/pull/23172
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23172
Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail:
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22857#discussion_r238450750
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -31,14 +31,14 @@ import org.apache.spark.scheduler.{SparkListener,
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23209
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23209
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23209
Kubernetes integration test status success
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5683/
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23209
Kubernetes integration test starting
URL:
https://amplab.cs.berkeley.edu/jenkins/job/testing-k8s-prb-make-spark-distribution-unified/5683/
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23209
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/99626/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23209
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23209
**[Test build #99626 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99626/testReport)**
for PR 23209 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/23209
**[Test build #99626 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99626/testReport)**
for PR 23209 at commit
Github user skonto commented on the issue:
https://github.com/apache/spark/pull/23209
@srowen I resolved the conflicts feel free to merge.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22904#discussion_r238440694
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -67,8 +66,16 @@
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22904#discussion_r238439850
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
---
@@ -67,8 +66,16 @@
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23092
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/23092
Merged build finished. Test PASSed.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/23055
(Belated +1.) Doc update looks fine. The previous one was misleading for
reasons that Ryan explains above, it has nothing to do with whether it's
Windows or not.
---
201 - 300 of 626 matches
Mail list logo
