[GitHub] AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446079413 Merged build finished. Test FAILed.

[GitHub] AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446078556 Test PASSed. Refer to this link for build results

[GitHub] AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446078552 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446078556 Test PASSed. Refer to this link for build results (access rights

[GitHub] AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446078552 Merged build finished. Test PASSed.

[GitHub] SparkQA commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
SparkQA commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446078542 **[Test build #99948 has

[GitHub] HyukjinKwon commented on a change in pull request #23207: [SPARK-26193][SQL] Implement shuffle write metrics in SQL

2018-12-10 Thread GitBox
HyukjinKwon commented on a change in pull request #23207: [SPARK-26193][SQL] Implement shuffle write metrics in SQL URL: https://github.com/apache/spark/pull/23207#discussion_r240478048 ## File path:

[GitHub] AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446077744 Test PASSed. Refer to this link for build results

[GitHub] AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446077742 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446077742 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446077744 Test PASSed. Refer to this link for build results (access rights

[GitHub] SparkQA commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
SparkQA commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446077714 **[Test build #99947 has

[GitHub] imatiach-msft commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
imatiach-msft commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446077221 ping @sethah @WeichenXu123 @jkbradley @actuaryzhang @srowen could

[GitHub] davidvrba commented on issue #23267: [SPARK-25401] [SQL] Reorder join predicates to match child outputOrdering

2018-12-10 Thread GitBox
davidvrba commented on issue #23267: [SPARK-25401] [SQL] Reorder join predicates to match child outputOrdering URL: https://github.com/apache/spark/pull/23267#issuecomment-446076725 cc @gatorsmile @cloud-fan @dongjoon-hyun can i ask for review please

[GitHub] dilipbiswal commented on issue #23211: [SPARK-19712][SQL] Move PullupCorrelatedPredicates and RewritePredicateSubquery after OptimizeSubqueries

2018-12-10 Thread GitBox
dilipbiswal commented on issue #23211: [SPARK-19712][SQL] Move PullupCorrelatedPredicates and RewritePredicateSubquery after OptimizeSubqueries URL: https://github.com/apache/spark/pull/23211#issuecomment-446076575 @cloud-fan Thanks Wenchen. It makes sense. I will work in creating a

[GitHub] dilipbiswal commented on a change in pull request #23211: [SPARK-19712][SQL] Move PullupCorrelatedPredicates and RewritePredicateSubquery after OptimizeSubqueries

2018-12-10 Thread GitBox
dilipbiswal commented on a change in pull request #23211: [SPARK-19712][SQL] Move PullupCorrelatedPredicates and RewritePredicateSubquery after OptimizeSubqueries URL: https://github.com/apache/spark/pull/23211#discussion_r240476585 ## File path:

[GitHub] AmplabJenkins removed a comment on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning URL: https://github.com/apache/spark/pull/23249#issuecomment-446075434 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning URL: https://github.com/apache/spark/pull/23249#issuecomment-446075434 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins removed a comment on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning URL: https://github.com/apache/spark/pull/23249#issuecomment-446075432 Merged build finished. Test PASSed. This

[GitHub] AmplabJenkins commented on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning URL: https://github.com/apache/spark/pull/23249#issuecomment-446075432 Merged build finished. Test PASSed. This is an

[GitHub] AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446075130 Test PASSed. Refer to this link for build results

[GitHub] SparkQA commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
SparkQA commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446075219 **[Test build #99946 has

[GitHub] SparkQA commented on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning

2018-12-10 Thread GitBox
SparkQA commented on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning URL: https://github.com/apache/spark/pull/23249#issuecomment-446075151 **[Test build #99941 has

[GitHub] SparkQA removed a comment on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning

2018-12-10 Thread GitBox
SparkQA removed a comment on issue #23249: [SPARK-26297][SQL] improve the doc of Distribution/Partitioning URL: https://github.com/apache/spark/pull/23249#issuecomment-446037548 **[Test build #99941 has

[GitHub] AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446075128 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446075130 Test PASSed. Refer to this link for build results (access rights

[GitHub] AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #17085: [SPARK-24102][ML][MLLIB] ML Evaluators should use weight column - added weight column for regression evaluator URL: https://github.com/apache/spark/pull/17085#issuecomment-446075128 Merged build finished. Test PASSed.

[GitHub] dongjoon-hyun commented on a change in pull request #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly

2018-12-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly URL: https://github.com/apache/spark/pull/23277#discussion_r240475106 ## File path:

[GitHub] dongjoon-hyun commented on a change in pull request #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly

2018-12-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly URL: https://github.com/apache/spark/pull/23277#discussion_r240473934 ## File path:

[GitHub] dongjoon-hyun commented on a change in pull request #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly

2018-12-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly URL: https://github.com/apache/spark/pull/23277#discussion_r240473934 ## File path:

[GitHub] dongjoon-hyun commented on a change in pull request #23280: [MINOR][SQL] Some errors in the notes.

2018-12-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #23280: [MINOR][SQL] Some errors in the notes. URL: https://github.com/apache/spark/pull/23280#discussion_r240471322 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala ##

[GitHub] dongjoon-hyun commented on a change in pull request #23280: [MINOR][SQL] Some errors in the notes.

2018-12-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #23280: [MINOR][SQL] Some errors in the notes. URL: https://github.com/apache/spark/pull/23280#discussion_r240471322 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/package.scala ##

[GitHub] SparkQA commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
SparkQA commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446069680 **[Test build #99945 has

[GitHub] AmplabJenkins removed a comment on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446069413 Test PASSed. Refer to this link for build results

[GitHub] AmplabJenkins commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446069413 Test PASSed. Refer to this link for build results (access

[GitHub] AmplabJenkins removed a comment on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446069410 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446069410 Merged build finished. Test PASSed.

[GitHub] dongjoon-hyun commented on issue #23271: [SPARK-26318][SQL] Enhance function merge performance in Row

2018-12-10 Thread GitBox
dongjoon-hyun commented on issue #23271: [SPARK-26318][SQL] Enhance function merge performance in Row URL: https://github.com/apache/spark/pull/23271#issuecomment-446068942 +1 for depreciation. This is an automated message

[GitHub] dongjoon-hyun commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
dongjoon-hyun commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446068837 Retest this please.

[GitHub] icexelloss closed pull request #23279: [SPARK-26328][SQL] Use GenerateOrdering for group key comparision in WindowExec

2018-12-10 Thread GitBox
icexelloss closed pull request #23279: [SPARK-26328][SQL] Use GenerateOrdering for group key comparision in WindowExec URL: https://github.com/apache/spark/pull/23279 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] viirya commented on issue #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager

2018-12-10 Thread GitBox
viirya commented on issue #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager URL: https://github.com/apache/spark/pull/23272#issuecomment-446067993 If you worry that the page is to be freed by the

[GitHub] dongjoon-hyun commented on a change in pull request #23253: [SPARK-26303][SQL] Return partial results for bad JSON records

2018-12-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #23253: [SPARK-26303][SQL] Return partial results for bad JSON records URL: https://github.com/apache/spark/pull/23253#discussion_r240469549 ## File path:

[GitHub] dongjoon-hyun commented on a change in pull request #23253: [SPARK-26303][SQL] Return partial results for bad JSON records

2018-12-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #23253: [SPARK-26303][SQL] Return partial results for bad JSON records URL: https://github.com/apache/spark/pull/23253#discussion_r240469549 ## File path:

[GitHub] AmplabJenkins removed a comment on issue #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics URL: https://github.com/apache/spark/pull/22279#issuecomment-446067496 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] AmplabJenkins removed a comment on issue #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics URL: https://github.com/apache/spark/pull/22279#issuecomment-446067495 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics URL: https://github.com/apache/spark/pull/22279#issuecomment-446067496 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] viirya commented on issue #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager

2018-12-10 Thread GitBox
viirya commented on issue #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager URL: https://github.com/apache/spark/pull/23272#issuecomment-446067447 Oh, you meant that the page is freed by other using

[GitHub] AmplabJenkins commented on issue #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics URL: https://github.com/apache/spark/pull/22279#issuecomment-446067495 Merged build finished. Test PASSed.

[GitHub] SparkQA removed a comment on issue #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics

2018-12-10 Thread GitBox
SparkQA removed a comment on issue #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics URL: https://github.com/apache/spark/pull/22279#issuecomment-446021730 **[Test build #99939 has

[GitHub] SparkQA commented on issue #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics

2018-12-10 Thread GitBox
SparkQA commented on issue #22279: [SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics URL: https://github.com/apache/spark/pull/22279#issuecomment-446067213 **[Test build #99939 has

[GitHub] AmplabJenkins removed a comment on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446065365 Test FAILed. Refer to this link for build results

[GitHub] AmplabJenkins commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446065363 Merged build finished. Test FAILed.

[GitHub] AmplabJenkins commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446065365 Test FAILed. Refer to this link for build results (access

[GitHub] AmplabJenkins removed a comment on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446065363 Merged build finished. Test FAILed.

[GitHub] SparkQA commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
SparkQA commented on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446065265 **[Test build #99942 has

[GitHub] SparkQA removed a comment on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE

2018-12-10 Thread GitBox
SparkQA removed a comment on issue #23213: [SPARK-26262][SQL] Runs SQLQueryTestSuite on mixed config sets: WHOLESTAGE_CODEGEN_ENABLED and CODEGEN_FACTORY_MODE URL: https://github.com/apache/spark/pull/23213#issuecomment-446048530 **[Test build #99942 has

[GitHub] dongjoon-hyun commented on a change in pull request #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager

2018-12-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager URL: https://github.com/apache/spark/pull/23272#discussion_r240465896 ## File path:

[GitHub] AmplabJenkins removed a comment on issue #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly URL: https://github.com/apache/spark/pull/23277#issuecomment-446064805 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins removed a comment on issue #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly URL: https://github.com/apache/spark/pull/23277#issuecomment-446064801 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly URL: https://github.com/apache/spark/pull/23277#issuecomment-446064801 Merged build finished. Test PASSed. This

[GitHub] AmplabJenkins commented on issue #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly URL: https://github.com/apache/spark/pull/23277#issuecomment-446064805 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] SparkQA removed a comment on issue #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly

2018-12-10 Thread GitBox
SparkQA removed a comment on issue #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly URL: https://github.com/apache/spark/pull/23277#issuecomment-446028080 **[Test build #99940 has

[GitHub] SparkQA commented on issue #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly

2018-12-10 Thread GitBox
SparkQA commented on issue #23277: [SPARK-26327][SQL] Metrics in FileSourceScanExec not update correctly URL: https://github.com/apache/spark/pull/23277#issuecomment-446064532 **[Test build #99940 has

[GitHub] dongjoon-hyun commented on a change in pull request #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager

2018-12-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager URL: https://github.com/apache/spark/pull/23272#discussion_r240465896 ## File path:

[GitHub] cloud-fan commented on a change in pull request #23253: [SPARK-26303][SQL] Return partial results for bad JSON records

2018-12-10 Thread GitBox
cloud-fan commented on a change in pull request #23253: [SPARK-26303][SQL] Return partial results for bad JSON records URL: https://github.com/apache/spark/pull/23253#discussion_r240465615 ## File path:

[GitHub] ueshin edited a comment on issue #22305: [SPARK-24561][SQL][Python] User-defined window aggregation functions with Pandas UDF (bounded window)

2018-12-10 Thread GitBox
ueshin edited a comment on issue #22305: [SPARK-24561][SQL][Python] User-defined window aggregation functions with Pandas UDF (bounded window) URL: https://github.com/apache/spark/pull/22305#issuecomment-446062061 LGTM. @felixcheung Could you help us review please? Thanks!

[GitHub] cloud-fan commented on a change in pull request #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subqueries

2018-12-10 Thread GitBox
cloud-fan commented on a change in pull request #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23057#discussion_r240465174 ## File path:

[GitHub] cloud-fan commented on a change in pull request #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subqueries

2018-12-10 Thread GitBox
cloud-fan commented on a change in pull request #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23057#discussion_r240465020 ## File path:

[GitHub] AmplabJenkins removed a comment on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators URL: https://github.com/apache/spark/pull/23278#issuecomment-446062086 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins removed a comment on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators URL: https://github.com/apache/spark/pull/23278#issuecomment-446062090 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins commented on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators URL: https://github.com/apache/spark/pull/23278#issuecomment-446062090 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] ueshin commented on issue #22305: [SPARK-24561][SQL][Python] User-defined window aggregation functions with Pandas UDF (bounded window)

2018-12-10 Thread GitBox
ueshin commented on issue #22305: [SPARK-24561][SQL][Python] User-defined window aggregation functions with Pandas UDF (bounded window) URL: https://github.com/apache/spark/pull/22305#issuecomment-446062061 LGTM. This is an

[GitHub] AmplabJenkins commented on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators URL: https://github.com/apache/spark/pull/23278#issuecomment-446062086 Merged build finished. Test PASSed. This is an

[GitHub] dongjoon-hyun commented on a change in pull request #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager

2018-12-10 Thread GitBox
dongjoon-hyun commented on a change in pull request #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager URL: https://github.com/apache/spark/pull/23272#discussion_r240464776 ## File path:

[GitHub] ueshin commented on a change in pull request #22305: [SPARK-24561][SQL][Python] User-defined window aggregation functions with Pandas UDF (bounded window)

2018-12-10 Thread GitBox
ueshin commented on a change in pull request #22305: [SPARK-24561][SQL][Python] User-defined window aggregation functions with Pandas UDF (bounded window) URL: https://github.com/apache/spark/pull/22305#discussion_r240464740 ## File path:

[GitHub] SparkQA removed a comment on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators

2018-12-10 Thread GitBox
SparkQA removed a comment on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators URL: https://github.com/apache/spark/pull/23278#issuecomment-446010375 **[Test build #99938 has

[GitHub] SparkQA commented on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators

2018-12-10 Thread GitBox
SparkQA commented on issue #23278: [SPARK-24920][Core] Allow sharing Netty's memory pool allocators URL: https://github.com/apache/spark/pull/23278#issuecomment-446061759 **[Test build #99938 has

[GitHub] cloud-fan commented on a change in pull request #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subqueries

2018-12-10 Thread GitBox
cloud-fan commented on a change in pull request #23057: [SPARK-26078][SQL] Dedup self-join attributes on IN subqueries URL: https://github.com/apache/spark/pull/23057#discussion_r240464363 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala ##

[GitHub] cloud-fan commented on a change in pull request #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
cloud-fan commented on a change in pull request #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#discussion_r240463891 ## File path:

[GitHub] cloud-fan commented on a change in pull request #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager

2018-12-10 Thread GitBox
cloud-fan commented on a change in pull request #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager URL: https://github.com/apache/spark/pull/23272#discussion_r240463496 ## File path:

[GitHub] HyukjinKwon commented on issue #23280: [MINOR][SQL] Some errors in the notes.

2018-12-10 Thread GitBox
HyukjinKwon commented on issue #23280: [MINOR][SQL] Some errors in the notes. URL: https://github.com/apache/spark/pull/23280#issuecomment-446060053 It's okay but mind taking another look and fix some more typos together while we're here? I'm pretty sure there are more.

[GitHub] AmplabJenkins removed a comment on issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision trees

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision trees URL: https://github.com/apache/spark/pull/21632#issuecomment-446059603 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] AmplabJenkins removed a comment on issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision trees

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision trees URL: https://github.com/apache/spark/pull/21632#issuecomment-446059600 Merged build finished. Test PASSed. This

[GitHub] AmplabJenkins commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision trees

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision trees URL: https://github.com/apache/spark/pull/21632#issuecomment-446059603 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] viirya commented on issue #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager

2018-12-10 Thread GitBox
viirya commented on issue #23272: [SPARK-26265][Core] Fix deadlock in BytesToBytesMap.MapIterator when locking both BytesToBytesMap.MapIterator and TaskMemoryManager URL: https://github.com/apache/spark/pull/23272#issuecomment-446059510 I think the page is used exclusively by the map and

[GitHub] AmplabJenkins commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision trees

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision trees URL: https://github.com/apache/spark/pull/21632#issuecomment-446059600 Merged build finished. Test PASSed. This is an

[GitHub] SparkQA removed a comment on issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision trees

2018-12-10 Thread GitBox
SparkQA removed a comment on issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision trees URL: https://github.com/apache/spark/pull/21632#issuecomment-446008972 **[Test build #99937 has

[GitHub] SparkQA commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision trees

2018-12-10 Thread GitBox
SparkQA commented on issue #21632: [SPARK-19591][ML][MLlib] Add sample weights to decision trees URL: https://github.com/apache/spark/pull/21632#issuecomment-446059275 **[Test build #99937 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/99937/testReport)**

[GitHub] srowen commented on issue #23262: [SPARK-26312][SQL]Replace RDDConversions.rowToRowRdd with RowEncoder to improve its conversion performance

2018-12-10 Thread GitBox
srowen commented on issue #23262: [SPARK-26312][SQL]Replace RDDConversions.rowToRowRdd with RowEncoder to improve its conversion performance URL: https://github.com/apache/spark/pull/23262#issuecomment-446059106 It's been working for me, with the merge script and with GitHub and gitbox

[GitHub] SparkQA commented on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule

2018-12-10 Thread GitBox
SparkQA commented on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule URL: https://github.com/apache/spark/pull/23273#issuecomment-446057878 **[Test build #99944 has

[GitHub] seancxmao commented on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule

2018-12-10 Thread GitBox
seancxmao commented on issue #23273: [SPARK-25212][SQL][FOLLOWUP][DOC] Fix comments of ConvertToLocalRelation rule URL: https://github.com/apache/spark/pull/23273#issuecomment-446057468 retest this please. This is an

[GitHub] JkSelf commented on a change in pull request #23204: Revert "[SPARK-21052][SQL] Add hash map metrics to join"

2018-12-10 Thread GitBox
JkSelf commented on a change in pull request #23204: Revert "[SPARK-21052][SQL] Add hash map metrics to join" URL: https://github.com/apache/spark/pull/23204#discussion_r240460948 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala ##

[GitHub] AmplabJenkins removed a comment on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446056860 Test PASSed. Refer to this link for build results (access rights to CI

[GitHub] SparkQA commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
SparkQA commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446057021 **[Test build #99943 has

[GitHub] AmplabJenkins removed a comment on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446056856 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446056860 Test PASSed. Refer to this link for build results (access rights to CI server

[GitHub] JkSelf commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
JkSelf commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446056930 @dongjoon-hyun updated the patch. and re-test. Thanks.

[GitHub] AmplabJenkins commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23269: [SPARK-26316] Revert hash join metrics in spark 21052 that causes performance degradation URL: https://github.com/apache/spark/pull/23269#issuecomment-446056856 Merged build finished. Test PASSed.

[GitHub] AmplabJenkins removed a comment on issue #23281: [MINOR][DOC]update the condition description of BypassMergeSortShuffl…

2018-12-10 Thread GitBox
AmplabJenkins removed a comment on issue #23281: [MINOR][DOC]update the condition description of BypassMergeSortShuffl… URL: https://github.com/apache/spark/pull/23281#issuecomment-446054026 Can one of the admins verify this patch?

[GitHub] AmplabJenkins commented on issue #23281: [MINOR][DOC]update the condition description of BypassMergeSortShuffl…

2018-12-10 Thread GitBox
AmplabJenkins commented on issue #23281: [MINOR][DOC]update the condition description of BypassMergeSortShuffl… URL: https://github.com/apache/spark/pull/23281#issuecomment-446054242 Can one of the admins verify this patch?

<    1   2   3   4   5   6   7   8   9   >