[GitHub] [spark] SparkQA commented on issue #25535: [SPARK-28835][SQL] Introduce TPCDSSchema

2019-08-21 Thread GitBox
SparkQA commented on issue #25535: [SPARK-28835][SQL] Introduce TPCDSSchema URL: https://github.com/apache/spark/pull/25535#issuecomment-523499928 **[Test build #109490 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109490/testReport)** for PR 25535 at

[GitHub] [spark] gengliangwang commented on issue #25538: Fix minor typo in SQLConf

2019-08-21 Thread GitBox
gengliangwang commented on issue #25538: Fix minor typo in SQLConf URL: https://github.com/apache/spark/pull/25538#issuecomment-523497989 @triplesheep Thanks for the fix. Could you create a jira ticket in https://issues.apache.org/jira/browse/SPARK and change the title as

[GitHub] [spark] dongjoon-hyun commented on issue #25516: [SPARK-26895][CORE][branch-2.4] prepareSubmitEnvironment should be called within doAs for proxy users

2019-08-21 Thread GitBox
dongjoon-hyun commented on issue #25516: [SPARK-26895][CORE][branch-2.4] prepareSubmitEnvironment should be called within doAs for proxy users URL: https://github.com/apache/spark/pull/25516#issuecomment-523497365 Thank you for pinging me, @vanzin .

[GitHub] [spark] AmplabJenkins removed a comment on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hiv

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523495298 Can one of the admins verify this

[GitHub] [spark] AmplabJenkins removed a comment on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523495505 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523495520 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] dongjoon-hyun commented on issue #25510: [SPARK-28780][ML] Delete the incorrect setWeightCol method in LinearSVCModel

2019-08-21 Thread GitBox
dongjoon-hyun commented on issue #25510: [SPARK-28780][ML] Delete the incorrect setWeightCol method in LinearSVCModel URL: https://github.com/apache/spark/pull/25510#issuecomment-523496591 Yep. Please make two PR for them, @zhengruifeng . Thanks.

[GitHub] [spark] SparkQA commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference

2019-08-21 Thread GitBox
SparkQA commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523496585 **[Test build #109500 has

[GitHub] [spark] helenyugithub commented on issue #25505: [SPARK-28776][ML] SparkML Writer gets hadoop conf from session state

2019-08-21 Thread GitBox
helenyugithub commented on issue #25505: [SPARK-28776][ML] SparkML Writer gets hadoop conf from session state URL: https://github.com/apache/spark/pull/25505#issuecomment-523496569 Thanks @srowen ! Now that the tests have passed, is this PR good to merge?

[GitHub] [spark] AmplabJenkins commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523496438 Can one of the admins verify this patch?

[GitHub] [spark] dongjoon-hyun commented on issue #25491: [SPARK-28699][SQL] Disable using radix sort for ShuffleExchangeExec in repartition case

2019-08-21 Thread GitBox
dongjoon-hyun commented on issue #25491: [SPARK-28699][SQL] Disable using radix sort for ShuffleExchangeExec in repartition case URL: https://github.com/apache/spark/pull/25491#issuecomment-523496074 Since there is an inevitable performance degradation in this PR, I'll `cc` once more .

[GitHub] [spark] AmplabJenkins removed a comment on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hiv

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523495040 Can one of the admins verify this

[GitHub] [spark] AmplabJenkins commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523495505 Merged build finished. Test PASSed. This

[GitHub] [spark] AmplabJenkins commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541#issuecomment-523495520 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523495298 Can one of the admins verify this patch?

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r315998940 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/PartitionTransforms.scala

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316012778 ## File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ## @@ -3942,6 +3943,61 @@

[GitHub] [spark] AmplabJenkins commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCLIDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542#issuecomment-523495040 Can one of the admins verify this patch?

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316003794 ## File path:

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316224997 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataFrameWriterV2Suite.scala ##

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316226686 ## File path: sql/core/src/test/scala/org/apache/spark/sql/sources/v2/DataFrameWriterV2Suite.scala ##

[GitHub] [spark] keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API

2019-08-21 Thread GitBox
keypointt commented on a change in pull request #25354: [SPARK-28612][SQL] Add DataFrameWriterV2 API URL: https://github.com/apache/spark/pull/25354#discussion_r316006273 ## File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ## @@ -3178,6 +3178,34 @@

[GitHub] [spark] sandeep-katta opened a new pull request #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCliDriver should be avoided as it returns the UDFClassLoader which is created by Hive

2019-08-21 Thread GitBox
sandeep-katta opened a new pull request #25542: [SPARK-28840][SQL] conf.getClassLoader in SparkSQLCliDriver should be avoided as it returns the UDFClassLoader which is created by Hive URL: https://github.com/apache/spark/pull/25542 ### What changes were proposed in this pull request?

[GitHub] [spark] AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523492322 Merged build finished. Test PASSed.

[GitHub] [spark] SparkQA removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
SparkQA removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523485612 **[Test build #109498 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523492327 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] huaxingao opened a new pull request #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference

2019-08-21 Thread GitBox
huaxingao opened a new pull request #25541: [SPARK-28831][DOC][SQL]Document CLEAR CACHE statement in SQL Reference URL: https://github.com/apache/spark/pull/25541 ### What changes were proposed in this pull request? Document CLEAR CACHE statement in SQL Reference ### Why

[GitHub] [spark] SparkQA commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
SparkQA commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523492180 **[Test build #109498 has

[GitHub] [spark] AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523492327 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523492322 Merged build finished. Test PASSed.

[GitHub] [spark] dilipbiswal commented on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference.

2019-08-21 Thread GitBox
dilipbiswal commented on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference. URL: https://github.com/apache/spark/pull/25539#issuecomment-523491648 cc @gatorsmile This is an automated message from the

[GitHub] [spark] SparkQA removed a comment on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference.

2019-08-21 Thread GitBox
SparkQA removed a comment on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference. URL: https://github.com/apache/spark/pull/25539#issuecomment-523485617 **[Test build #109499 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference.

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference. URL: https://github.com/apache/spark/pull/25539#issuecomment-523491121 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference.

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference. URL: https://github.com/apache/spark/pull/25539#issuecomment-523491131 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference.

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference. URL: https://github.com/apache/spark/pull/25539#issuecomment-523491131 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference.

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference. URL: https://github.com/apache/spark/pull/25539#issuecomment-523491121 Merged build finished. Test PASSed. This is an

[GitHub] [spark] srowen closed pull request #25510: [SPARK-28780][ML] Delete the incorrect setWeightCol method in LinearSVCModel

2019-08-21 Thread GitBox
srowen closed pull request #25510: [SPARK-28780][ML] Delete the incorrect setWeightCol method in LinearSVCModel URL: https://github.com/apache/spark/pull/25510 This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference.

2019-08-21 Thread GitBox
SparkQA commented on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference. URL: https://github.com/apache/spark/pull/25539#issuecomment-523490962 **[Test build #109499 has

[GitHub] [spark] srowen commented on issue #25510: [SPARK-28780][ML] Delete the incorrect setWeightCol method in LinearSVCModel

2019-08-21 Thread GitBox
srowen commented on issue #25510: [SPARK-28780][ML] Delete the incorrect setWeightCol method in LinearSVCModel URL: https://github.com/apache/spark/pull/25510#issuecomment-523490966 Merged to master This is an automated

[GitHub] [spark] AmplabJenkins removed a comment on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-523487212 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-21 Thread GitBox
SparkQA removed a comment on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-523407339 **[Test build #109489 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-523487190 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-523487190 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-523487212 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316206367 ## File path: core/src/main/java/org/apache/spark/io/FileUtility.java ## @@ -0,0

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316203629 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316212381 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316209811 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316177998 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316214950 ## File path: core/src/main/java/org/apache/spark/io/FileUtility.java ## @@ -0,0

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316213529 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316181529 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316222435 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316182249 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316133646 ## File path: pom.xml ## @@ -190,6 +190,7 @@ 1.1 2.52.0 2.22 +6.0.1

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316164117 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316134867 ## File path: sql/core/pom.xml ## @@ -147,6 +147,12 @@ mockito-core test

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316178811 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316170728 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316136642 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316167162 ## File path:

[GitHub] [spark] gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation

2019-08-21 Thread GitBox
gaborgsomogyi commented on a change in pull request #24922: [SPARK-28120][SS] Rocksdb state storage implementation URL: https://github.com/apache/spark/pull/24922#discussion_r316180120 ## File path:

[GitHub] [spark] SparkQA commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs

2019-08-21 Thread GitBox
SparkQA commented on issue #25465: [SPARK-28747][SQL] merge the two data source v2 fallback configs URL: https://github.com/apache/spark/pull/25465#issuecomment-523486393 **[Test build #109489 has

[GitHub] [spark] triplesheep commented on issue #25538: Fix minor typo in SQLConf

2019-08-21 Thread GitBox
triplesheep commented on issue #25538: Fix minor typo in SQLConf URL: https://github.com/apache/spark/pull/25538#issuecomment-523485868 cc @CodingCat @gengliangwang This is an automated message from the Apache Git Service.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference.

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference. URL: https://github.com/apache/spark/pull/25539#issuecomment-523484687 Merged build finished. Test PASSed. This is

[GitHub] [spark] AmplabJenkins removed a comment on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference.

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference. URL: https://github.com/apache/spark/pull/25539#issuecomment-523484695 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523484634 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523484638 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA commented on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference.

2019-08-21 Thread GitBox
SparkQA commented on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference. URL: https://github.com/apache/spark/pull/25539#issuecomment-523485617 **[Test build #109499 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/109499/testReport)**

[GitHub] [spark] SparkQA commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
SparkQA commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523485612 **[Test build #109498 has

[GitHub] [spark] AmplabJenkins commented on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference.

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference. URL: https://github.com/apache/spark/pull/25539#issuecomment-523484695 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523484638 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference.

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25539: [SPARK-28808][SQL] Document SHOW FUNCTIONS in SQL Reference. URL: https://github.com/apache/spark/pull/25539#issuecomment-523484687 Merged build finished. Test PASSed. This is an

[GitHub] [spark] AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540#issuecomment-523484634 Merged build finished. Test PASSed.

[GitHub] [spark] wangyum commented on a change in pull request #24715: [SPARK-25474][SQL] Data source tables support fallback to HDFS for size estimation

2019-08-21 Thread GitBox
wangyum commented on a change in pull request #24715: [SPARK-25474][SQL] Data source tables support fallback to HDFS for size estimation URL: https://github.com/apache/spark/pull/24715#discussion_r316218631 ## File path:

[GitHub] [spark] huaxingao opened a new pull request #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference

2019-08-21 Thread GitBox
huaxingao opened a new pull request #25540: [SPARK-28830][DOC][SQL]Document UNCACHE TABLE statement in SQL Reference URL: https://github.com/apache/spark/pull/25540 ### What changes were proposed in this pull request? Document UNCACHE TABLE statement in SQL Reference ### Why are

[GitHub] [spark] dilipbiswal opened a new pull request #25539: [SPARK-28808] Document SHOW FUNCTIONS in SQL Reference.

2019-08-21 Thread GitBox
dilipbiswal opened a new pull request #25539: [SPARK-28808] Document SHOW FUNCTIONS in SQL Reference. URL: https://github.com/apache/spark/pull/25539 ### What changes were proposed in this pull request? Document SHOW FUNCTIONS statement in SQL Reference Guide. ### Why are the

[GitHub] [spark] cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#discussion_r316216553 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#discussion_r316214020 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#discussion_r316213585 ## File path:

[GitHub] [spark] AmplabJenkins removed a comment on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#issuecomment-523477904 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-08-21 Thread GitBox
SparkQA removed a comment on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#issuecomment-523464692 **[Test build #109497 has

[GitHub] [spark] AmplabJenkins removed a comment on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-08-21 Thread GitBox
AmplabJenkins removed a comment on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#issuecomment-523477890 Merged build finished. Test PASSed.

[GitHub] [spark] AmplabJenkins commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#issuecomment-523477904 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-08-21 Thread GitBox
AmplabJenkins commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#issuecomment-523477890 Merged build finished. Test PASSed. This

[GitHub] [spark] SparkQA commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-08-21 Thread GitBox
SparkQA commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#issuecomment-523477725 **[Test build #109497 has

[GitHub] [spark] cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#discussion_r316209454 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#discussion_r316207803 ## File path:

[GitHub] [spark] cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #25461: [SPARK-28741][SQL]Throw exceptions when casting to integers causes overflow URL: https://github.com/apache/spark/pull/25461#discussion_r316207803 ## File path:

[GitHub] [spark] cloud-fan commented on issue #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum

2019-08-21 Thread GitBox
cloud-fan commented on issue #25347: [SPARK-28610][SQL] Allow having a decimal buffer for long sum URL: https://github.com/apache/spark/pull/25347#issuecomment-523465552 We need to be careful when adding configs to control query semantic. We have a lot of such configs now, but most of

[GitHub] [spark] SparkQA commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-08-21 Thread GitBox
SparkQA commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#issuecomment-523464692 **[Test build #109497 has

[GitHub] [spark] dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming

2019-08-21 Thread GitBox
dongjinleekr commented on issue #22282: [SPARK-23539][SS] Add support for Kafka headers in Structured Streaming URL: https://github.com/apache/spark/pull/22282#issuecomment-523463288 @zsxwing Here it is. Fixed. This is an

[GitHub] [spark] cloud-fan commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-08-21 Thread GitBox
cloud-fan commented on issue #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#issuecomment-523461778 LGTM except for several comments, thanks for working on it! Let's remove WIP from the PR title

[GitHub] [spark] cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#discussion_r316189448 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/Exchange.scala ##

[GitHub] [spark] cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#discussion_r316188213 ## File path: sql/core/src/test/resources/sql-tests/inputs/explain.sql ## @@ -0,0 +1,97 @@ +--

[GitHub] [spark] steveloughran commented on issue #24970: [SPARK-23977][SQL] Support High Performance S3A committers [test-hadoop3.2]

2019-08-21 Thread GitBox
steveloughran commented on issue #24970: [SPARK-23977][SQL] Support High Performance S3A committers [test-hadoop3.2] URL: https://github.com/apache/spark/pull/24970#issuecomment-523460501 thanks! This is an automated message

[GitHub] [spark] cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#discussion_r316188547 ## File path: sql/core/src/test/resources/sql-tests/inputs/explain.sql ## @@ -0,0 +1,97 @@ +--

[GitHub] [spark] cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#discussion_r316187845 ## File path: sql/core/src/test/resources/sql-tests/inputs/explain.sql ## @@ -0,0 +1,97 @@ +--

[GitHub] [spark] cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#discussion_r316184167 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala ##

[GitHub] [spark] cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command

2019-08-21 Thread GitBox
cloud-fan commented on a change in pull request #24759: [SPARK-27395][SQL][WIP] Improve EXPLAIN command URL: https://github.com/apache/spark/pull/24759#discussion_r316183461 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala

<    5   6   7   8   9   10   11   12   13   14   >