[GitHub] [spark] AmplabJenkins commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655280081 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline

2020-07-07 Thread GitBox
SparkQA commented on pull request #28803: URL: https://github.com/apache/spark/pull/28803#issuecomment-655279892 **[Test build #125295 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125295/testReport)** for PR 28803 at commit

[GitHub] [spark] SparkQA commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
SparkQA commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655279925 **[Test build #125290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125290/testReport)** for PR 28676 at commit

[GitHub] [spark] SparkQA commented on pull request #28993: [SPARK-32168][SQL] Fix hidden partitioning correctness bug in SQL overwrite

2020-07-07 Thread GitBox
SparkQA commented on pull request #28993: URL: https://github.com/apache/spark/pull/28993#issuecomment-655279884 **[Test build #125256 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125256/testReport)** for PR 28993 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #29019: [2.4][SPARK-32167][SQL] Fix GetArrayStructFields to respect inner field's nullability together

2020-07-07 Thread GitBox
dongjoon-hyun commented on pull request #29019: URL: https://github.com/apache/spark/pull/29019#issuecomment-655279313 Gentle ping, @cloud-fan ~ This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] viirya commented on a change in pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort/filter plans

2020-07-07 Thread GitBox
viirya commented on a change in pull request #28898: URL: https://github.com/apache/spark/pull/28898#discussion_r451278529 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasingSuite.scala ## @@ -493,6 +491,156 @@ class

[GitHub] [spark] ulysses-you commented on pull request #29033: [SPARK-30703][SQL][FOLLOWUP] Update SqlBase.g4 invalid comment

2020-07-07 Thread GitBox
ulysses-you commented on pull request #29033: URL: https://github.com/apache/spark/pull/29033#issuecomment-655278730 thanks for merging! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] gengliangwang commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline

2020-07-07 Thread GitBox
gengliangwang commented on pull request #28803: URL: https://github.com/apache/spark/pull/28803#issuecomment-655278687 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] HyukjinKwon commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-07 Thread GitBox
HyukjinKwon commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-655278572 If we're going to treat `void` as Hive legacy, let's don't support it at all and make the direction to deprecate and remove `NullType` away. If we'll still care and

[GitHub] [spark] HyukjinKwon commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-07 Thread GitBox
HyukjinKwon commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-655277714 Re: https://github.com/apache/spark/pull/28833#discussion_r448165084 Sorry I read the comments just now. So the decision here is we allow to parse `void` as

[GitHub] [spark] viirya commented on a change in pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
viirya commented on a change in pull request #29026: URL: https://github.com/apache/spark/pull/29026#discussion_r451275938 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala ## @@ -58,39 +58,50 @@ case class Sum(child:

[GitHub] [spark] viirya commented on a change in pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
viirya commented on a change in pull request #29026: URL: https://github.com/apache/spark/pull/29026#discussion_r451274175 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala ## @@ -58,39 +58,50 @@ case class Sum(child:

[GitHub] [spark] viirya commented on a change in pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
viirya commented on a change in pull request #29026: URL: https://github.com/apache/spark/pull/29026#discussion_r451274175 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala ## @@ -58,39 +58,50 @@ case class Sum(child:

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655275929 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] viirya commented on a change in pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
viirya commented on a change in pull request #29026: URL: https://github.com/apache/spark/pull/29026#discussion_r451275938 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala ## @@ -58,39 +58,50 @@ case class Sum(child:

[GitHub] [spark] SparkQA removed a comment on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655268405 **[Test build #125294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125294/testReport)** for PR 27983 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655275925 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
SparkQA commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655275899 **[Test build #125294 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125294/testReport)** for PR 27983 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655275925 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] viirya commented on a change in pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
viirya commented on a change in pull request #29026: URL: https://github.com/apache/spark/pull/29026#discussion_r451274175 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala ## @@ -58,39 +58,50 @@ case class Sum(child:

[GitHub] [spark] viirya commented on a change in pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
viirya commented on a change in pull request #29026: URL: https://github.com/apache/spark/pull/29026#discussion_r451274175 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala ## @@ -58,39 +58,50 @@ case class Sum(child:

[GitHub] [spark] viirya commented on a change in pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
viirya commented on a change in pull request #29026: URL: https://github.com/apache/spark/pull/29026#discussion_r451274175 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala ## @@ -58,39 +58,50 @@ case class Sum(child:

[GitHub] [spark] LantaoJin edited a comment on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
LantaoJin edited a comment on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-655272794 In the case I given in the description. If I add a LIMIT in the SQL ``` SELECT * FROM skewData1 AS data1 INNER JOIN ( SELECT skewData2.key2,

[GitHub] [spark] LantaoJin commented on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
LantaoJin commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-655272794 In the case I given in the description. If I add a LIMIT in the SQL ``` SELECT * FROM skewData1 AS data1 INNER JOIN ( SELECT skewData2.key2,

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
dongjoon-hyun commented on a change in pull request #29022: URL: https://github.com/apache/spark/pull/29022#discussion_r451271798 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -2030,6 +2030,12 @@ class AstBuilder(conf:

[GitHub] [spark] viirya commented on pull request #29027: [SPARK-32163][SQL][3.0] Nested pruning should work even with cosmetic variations

2020-07-07 Thread GitBox
viirya commented on pull request #29027: URL: https://github.com/apache/spark/pull/29027#issuecomment-655271805 Thanks @dongjoon-hyun @maropu This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655271084 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655271080 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655271080 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655125800 **[Test build #125254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125254/testReport)** for PR 29026 at commit

[GitHub] [spark] SparkQA commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
SparkQA commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655269950 **[Test build #125254 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125254/testReport)** for PR 29026 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655268711 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655268711 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
SparkQA commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655268405 **[Test build #125294 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125294/testReport)** for PR 27983 at commit

[GitHub] [spark] AngersZhuuuu commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AngersZh commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655267146 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655266127 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29031: [SPARK-32216][SQL] Remove redundant ProjectExec

2020-07-07 Thread GitBox
HyukjinKwon commented on a change in pull request #29031: URL: https://github.com/apache/spark/pull/29031#discussion_r451267070 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -1224,6 +1224,15 @@ object SQLConf { .booleanConf

[GitHub] [spark] AmplabJenkins commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655266121 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655266121 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] SparkQA removed a comment on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655258914 **[Test build #125291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125291/testReport)** for PR 27983 at commit

[GitHub] [spark] SparkQA commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
SparkQA commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655266066 **[Test build #125291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125291/testReport)** for PR 27983 at commit

[GitHub] [spark] LantaoJin closed pull request #28935: [SPARK-20680][SQL] Adding HiveVoidType in Spark to be compatible with Hive

2020-07-07 Thread GitBox
LantaoJin closed pull request #28935: URL: https://github.com/apache/spark/pull/28935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] LantaoJin commented on pull request #28935: [SPARK-20680][SQL] Adding HiveVoidType in Spark to be compatible with Hive

2020-07-07 Thread GitBox
LantaoJin commented on pull request #28935: URL: https://github.com/apache/spark/pull/28935#issuecomment-655264946 Close this since #28833 merged. Thank you! This is an automated message from the Apache Git Service. To

[GitHub] [spark] LantaoJin commented on pull request #28833: [SPARK-20680][SQL] Spark-sql do not support for creating table with void column datatype

2020-07-07 Thread GitBox
LantaoJin commented on pull request #28833: URL: https://github.com/apache/spark/pull/28833#issuecomment-655263937 Thank you for all kindly review. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-655262982 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655262820 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655262815 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AmplabJenkins commented on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-655262982 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655256853 **[Test build #125288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125288/testReport)** for PR 25290 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655262815 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #29021: [WIP][SPARK-32201][SQL] More general skew join pattern matching

2020-07-07 Thread GitBox
SparkQA commented on pull request #29021: URL: https://github.com/apache/spark/pull/29021#issuecomment-655262748 **[Test build #125293 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125293/testReport)** for PR 29021 at commit

[GitHub] [spark] SparkQA commented on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
SparkQA commented on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655262790 **[Test build #125288 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125288/testReport)** for PR 25290 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655261181 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655261181 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] sarutak commented on pull request #28803: [SPARK-31971][WEBUI] Add pagination support for all jobs timeline

2020-07-07 Thread GitBox
sarutak commented on pull request #28803: URL: https://github.com/apache/spark/pull/28803#issuecomment-655260973 cc: @dongjoon-hyun This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] SparkQA commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
SparkQA commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655260805 **[Test build #125292 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125292/testReport)** for PR 29026 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #28983: [SPARK-32159][SQL] Fix integration between Aggregator[Array[_], _, _] and UnresolvedMapObjects

2020-07-07 Thread GitBox
cloud-fan commented on a change in pull request #28983: URL: https://github.com/apache/spark/pull/28983#discussion_r451261067 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala ## @@ -678,6 +678,13 @@ object MapObjects {

[GitHub] [spark] cloud-fan commented on a change in pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
cloud-fan commented on a change in pull request #29022: URL: https://github.com/apache/spark/pull/29022#discussion_r451260686 ## File path: docs/sql-ref-literals.md ## @@ -239,6 +244,10 @@ E [ + | - ] digit [ ... ] Case insensitive, indicates `DOUBLE`, which is an

[GitHub] [spark] sarutak commented on a change in pull request #29029: [SPARK-32214][SQL] The type conversion function generated in makeFromJava for "other" type uses a wrong variable.

2020-07-07 Thread GitBox
sarutak commented on a change in pull request #29029: URL: https://github.com/apache/spark/pull/29029#discussion_r451260580 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala ## @@ -198,7 +198,7 @@ object EvaluatePython {

[GitHub] [spark] sarutak commented on a change in pull request #29029: [SPARK-32214][SQL] The type conversion function generated in makeFromJava for "other" type uses a wrong variable.

2020-07-07 Thread GitBox
sarutak commented on a change in pull request #29029: URL: https://github.com/apache/spark/pull/29029#discussion_r451260580 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala ## @@ -198,7 +198,7 @@ object EvaluatePython {

[GitHub] [spark] HyukjinKwon commented on a change in pull request #29029: [SPARK-32214][SQL] The type conversion function generated in makeFromJava for "other" type uses a wrong variable.

2020-07-07 Thread GitBox
HyukjinKwon commented on a change in pull request #29029: URL: https://github.com/apache/spark/pull/29029#discussion_r451260651 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/EvaluatePython.scala ## @@ -198,7 +198,7 @@ object EvaluatePython {

[GitHub] [spark] cloud-fan commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
cloud-fan commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655259660 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655259202 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655259164 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] imback82 commented on a change in pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
imback82 commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r451259973 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/joins/BroadcastJoinSuite.scala ## @@ -415,6 +417,192 @@ abstract class

[GitHub] [spark] AmplabJenkins commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655259164 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] imback82 commented on a change in pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
imback82 commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r451259932 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -60,6 +62,66 @@ case class

[GitHub] [spark] AmplabJenkins commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655259202 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-655259150 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] cloud-fan commented on pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
cloud-fan commented on pull request #29026: URL: https://github.com/apache/spark/pull/29026#issuecomment-655259298 > So now we have UnsafeRow.setDecimal silently returns a null for an overflowed decimal value in setDecimal, but getDecimal throws error. There is inconsistency here. Why is

[GitHub] [spark] SparkQA commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
SparkQA commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655258914 **[Test build #125291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125291/testReport)** for PR 27983 at commit

[GitHub] [spark] SparkQA commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-07 Thread GitBox
SparkQA commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-655258899 **[Test build #125289 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125289/testReport)** for PR 28977 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655258792 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] imback82 commented on a change in pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
imback82 commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r451259886 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -60,6 +62,66 @@ case class

[GitHub] [spark] AmplabJenkins commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-655259150 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] xuanyuanking commented on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-07 Thread GitBox
xuanyuanking commented on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-655258638 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
SparkQA commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655258874 **[Test build #125290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125290/testReport)** for PR 28676 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655258792 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] imback82 commented on a change in pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
imback82 commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r451259594 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ## @@ -60,6 +62,66 @@ case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655257914 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] AngersZhuuuu commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AngersZh commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655258140 @dongjoon-hyun do you know why test failed a lot of times of https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125070/testReport/ In my local it's ok to

[GitHub] [spark] SparkQA removed a comment on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655125865 **[Test build #125255 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125255/testReport)** for PR 28676 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655257909 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA commented on pull request #28676: [SPARK-31869][SQL] BroadcastHashJoinExec can utilize the build side for its output partitioning

2020-07-07 Thread GitBox
SparkQA commented on pull request #28676: URL: https://github.com/apache/spark/pull/28676#issuecomment-655257968 **[Test build #125255 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125255/testReport)** for PR 28676 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655257909 Merged build finished. Test FAILed. This is an automated message from the Apache Git Service. To

[GitHub] [spark] AngersZhuuuu commented on pull request #27983: [SPARK-32105][SQL]Refactor current ScriptTransformationExec code

2020-07-07 Thread GitBox
AngersZh commented on pull request #27983: URL: https://github.com/apache/spark/pull/27983#issuecomment-655257972 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AmplabJenkins removed a comment on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-655257219 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655257280 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-655257219 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
AmplabJenkins commented on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655257280 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] SparkQA removed a comment on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655193968 **[Test build #125267 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125267/testReport)** for PR 28859 at commit

[GitHub] [spark] SparkQA commented on pull request #28859: [SPARK-32024][WEBUI] Update ApplicationStoreInfo.size during HistoryServerDiskManager initializing

2020-07-07 Thread GitBox
SparkQA commented on pull request #28859: URL: https://github.com/apache/spark/pull/28859#issuecomment-655257055 **[Test build #125267 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125267/testReport)** for PR 28859 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
cloud-fan commented on a change in pull request #29026: URL: https://github.com/apache/spark/pull/29026#discussion_r451258078 ## File path: sql/core/src/test/scala/org/apache/spark/sql/UnsafeRowSuite.scala ## @@ -178,4 +178,14 @@ class UnsafeRowSuite extends SparkFunSuite {

[GitHub] [spark] SparkQA commented on pull request #29022: [SPARK-32207][SQL] Support 'F'-suffixed Float Literals

2020-07-07 Thread GitBox
SparkQA commented on pull request #29022: URL: https://github.com/apache/spark/pull/29022#issuecomment-655256843 **[Test build #125287 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125287/testReport)** for PR 29022 at commit

[GitHub] [spark] SparkQA commented on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
SparkQA commented on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655256853 **[Test build #125288 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125288/testReport)** for PR 25290 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #29026: [SPARK-28067][SPARK-32018] Fix decimal overflow issues

2020-07-07 Thread GitBox
cloud-fan commented on a change in pull request #29026: URL: https://github.com/apache/spark/pull/29026#discussion_r451257595 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Sum.scala ## @@ -58,39 +58,50 @@ case class Sum(child:

[GitHub] [spark] HyukjinKwon closed pull request #29023: local_connect_and_auth takes 2 arguments, 3 given

2020-07-07 Thread GitBox
HyukjinKwon closed pull request #29023: URL: https://github.com/apache/spark/pull/29023 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #28363: [SPARK-27188][SS] FileStreamSink: provide a new option to have retention on output files

2020-07-07 Thread GitBox
AmplabJenkins removed a comment on pull request #28363: URL: https://github.com/apache/spark/pull/28363#issuecomment-655255939 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] [spark] SparkQA removed a comment on pull request #28977: [WIP] Add all hive.execution suite in the parallel test group

2020-07-07 Thread GitBox
SparkQA removed a comment on pull request #28977: URL: https://github.com/apache/spark/pull/28977#issuecomment-655246106 **[Test build #125283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/125283/testReport)** for PR 28977 at commit

[GitHub] [spark] AngersZhuuuu commented on pull request #25290: [SPARK-28551][SQL]Add a Checker Rule when CTAS SQL with LOCATION

2020-07-07 Thread GitBox
AngersZh commented on pull request #25290: URL: https://github.com/apache/spark/pull/25290#issuecomment-655256004 retest this please This is an automated message from the Apache Git Service. To respond to the message,

<    1   2   3   4   5   6   7   8   9   10   >