[GitHub] [spark] HyukjinKwon commented on pull request #31527: [MINOR] Add a note about pip installation test in RC for release vote template

2021-02-08 Thread GitBox
HyukjinKwon commented on pull request #31527: URL: https://github.com/apache/spark/pull/31527#issuecomment-775147783 Thanks @srowen. Merged to master. This is an automated message from the Apache Git Service. To

[GitHub] [spark] cloud-fan commented on a change in pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31489: URL: https://github.com/apache/spark/pull/31489#discussion_r572042517 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetPartitionReaderFactory.scala ## @@ -52,14 +52,16 @@

[GitHub] [spark] cloud-fan commented on a change in pull request #31489: [SPARK-34377][SQL] Add new parquet datasource options to control datetime rebasing in read

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31489: URL: https://github.com/apache/spark/pull/31489#discussion_r572042040 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetPartitionReaderFactory.scala ## @@ -52,14 +52,16 @@

[GitHub] [spark] MaxGekk commented on a change in pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-08 Thread GitBox
MaxGekk commented on a change in pull request #31524: URL: https://github.com/apache/spark/pull/31524#discussion_r572041366 ## File path: docs/sql-ref-syntax-ddl-alter-table.md ## @@ -27,6 +27,9 @@ license: | `ALTER TABLE RENAME TO` statement changes the table name of an

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-775143616 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135015/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31524: URL: https://github.com/apache/spark/pull/31524#issuecomment-775143615 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135026/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31073: [SPARK-33995][SQL] Expose make_interval as a Scala function

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31073: URL: https://github.com/apache/spark/pull/31073#issuecomment-774492810 Can one of the admins verify this patch? This is an automated message from the Apache Git

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31520: [SPARK-34355][CORE][SQL][FOLLOWUP] Log commit time in all File Writer

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775143617 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA commented on pull request #31073: [SPARK-33995][SQL] Expose make_interval as a Scala function

2021-02-08 Thread GitBox
SparkQA commented on pull request #31073: URL: https://github.com/apache/spark/pull/31073#issuecomment-775144967 **[Test build #135029 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135029/testReport)** for PR 31073 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #31527: [MINOR] Add a note about pip installation test in RC for release vote template

2021-02-08 Thread GitBox
HyukjinKwon commented on pull request #31527: URL: https://github.com/apache/spark/pull/31527#issuecomment-775144875 cc @srowen and @holdenk FYI This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] HyukjinKwon opened a new pull request #31527: [MINOR] Add a note about pip installation test in RC for release vote template

2021-02-08 Thread GitBox
HyukjinKwon opened a new pull request #31527: URL: https://github.com/apache/spark/pull/31527 ### What changes were proposed in this pull request? This PR proposes to add a note about pip installation test in RC for release vote template. ### Why are the changes needed?

[GitHub] [spark] AmplabJenkins commented on pull request #31520: [SPARK-34355][CORE][SQL][FOLLOWUP] Log commit time in all File Writer

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775143621 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [spark] AmplabJenkins commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-775143616 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135015/

[GitHub] [spark] cloud-fan commented on a change in pull request #31466: [SPARK-34352][SQL] Improve SQLQueryTestSuite so as could run on windows system

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31466: URL: https://github.com/apache/spark/pull/31466#discussion_r572038364 ## File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ## @@ -154,10 +154,14 @@ class SQLQueryTestSuite extends QueryTest

[GitHub] [spark] AmplabJenkins commented on pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31524: URL: https://github.com/apache/spark/pull/31524#issuecomment-775143615 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135026/

[GitHub] [spark] MaxGekk commented on a change in pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-08 Thread GitBox
MaxGekk commented on a change in pull request #31524: URL: https://github.com/apache/spark/pull/31524#discussion_r572038254 ## File path: docs/sql-ref-syntax-ddl-alter-table.md ## @@ -187,6 +194,8 @@ ALTER TABLE table_identifier [ partition_spec ] SET SERDE serde_class_name

[GitHub] [spark] MaxGekk commented on a change in pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-08 Thread GitBox
MaxGekk commented on a change in pull request #31524: URL: https://github.com/apache/spark/pull/31524#discussion_r572037646 ## File path: docs/sql-ref-syntax-ddl-alter-table.md ## @@ -27,6 +27,9 @@ license: | `ALTER TABLE RENAME TO` statement changes the table name of an

[GitHub] [spark] cloud-fan commented on a change in pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31524: URL: https://github.com/apache/spark/pull/31524#discussion_r572036282 ## File path: docs/sql-ref-syntax-ddl-alter-table.md ## @@ -187,6 +194,8 @@ ALTER TABLE table_identifier [ partition_spec ] SET SERDE serde_class_name

[GitHub] [spark] cloud-fan commented on a change in pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31524: URL: https://github.com/apache/spark/pull/31524#discussion_r572035577 ## File path: docs/sql-ref-syntax-ddl-alter-table.md ## @@ -27,6 +27,9 @@ license: | `ALTER TABLE RENAME TO` statement changes the table name of an

[GitHub] [spark] SparkQA commented on pull request #31378: [SPARK-34240][SQL] Unify output of `SHOW TBLPROPERTIES` clause's output attribute's schema and ExprID

2021-02-08 Thread GitBox
SparkQA commented on pull request #31378: URL: https://github.com/apache/spark/pull/31378#issuecomment-775139197 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39610/

[GitHub] [spark] cloud-fan commented on a change in pull request #30869: [SPARK-33865][SQL] When HiveDDL, we need check avro schema too

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #30869: URL: https://github.com/apache/spark/pull/30869#discussion_r572030438 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormat.scala ## @@ -162,6 +162,8 @@ trait FileFormat { * By

[GitHub] [spark] SparkQA commented on pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-08 Thread GitBox
SparkQA commented on pull request #31524: URL: https://github.com/apache/spark/pull/31524#issuecomment-775136139 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39609/

[GitHub] [spark] cloud-fan commented on a change in pull request #30869: [SPARK-33865][SQL] When HiveDDL, we need check avro schema too

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #30869: URL: https://github.com/apache/spark/pull/30869#discussion_r57203 ## File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala ## @@ -2876,6 +2877,33 @@ class HiveDDLSuite } }

[GitHub] [spark] SparkQA removed a comment on pull request #31520: [SPARK-34355][CORE][SQL][FOLLOWUP] Log commit time in all File Writer

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775044219 **[Test build #135021 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135021/testReport)** for PR 31520 at commit

[GitHub] [spark] SparkQA commented on pull request #31520: [SPARK-34355][CORE][SQL][FOLLOWUP] Log commit time in all File Writer

2021-02-08 Thread GitBox
SparkQA commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775130059 **[Test build #135021 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135021/testReport)** for PR 31520 at commit

[GitHub] [spark] MaxGekk commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
MaxGekk commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r572023668 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala ## @@ -119,6 +101,32 @@ trait ShowTablesSuiteBase

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
HyukjinKwon commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r572020314 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala ## @@ -119,6 +101,32 @@ trait

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
HyukjinKwon commented on a change in pull request #31245: URL: https://github.com/apache/spark/pull/31245#discussion_r572020055 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala ## @@ -119,6 +101,32 @@ trait

[GitHub] [spark] SparkQA removed a comment on pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31524: URL: https://github.com/apache/spark/pull/31524#issuecomment-775116106 **[Test build #135026 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135026/testReport)** for PR 31524 at commit

[GitHub] [spark] SparkQA commented on pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-08 Thread GitBox
SparkQA commented on pull request #31524: URL: https://github.com/apache/spark/pull/31524#issuecomment-775123809 **[Test build #135026 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135026/testReport)** for PR 31524 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-774968499 **[Test build #135015 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135015/testReport)** for PR 31245 at commit

[GitHub] [spark] SparkQA commented on pull request #31245: [SPARK-34157][SQL] Unify output of SHOW TABLES and pass output attributes properly

2021-02-08 Thread GitBox
SparkQA commented on pull request #31245: URL: https://github.com/apache/spark/pull/31245#issuecomment-775122966 **[Test build #135015 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135015/testReport)** for PR 31245 at commit

[GitHub] [spark] HyukjinKwon closed pull request #31525: [MINOR][INFRA][DOC][3.1] Change the facetFilters of Docsearch to 3.1.1

2021-02-08 Thread GitBox
HyukjinKwon closed pull request #31525: URL: https://github.com/apache/spark/pull/31525 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] HyukjinKwon commented on pull request #31525: [MINOR][INFRA][DOC][3.1] Change the facetFilters of Docsearch to 3.1.1

2021-02-08 Thread GitBox
HyukjinKwon commented on pull request #31525: URL: https://github.com/apache/spark/pull/31525#issuecomment-775121171 Merged to branch-3.1. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on pull request #31073: [SPARK-33995][SQL] Expose make_interval as a Scala function

2021-02-08 Thread GitBox
cloud-fan commented on pull request #31073: URL: https://github.com/apache/spark/pull/31073#issuecomment-775120028 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] cloud-fan commented on a change in pull request #31378: [SPARK-34240][SQL] Unify output of `SHOW TBLPROPERTIES` clause's output attribute's schema and ExprID

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31378: URL: https://github.com/apache/spark/pull/31378#discussion_r572015001 ## File path: sql/core/src/test/resources/sql-tests/inputs/show-tblproperties.sql ## @@ -6,6 +6,13 @@ SHOW TBLPROPERTIES tbl; SHOW TBLPROPERTIES

[GitHub] [spark] HyukjinKwon opened a new pull request #31526: [SPARK-34157][BUILD][FOLLOW-UP] Fix Scala 2.13 compliation error via using deep

2021-02-08 Thread GitBox
HyukjinKwon opened a new pull request #31526: URL: https://github.com/apache/spark/pull/31526 ### What changes were proposed in this pull request? This PR is a followup of https://github.com/apache/spark/pull/31245: ``` [error]

[GitHub] [spark] cloud-fan commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r572014419 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlanVisitor.scala ## @@ -47,6 +49,16 @@ trait

[GitHub] [spark] Ngone51 commented on pull request #31517: [WIP][SPARK-34309][CORE][SQL] Use Caffeine instead of Guava Cache

2021-02-08 Thread GitBox
Ngone51 commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-775117864 Just out of curiosity, how much performance improvement we can get by using Caffeine? Do we have a rough number?

[GitHub] [spark] Ngone51 commented on a change in pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job

2021-02-08 Thread GitBox
Ngone51 commented on a change in pull request #31521: URL: https://github.com/apache/spark/pull/31521#discussion_r572010794 ## File path: core/src/main/scala/org/apache/spark/SparkContext.scala ## @@ -719,10 +719,23 @@ class SparkContext(config: SparkConf) extends Logging {

[GitHub] [spark] SparkQA commented on pull request #31378: [SPARK-34240][SQL] Unify output of `SHOW TBLPROPERTIES` clause's output attribute's schema and ExprID

2021-02-08 Thread GitBox
SparkQA commented on pull request #31378: URL: https://github.com/apache/spark/pull/31378#issuecomment-775116045 **[Test build #135027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135027/testReport)** for PR 31378 at commit

[GitHub] [spark] SparkQA commented on pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-08 Thread GitBox
SparkQA commented on pull request #31524: URL: https://github.com/apache/spark/pull/31524#issuecomment-775116106 **[Test build #135026 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135026/testReport)** for PR 31524 at commit

[GitHub] [spark] Ngone51 commented on a change in pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job

2021-02-08 Thread GitBox
Ngone51 commented on a change in pull request #31521: URL: https://github.com/apache/spark/pull/31521#discussion_r572010794 ## File path: core/src/main/scala/org/apache/spark/SparkContext.scala ## @@ -719,10 +719,23 @@ class SparkContext(config: SparkConf) extends Logging {

[GitHub] [spark] Ngone51 commented on a change in pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job

2021-02-08 Thread GitBox
Ngone51 commented on a change in pull request #31521: URL: https://github.com/apache/spark/pull/31521#discussion_r572010794 ## File path: core/src/main/scala/org/apache/spark/SparkContext.scala ## @@ -719,10 +719,23 @@ class SparkContext(config: SparkConf) extends Logging {

[GitHub] [spark] SparkQA removed a comment on pull request #31520: [SPARK-34355][CORE][SQL][FOLLOWUP] Log commit time in all File Writer

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-774960569 **[Test build #135013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135013/testReport)** for PR 31520 at commit

[GitHub] [spark] gengliangwang opened a new pull request #31525: [3.1][INFRA][DOC] Change the facetFilters of Docsearch to 3.1.1

2021-02-08 Thread GitBox
gengliangwang opened a new pull request #31525: URL: https://github.com/apache/spark/pull/31525 ### What changes were proposed in this pull request? As https://github.com/algolia/docsearch-configs/pull/3391 is merged, This PR changes the facetFilters of Docsearch as 3.1.1.

[GitHub] [spark] SparkQA commented on pull request #31520: [SPARK-34355][CORE][SQL][FOLLOWUP] Log commit time in all File Writer

2021-02-08 Thread GitBox
SparkQA commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775113086 **[Test build #135013 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135013/testReport)** for PR 31520 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31508: [SPARK-34393][SQL] Unify output of SHOW VIEWS and pass output attributes properly

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31508: URL: https://github.com/apache/spark/pull/31508#issuecomment-775112580 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135012/

[GitHub] [spark] AmplabJenkins commented on pull request #31508: [SPARK-34393][SQL] Unify output of SHOW VIEWS and pass output attributes properly

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31508: URL: https://github.com/apache/spark/pull/31508#issuecomment-775112580 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135012/

[GitHub] [spark] SparkQA removed a comment on pull request #31508: [SPARK-34393][SQL] Unify output of SHOW VIEWS and pass output attributes properly

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31508: URL: https://github.com/apache/spark/pull/31508#issuecomment-774939013 **[Test build #135012 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135012/testReport)** for PR 31508 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r572007541 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java ## @@ -64,7 +64,20 @@ static TableChange

[GitHub] [spark] SparkQA commented on pull request #31508: [SPARK-34393][SQL] Unify output of SHOW VIEWS and pass output attributes properly

2021-02-08 Thread GitBox
SparkQA commented on pull request #31508: URL: https://github.com/apache/spark/pull/31508#issuecomment-775111325 **[Test build #135012 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135012/testReport)** for PR 31508 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #31494: [SPARK-34380][SQL] Support ifExists for ALTER TABLE ... UNSET TBLPROPERTIES for v2 command

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31494: URL: https://github.com/apache/spark/pull/31494#discussion_r572005786 ## File path: sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableChange.java ## @@ -64,7 +64,20 @@ static TableChange

[GitHub] [spark] cloud-fan commented on a change in pull request #31258: [SPARK-34168] [SQL] Support DPP in AQE when the join is Broadcast hash join at the beginning

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31258: URL: https://github.com/apache/spark/pull/31258#discussion_r572004814 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/QueryStageExec.scala ## @@ -165,7 +175,8 @@ case class

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31520: [SPARK-34355][CORE][SQL][FOLLOWUP] Log commit time in all File Writer

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775104877 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135018/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31470: [SPARK-34354][SQL] Fix failure when apply CostBasedJoinReorder on self-join

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31470: URL: https://github.com/apache/spark/pull/31470#issuecomment-775104873 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39605/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31519: [SPARK-34394][SQL] Unify output of SHOW FUNCTIONS and pass output attributes properly

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31519: URL: https://github.com/apache/spark/pull/31519#issuecomment-775104874 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135010/

[GitHub] [spark] AmplabJenkins commented on pull request #31470: [SPARK-34354][SQL] Fix failure when apply CostBasedJoinReorder on self-join

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31470: URL: https://github.com/apache/spark/pull/31470#issuecomment-775104873 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39605/

[GitHub] [spark] AmplabJenkins commented on pull request #31520: [SPARK-34355][CORE][SQL][FOLLOWUP] Log commit time in all File Writer

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775104877 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135018/

[GitHub] [spark] AmplabJenkins commented on pull request #31519: [SPARK-34394][SQL] Unify output of SHOW FUNCTIONS and pass output attributes properly

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31519: URL: https://github.com/apache/spark/pull/31519#issuecomment-775104874 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135010/

[GitHub] [spark] SparkQA commented on pull request #31466: [SPARK-34352][SQL] Improve SQLQueryTestSuite so as could run on windows system

2021-02-08 Thread GitBox
SparkQA commented on pull request #31466: URL: https://github.com/apache/spark/pull/31466#issuecomment-775104234 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39608/

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
AngersZh commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r57261 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlanVisitor.scala ## @@ -47,6 +49,16 @@ trait

[GitHub] [spark] MaxGekk commented on pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-08 Thread GitBox
MaxGekk commented on pull request #31524: URL: https://github.com/apache/spark/pull/31524#issuecomment-775103312 @sunchao @cloud-fan @HyukjinKwon @dongjoon-hyun Could you review this PR, please. This is an automated message

[GitHub] [spark] MaxGekk opened a new pull request #31524: [SPARK-34401][SQL][DOCS] Update docs about altering cached tables/views

2021-02-08 Thread GitBox
MaxGekk opened a new pull request #31524: URL: https://github.com/apache/spark/pull/31524 ### What changes were proposed in this pull request? Update public docs of SQL commands about altering cached tables/views. For instance:

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31378: [SPARK-34240][SQL] Unify output of `SHOW TBLPROPERTIES` clause's output attribute's schema and ExprID

2021-02-08 Thread GitBox
AngersZh commented on a change in pull request #31378: URL: https://github.com/apache/spark/pull/31378#discussion_r571998057 ## File path: sql/core/src/test/resources/sql-tests/inputs/show-tblproperties.sql ## @@ -6,6 +6,13 @@ SHOW TBLPROPERTIES tbl; SHOW TBLPROPERTIES

[GitHub] [spark] HyukjinKwon commented on pull request #31523: [SPARK-33354][DOC] Remove an unnecessary quote in doc

2021-02-08 Thread GitBox
HyukjinKwon commented on pull request #31523: URL: https://github.com/apache/spark/pull/31523#issuecomment-775100166 Merged to master and branch-3.1. This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] HyukjinKwon closed pull request #31523: [SPARK-33354][DOC] Remove an unnecessary quote in doc

2021-02-08 Thread GitBox
HyukjinKwon closed pull request #31523: URL: https://github.com/apache/spark/pull/31523 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] cloud-fan commented on a change in pull request #31500: [SPARK-34388][SQL] Propagate the registered UDF name to ScalaUDF, ScalaUDAF and ScalaAggregator

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31500: URL: https://github.com/apache/spark/pull/31500#discussion_r571994908 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala ## @@ -1088,4 +1088,6 @@ trait

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
AngersZh commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r571993370 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlanVisitor.scala ## @@ -47,6 +49,16 @@ trait

[GitHub] [spark] gengliangwang opened a new pull request #31523: [SPARK-33354][DOC] Remove an unnecessary quote in doc

2021-02-08 Thread GitBox
gengliangwang opened a new pull request #31523: URL: https://github.com/apache/spark/pull/31523 ### What changes were proposed in this pull request? Remove an unnecessary quote in the documentation. Super trivial. ### Why are the changes needed? Fix a

[GitHub] [spark] SparkQA removed a comment on pull request #31520: [SPARK-34355][CORE][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775007297 **[Test build #135018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135018/testReport)** for PR 31520 at commit

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
AngersZh commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r571992802 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlanVisitor.scala ## @@ -47,6 +49,16 @@ trait

[GitHub] [spark] SparkQA commented on pull request #31520: [SPARK-34355][CORE][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
SparkQA commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775096290 **[Test build #135018 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135018/testReport)** for PR 31520 at commit

[GitHub] [spark] cloud-fan commented on pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly

2021-02-08 Thread GitBox
cloud-fan commented on pull request #31442: URL: https://github.com/apache/spark/pull/31442#issuecomment-775094701 LGTM except one comment about migration guide. This is an automated message from the Apache Git Service. To

[GitHub] [spark] cloud-fan commented on a change in pull request #31442: [SPARK-34333][SQL] Fix PostgresDialect to handle money types properly

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31442: URL: https://github.com/apache/spark/pull/31442#discussion_r571990570 ## File path: docs/sql-migration-guide.md ## @@ -24,6 +24,8 @@ license: | ## Upgrading from Spark SQL 3.1 to 3.2 + - In Spark 3.2, money type in

[GitHub] [spark] cloud-fan commented on pull request #31475: [SPARK-34360][SQL] Support table truncation by v2 Table Catalogs

2021-02-08 Thread GitBox
cloud-fan commented on pull request #31475: URL: https://github.com/apache/spark/pull/31475#issuecomment-775093012 LGTM, also cc @rdblue @imback82 @dongjoon-hyun This is an automated message from the Apache Git Service. To

[GitHub] [spark] cloud-fan commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r571988475 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlanVisitor.scala ## @@ -47,6 +49,16 @@ trait

[GitHub] [spark] cloud-fan commented on a change in pull request #31485: [SPARK-34137][SQL] Update suquery's stats when build LogicalPlan's stats

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31485: URL: https://github.com/apache/spark/pull/31485#discussion_r571987869 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlanVisitor.scala ## @@ -47,6 +49,16 @@ trait

[GitHub] [spark] SparkQA removed a comment on pull request #31519: [SPARK-34394][SQL] Unify output of SHOW FUNCTIONS and pass output attributes properly

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31519: URL: https://github.com/apache/spark/pull/31519#issuecomment-774937492 **[Test build #135010 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135010/testReport)** for PR 31519 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571986698 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala ## @@ -157,7 +156,7 @@ case class ExplainCommand(

[GitHub] [spark] SparkQA commented on pull request #31519: [SPARK-34394][SQL] Unify output of SHOW FUNCTIONS and pass output attributes properly

2021-02-08 Thread GitBox
SparkQA commented on pull request #31519: URL: https://github.com/apache/spark/pull/31519#issuecomment-775090378 **[Test build #135010 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135010/testReport)** for PR 31519 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r570991936 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala ## @@ -504,8 +504,7 @@ abstract class TreeNode[BaseType

[GitHub] [spark] cloud-fan commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571985735 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala ## @@ -504,8 +504,7 @@ abstract class TreeNode[BaseType

[GitHub] [spark] cloud-fan commented on a change in pull request #31378: [SPARK-34240][SQL] Unify output of `SHOW TBLPROPERTIES` clause's output attribute's schema and ExprID

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31378: URL: https://github.com/apache/spark/pull/31378#discussion_r571983429 ## File path: sql/core/src/test/resources/sql-tests/inputs/show-tblproperties.sql ## @@ -6,6 +6,13 @@ SHOW TBLPROPERTIES tbl; SHOW TBLPROPERTIES

[GitHub] [spark] cloud-fan commented on a change in pull request #31378: [SPARK-34240][SQL] Unify output of `SHOW TBLPROPERTIES` clause's output attribute's schema and ExprID

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31378: URL: https://github.com/apache/spark/pull/31378#discussion_r571983429 ## File path: sql/core/src/test/resources/sql-tests/inputs/show-tblproperties.sql ## @@ -6,6 +6,13 @@ SHOW TBLPROPERTIES tbl; SHOW TBLPROPERTIES

[GitHub] [spark] cloud-fan commented on a change in pull request #31378: [SPARK-34240][SQL] Unify output of `SHOW TBLPROPERTIES` clause's output attribute's schema and ExprID

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31378: URL: https://github.com/apache/spark/pull/31378#discussion_r571982639 ## File path: sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala ## @@ -481,8 +481,14 @@ class

[GitHub] [spark] cloud-fan closed pull request #31518: [SPARK-34239][SQL][FOLLOW_UP] SHOW COLUMNS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
cloud-fan closed pull request #31518: URL: https://github.com/apache/spark/pull/31518 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on pull request #31518: [SPARK-34239][SQL][FOLLOW_UP] SHOW COLUMNS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
cloud-fan commented on pull request #31518: URL: https://github.com/apache/spark/pull/31518#issuecomment-775084376 thanks, merging to master! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] SparkQA commented on pull request #31466: [SPARK-34352][SQL] Improve SQLQueryTestSuite so as could run on windows system

2021-02-08 Thread GitBox
SparkQA commented on pull request #31466: URL: https://github.com/apache/spark/pull/31466#issuecomment-775080723 **[Test build #135025 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135025/testReport)** for PR 31466 at commit

[GitHub] [spark] SparkQA commented on pull request #31470: [SPARK-34354][SQL] Fix failure when apply CostBasedJoinReorder on self-join

2021-02-08 Thread GitBox
SparkQA commented on pull request #31470: URL: https://github.com/apache/spark/pull/31470#issuecomment-775080149 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39605/

[GitHub] [spark] AngersZhuuuu commented on pull request #31516: [SPARK-34238][SQL][FOLLOW_UP] SHOW PARTITIONS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
AngersZh commented on pull request #31516: URL: https://github.com/apache/spark/pull/31516#issuecomment-775076483 FYI @cloud-fan This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] AngersZhuuuu commented on pull request #31518: [SPARK-34239][SQL][FOLLOW_UP] SHOW COLUMNS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
AngersZh commented on pull request #31518: URL: https://github.com/apache/spark/pull/31518#issuecomment-775076252 FYI @cloud-fan This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [spark] SparkQA removed a comment on pull request #31518: [SPARK-34239][SQL][FOLLOW_UP] SHOW COLUMNS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31518: URL: https://github.com/apache/spark/pull/31518#issuecomment-774906642 **[Test build #135005 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135005/testReport)** for PR 31518 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31520: [SPARK-34355][CORE][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-775071544 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31466: [SPARK-34352][SQL] Improve SQLQueryTestSuite so as could run on windows system

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31466: URL: https://github.com/apache/spark/pull/31466#issuecomment-775071593 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] SparkQA removed a comment on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #31521: URL: https://github.com/apache/spark/pull/31521#issuecomment-774999620 **[Test build #135017 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135017/testReport)** for PR 31521 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31521: [SPARK-34400][CORE] Check spark.job.interruptOnCancel value is illegal before submit job

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31521: URL: https://github.com/apache/spark/pull/31521#issuecomment-775071598 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31518: [SPARK-34239][SQL][FOLLOW_UP] SHOW COLUMNS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31518: URL: https://github.com/apache/spark/pull/31518#issuecomment-775072743 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135005/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31516: [SPARK-34238][SQL][FOLLOW_UP] SHOW PARTITIONS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31516: URL: https://github.com/apache/spark/pull/31516#issuecomment-775071591 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135007/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31522: [SPARK-34399][SQL] Add commit duration to SQL tab's graph node.

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31522: URL: https://github.com/apache/spark/pull/31522#issuecomment-775071600 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39599/

<    1   2   3   4   5   6   7   8   >