[GitHub] [spark] hammertank commented on pull request #30894: [SPARK-33152][SQL] Improve the performance of constraint propagation for Project and Aggregate

2021-02-08 Thread GitBox
hammertank commented on pull request #30894: URL: https://github.com/apache/spark/pull/30894#issuecomment-774965798 Checked the 2 git action errors: 1. CliSuite.SPARK-29022: Commands using SerDe provided in --hive.aux.jars.path It is a timeout error and cannot be reproduced in my

[GitHub] [spark] SparkQA removed a comment on pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
SparkQA removed a comment on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-774961216 **[Test build #135014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135014/testReport)** for PR 30363 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-774964850 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135014/

[GitHub] [spark] AmplabJenkins commented on pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-774964850 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135014/

[GitHub] [spark] SparkQA commented on pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
SparkQA commented on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-774964805 **[Test build #135014 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135014/testReport)** for PR 30363 at commit

[GitHub] [spark] SparkQA commented on pull request #31508: [SPARK-34393][SQL] Unify output of SHOW VIEWS and pass output attributes properly

2021-02-08 Thread GitBox
SparkQA commented on pull request #31508: URL: https://github.com/apache/spark/pull/31508#issuecomment-774962959 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39595/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31516: [SPARK-34238][SQL][FOLLOW_UP] SHOW PARTITIONS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31516: URL: https://github.com/apache/spark/pull/31516#issuecomment-774960233 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39590/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31471: [SPARK-34355][SQL] Add log and time cost for commit job

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31471: URL: https://github.com/apache/spark/pull/31471#issuecomment-774960234 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134999/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31518: [SPARK-34239][SQL][FOLLOW_UP] SHOW COLUMNS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31518: URL: https://github.com/apache/spark/pull/31518#issuecomment-774960236 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39588/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31517: [WIP][SPARK-34309][CORE][SQL] Use Caffeine instead of Guava Cache

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-774960953 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39594/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31491: [SPARK-34379][SQL] Map JDBC RowID to StringType rather than LongType

2021-02-08 Thread GitBox
AmplabJenkins removed a comment on pull request #31491: URL: https://github.com/apache/spark/pull/31491#issuecomment-774960235 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134997/

[GitHub] [spark] HeartSaVioR commented on a change in pull request #31495: [SPARK-34383][SS] Optimize WAL commit phase via reducing cost of filesystem operations

2021-02-08 Thread GitBox
HeartSaVioR commented on a change in pull request #31495: URL: https://github.com/apache/spark/pull/31495#discussion_r571850667 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala ## @@ -239,18 +239,35 @@ class

[GitHub] [spark] HeartSaVioR commented on a change in pull request #31495: [SPARK-34383][SS] Optimize WAL commit phase via reducing cost of filesystem operations

2021-02-08 Thread GitBox
HeartSaVioR commented on a change in pull request #31495: URL: https://github.com/apache/spark/pull/31495#discussion_r571850667 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala ## @@ -239,18 +239,35 @@ class

[GitHub] [spark] gaborgsomogyi commented on pull request #31384: [SPARK-31816][SQL][DOCS] Added high level description about JDBC connection providers for users/developers

2021-02-08 Thread GitBox
gaborgsomogyi commented on pull request #31384: URL: https://github.com/apache/spark/pull/31384#issuecomment-774961380 Since it's a quite fresh feature not many peoples touched it, only @maropu who I know. Maybe he's just busy w/ other stuff and need some time.

[GitHub] [spark] SparkQA commented on pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
SparkQA commented on pull request #30363: URL: https://github.com/apache/spark/pull/30363#issuecomment-774961216 **[Test build #135014 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135014/testReport)** for PR 30363 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #31517: [WIP][SPARK-34309][CORE][SQL] Use Caffeine instead of Guava Cache

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-774960953 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39594/

[GitHub] [spark] SparkQA commented on pull request #31520: [SPARK-34355][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
SparkQA commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-774960569 **[Test build #135013 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135013/testReport)** for PR 31520 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #31491: [SPARK-34379][SQL] Map JDBC RowID to StringType rather than LongType

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31491: URL: https://github.com/apache/spark/pull/31491#issuecomment-774960235 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134997/

[GitHub] [spark] AmplabJenkins commented on pull request #31516: [SPARK-34238][SQL][FOLLOW_UP] SHOW PARTITIONS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31516: URL: https://github.com/apache/spark/pull/31516#issuecomment-774960233 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39590/

[GitHub] [spark] AmplabJenkins commented on pull request #31471: [SPARK-34355][SQL] Add log and time cost for commit job

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31471: URL: https://github.com/apache/spark/pull/31471#issuecomment-774960234 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134999/

[GitHub] [spark] AmplabJenkins commented on pull request #31518: [SPARK-34239][SQL][FOLLOW_UP] SHOW COLUMNS Keep consistence with other `SHOW` command

2021-02-08 Thread GitBox
AmplabJenkins commented on pull request #31518: URL: https://github.com/apache/spark/pull/31518#issuecomment-774960236 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39588/

[GitHub] [spark] viirya commented on a change in pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
viirya commented on a change in pull request #30363: URL: https://github.com/apache/spark/pull/30363#discussion_r571846695 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -3799,6 +3801,27 @@ class SQLConf extends Serializable with

[GitHub] [spark] viirya commented on a change in pull request #30363: [SPARK-33438][SQL] Eagerly init objects with defined SQL Confs for command `set -v`

2021-02-08 Thread GitBox
viirya commented on a change in pull request #30363: URL: https://github.com/apache/spark/pull/30363#discussion_r571846243 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ## @@ -3799,6 +3801,27 @@ class SQLConf extends Serializable with

[GitHub] [spark] AngersZhuuuu commented on pull request #31520: [SPARK-34355][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
AngersZh commented on pull request #31520: URL: https://github.com/apache/spark/pull/31520#issuecomment-774955534 gentle ping @HeartSaVioR This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on a change in pull request #31348: [SPARK-34245][CORE] Ensure Master removes executors that failed to send finished state

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31348: URL: https://github.com/apache/spark/pull/31348#discussion_r571844600 ## File path: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala ## @@ -750,6 +750,36 @@ private[deploy] class Worker( } } +

[GitHub] [spark] AngersZhuuuu opened a new pull request #31520: [SPARK-34355][SQL][FOLLOWUP] Log FileBatchWrite's commit time too

2021-02-08 Thread GitBox
AngersZh opened a new pull request #31520: URL: https://github.com/apache/spark/pull/31520 ### What changes were proposed in this pull request? When doing https://issues.apache.org/jira/browse/SPARK-34399 based on https://github.com/apache/spark/pull/31471 Found FileBatchWrite

[GitHub] [spark] viirya commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-08 Thread GitBox
viirya commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571843989 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala ## @@ -169,7 +169,7 @@ abstract class

[GitHub] [spark] cloud-fan commented on a change in pull request #31337: [SPARK-34234][SQL] Remove TreeNodeException that didn't work

2021-02-08 Thread GitBox
cloud-fan commented on a change in pull request #31337: URL: https://github.com/apache/spark/pull/31337#discussion_r571842005 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala ## @@ -169,7 +169,7 @@ abstract class

[GitHub] [spark] HeartSaVioR commented on a change in pull request #31495: [SPARK-34383][SS] Optimize WAL commit phase via reducing cost of filesystem operations

2021-02-08 Thread GitBox
HeartSaVioR commented on a change in pull request #31495: URL: https://github.com/apache/spark/pull/31495#discussion_r571841510 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/OffsetSeqLog.scala ## @@ -46,6 +47,23 @@ import

<    3   4   5   6   7   8