[GitHub] [spark] SparkQA commented on pull request #32365: [SPARK-35228][SQL] Add expression ToHiveString for keep consistent between hive/spark format in df.show

2021-06-30 Thread GitBox
SparkQA commented on pull request #32365: URL: https://github.com/apache/spark/pull/32365#issuecomment-871944516 **[Test build #140485 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140485/testReport)** for PR 32365 at commit

[GitHub] [spark] ulysses-you commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
ulysses-you commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871941978 thank you all ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] SparkQA commented on pull request #32365: [SPARK-35228][SQL] Add expression ToHiveString for keep consistent between hive/spark format in df.show

2021-06-30 Thread GitBox
SparkQA commented on pull request #32365: URL: https://github.com/apache/spark/pull/32365#issuecomment-871938662 **[Test build #140485 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140485/testReport)** for PR 32365 at commit

[GitHub] [spark] cloud-fan closed pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
cloud-fan closed pull request #33165: URL: https://github.com/apache/spark/pull/33165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] cloud-fan commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
cloud-fan commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871938652 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871937797 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44993/

[GitHub] [spark] SparkQA commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
SparkQA commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871937786 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44993/ --

[GitHub] [spark] AmplabJenkins commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871937797 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44993/ --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33157: [WIP][SPARK-35954] Upgrade Apache Curator Dependency to 4.2.0

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33157: URL: https://github.com/apache/spark/pull/33157#issuecomment-871519792 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [spark] SparkQA commented on pull request #32832: [SPARK-35686][SQL] Not allow using auto-generated alias when creating view

2021-06-30 Thread GitBox
SparkQA commented on pull request #32832: URL: https://github.com/apache/spark/pull/32832#issuecomment-871937014 **[Test build #140484 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140484/testReport)** for PR 32832 at commit

[GitHub] [spark] SparkQA commented on pull request #33157: [WIP][SPARK-35954] Upgrade Apache Curator Dependency to 4.2.0

2021-06-30 Thread GitBox
SparkQA commented on pull request #33157: URL: https://github.com/apache/spark/pull/33157#issuecomment-871936855 **[Test build #140483 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140483/testReport)** for PR 33157 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
HyukjinKwon commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871936789 Looks good 2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] SparkQA commented on pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
SparkQA commented on pull request #33164: URL: https://github.com/apache/spark/pull/33164#issuecomment-871936763 **[Test build #140482 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140482/testReport)** for PR 33164 at commit

[GitHub] [spark] LuciferYang commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
LuciferYang commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871936677 > Yes, Apache Spark 3.2 will be the first release having Scala 2.13 additionally. > After branch cut, I'll try to switch the default to Scala 2.13 in master branch. >

[GitHub] [spark] dongjoon-hyun edited a comment on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
dongjoon-hyun edited a comment on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871936074 Yes, Apache Spark 3.2 will be the first release having Scala 2.13 additionally. After branch cut, I'll try to switch the default to Scala 2.13 in `master`

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33038: [SPARK-35861][SS] Introduce "prefix match scan" feature on state store

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33038: URL: https://github.com/apache/spark/pull/33038#issuecomment-871936166 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140470/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871936165 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44989/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871936161 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44991/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871936164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44992/

[GitHub] [spark] cloud-fan commented on a change in pull request #32832: [SPARK-35686][SQL] Not allow using auto-generated alias when creating view

2021-06-30 Thread GitBox
cloud-fan commented on a change in pull request #32832: URL: https://github.com/apache/spark/pull/32832#discussion_r661988654 ## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala ## @@ -910,4 +910,45 @@ abstract class SQLViewSuite extends

[GitHub] [spark] karenfeng commented on a change in pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
karenfeng commented on a change in pull request #33164: URL: https://github.com/apache/spark/pull/33164#discussion_r661988603 ## File path: core/src/test/java/org/apache/spark/SparkThrowableSuite.java ## @@ -0,0 +1,150 @@ +package org.apache.spark; Review comment:

[GitHub] [spark] karenfeng commented on a change in pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
karenfeng commented on a change in pull request #33164: URL: https://github.com/apache/spark/pull/33164#discussion_r661988526 ## File path: core/src/main/java/org/apache/spark/SparkThrowable.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] karenfeng commented on a change in pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
karenfeng commented on a change in pull request #33164: URL: https://github.com/apache/spark/pull/33164#discussion_r661988466 ## File path: core/src/main/scala/org/apache/spark/SparkError.scala ## @@ -1,83 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [spark] LuciferYang commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
LuciferYang commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871936226 > Take your time, @LuciferYang . This should target Apache Spark 3.3 because Apache Spark 3.2 branch cut is July 1st. > > There are some busy cases today, we'll try

[GitHub] [spark] AmplabJenkins commented on pull request #33038: [SPARK-35861][SS] Introduce "prefix match scan" feature on state store

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33038: URL: https://github.com/apache/spark/pull/33038#issuecomment-871936166 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140470/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871936164 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44992/ --

[GitHub] [spark] AmplabJenkins commented on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871936161 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44991/ --

[GitHub] [spark] AmplabJenkins commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871936165 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44989/ --

[GitHub] [spark] karenfeng commented on a change in pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
karenfeng commented on a change in pull request #33164: URL: https://github.com/apache/spark/pull/33164#discussion_r661988355 ## File path: core/src/test/java/org/apache/spark/SparkThrowableSuite.java ## @@ -0,0 +1,150 @@ +package org.apache.spark; + +import java.io.*; +import

[GitHub] [spark] dongjoon-hyun commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871936074 Yes, Apache Spark 3.2 will be the first release having Scala 2.13 additionally. After branch cut, I'll try to switch the default to Scala 2.13 in `master` branch.

[GitHub] [spark] karenfeng commented on a change in pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
karenfeng commented on a change in pull request #33164: URL: https://github.com/apache/spark/pull/33164#discussion_r661987917 ## File path: core/src/main/java/org/apache/spark/SparkThrowable.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [spark] LuciferYang commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
LuciferYang commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871935280 @dongjoon-hyun A question unrelated to this pr, do we have plans to make Scala 2.13 as default? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [spark] LuciferYang removed a comment on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
LuciferYang removed a comment on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871932774 ok ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] LuciferYang commented on a change in pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
LuciferYang commented on a change in pull request #31517: URL: https://github.com/apache/spark/pull/31517#discussion_r661986787 ## File path: common/network-shuffle/pom.xml ## @@ -58,6 +58,14 @@ slf4j-api provided + + com.github.ben-manes.caffeine

[GitHub] [spark] SparkQA commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
SparkQA commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871933838 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44989/ -- This is an automated message from the

[GitHub] [spark] LuciferYang commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
LuciferYang commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871932774 ok ~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] SparkQA commented on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
SparkQA commented on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871928722 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44992/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
SparkQA commented on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871928100 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44991/ -- This is an automated message from the

[GitHub] [spark] dongjoon-hyun commented on pull request #33157: [WIP][SPARK-35954] Upgrade Apache Curator Dependency to 4.2.0

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #33157: URL: https://github.com/apache/spark/pull/33157#issuecomment-871927557 ok to test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] dongjoon-hyun commented on pull request #33157: [WIP][SPARK-35954] Upgrade Apache Curator Dependency to 4.2.0

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #33157: URL: https://github.com/apache/spark/pull/33157#issuecomment-871927449 cc @sunchao since @nirousseau wrote the following in the JIRA. > Spark 3.2.0 aims to support Hadoop 3.3.1 ; this Hadoop release bundles the following shared libraries :

[GitHub] [spark] dongjoon-hyun commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871924006 Take your time, @LuciferYang . This should target Apache Spark 3.3 because Apache Spark 3.2 branch cut is July 1st. > There are some busy cases today, we'll try to fix

[GitHub] [spark] SparkQA removed a comment on pull request #33038: [SPARK-35861][SS] Introduce "prefix match scan" feature on state store

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #33038: URL: https://github.com/apache/spark/pull/33038#issuecomment-871821101 **[Test build #140470 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140470/testReport)** for PR 33038 at commit

[GitHub] [spark] SparkQA commented on pull request #33038: [SPARK-35861][SS] Introduce "prefix match scan" feature on state store

2021-06-30 Thread GitBox
SparkQA commented on pull request #33038: URL: https://github.com/apache/spark/pull/33038#issuecomment-871923225 **[Test build #140470 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140470/testReport)** for PR 33038 at commit

[GitHub] [spark] HyukjinKwon edited a comment on pull request #33146: [SPARK-35912][SQL] Fix cast struct contains null value to string/struct

2021-06-30 Thread GitBox
HyukjinKwon edited a comment on pull request #33146: URL: https://github.com/apache/spark/pull/33146#issuecomment-871912905 Shouldn't it fail instead of setting it as `0` or `null`? I feel like the handling should be done somewhere in `JacksonParser`. -- This is an automated message

[GitHub] [spark] linhongliu-db commented on a change in pull request #32831: [SPARK-35685][SQL] Prompt recreating the view when there is an incompatible schema issue

2021-06-30 Thread GitBox
linhongliu-db commented on a change in pull request #32831: URL: https://github.com/apache/spark/pull/32831#discussion_r661975979 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala ## @@ -846,6 +846,30 @@ class SessionCatalog(

[GitHub] [spark] cloud-fan commented on a change in pull request #33146: [SPARK-35912][SQL] Fix cast struct contains null value to string/struct

2021-06-30 Thread GitBox
cloud-fan commented on a change in pull request #33146: URL: https://github.com/apache/spark/pull/33146#discussion_r661973792 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala ## @@ -406,19 +406,21 @@ abstract class CastBase

[GitHub] [spark] venkata91 commented on a change in pull request #33034: WIP: [SPARK-32923][CORE][SHUFFLE] Handle indeterminate stage retries for push-based shuffle

2021-06-30 Thread GitBox
venkata91 commented on a change in pull request #33034: URL: https://github.com/apache/spark/pull/33034#discussion_r661972672 ## File path: common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java ## @@ -222,7 +223,7 @@ public void

[GitHub] [spark] venkata91 commented on a change in pull request #33034: WIP: [SPARK-32923][CORE][SHUFFLE] Handle indeterminate stage retries for push-based shuffle

2021-06-30 Thread GitBox
venkata91 commented on a change in pull request #33034: URL: https://github.com/apache/spark/pull/33034#discussion_r661972672 ## File path: common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java ## @@ -222,7 +223,7 @@ public void

[GitHub] [spark] ulysses-you commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
ulysses-you commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871915784 cc @wangyum @cloud-fan @yaooqinn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] SparkQA commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader when REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
SparkQA commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871915423 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44989/ -- This is an automated message from the Apache

[GitHub] [spark] HyukjinKwon commented on pull request #33146: [SPARK-35912][SQL] Fix cast struct contains null value to string/struct

2021-06-30 Thread GitBox
HyukjinKwon commented on pull request #33146: URL: https://github.com/apache/spark/pull/33146#issuecomment-871912905 Shouldn't it fail instead of setting it as `0`? I feel like the handling should be done somewhere in `JacksonParser`. -- This is an automated message from the Apache Git

[GitHub] [spark] Ngone51 commented on a change in pull request #33034: WIP: [SPARK-32923][CORE][SHUFFLE] Handle indeterminate stage retries for push-based shuffle

2021-06-30 Thread GitBox
Ngone51 commented on a change in pull request #33034: URL: https://github.com/apache/spark/pull/33034#discussion_r661965448 ## File path: common/network-common/src/main/java/org/apache/spark/network/client/TransportClient.java ## @@ -222,7 +223,7 @@ public void

[GitHub] [spark] SparkQA commented on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
SparkQA commented on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871912023 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44992/ -- This is an automated message from the Apache

[GitHub] [spark] dongjoon-hyun commented on pull request #33070: [SPARK-35551][SQL] Handle the COUNT bug for lateral subqueries

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #33070: URL: https://github.com/apache/spark/pull/33070#issuecomment-871911950 Gentle ping, @allisonwang-db . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] SparkQA commented on pull request #31517: [SPARK-34309][BUILD][CORE][SQL][K8S]Use Caffeine instead of Guava Cache

2021-06-30 Thread GitBox
SparkQA commented on pull request #31517: URL: https://github.com/apache/spark/pull/31517#issuecomment-871911777 **[Test build #140481 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140481/testReport)** for PR 31517 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33164: URL: https://github.com/apache/spark/pull/33164#issuecomment-871911437 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44990/

[GitHub] [spark] SparkQA commented on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
SparkQA commented on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871911539 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44991/ -- This is an automated message from the Apache

[GitHub] [spark] dongjoon-hyun closed pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
dongjoon-hyun closed pull request #33163: URL: https://github.com/apache/spark/pull/33163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] AmplabJenkins commented on pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33164: URL: https://github.com/apache/spark/pull/33164#issuecomment-871911437 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44990/ --

[GitHub] [spark] SparkQA commented on pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
SparkQA commented on pull request #33164: URL: https://github.com/apache/spark/pull/33164#issuecomment-871911422 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44990/ --

[GitHub] [spark] AmplabJenkins removed a comment on pull request #31569: [SPARK-34443][CORE] Replace symbol literals with Symbol constructor invocations to comply with Scala 2.13

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #31569: URL: https://github.com/apache/spark/pull/31569#issuecomment-871910607 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140475/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33028: [SPARK-35714][FOLLOW-UP][CORE] Use a shared stopping flag for WorkerWatcher to avoid the duplicate System.exit

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33028: URL: https://github.com/apache/spark/pull/33028#issuecomment-871910604 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140473/

[GitHub] [spark] AmplabJenkins commented on pull request #33028: [SPARK-35714][FOLLOW-UP][CORE] Use a shared stopping flag for WorkerWatcher to avoid the duplicate System.exit

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33028: URL: https://github.com/apache/spark/pull/33028#issuecomment-871910604 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140473/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #31569: [SPARK-34443][CORE] Replace symbol literals with Symbol constructor invocations to comply with Scala 2.13

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #31569: URL: https://github.com/apache/spark/pull/31569#issuecomment-871910607 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140475/ -- This

[GitHub] [spark] dongjoon-hyun commented on pull request #33155: [SPARK-35950][WebUI] Failed to toggle Exec Loss Reason in the executors page

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #33155: URL: https://github.com/apache/spark/pull/33155#issuecomment-871909730 Thank you for the fix, @pingsutw . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [spark] dongjoon-hyun commented on pull request #33155: [SPARK-35950][WebUI] Failed to toggle Exec Loss Reason in the executors page

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #33155: URL: https://github.com/apache/spark/pull/33155#issuecomment-871909662 Oh, sorry for missing your ping, @gengliangwang . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] gengliangwang closed pull request #33155: [SPARK-35950][WebUI] Failed to toggle Exec Loss Reason in the executors page

2021-06-30 Thread GitBox
gengliangwang closed pull request #33155: URL: https://github.com/apache/spark/pull/33155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] gengliangwang commented on pull request #33155: [SPARK-35950][WebUI] Failed to toggle Exec Loss Reason in the executors page

2021-06-30 Thread GitBox
gengliangwang commented on pull request #33155: URL: https://github.com/apache/spark/pull/33155#issuecomment-871909040 Merging to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] sigmod commented on a change in pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
sigmod commented on a change in pull request #33164: URL: https://github.com/apache/spark/pull/33164#discussion_r661960275 ## File path: core/src/test/java/org/apache/spark/SparkThrowableSuite.java ## @@ -0,0 +1,150 @@ +package org.apache.spark; Review comment: copy

[GitHub] [spark] SparkQA removed a comment on pull request #31569: [SPARK-34443][CORE] Replace symbol literals with Symbol constructor invocations to comply with Scala 2.13

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #31569: URL: https://github.com/apache/spark/pull/31569#issuecomment-871846487 **[Test build #140475 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140475/testReport)** for PR 31569 at commit

[GitHub] [spark] SparkQA commented on pull request #31569: [SPARK-34443][CORE] Replace symbol literals with Symbol constructor invocations to comply with Scala 2.13

2021-06-30 Thread GitBox
SparkQA commented on pull request #31569: URL: https://github.com/apache/spark/pull/31569#issuecomment-871905813 **[Test build #140475 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140475/testReport)** for PR 31569 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #33028: [SPARK-35714][FOLLOW-UP][CORE] Use a shared stopping flag for WorkerWatcher to avoid the duplicate System.exit

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #33028: URL: https://github.com/apache/spark/pull/33028#issuecomment-871843586 **[Test build #140473 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140473/testReport)** for PR 33028 at commit

[GitHub] [spark] SparkQA commented on pull request #33028: [SPARK-35714][FOLLOW-UP][CORE] Use a shared stopping flag for WorkerWatcher to avoid the duplicate System.exit

2021-06-30 Thread GitBox
SparkQA commented on pull request #33028: URL: https://github.com/apache/spark/pull/33028#issuecomment-871901987 **[Test build #140473 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140473/testReport)** for PR 33028 at commit

[GitHub] [spark] dongjoon-hyun commented on pull request #33149: [SPARK-35947][INFRA] Increase JVM stack size in release-build.sh

2021-06-30 Thread GitBox
dongjoon-hyun commented on pull request #33149: URL: https://github.com/apache/spark/pull/33149#issuecomment-871898355 The daily publish GitHub Action job is recovered. - https://github.com/apache/spark/actions/workflows/publish_snapshot.yml?query=branch%3Amaster -- This is an

[GitHub] [spark] cfmcgrady commented on pull request #33146: [SPARK-35912][SQL] Fix cast struct contains null value to string/struct

2021-06-30 Thread GitBox
cfmcgrady commented on pull request #33146: URL: https://github.com/apache/spark/pull/33146#issuecomment-871895699 > Hey mind explaining why cast path issue is related to being cached? Actually, the cached result is what we want. The issue is that `spark.read.json` is not an

[GitHub] [spark] dgd-contributor commented on pull request #32951: [SPARK-33603][SQL] Grouping execution/command

2021-06-30 Thread GitBox
dgd-contributor commented on pull request #32951: URL: https://github.com/apache/spark/pull/32951#issuecomment-871889961 @beliefer I've resolve the rest change requires, can you review them -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [spark] Ngone51 commented on pull request #33028: [SPARK-35714][FOLLOW-UP][CORE] Use a shared stopping flag for WorkerWatcher to avoid the duplicate System.exit

2021-06-30 Thread GitBox
Ngone51 commented on pull request #33028: URL: https://github.com/apache/spark/pull/33028#issuecomment-871889819 Thanks all! Merged to Master/3.1/3.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] SparkQA removed a comment on pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
SparkQA removed a comment on pull request #33164: URL: https://github.com/apache/spark/pull/33164#issuecomment-871889019 **[Test build #140478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140478/testReport)** for PR 33164 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33164: URL: https://github.com/apache/spark/pull/33164#issuecomment-871889188 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140478/

[GitHub] [spark] Ngone51 closed pull request #33028: [SPARK-35714][FOLLOW-UP][CORE] Use a shared stopping flag for WorkerWatcher to avoid the duplicate System.exit

2021-06-30 Thread GitBox
Ngone51 closed pull request #33028: URL: https://github.com/apache/spark/pull/33028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] SparkQA commented on pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
SparkQA commented on pull request #33164: URL: https://github.com/apache/spark/pull/33164#issuecomment-871889175 **[Test build #140478 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140478/testReport)** for PR 33164 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33164: URL: https://github.com/apache/spark/pull/33164#issuecomment-871889188 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140478/ -- This

[GitHub] [spark] SparkQA commented on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
SparkQA commented on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871889034 **[Test build #140479 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140479/testReport)** for PR 33163 at commit

[GitHub] [spark] SparkQA commented on pull request #33142: [SPARK-35940][SQL] Refactor EquivalentExpressions to make it more efficient

2021-06-30 Thread GitBox
SparkQA commented on pull request #33142: URL: https://github.com/apache/spark/pull/33142#issuecomment-871889080 **[Test build #140480 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140480/testReport)** for PR 33142 at commit

[GitHub] [spark] SparkQA commented on pull request #33165: [SPARK-35961][SQL] Only use local shuffle reader for REBALANCE_PARTITIONS_BY_NONE without CustomShuffleReaderExec

2021-06-30 Thread GitBox
SparkQA commented on pull request #33165: URL: https://github.com/apache/spark/pull/33165#issuecomment-871889009 **[Test build #140477 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140477/testReport)** for PR 33165 at commit

[GitHub] [spark] SparkQA commented on pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
SparkQA commented on pull request #33164: URL: https://github.com/apache/spark/pull/33164#issuecomment-871889019 **[Test build #140478 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140478/testReport)** for PR 33164 at commit

[GitHub] [spark] dgd-contributor commented on a change in pull request #32951: [SPARK-33603][SQL] Grouping execution/command

2021-06-30 Thread GitBox
dgd-contributor commented on a change in pull request #32951: URL: https://github.com/apache/spark/pull/32951#discussion_r661947669 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala ## @@ -1694,4 +1697,355 @@ private[spark]

[GitHub] [spark] HyukjinKwon commented on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
HyukjinKwon commented on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871888516 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871888275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33093: URL: https://github.com/apache/spark/pull/33093#issuecomment-871888276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins removed a comment on pull request #32365: [SPARK-35228][SQL] Add expression ToHiveString for keep consistent between hive/spark format in df.show

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #32365: URL: https://github.com/apache/spark/pull/32365#issuecomment-871872122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33162: [WIP][SPARK-35615] Make all basic operators data-type-based

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33162: URL: https://github.com/apache/spark/pull/33162#issuecomment-871888277 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44986/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33028: [SPARK-35714][FOLLOW-UP][CORE] Use a shared stopping flag for WorkerWatcher to avoid the duplicate System.exit

2021-06-30 Thread GitBox
AmplabJenkins removed a comment on pull request #33028: URL: https://github.com/apache/spark/pull/33028#issuecomment-871888274 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44987/

[GitHub] [spark] AmplabJenkins commented on pull request #33028: [SPARK-35714][FOLLOW-UP][CORE] Use a shared stopping flag for WorkerWatcher to avoid the duplicate System.exit

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33028: URL: https://github.com/apache/spark/pull/33028#issuecomment-871888274 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44987/ --

[GitHub] [spark] cloud-fan commented on a change in pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
cloud-fan commented on a change in pull request #33164: URL: https://github.com/apache/spark/pull/33164#discussion_r661947165 ## File path: core/src/test/java/org/apache/spark/SparkThrowableSuite.java ## @@ -0,0 +1,150 @@ +package org.apache.spark; + +import java.io.*; +import

[GitHub] [spark] AmplabJenkins commented on pull request #32365: [SPARK-35228][SQL] Add expression ToHiveString for keep consistent between hive/spark format in df.show

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #32365: URL: https://github.com/apache/spark/pull/32365#issuecomment-871888282 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44988/ --

[GitHub] [spark] AmplabJenkins commented on pull request #33093: [SPARK-35897][SS][WIP] Support user defined initial state with flatMapGroupsWithState in Structured Streaming

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33093: URL: https://github.com/apache/spark/pull/33093#issuecomment-871888283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] AmplabJenkins commented on pull request #33162: [WIP][SPARK-35615] Make all basic operators data-type-based

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33162: URL: https://github.com/apache/spark/pull/33162#issuecomment-871888277 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44986/ --

[GitHub] [spark] AmplabJenkins commented on pull request #33163: [SPARK-35960][BUILD][TEST] Bump the scalatest version to 3.2.9

2021-06-30 Thread GitBox
AmplabJenkins commented on pull request #33163: URL: https://github.com/apache/spark/pull/33163#issuecomment-871888278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] cloud-fan commented on a change in pull request #33164: [SPARK-35958][CORE] Refactor SparkError.scala to SparkThrowable.java

2021-06-30 Thread GitBox
cloud-fan commented on a change in pull request #33164: URL: https://github.com/apache/spark/pull/33164#discussion_r661946823 ## File path: core/src/main/scala/org/apache/spark/SparkError.scala ## @@ -1,83 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under

  1   2   3   4   5   6   7   8   >