[GitHub] [spark] SparkQA commented on pull request #33162: [WIP][SPARK-35615] Make all basic operators data-type-based

2021-07-06 Thread GitBox
SparkQA commented on pull request #33162: URL: https://github.com/apache/spark/pull/33162#issuecomment-874948398 **[Test build #140712 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140712/testReport)** for PR 33162 at commit

[GitHub] [spark] SparkQA commented on pull request #32949: [SPARK-35749][SPARK-35773][SQL] Parse unit list interval literals as tightest year-month/day-time interval types

2021-07-06 Thread GitBox
SparkQA commented on pull request #32949: URL: https://github.com/apache/spark/pull/32949#issuecomment-874945132 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45222/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33220: [WIP][SPARK-35993][TESTS] Fix flaky tests for RocksDBSuite

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33220: URL: https://github.com/apache/spark/pull/33220#issuecomment-874940862 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140705/

[GitHub] [spark] AmplabJenkins commented on pull request #33220: [WIP][SPARK-35993][TESTS] Fix flaky tests for RocksDBSuite

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33220: URL: https://github.com/apache/spark/pull/33220#issuecomment-874940862 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140705/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #33220: [WIP][SPARK-35993][TESTS] Fix flaky tests for RocksDBSuite

2021-07-06 Thread GitBox
SparkQA removed a comment on pull request #33220: URL: https://github.com/apache/spark/pull/33220#issuecomment-874787659 **[Test build #140705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140705/testReport)** for PR 33220 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #33191: [SPARK-35985][SQL] push partitionFilters for empty readDataSchema

2021-07-06 Thread GitBox
cloud-fan commented on a change in pull request #33191: URL: https://github.com/apache/spark/pull/33191#discussion_r664741337 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitions.scala ## @@ -120,7 +120,7 @@ private[sql]

[GitHub] [spark] SparkQA commented on pull request #33220: [WIP][SPARK-35993][TESTS] Fix flaky tests for RocksDBSuite

2021-07-06 Thread GitBox
SparkQA commented on pull request #33220: URL: https://github.com/apache/spark/pull/33220#issuecomment-874939972 **[Test build #140705 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140705/testReport)** for PR 33220 at commit

[GitHub] [spark] cloud-fan commented on a change in pull request #33219: [SPARK-36012][SQL] Add null flag when SHOW CREATE TABLE in v2

2021-07-06 Thread GitBox
cloud-fan commented on a change in pull request #33219: URL: https://github.com/apache/spark/pull/33219#discussion_r664739741 ## File path: sql/core/src/test/scala/org/apache/spark/sql/ShowCreateTableSuite.scala ## @@ -182,6 +182,27 @@ abstract class ShowCreateTableSuite

[GitHub] [spark] cloud-fan commented on a change in pull request #33219: [SPARK-36012][SQL] Add null flag when SHOW CREATE TABLE in v2

2021-07-06 Thread GitBox
cloud-fan commented on a change in pull request #33219: URL: https://github.com/apache/spark/pull/33219#discussion_r664738963 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -670,7 +670,7 @@ class DataFrameSetOperationsSuite

[GitHub] [spark] cloud-fan commented on a change in pull request #33219: [SPARK-36012][SQL] Add null flag when SHOW CREATE TABLE in v2

2021-07-06 Thread GitBox
cloud-fan commented on a change in pull request #33219: URL: https://github.com/apache/spark/pull/33219#discussion_r664738897 ## File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSetOperationsSuite.scala ## @@ -654,7 +654,7 @@ class DataFrameSetOperationsSuite

[GitHub] [spark] MaxGekk commented on a change in pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
MaxGekk commented on a change in pull request #33231: URL: https://github.com/apache/spark/pull/33231#discussion_r664733063 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala ## @@ -594,23 +596,29 @@ object IntervalUtils {

[GitHub] [spark] MaxGekk commented on a change in pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
MaxGekk commented on a change in pull request #33231: URL: https://github.com/apache/spark/pull/33231#discussion_r664731663 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala ## @@ -541,15 +541,17 @@ object IntervalUtils { }

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33231: URL: https://github.com/apache/spark/pull/33231#issuecomment-874929332 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45221/

[GitHub] [spark] AmplabJenkins commented on pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33231: URL: https://github.com/apache/spark/pull/33231#issuecomment-874929332 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45221/ --

[GitHub] [spark] SparkQA commented on pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
SparkQA commented on pull request #33231: URL: https://github.com/apache/spark/pull/33231#issuecomment-874929306 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45221/ --

[GitHub] [spark] SparkQA commented on pull request #33162: [WIP][SPARK-35615] Make all basic operators data-type-based

2021-07-06 Thread GitBox
SparkQA commented on pull request #33162: URL: https://github.com/apache/spark/pull/33162#issuecomment-874928865 **[Test build #140712 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140712/testReport)** for PR 33162 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33182: [SPARK-35984][SQL][TEST] Config to force applying shuffled hash join

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-874928038 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45220/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33233: URL: https://github.com/apache/spark/pull/33233#issuecomment-874928037 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45219/

[GitHub] [spark] AmplabJenkins commented on pull request #33182: [SPARK-35984][SQL][TEST] Config to force applying shuffled hash join

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-874928038 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45220/ --

[GitHub] [spark] AmplabJenkins commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33233: URL: https://github.com/apache/spark/pull/33233#issuecomment-874928037 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45219/ --

[GitHub] [spark] MaxGekk commented on a change in pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
MaxGekk commented on a change in pull request #33231: URL: https://github.com/apache/spark/pull/33231#discussion_r664729339 ## File path: sql/core/src/test/resources/sql-tests/results/interval.sql.out ## @@ -1459,3 +1459,83 @@ struct<> -- !query output

[GitHub] [spark] cloud-fan closed pull request #33182: [SPARK-35984][SQL][TEST] Config to force applying shuffled hash join

2021-07-06 Thread GitBox
cloud-fan closed pull request #33182: URL: https://github.com/apache/spark/pull/33182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] cloud-fan commented on pull request #33182: [SPARK-35984][SQL][TEST] Config to force applying shuffled hash join

2021-07-06 Thread GitBox
cloud-fan commented on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-874927658 thanks, merging to master/3.2 (to improve test coverage) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [spark] MaxGekk commented on a change in pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
MaxGekk commented on a change in pull request #33231: URL: https://github.com/apache/spark/pull/33231#discussion_r664727850 ## File path: sql/core/src/test/resources/sql-tests/results/interval.sql.out ## @@ -1459,3 +1459,83 @@ struct<> -- !query output

[GitHub] [spark] cloud-fan commented on a change in pull request #32949: [SPARK-35749][SPARK-35773][SQL] Parse unit list interval literals as tightest year-month/day-time interval types

2021-07-06 Thread GitBox
cloud-fan commented on a change in pull request #32949: URL: https://github.com/apache/spark/pull/32949#discussion_r664727460 ## File path: sql/core/src/test/resources/sql-tests/inputs/cast.sql ## @@ -58,8 +58,10 @@ DESC FUNCTION EXTENDED boolean; -- TODO: migrate all cast

[GitHub] [spark] cloud-fan commented on a change in pull request #32949: [SPARK-35749][SPARK-35773][SQL] Parse unit list interval literals as tightest year-month/day-time interval types

2021-07-06 Thread GitBox
cloud-fan commented on a change in pull request #32949: URL: https://github.com/apache/spark/pull/32949#discussion_r664725043 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala ## @@ -210,6 +212,20 @@ object QueryParsingErrors {

[GitHub] [spark] steven-aerts commented on a change in pull request #33191: [SPARK-35985][SQL] push partitionFilters for empty readDataSchema

2021-07-06 Thread GitBox
steven-aerts commented on a change in pull request #33191: URL: https://github.com/apache/spark/pull/33191#discussion_r664724961 ## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PruneFileSourcePartitions.scala ## @@ -120,7 +120,7 @@

[GitHub] [spark] cloud-fan commented on a change in pull request #32949: [SPARK-35749][SPARK-35773][SQL] Parse unit list interval literals as tightest year-month/day-time interval types

2021-07-06 Thread GitBox
cloud-fan commented on a change in pull request #32949: URL: https://github.com/apache/spark/pull/32949#discussion_r664724125 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala ## @@ -210,6 +212,20 @@ object QueryParsingErrors {

[GitHub] [spark] SparkQA commented on pull request #32949: [SPARK-35749][SPARK-35773][SQL] Parse unit list interval literals as tightest year-month/day-time interval types

2021-07-06 Thread GitBox
SparkQA commented on pull request #32949: URL: https://github.com/apache/spark/pull/32949#issuecomment-874921714 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45222/ -- This is an automated message from the Apache

[GitHub] [spark] cloud-fan commented on a change in pull request #32949: [SPARK-35749][SPARK-35773][SQL] Parse unit list interval literals as tightest year-month/day-time interval types

2021-07-06 Thread GitBox
cloud-fan commented on a change in pull request #32949: URL: https://github.com/apache/spark/pull/32949#discussion_r664723089 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -2386,20 +2386,42 @@ class AstBuilder extends

[GitHub] [spark] sunchao commented on pull request #29326: [WIP][SPARK-32502][BUILD] Upgrade Guava to 27.0-jre

2021-07-06 Thread GitBox
sunchao commented on pull request #29326: URL: https://github.com/apache/spark/pull/29326#issuecomment-874917606 Oh I didn't even realize that Spark is using `hive-exec-core` jar. Does that mean it doesn't take advantage of the Guava shading from Hive 2.3.8+ at all? One idea is to

[GitHub] [spark] cloud-fan commented on a change in pull request #32949: [SPARK-35749][SPARK-35773][SQL] Parse unit list interval literals as tightest year-month/day-time interval types

2021-07-06 Thread GitBox
cloud-fan commented on a change in pull request #32949: URL: https://github.com/apache/spark/pull/32949#discussion_r664717265 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala ## @@ -2386,20 +2386,42 @@ class AstBuilder extends

[GitHub] [spark] SparkQA commented on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-06 Thread GitBox
SparkQA commented on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-874910699 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45220/ -- This is an automated message from the

[GitHub] [spark] cloud-fan commented on a change in pull request #32949: [SPARK-35749][SPARK-35773][SQL] Parse unit list interval literals as tightest year-month/day-time interval types

2021-07-06 Thread GitBox
cloud-fan commented on a change in pull request #32949: URL: https://github.com/apache/spark/pull/32949#discussion_r664705185 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ## @@ -2526,10 +2526,10 @@ object

[GitHub] [spark] xinrong-databricks commented on pull request #33095: [SPARK-35339][PYTHON] Improve unit tests for data-type-based basic operations

2021-07-06 Thread GitBox
xinrong-databricks commented on pull request #33095: URL: https://github.com/apache/spark/pull/33095#issuecomment-874904091 Thank you @ueshin ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] SparkQA commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0

2021-07-06 Thread GitBox
SparkQA commented on pull request #33233: URL: https://github.com/apache/spark/pull/33233#issuecomment-874903753 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45219/ -- This is an automated message from the

[GitHub] [spark] cloud-fan commented on a change in pull request #32949: [SPARK-35749][SPARK-35773][SQL] Parse unit list interval literals as tightest year-month/day-time interval types

2021-07-06 Thread GitBox
cloud-fan commented on a change in pull request #32949: URL: https://github.com/apache/spark/pull/32949#discussion_r664704259 ## File path: docs/sql-migration-guide.md ## @@ -83,7 +83,9 @@ license: | - In Spark 3.2, `TRANSFORM` operator can support

[GitHub] [spark] xinrong-databricks commented on pull request #33206: [SPARK-36002][PYTHON] Consolidate tests for data-type-based operations of decimal Series

2021-07-06 Thread GitBox
xinrong-databricks commented on pull request #33206: URL: https://github.com/apache/spark/pull/33206#issuecomment-874902728 Thank you @Yikun! That makes code much cleaner. What do you think of testing other operators (e.g.`test_add`) for `numeric_withnan_pser_psser_pairs`? That

[GitHub] [spark] xinrong-databricks commented on a change in pull request #33174: [SPARK-35721][PYTHON] Path level discover for python unittests

2021-07-06 Thread GitBox
xinrong-databricks commented on a change in pull request #33174: URL: https://github.com/apache/spark/pull/33174#discussion_r664693878 ## File path: python/run-tests.py ## @@ -40,6 +44,111 @@ from sparktestsupport.shellutils import which, subprocess_check_output # noqa from

[GitHub] [spark] SparkQA commented on pull request #32949: [SPARK-35749][SPARK-35773][SQL] Parse unit list interval literals as tightest year-month/day-time interval types

2021-07-06 Thread GitBox
SparkQA commented on pull request #32949: URL: https://github.com/apache/spark/pull/32949#issuecomment-874885114 **[Test build #140711 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140711/testReport)** for PR 32949 at commit

[GitHub] [spark] SparkQA commented on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-06 Thread GitBox
SparkQA commented on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-874884772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [spark] SparkQA commented on pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
SparkQA commented on pull request #33231: URL: https://github.com/apache/spark/pull/33231#issuecomment-874884746 **[Test build #140709 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140709/testReport)** for PR 33231 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33214: [SPARK-35929][PYTHON] Support to infer nested dict as a struct when creating a DataFrame

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33214: URL: https://github.com/apache/spark/pull/33214#issuecomment-874883834 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45217/

[GitHub] [spark] AmplabJenkins commented on pull request #33234: [SPARK-36011][SQL][3.0] Disallow altering permanent views based on temporary views or UDFs

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33234: URL: https://github.com/apache/spark/pull/33234#issuecomment-874884293 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33220: [WIP][SPARK-35993][TESTS] Fix flaky tests for RocksDBSuite

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33220: URL: https://github.com/apache/spark/pull/33220#issuecomment-874883835 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45216/

[GitHub] [spark] AmplabJenkins commented on pull request #33220: [WIP][SPARK-35993][TESTS] Fix flaky tests for RocksDBSuite

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33220: URL: https://github.com/apache/spark/pull/33220#issuecomment-874883835 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45216/ --

[GitHub] [spark] AmplabJenkins commented on pull request #33214: [SPARK-35929][PYTHON] Support to infer nested dict as a struct when creating a DataFrame

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33214: URL: https://github.com/apache/spark/pull/33214#issuecomment-874883834 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45217/ --

[GitHub] [spark] viirya commented on a change in pull request #33227: [SPARK-35972][SQL][3.1] When replace ExtractValue in NestedColumnAliasing we should use semanticEquals

2021-07-06 Thread GitBox
viirya commented on a change in pull request #33227: URL: https://github.com/apache/spark/pull/33227#discussion_r664682408 ## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasingSuite.scala ## @@ -684,6 +684,31 @@ class

[GitHub] [spark] SparkQA commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0

2021-07-06 Thread GitBox
SparkQA commented on pull request #33233: URL: https://github.com/apache/spark/pull/33233#issuecomment-874878292 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45219/ -- This is an automated message from the Apache

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
AngersZh commented on a change in pull request #33231: URL: https://github.com/apache/spark/pull/33231#discussion_r664674353 ## File path: sql/core/src/test/resources/sql-tests/results/interval.sql.out ## @@ -1459,3 +1459,83 @@ struct<> -- !query output

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
AngersZh commented on a change in pull request #33231: URL: https://github.com/apache/spark/pull/33231#discussion_r664674353 ## File path: sql/core/src/test/resources/sql-tests/results/interval.sql.out ## @@ -1459,3 +1459,83 @@ struct<> -- !query output

[GitHub] [spark] jerqi opened a new pull request #33234: [SPARK-36011][SQL][3.0] Disallow altering permanent views based on temporary views or UDFs

2021-07-06 Thread GitBox
jerqi opened a new pull request #33234: URL: https://github.com/apache/spark/pull/33234 backport #33204 to 3.0 ### What changes were proposed in this pull request? PR #15764 disabled creating permanent views based on temporary views or UDFs. But AlterViewCommand didn't block

[GitHub] [spark] MaxGekk commented on a change in pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
MaxGekk commented on a change in pull request #33231: URL: https://github.com/apache/spark/pull/33231#discussion_r664664299 ## File path: sql/core/src/test/resources/sql-tests/results/interval.sql.out ## @@ -1459,3 +1459,83 @@ struct<> -- !query output

[GitHub] [spark] attilapiros commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0

2021-07-06 Thread GitBox
attilapiros commented on pull request #33233: URL: https://github.com/apache/spark/pull/33233#issuecomment-874860727 cc @dongjoon-hyun @srowen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] SparkQA commented on pull request #33214: [SPARK-35929][PYTHON] Support to infer nested dict as a struct when creating a DataFrame

2021-07-06 Thread GitBox
SparkQA commented on pull request #33214: URL: https://github.com/apache/spark/pull/33214#issuecomment-874859493 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45217/ -- This is an automated message from the

[GitHub] [spark] AngersZhuuuu commented on a change in pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
AngersZh commented on a change in pull request #33231: URL: https://github.com/apache/spark/pull/33231#discussion_r66465 ## File path: sql/core/src/test/resources/sql-tests/results/interval.sql.out ## @@ -1459,3 +1459,83 @@ struct<> -- !query output

[GitHub] [spark] SparkQA commented on pull request #33220: [WIP][SPARK-35993][TESTS] Fix flaky tests for RocksDBSuite

2021-07-06 Thread GitBox
SparkQA commented on pull request #33220: URL: https://github.com/apache/spark/pull/33220#issuecomment-874852866 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45216/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #33187: [SPARK-35988][SS] The implementation for RocksDBStateStoreProvider

2021-07-06 Thread GitBox
SparkQA commented on pull request #33187: URL: https://github.com/apache/spark/pull/33187#issuecomment-874852636 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45218/ -- This is an automated message from the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33187: [SPARK-35988][SS] The implementation for RocksDBStateStoreProvider

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33187: URL: https://github.com/apache/spark/pull/33187#issuecomment-874852703 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45218/

[GitHub] [spark] AmplabJenkins commented on pull request #33187: [SPARK-35988][SS] The implementation for RocksDBStateStoreProvider

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33187: URL: https://github.com/apache/spark/pull/33187#issuecomment-874852703 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45218/ --

[GitHub] [spark] SparkQA removed a comment on pull request #33222: [SPARK-36020][SQL] Check logical link in remove redundant projects

2021-07-06 Thread GitBox
SparkQA removed a comment on pull request #33222: URL: https://github.com/apache/spark/pull/33222#issuecomment-874664963 **[Test build #140702 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140702/testReport)** for PR 33222 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33222: [SPARK-36020][SQL] Check logical link in remove redundant projects

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33222: URL: https://github.com/apache/spark/pull/33222#issuecomment-874849904 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140702/

[GitHub] [spark] AmplabJenkins commented on pull request #33222: [SPARK-36020][SQL] Check logical link in remove redundant projects

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33222: URL: https://github.com/apache/spark/pull/33222#issuecomment-874849904 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140702/ -- This

[GitHub] [spark] SparkQA commented on pull request #33222: [SPARK-36020][SQL] Check logical link in remove redundant projects

2021-07-06 Thread GitBox
SparkQA commented on pull request #33222: URL: https://github.com/apache/spark/pull/33222#issuecomment-874847963 **[Test build #140702 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140702/testReport)** for PR 33222 at commit

[GitHub] [spark] SparkQA commented on pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0

2021-07-06 Thread GitBox
SparkQA commented on pull request #33233: URL: https://github.com/apache/spark/pull/33233#issuecomment-874846896 **[Test build #140708 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140708/testReport)** for PR 33233 at commit

[GitHub] [spark] attilapiros opened a new pull request #33233: [SPARK-36026][BUILD][K8S] Upgrade kubernetes-client to 5.5.0

2021-07-06 Thread GitBox
attilapiros opened a new pull request #33233: URL: https://github.com/apache/spark/pull/33233 ### What changes were proposed in this pull request? Upgrading the kubernetes-client to 5.5.0 ### Why are the changes needed? There are [several

[GitHub] [spark] AmplabJenkins commented on pull request #33232: [SPARK-36027][SQL] Add the code change to pushdown filter in case of typedFilter

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33232: URL: https://github.com/apache/spark/pull/33232#issuecomment-874842990 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] SaurabhChawla100 opened a new pull request #33232: [SPARK-36027][SQL] Add the code change to pushdown filter in case of typedFilter

2021-07-06 Thread GitBox
SaurabhChawla100 opened a new pull request #33232: URL: https://github.com/apache/spark/pull/33232 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change?

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-874835383 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140701/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33229: [SPARK-36025][SQL][TESTS] Reduce the run time of DateExpressionsSuite

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33229: URL: https://github.com/apache/spark/pull/33229#issuecomment-874835382 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140699/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33231: URL: https://github.com/apache/spark/pull/33231#issuecomment-874835388 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45215/

[GitHub] [spark] AmplabJenkins commented on pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33231: URL: https://github.com/apache/spark/pull/33231#issuecomment-874835388 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45215/ --

[GitHub] [spark] AmplabJenkins commented on pull request #33229: [SPARK-36025][SQL][TESTS] Reduce the run time of DateExpressionsSuite

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33229: URL: https://github.com/apache/spark/pull/33229#issuecomment-874835382 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140699/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-874835383 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140701/ -- This

[GitHub] [spark] SparkQA commented on pull request #33214: [SPARK-35929][PYTHON] Support to infer nested dict as a struct when creating a DataFrame

2021-07-06 Thread GitBox
SparkQA commented on pull request #33214: URL: https://github.com/apache/spark/pull/33214#issuecomment-874830360 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45217/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #33220: [WIP][SPARK-35993][TESTS] Fix flaky tests for RocksDBSuite

2021-07-06 Thread GitBox
SparkQA commented on pull request #33220: URL: https://github.com/apache/spark/pull/33220#issuecomment-874824994 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45216/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #33187: [SPARK-35988][SS] The implementation for RocksDBStateStoreProvider

2021-07-06 Thread GitBox
SparkQA commented on pull request #33187: URL: https://github.com/apache/spark/pull/33187#issuecomment-874823825 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45218/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
SparkQA commented on pull request #33231: URL: https://github.com/apache/spark/pull/33231#issuecomment-874823599 Kubernetes integration test status success URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45215/ -- This is an automated message from the

[GitHub] [spark] SparkQA removed a comment on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-06 Thread GitBox
SparkQA removed a comment on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-874634979 **[Test build #140701 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140701/testReport)** for PR 33182 at commit

[GitHub] [spark] SparkQA commented on pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-06 Thread GitBox
SparkQA commented on pull request #33182: URL: https://github.com/apache/spark/pull/33182#issuecomment-874822660 **[Test build #140701 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140701/testReport)** for PR 33182 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #33229: [SPARK-36025][SQL][TESTS] Reduce the run time of DateExpressionsSuite

2021-07-06 Thread GitBox
SparkQA removed a comment on pull request #33229: URL: https://github.com/apache/spark/pull/33229#issuecomment-874626885 **[Test build #140699 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140699/testReport)** for PR 33229 at commit

[GitHub] [spark] SparkQA commented on pull request #33229: [SPARK-36025][SQL][TESTS] Reduce the run time of DateExpressionsSuite

2021-07-06 Thread GitBox
SparkQA commented on pull request #33229: URL: https://github.com/apache/spark/pull/33229#issuecomment-874805514 **[Test build #140699 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140699/testReport)** for PR 33229 at commit

[GitHub] [spark] SparkQA commented on pull request #33231: [SPARK-36021][SQL] Parse interval literals should support more than 2 digits

2021-07-06 Thread GitBox
SparkQA commented on pull request #33231: URL: https://github.com/apache/spark/pull/33231#issuecomment-874793736 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45215/ -- This is an automated message from the Apache

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33214: [SPARK-35929][PYTHON] Support to infer nested dict as a struct when creating a DataFrame

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33214: URL: https://github.com/apache/spark/pull/33214#issuecomment-874789025 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140706/

[GitHub] [spark] SparkQA removed a comment on pull request #33214: [SPARK-35929][PYTHON] Support to infer nested dict as a struct when creating a DataFrame

2021-07-06 Thread GitBox
SparkQA removed a comment on pull request #33214: URL: https://github.com/apache/spark/pull/33214#issuecomment-874787591 **[Test build #140706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140706/testReport)** for PR 33214 at commit

[GitHub] [spark] SparkQA commented on pull request #33214: [SPARK-35929][PYTHON] Support to infer nested dict as a struct when creating a DataFrame

2021-07-06 Thread GitBox
SparkQA commented on pull request #33214: URL: https://github.com/apache/spark/pull/33214#issuecomment-874788987 **[Test build #140706 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140706/testReport)** for PR 33214 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #33214: [SPARK-35929][PYTHON] Support to infer nested dict as a struct when creating a DataFrame

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33214: URL: https://github.com/apache/spark/pull/33214#issuecomment-874789025 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140706/ -- This

[GitHub] [spark] SparkQA commented on pull request #33187: [SPARK-35988][SS] The implementation for RocksDBStateStoreProvider

2021-07-06 Thread GitBox
SparkQA commented on pull request #33187: URL: https://github.com/apache/spark/pull/33187#issuecomment-874787722 **[Test build #140707 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140707/testReport)** for PR 33187 at commit

[GitHub] [spark] SparkQA commented on pull request #33214: [SPARK-35929][PYTHON] Support to infer nested dict as a struct when creating a DataFrame

2021-07-06 Thread GitBox
SparkQA commented on pull request #33214: URL: https://github.com/apache/spark/pull/33214#issuecomment-874787591 **[Test build #140706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140706/testReport)** for PR 33214 at commit

[GitHub] [spark] SparkQA commented on pull request #33220: [WIP][SPARK-35993][TESTS] Fix flaky tests for RocksDBSuite

2021-07-06 Thread GitBox
SparkQA commented on pull request #33220: URL: https://github.com/apache/spark/pull/33220#issuecomment-874787659 **[Test build #140705 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140705/testReport)** for PR 33220 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #33220: [WIP][SPARK-35993][TESTS] Fix flaky tests for RocksDBSuite

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33220: URL: https://github.com/apache/spark/pull/33220#issuecomment-874784432 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140695/ -- This

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33220: [WIP][SPARK-35993][TESTS] Fix flaky tests for RocksDBSuite

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33220: URL: https://github.com/apache/spark/pull/33220#issuecomment-874784432 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140695/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33216: URL: https://github.com/apache/spark/pull/33216#issuecomment-874784435 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45214/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33217: [SPARK-36023][SPARK-35735][SPARK-35768][SQL] Refactor code about parse string to DT/YM

2021-07-06 Thread GitBox
AmplabJenkins removed a comment on pull request #33217: URL: https://github.com/apache/spark/pull/33217#issuecomment-874784431 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140698/

[GitHub] [spark] AmplabJenkins commented on pull request #33217: [SPARK-36023][SPARK-35735][SPARK-35768][SQL] Refactor code about parse string to DT/YM

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33217: URL: https://github.com/apache/spark/pull/33217#issuecomment-874784431 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140698/ -- This

[GitHub] [spark] AmplabJenkins commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core

2021-07-06 Thread GitBox
AmplabJenkins commented on pull request #33216: URL: https://github.com/apache/spark/pull/33216#issuecomment-874784435 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45214/ --

[GitHub] [spark] SparkQA removed a comment on pull request #33217: [SPARK-36023][SPARK-35735][SPARK-35768][SQL] Refactor code about parse string to DT/YM

2021-07-06 Thread GitBox
SparkQA removed a comment on pull request #33217: URL: https://github.com/apache/spark/pull/33217#issuecomment-874598517 **[Test build #140698 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140698/testReport)** for PR 33217 at commit

[GitHub] [spark] SparkQA commented on pull request #33217: [SPARK-36023][SPARK-35735][SPARK-35768][SQL] Refactor code about parse string to DT/YM

2021-07-06 Thread GitBox
SparkQA commented on pull request #33217: URL: https://github.com/apache/spark/pull/33217#issuecomment-874776334 **[Test build #140698 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/140698/testReport)** for PR 33217 at commit

[GitHub] [spark] SparkQA commented on pull request #33216: [SPARK-36018][CORE][SQL] Some Improvement for Spark Core

2021-07-06 Thread GitBox
SparkQA commented on pull request #33216: URL: https://github.com/apache/spark/pull/33216#issuecomment-874768818 Kubernetes integration test unable to build dist. exiting with code: 1 URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45214/ --

[GitHub] [spark] cloud-fan commented on a change in pull request #33182: [SPARK-35984][SQL] Config to force applying shuffled hash join

2021-07-06 Thread GitBox
cloud-fan commented on a change in pull request #33182: URL: https://github.com/apache/spark/pull/33182#discussion_r664559822 ## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala ## @@ -274,14 +275,17 @@ trait JoinSelectionHelper {

<    1   2   3   4   5   6   7   8   9   10   >