[GitHub] [spark] SparkQA commented on pull request #34636: [WIP][SPARK-37359][K8S] Cleanup the Spark Kubernetes Integration tests

2021-12-19 Thread GitBox
SparkQA commented on pull request #34636: URL: https://github.com/apache/spark/pull/34636#issuecomment-997682034 **[Test build #146393 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146393/testReport)** for PR 34636 at commit

[GitHub] [spark] SparkQA removed a comment on pull request #34904: [SPARK-37644][SQL] Support datasource v2 complete aggregate pushdown

2021-12-19 Thread GitBox
SparkQA removed a comment on pull request #34904: URL: https://github.com/apache/spark/pull/34904#issuecomment-997544960 **[Test build #146384 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146384/testReport)** for PR 34904 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34904: [SPARK-37644][SQL] Support datasource v2 complete aggregate pushdown

2021-12-19 Thread GitBox
AmplabJenkins removed a comment on pull request #34904: URL: https://github.com/apache/spark/pull/34904#issuecomment-997680343 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146384/

[GitHub] [spark] AmplabJenkins commented on pull request #34904: [SPARK-37644][SQL] Support datasource v2 complete aggregate pushdown

2021-12-19 Thread GitBox
AmplabJenkins commented on pull request #34904: URL: https://github.com/apache/spark/pull/34904#issuecomment-997680343 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146384/ -- This

[GitHub] [spark] SparkQA commented on pull request #34904: [SPARK-37644][SQL] Support datasource v2 complete aggregate pushdown

2021-12-19 Thread GitBox
SparkQA commented on pull request #34904: URL: https://github.com/apache/spark/pull/34904#issuecomment-997677240 **[Test build #146384 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146384/testReport)** for PR 34904 at commit

[GitHub] [spark] AmplabJenkins commented on pull request #34956: [SPARK-37688][CORE] ExecutorMonitor should ignore SparkListenerBlockUpdated event if executor was not active

2021-12-19 Thread GitBox
AmplabJenkins commented on pull request #34956: URL: https://github.com/apache/spark/pull/34956#issuecomment-997676462 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] sleep1661 opened a new pull request #34956: [SPARK-37688][CORE] ExecutorMonitor should ignore SparkListenerBlockUpdated event if executor was not active

2021-12-19 Thread GitBox
sleep1661 opened a new pull request #34956: URL: https://github.com/apache/spark/pull/34956 ### What changes were proposed in this pull request? `ExecutorMonitor` should ignore `SparkListenerBlockUpdated` event if executor was not active ### Why are the changes

[GitHub] [spark] SparkQA commented on pull request #34636: [WIP][SPARK-37359][K8S] Cleanup the Spark Kubernetes Integration tests

2021-12-19 Thread GitBox
SparkQA commented on pull request #34636: URL: https://github.com/apache/spark/pull/34636#issuecomment-997673825 **[Test build #146393 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146393/testReport)** for PR 34636 at commit

[GitHub] [spark] SparkQA commented on pull request #34894: [WIP][SPARK-37641][SQL] Support ANSI Aggregate Function: regr_r2

2021-12-19 Thread GitBox
SparkQA commented on pull request #34894: URL: https://github.com/apache/spark/pull/34894#issuecomment-997673594 **[Test build #146391 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146391/testReport)** for PR 34894 at commit

[GitHub] [spark] SparkQA commented on pull request #34868: [SPARK-37614][SQL] Support ANSI Aggregate Function: regr_avgx & regr_avgy

2021-12-19 Thread GitBox
SparkQA commented on pull request #34868: URL: https://github.com/apache/spark/pull/34868#issuecomment-997673627 **[Test build #146392 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146392/testReport)** for PR 34868 at commit

[GitHub] [spark] SparkQA commented on pull request #34931: [SPARK-37657][PYTHON] Support str and timestamp for (Series|DataFrame).describe()

2021-12-19 Thread GitBox
SparkQA commented on pull request #34931: URL: https://github.com/apache/spark/pull/34931#issuecomment-997673532 **[Test build #146390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146390/testReport)** for PR 34931 at commit

[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
SparkQA commented on pull request #34939: URL: https://github.com/apache/spark/pull/34939#issuecomment-997673460 **[Test build #146389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146389/testReport)** for PR 34939 at commit

[GitHub] [spark] SparkQA commented on pull request #34943: [WIP][SPARK-37672][SQL] Support ANSI Aggregate Function: regr_sxx

2021-12-19 Thread GitBox
SparkQA commented on pull request #34943: URL: https://github.com/apache/spark/pull/34943#issuecomment-997673445 **[Test build #146388 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146388/testReport)** for PR 34943 at commit

[GitHub] [spark] SparkQA commented on pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation

2021-12-19 Thread GitBox
SparkQA commented on pull request #34954: URL: https://github.com/apache/spark/pull/34954#issuecomment-997673438 **[Test build #146387 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146387/testReport)** for PR 34954 at commit

[GitHub] [spark] beliefer closed pull request #34955: [SPARK-37613][SQL][FOLLOWUP] Correct the comment of regr_count

2021-12-19 Thread GitBox
beliefer closed pull request #34955: URL: https://github.com/apache/spark/pull/34955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] beliefer opened a new pull request #34955: [SPARK-37613][SQL][FOLLOWUP] Correct the comment of regr_count

2021-12-19 Thread GitBox
beliefer opened a new pull request #34955: URL: https://github.com/apache/spark/pull/34955 ### What changes were proposed in this pull request? https://github.com/apache/spark/pull/34880 exists a mistake of comment. This PR used to fix it. ### Why are the changes needed?

[GitHub] [spark] Ngone51 commented on pull request #34749: [SPARK-37493][CORE] show gc time and duration time of driver in executors page

2021-12-19 Thread GitBox
Ngone51 commented on pull request #34749: URL: https://github.com/apache/spark/pull/34749#issuecomment-997656742 Which `duration`? @summaryzb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [spark] LuciferYang removed a comment on pull request #34941: [SPARK-6305][BUILD][FOLLOWUP] Remove log4j1 properties files

2021-12-19 Thread GitBox
LuciferYang removed a comment on pull request #34941: URL: https://github.com/apache/spark/pull/34941#issuecomment-997653269 When I run ``` mvn clean install -pl repl -Dtest=none -DwildcardSuites=org.apache.spark.repl.ReplSuite -am ``` There is one case failed: ``` -

[GitHub] [spark] Ngone51 commented on a change in pull request #34834: [SPARK-37580][CORE] Reset numFailures when one of task attempts succeeds

2021-12-19 Thread GitBox
Ngone51 commented on a change in pull request #34834: URL: https://github.com/apache/spark/pull/34834#discussion_r772123161 ## File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ## @@ -820,6 +820,7 @@ private[spark] class TaskSetManager(

[GitHub] [spark] LuciferYang commented on pull request #34941: [SPARK-6305][BUILD][FOLLOWUP] Remove log4j1 properties files

2021-12-19 Thread GitBox
LuciferYang commented on pull request #34941: URL: https://github.com/apache/spark/pull/34941#issuecomment-997653269 When I run ``` mvn clean install -pl repl -Dtest=none -DwildcardSuites=org.apache.spark.repl.ReplSuite -am ``` There is one case failed: ``` -

[GitHub] [spark] Yikun commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
Yikun commented on pull request #34939: URL: https://github.com/apache/spark/pull/34939#issuecomment-997649373 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] Yikun commented on pull request #34636: [WIP][SPARK-37359][K8S] Cleanup the Spark Kubernetes Integration tests

2021-12-19 Thread GitBox
Yikun commented on pull request #34636: URL: https://github.com/apache/spark/pull/34636#issuecomment-997649166 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] WangGuangxin commented on a change in pull request #34846: [SPARK-37593][CORE] Optimize HeapMemoryAllocator to avoid memory waste when using G1GC

2021-12-19 Thread GitBox
WangGuangxin commented on a change in pull request #34846: URL: https://github.com/apache/spark/pull/34846#discussion_r772120430 ## File path: core/src/main/scala/org/apache/spark/memory/MemoryManager.scala ## @@ -255,7 +256,17 @@ private[spark] abstract class MemoryManager(

[GitHub] [spark] AngersZhuuuu opened a new pull request #34954: [SPARK-37689][SQL] Expand should be supported in PropagateEmptyRelation

2021-12-19 Thread GitBox
AngersZh opened a new pull request #34954: URL: https://github.com/apache/spark/pull/34954 ### What changes were proposed in this pull request? We meet a case that when there is a empty relation, HashAggregateExec still triggered to execute and return an empty result. It's not

[GitHub] [spark] Yikun commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
Yikun commented on pull request #34939: URL: https://github.com/apache/spark/pull/34939#issuecomment-997648029 cc @dongjoon-hyun @holdenk @attilapiros -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
AmplabJenkins removed a comment on pull request #34939: URL: https://github.com/apache/spark/pull/34939#issuecomment-997639341 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146386/

[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
AmplabJenkins commented on pull request #34939: URL: https://github.com/apache/spark/pull/34939#issuecomment-997639341 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146386/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
SparkQA removed a comment on pull request #34939: URL: https://github.com/apache/spark/pull/34939#issuecomment-997567567 **[Test build #146386 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146386/testReport)** for PR 34939 at commit

[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
SparkQA commented on pull request #34939: URL: https://github.com/apache/spark/pull/34939#issuecomment-997631843 **[Test build #146386 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146386/testReport)** for PR 34939 at commit

[GitHub] [spark] Yikun removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
Yikun removed a comment on pull request #34939: URL: https://github.com/apache/spark/pull/34939#issuecomment-997555454 cc @dongjoon-hyun @holdenk @attilapiros -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] summaryzb commented on pull request #34749: [SPARK-37493][CORE] show gc time and duration time of driver in executors page

2021-12-19 Thread GitBox
summaryzb commented on pull request #34749: URL: https://github.com/apache/spark/pull/34749#issuecomment-997620730 > Hi @summaryzb Just wonder why the `Task Time` is 1.9 min while the `Total Tasks` of the driver is 0? This pr aims at showing `gc time` and `duration time`(equivalent

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34575: [SPARK-37273][SQL] Support hidden file metadata columns in Spark SQL

2021-12-19 Thread GitBox
AmplabJenkins removed a comment on pull request #34575: URL: https://github.com/apache/spark/pull/34575#issuecomment-997619598 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146383/

[GitHub] [spark] AmplabJenkins commented on pull request #34575: [SPARK-37273][SQL] Support hidden file metadata columns in Spark SQL

2021-12-19 Thread GitBox
AmplabJenkins commented on pull request #34575: URL: https://github.com/apache/spark/pull/34575#issuecomment-997619598 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146383/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #34575: [SPARK-37273][SQL] Support hidden file metadata columns in Spark SQL

2021-12-19 Thread GitBox
SparkQA removed a comment on pull request #34575: URL: https://github.com/apache/spark/pull/34575#issuecomment-997498035 **[Test build #146383 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146383/testReport)** for PR 34575 at commit

[GitHub] [spark] SparkQA commented on pull request #34575: [SPARK-37273][SQL] Support hidden file metadata columns in Spark SQL

2021-12-19 Thread GitBox
SparkQA commented on pull request #34575: URL: https://github.com/apache/spark/pull/34575#issuecomment-997617358 **[Test build #146383 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146383/testReport)** for PR 34575 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
AmplabJenkins removed a comment on pull request #34939: URL: https://github.com/apache/spark/pull/34939#issuecomment-997613126 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50861/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-12-19 Thread GitBox
AmplabJenkins removed a comment on pull request #33628: URL: https://github.com/apache/spark/pull/33628#issuecomment-997613127 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146385/

[GitHub] [spark] AmplabJenkins commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
AmplabJenkins commented on pull request #34939: URL: https://github.com/apache/spark/pull/34939#issuecomment-997613126 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50861/ --

[GitHub] [spark] AmplabJenkins commented on pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-12-19 Thread GitBox
AmplabJenkins commented on pull request #33628: URL: https://github.com/apache/spark/pull/33628#issuecomment-997613127 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146385/ -- This

[GitHub] [spark] SparkQA removed a comment on pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-12-19 Thread GitBox
SparkQA removed a comment on pull request #33628: URL: https://github.com/apache/spark/pull/33628#issuecomment-997545379 **[Test build #146385 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146385/testReport)** for PR 33628 at commit

[GitHub] [spark] SparkQA commented on pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-12-19 Thread GitBox
SparkQA commented on pull request #33628: URL: https://github.com/apache/spark/pull/33628#issuecomment-997606796 **[Test build #146385 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146385/testReport)** for PR 33628 at commit

[GitHub] [spark] beliefer commented on a change in pull request #34941: [SPARK-6305][BUILD][FOLLOWUP] Remove log4j1 properties files

2021-12-19 Thread GitBox
beliefer commented on a change in pull request #34941: URL: https://github.com/apache/spark/pull/34941#discussion_r772085707 ## File path: conf/log4j2.properties.template ## @@ -0,0 +1,63 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
SparkQA commented on pull request #34939: URL: https://github.com/apache/spark/pull/34939#issuecomment-997606035 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50861/ -- This is an automated message from the

[GitHub] [spark] beliefer commented on pull request #34941: [SPARK-6305][BUILD][FOLLOWUP] Remove log4j1 properties files

2021-12-19 Thread GitBox
beliefer commented on pull request #34941: URL: https://github.com/apache/spark/pull/34941#issuecomment-997605728 It seems the migration makes break change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AmplabJenkins commented on pull request #34953: [SPARK-37682][SQL][WIP]Apply 'merged column' and 'bit vector' in RewriteDistinctAggregates

2021-12-19 Thread GitBox
AmplabJenkins commented on pull request #34953: URL: https://github.com/apache/spark/pull/34953#issuecomment-997590938 Can one of the admins verify this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-12-19 Thread GitBox
AmplabJenkins removed a comment on pull request #33628: URL: https://github.com/apache/spark/pull/33628#issuecomment-997590519 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50860/

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34904: [SPARK-37644][SQL] Support datasource v2 complete aggregate pushdown

2021-12-19 Thread GitBox
AmplabJenkins removed a comment on pull request #34904: URL: https://github.com/apache/spark/pull/34904#issuecomment-997590518 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50859/

[GitHub] [spark] AmplabJenkins commented on pull request #34904: [SPARK-37644][SQL] Support datasource v2 complete aggregate pushdown

2021-12-19 Thread GitBox
AmplabJenkins commented on pull request #34904: URL: https://github.com/apache/spark/pull/34904#issuecomment-997590518 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50859/ --

[GitHub] [spark] AmplabJenkins commented on pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-12-19 Thread GitBox
AmplabJenkins commented on pull request #33628: URL: https://github.com/apache/spark/pull/33628#issuecomment-997590519 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50860/ --

[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
SparkQA commented on pull request #34939: URL: https://github.com/apache/spark/pull/34939#issuecomment-997583381 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50861/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34904: [SPARK-37644][SQL] Support datasource v2 complete aggregate pushdown

2021-12-19 Thread GitBox
SparkQA commented on pull request #34904: URL: https://github.com/apache/spark/pull/34904#issuecomment-997582331 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50859/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-12-19 Thread GitBox
SparkQA commented on pull request #33628: URL: https://github.com/apache/spark/pull/33628#issuecomment-997581961 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50860/ -- This is an automated message from the

[GitHub] [spark] LuciferYang commented on a change in pull request #34895: [SPARK-6305][BUILD] Migrate from log4j1 to log4j2

2021-12-19 Thread GitBox
LuciferYang commented on a change in pull request #34895: URL: https://github.com/apache/spark/pull/34895#discussion_r772067137 ## File path: launcher/src/test/java/org/apache/spark/launcher/ChildProcAppHandleSuite.java ## @@ -238,22 +242,29 @@ String findSparkSubmit() {

[GitHub] [spark] Flyangz opened a new pull request #34953: [SPARK-37682][SQL][WIP]Apply 'merged column' and 'bit vector' in RewriteDistinctAggregates

2021-12-19 Thread GitBox
Flyangz opened a new pull request #34953: URL: https://github.com/apache/spark/pull/34953 ### What changes were proposed in this pull request? Adjust the grouping rules of `distinctAggGroups`, specifically in `RewriteDistinctAggregates.groupDistinctAggExpr`, so that some 'distinct' can

[GitHub] [spark] srowen commented on a change in pull request #34895: [SPARK-6305][BUILD] Migrate from log4j1 to log4j2

2021-12-19 Thread GitBox
srowen commented on a change in pull request #34895: URL: https://github.com/apache/spark/pull/34895#discussion_r772066437 ## File path: launcher/src/test/java/org/apache/spark/launcher/ChildProcAppHandleSuite.java ## @@ -238,22 +242,29 @@ String findSparkSubmit() { * A

[GitHub] [spark] SparkQA commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
SparkQA commented on pull request #34939: URL: https://github.com/apache/spark/pull/34939#issuecomment-997567567 **[Test build #146386 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146386/testReport)** for PR 34939 at commit

[GitHub] [spark] AngersZhuuuu closed pull request #33716: [SPARK-36485][SQL] Support cast type constructed string as year month interval

2021-12-19 Thread GitBox
AngersZh closed pull request #33716: URL: https://github.com/apache/spark/pull/33716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] AngersZhuuuu commented on pull request #34326: [SPARK-37053][CORE] Add metrics to SparkHistoryServer

2021-12-19 Thread GitBox
AngersZh commented on pull request #34326: URL: https://github.com/apache/spark/pull/34326#issuecomment-997564772 Can any committer review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] AngersZhuuuu closed pull request #34448: [SPARK-37169][SQL] Fix incorrect cast value when cast DateType to NumericType

2021-12-19 Thread GitBox
AngersZh closed pull request #34448: URL: https://github.com/apache/spark/pull/34448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] AngersZhuuuu removed a comment on pull request #34616: [SPARK-37344][SQL][DOC] spark-sql cli will keep `\` when match `\;` after spark3

2021-12-19 Thread GitBox
AngersZh removed a comment on pull request #34616: URL: https://github.com/apache/spark/pull/34616#issuecomment-995389792 ping @wangyum -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] AngersZhuuuu commented on pull request #34616: [SPARK-37344][SQL][DOC] spark-sql cli will keep `\` when match `\;` after spark3

2021-12-19 Thread GitBox
AngersZh commented on pull request #34616: URL: https://github.com/apache/spark/pull/34616#issuecomment-997564223 ping @wangyum -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] AngersZhuuuu commented on pull request #34453: [SPARK-37173][SQL] SparkGetFunctionOperation return builtin function only once

2021-12-19 Thread GitBox
AngersZh commented on pull request #34453: URL: https://github.com/apache/spark/pull/34453#issuecomment-997564071 Any more suggestion? also cc @wangyum -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] AngersZhuuuu commented on pull request #34695: [SPARK-32446][CORE] Add percentile distribution REST API & UI of peak memory metrics for all executors

2021-12-19 Thread GitBox
AngersZh commented on pull request #34695: URL: https://github.com/apache/spark/pull/34695#issuecomment-997563847 Any more suggestion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] SparkQA commented on pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-12-19 Thread GitBox
SparkQA commented on pull request #33628: URL: https://github.com/apache/spark/pull/33628#issuecomment-997561122 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50860/ -- This is an automated message from the Apache

[GitHub] [spark] SparkQA commented on pull request #34904: [SPARK-37644][SQL] Support datasource v2 complete aggregate pushdown

2021-12-19 Thread GitBox
SparkQA commented on pull request #34904: URL: https://github.com/apache/spark/pull/34904#issuecomment-997560590 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50859/ -- This is an automated message from the Apache

[GitHub] [spark] LuciferYang commented on a change in pull request #34941: [SPARK-6305][BUILD][FOLLOWUP] Remove log4j1 properties files

2021-12-19 Thread GitBox
LuciferYang commented on a change in pull request #34941: URL: https://github.com/apache/spark/pull/34941#discussion_r772057033 ## File path: conf/log4j2.properties.template ## @@ -0,0 +1,63 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [spark] LuciferYang commented on a change in pull request #34941: [SPARK-6305][BUILD][FOLLOWUP] Remove log4j1 properties files

2021-12-19 Thread GitBox
LuciferYang commented on a change in pull request #34941: URL: https://github.com/apache/spark/pull/34941#discussion_r772057033 ## File path: conf/log4j2.properties.template ## @@ -0,0 +1,63 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [spark] LuciferYang commented on a change in pull request #34941: [SPARK-6305][BUILD][FOLLOWUP] Remove log4j1 properties files

2021-12-19 Thread GitBox
LuciferYang commented on a change in pull request #34941: URL: https://github.com/apache/spark/pull/34941#discussion_r772057033 ## File path: conf/log4j2.properties.template ## @@ -0,0 +1,63 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [spark] Yikun commented on a change in pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
Yikun commented on a change in pull request #34939: URL: https://github.com/apache/spark/pull/34939#discussion_r772055958 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala ## @@ -68,6 +69,8 @@

[GitHub] [spark] Yikun commented on pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
Yikun commented on pull request #34939: URL: https://github.com/apache/spark/pull/34939#issuecomment-997555454 cc @dongjoon-hyun @holdenk @attilapiros -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [spark] Yikun commented on a change in pull request #34939: [SPARK-37258][K8S][BUILD] Upgrade kubernetes-client to 5.11.0

2021-12-19 Thread GitBox
Yikun commented on a change in pull request #34939: URL: https://github.com/apache/spark/pull/34939#discussion_r772055958 ## File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala ## @@ -68,6 +69,8 @@

[GitHub] [spark] LuciferYang commented on a change in pull request #34895: [SPARK-6305][BUILD] Migrate from log4j1 to log4j2

2021-12-19 Thread GitBox
LuciferYang commented on a change in pull request #34895: URL: https://github.com/apache/spark/pull/34895#discussion_r772053180 ## File path: launcher/src/test/java/org/apache/spark/launcher/ChildProcAppHandleSuite.java ## @@ -238,22 +242,29 @@ String findSparkSubmit() {

[GitHub] [spark] SparkQA commented on pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-12-19 Thread GitBox
SparkQA commented on pull request #33628: URL: https://github.com/apache/spark/pull/33628#issuecomment-997545379 **[Test build #146385 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146385/testReport)** for PR 33628 at commit

[GitHub] [spark] SparkQA commented on pull request #34904: [SPARK-37644][SQL] Support datasource v2 complete aggregate pushdown

2021-12-19 Thread GitBox
SparkQA commented on pull request #34904: URL: https://github.com/apache/spark/pull/34904#issuecomment-997544960 **[Test build #146384 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146384/testReport)** for PR 34904 at commit

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34575: [SPARK-37273][SQL] Support hidden file metadata columns in Spark SQL

2021-12-19 Thread GitBox
AmplabJenkins removed a comment on pull request #34575: URL: https://github.com/apache/spark/pull/34575#issuecomment-997543769 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50858/

[GitHub] [spark] LuciferYang commented on pull request #34942: [SPARK-37680][CORE] Support RocksDB backend in Spark History Server

2021-12-19 Thread GitBox
LuciferYang commented on pull request #34942: URL: https://github.com/apache/spark/pull/34942#issuecomment-997543951 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] AmplabJenkins commented on pull request #34575: [SPARK-37273][SQL] Support hidden file metadata columns in Spark SQL

2021-12-19 Thread GitBox
AmplabJenkins commented on pull request #34575: URL: https://github.com/apache/spark/pull/34575#issuecomment-997543769 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50858/ --

[GitHub] [spark] LuciferYang commented on a change in pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-12-19 Thread GitBox
LuciferYang commented on a change in pull request #33628: URL: https://github.com/apache/spark/pull/33628#discussion_r772045868 ## File path: core/src/main/scala/org/apache/spark/storage/DiskBlockObjectWriter.scala ## @@ -272,6 +279,25 @@ private[spark] class

[GitHub] [spark] LuciferYang commented on a change in pull request #33628: [SPARK-36406][CORE] Avoid unnecessary file operations before delete a write failed file held by DiskBlockObjectWriter

2021-12-19 Thread GitBox
LuciferYang commented on a change in pull request #33628: URL: https://github.com/apache/spark/pull/33628#discussion_r772045307 ## File path: core/src/main/scala/org/apache/spark/storage/DiskBlockObjectWriter.scala ## @@ -272,6 +279,25 @@ private[spark] class

[GitHub] [spark] SparkQA commented on pull request #34575: [SPARK-37273][SQL] Support hidden file metadata columns in Spark SQL

2021-12-19 Thread GitBox
SparkQA commented on pull request #34575: URL: https://github.com/apache/spark/pull/34575#issuecomment-997536317 Kubernetes integration test status failure URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50858/ -- This is an automated message from the

[GitHub] [spark] SparkQA commented on pull request #34575: [SPARK-37273][SQL] Support hidden file metadata columns in Spark SQL

2021-12-19 Thread GitBox
SparkQA commented on pull request #34575: URL: https://github.com/apache/spark/pull/34575#issuecomment-997514370 Kubernetes integration test starting URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50858/ -- This is an automated message from the Apache

[GitHub] [spark] dchvn commented on pull request #34673: [SPARK-37343][SQL] Implement createIndex, IndexExists and dropIndex in JDBC (Postgres dialect)

2021-12-19 Thread GitBox
dchvn commented on pull request #34673: URL: https://github.com/apache/spark/pull/34673#issuecomment-997509360 Thank you!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] HyukjinKwon commented on a change in pull request #34745: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context

2021-12-19 Thread GitBox
HyukjinKwon commented on a change in pull request #34745: URL: https://github.com/apache/spark/pull/34745#discussion_r772029590 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcConnectionProvider.scala ## @@ -53,12 +53,25 @@ abstract class

[GitHub] [spark] dchvn commented on pull request #34678: [SPARK-37407][PYTHON] Inline type hints for python/pyspark/ml/functions.py

2021-12-19 Thread GitBox
dchvn commented on pull request #34678: URL: https://github.com/apache/spark/pull/34678#issuecomment-997505515 cc @zero323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] itholic commented on a change in pull request #34931: [SPARK-37657][PYTHON] Support str and timestamp for (Series|DataFrame).describe()

2021-12-19 Thread GitBox
itholic commented on a change in pull request #34931: URL: https://github.com/apache/spark/pull/34931#discussion_r772029264 ## File path: python/pyspark/pandas/frame.py ## @@ -8828,22 +8842,108 @@ def describe(self, percentiles: Optional[List[float]] = None) -> "DataFrame":

[GitHub] [spark] HyukjinKwon commented on a change in pull request #34745: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context

2021-12-19 Thread GitBox
HyukjinKwon commented on a change in pull request #34745: URL: https://github.com/apache/spark/pull/34745#discussion_r772029246 ## File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcConnectionProvider.scala ## @@ -53,12 +53,25 @@ abstract class

[GitHub] [spark] HyukjinKwon commented on pull request #34745: [SPARK-37391][SQL]JdbcConnectionProvider tells if it modifies security context

2021-12-19 Thread GitBox
HyukjinKwon commented on pull request #34745: URL: https://github.com/apache/spark/pull/34745#issuecomment-997504813 @tdg5, thanks i think it's getting closer to be merged. but just to be sure, would you mind enabling GitHub Actions in your forked repository? See also

[GitHub] [spark] HyukjinKwon commented on a change in pull request #34931: [SPARK-37657][PYTHON] Support str and timestamp for (Series|DataFrame).describe()

2021-12-19 Thread GitBox
HyukjinKwon commented on a change in pull request #34931: URL: https://github.com/apache/spark/pull/34931#discussion_r772027226 ## File path: python/pyspark/pandas/frame.py ## @@ -8828,22 +8842,108 @@ def describe(self, percentiles: Optional[List[float]] = None) ->

[GitHub] [spark] viirya closed pull request #34941: [SPARK-6305][BUILD][FOLLOWUP] Remove log4j1 properties files

2021-12-19 Thread GitBox
viirya closed pull request #34941: URL: https://github.com/apache/spark/pull/34941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] viirya commented on pull request #34941: [SPARK-6305][BUILD][FOLLOWUP] Remove log4j1 properties files

2021-12-19 Thread GitBox
viirya commented on pull request #34941: URL: https://github.com/apache/spark/pull/34941#issuecomment-997498509 Thanks. Merging to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] HyukjinKwon closed pull request #34952: [MINOR][PYTHON][DOCS] Fix some typos in docstrings and messages

2021-12-19 Thread GitBox
HyukjinKwon closed pull request #34952: URL: https://github.com/apache/spark/pull/34952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] SparkQA commented on pull request #34575: [SPARK-37273][SQL] Support hidden file metadata columns in Spark SQL

2021-12-19 Thread GitBox
SparkQA commented on pull request #34575: URL: https://github.com/apache/spark/pull/34575#issuecomment-997498035 **[Test build #146383 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146383/testReport)** for PR 34575 at commit

[GitHub] [spark] HyukjinKwon commented on pull request #34952: [MINOR][PYTHON][DOCS] Fix some typos in docstrings and messages

2021-12-19 Thread GitBox
HyukjinKwon commented on pull request #34952: URL: https://github.com/apache/spark/pull/34952#issuecomment-997498092 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] AmplabJenkins removed a comment on pull request #34941: [SPARK-6305][BUILD][FOLLOWUP] Remove log4j1 properties files

2021-12-19 Thread GitBox
AmplabJenkins removed a comment on pull request #34941: URL: https://github.com/apache/spark/pull/34941#issuecomment-997496562 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146382/

[GitHub] [spark] AmplabJenkins commented on pull request #34941: [SPARK-6305][BUILD][FOLLOWUP] Remove log4j1 properties files

2021-12-19 Thread GitBox
AmplabJenkins commented on pull request #34941: URL: https://github.com/apache/spark/pull/34941#issuecomment-997496562 Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146382/ -- This

[GitHub] [spark] HyukjinKwon commented on pull request #34951: [SPARK-37686][PYTHON][SQL] Use _invoke_function helpers for all pyspark.sql.functions

2021-12-19 Thread GitBox
HyukjinKwon commented on pull request #34951: URL: https://github.com/apache/spark/pull/34951#issuecomment-997495351 Wow .. this is a big change. cc @ueshin @BryanCutler @viirya too FYI. I will review this closely within this week  -- This is an automated message from the Apache Git

[GitHub] [spark] SparkQA removed a comment on pull request #34941: [SPARK-6305][BUILD][FOLLOWUP] Remove log4j1 properties files

2021-12-19 Thread GitBox
SparkQA removed a comment on pull request #34941: URL: https://github.com/apache/spark/pull/34941#issuecomment-997466121 **[Test build #146382 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146382/testReport)** for PR 34941 at commit

[GitHub] [spark] SparkQA commented on pull request #34941: [SPARK-6305][BUILD][FOLLOWUP] Remove log4j1 properties files

2021-12-19 Thread GitBox
SparkQA commented on pull request #34941: URL: https://github.com/apache/spark/pull/34941#issuecomment-997493932 **[Test build #146382 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146382/testReport)** for PR 34941 at commit

[GitHub] [spark] github-actions[bot] closed pull request #33339: [SPARK-36133][SQL] Add empty check for catalog name

2021-12-19 Thread GitBox
github-actions[bot] closed pull request #9: URL: https://github.com/apache/spark/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [spark] github-actions[bot] commented on pull request #33946: [SPARK-36703][SQL] Remove the Sort if it is the child of RepartitionByExpression

2021-12-19 Thread GitBox
github-actions[bot] commented on pull request #33946: URL: https://github.com/apache/spark/pull/33946#issuecomment-997490120 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue

  1   2   3   >