[GitHub] [spark] cloud-fan commented on pull request #36662: [SPARK-39286][DOC] Update documentation for the decode function

2022-06-07 Thread GitBox
cloud-fan commented on PR #36662: URL: https://github.com/apache/spark/pull/36662#issuecomment-1148337126 thanks, merging to master/3.3! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] Ngone51 commented on pull request #36716: [SPARK-39062][CORE] Add stage level resource scheduling support for standalone cluster

2022-06-07 Thread GitBox
Ngone51 commented on PR #36716: URL: https://github.com/apache/spark/pull/36716#issuecomment-1148335486 cc @tgravescs for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [spark] LuciferYang closed pull request #36732: [SPARK-39345][CORE][SQL][DSTREAM][ML][MESOS][SS] Replace `filter(!condition)` with `filterNot(condition)`

2022-06-07 Thread GitBox
LuciferYang closed pull request #36732: [SPARK-39345][CORE][SQL][DSTREAM][ML][MESOS][SS] Replace `filter(!condition)` with `filterNot(condition)` URL: https://github.com/apache/spark/pull/36732 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [spark] ulysses-you opened a new pull request, #36785: [SPARK-39397][SQL] Relax AliasAwareOutputExpression to support alias with expression

2022-06-07 Thread GitBox
ulysses-you opened a new pull request, #36785: URL: https://github.com/apache/spark/pull/36785 ### What changes were proposed in this pull request? Change AliasAwareOutputExpression to using expression rather than attribute to track if we can nomalize. So the aliased

[GitHub] [spark] HyukjinKwon commented on pull request #36784: [SPARK-39396][SQL] Fix LDAP login exception 'error code 49 - invalid credentials'

2022-06-07 Thread GitBox
HyukjinKwon commented on PR #36784: URL: https://github.com/apache/spark/pull/36784#issuecomment-1148308085 cc @wangyum FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [spark] Resol1992 commented on pull request #30317: [SPARK-33409][SQL] And task killed check in BroadcastNestedLoopJoin to interrupt it after the job is killed

2022-06-07 Thread GitBox
Resol1992 commented on PR #30317: URL: https://github.com/apache/spark/pull/30317#issuecomment-1148301891 hi, @constzhou Recently, the same issue aslo occurs to me, could I talk with you about this issue? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [spark] cloud-fan commented on pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear

2022-06-07 Thread GitBox
cloud-fan commented on PR #35612: URL: https://github.com/apache/spark/pull/35612#issuecomment-1148292841 @AngersZh can you retrigger the tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] cloud-fan commented on a diff in pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear

2022-06-07 Thread GitBox
cloud-fan commented on code in PR #35612: URL: https://github.com/apache/spark/pull/35612#discussion_r890851508 ## sql/hive-thriftserver/src/main/java/org/apache/hive/service/server/HiveServer2.java: ## @@ -259,7 +260,7 @@ static class HelpOptionExecutor implements

[GitHub] [spark] Borjianamin98 commented on pull request #36781: [SPARK-39393][SQL] Parquet data source only supports push-down predicate filters for non-repeated primitive types

2022-06-07 Thread GitBox
Borjianamin98 commented on PR #36781: URL: https://github.com/apache/spark/pull/36781#issuecomment-1148284070 > @Borjianamin98 Could you please add a test? I agree. I added a test for this. This is my first experience participating in the Spark project and I hope I did well. :) --

[GitHub] [spark] ArvinZheng commented on a diff in pull request #35484: [SPARK-38181][SS][DOCS] Update comments in KafkaDataConsumer.scala

2022-06-07 Thread GitBox
ArvinZheng commented on code in PR #35484: URL: https://github.com/apache/spark/pull/35484#discussion_r890843318 ## connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/consumer/KafkaDataConsumer.scala: ## @@ -298,9 +296,10 @@ private[kafka010] class

[GitHub] [spark] olaky commented on pull request #36762: [SPARK-39259][SQL][TEST][FOLLOWUP] Fix Scala 2.13 `ClassCastException` in `ComputeCurrentTimeSuite`

2022-06-07 Thread GitBox
olaky commented on PR #36762: URL: https://github.com/apache/spark/pull/36762#issuecomment-1148259858 @dongjoon-hyun thanks a lot for picking this up for me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] olaky commented on pull request #36753: [SPARK-39259][SQL][3.2] Evaluate timestamps consistently in subqueries

2022-06-07 Thread GitBox
olaky commented on PR #36753: URL: https://github.com/apache/spark/pull/36753#issuecomment-1148258363 I cherry-picked 583a9c75bbb35387169d4f0cf763ef566d899954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [spark] zhengruifeng commented on pull request #35250: [SPARK-37961][SQL] Override maxRows/maxRowsPerPartition for some logical operators

2022-06-07 Thread GitBox
zhengruifeng commented on PR #35250: URL: https://github.com/apache/spark/pull/35250#issuecomment-1148255084 @cloud-fan Sure, Let me update this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [spark] LuciferYang commented on pull request #36732: [SPARK-39345][CORE][SQL][DSTREAM][ML][MESOS][SS] Replace `filter(!condition)` with `filterNot(condition)`

2022-06-07 Thread GitBox
LuciferYang commented on PR #36732: URL: https://github.com/apache/spark/pull/36732#issuecomment-1148250861 > No, we wouldn't backport this, that's more change. Does this offer any benefit? I'm not sure it's more readable even. If the readability is not improved, let me close this

[GitHub] [spark] shiyuhang0 commented on pull request #21990: [SPARK-25003][PYSPARK] Use SessionExtensions in Pyspark

2022-06-07 Thread GitBox
shiyuhang0 commented on PR #21990: URL: https://github.com/apache/spark/pull/21990#issuecomment-1148248826 Why not port it to Spark < 3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [spark] beliefer commented on a diff in pull request #36776: [SPARK-38997][SPARK-39037][SQL][FOLLOWUP] `PushableColumnWithoutNestedColumn` need be translated to predicate too

2022-06-07 Thread GitBox
beliefer commented on code in PR #36776: URL: https://github.com/apache/spark/pull/36776#discussion_r890808786 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -55,8 +55,13 @@ class V2ExpressionBuilder( } else {

[GitHub] [spark] AngersZhuuuu commented on pull request #35612: [SPARK-38289][SQL] Refactor SQL CLI exit code to make it more clear

2022-06-07 Thread GitBox
AngersZh commented on PR #35612: URL: https://github.com/apache/spark/pull/35612#issuecomment-1148234463 Looks like the latest failed test not related to this pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [spark] huaxingao commented on a diff in pull request #36776: [SPARK-38997][SPARK-39037][SQL][FOLLOWUP] `PushableColumnWithoutNestedColumn` need be translated to predicate too

2022-06-07 Thread GitBox
huaxingao commented on code in PR #36776: URL: https://github.com/apache/spark/pull/36776#discussion_r890797844 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/util/V2ExpressionBuilder.scala: ## @@ -55,8 +55,13 @@ class V2ExpressionBuilder( } else {

<    1   2   3