[GitHub] spark pull request #18836: Update SortMergeJoinExec.scala

2017-08-03 Thread BoleynSu
Github user BoleynSu commented on a diff in the pull request: https://github.com/apache/spark/pull/18836#discussion_r131316095 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala --- @@ -82,7 +82,7 @@ case class SortMergeJoinExec

[GitHub] spark issue #18836: Update SortMergeJoinExec.scala

2017-08-03 Thread BoleynSu
Github user BoleynSu commented on the issue: https://github.com/apache/spark/pull/18836 @gatorsmile I am not familiar with the PR process, it is great that you can take it over. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark issue #18836: Update SortMergeJoinExec.scala

2017-08-03 Thread BoleynSu
Github user BoleynSu commented on the issue: https://github.com/apache/spark/pull/18836 A test case to make the existing code fail. @srowen I am sorry that this pull request is not well formatted but I just want to help. ```scala import org.apache.spark.sql.SparkSession

[GitHub] spark pull request #18836: Update SortMergeJoinExec.scala

2017-08-03 Thread BoleynSu
GitHub user BoleynSu opened a pull request: https://github.com/apache/spark/pull/18836 Update SortMergeJoinExec.scala fix a bug in outputOrdering ## What changes were proposed in this pull request? Change `case Inner` to `case _: InnerLike` so that Cross