Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/17864
Thanks for following up on this, Felix.
Still waiting for an agreement on this...
Would like to have more direction on this.
---
If your project is set up for it, you can reply
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18870
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18831
Thanks both for the comments. Yes, I think it's be to keep this PR on
offset and we can address the other improvements later.
---
If your project is set up for it, you can reply
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18831#discussion_r131386220
--- Diff: R/pkg/tests/fulltests/test_mllib_regression.R ---
@@ -173,6 +173,14 @@ test_that("spark.glm summary", {
expect_equal(stats$d
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18831
Thanks for your comments, Felix.
Addressed all issues.
@yanboliang Could you take a quick look?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18831
Jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user actuaryzhang opened a pull request:
https://github.com/apache/spark/pull/18831
[SPARK-21622][ML][SparkR] Support offset in SparkR GLM
## What changes were proposed in this pull request?
Support offset in SparkR GLM #16699
You can merge this pull request into a Git
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18809
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
Made a new commit to address the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r127853762
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -452,6 +452,8 @@ object
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
@yanboliang Thanks for the suggestions. I have made a new commit that
addresses your comments.
In the new version, I used an array of tuple to represent the coefficient
matrix. I used
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r127844484
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -1441,4 +1460,33 @@ class
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r127844472
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -1441,4 +1460,33 @@ class
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16630#discussion_r127844463
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -1187,6 +1189,23 @@ class
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16630
@yanboliang Could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18534
@yanboliang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user actuaryzhang opened a pull request:
https://github.com/apache/spark/pull/18534
[SPARK-21310][ML][PySpark] Expose offset in PySpark
## What changes were proposed in this pull request?
Add offset to PySpark in GLM as in #16699.
## How was this patch tested
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18481#discussion_r125349671
--- Diff: R/pkg/R/functions.R ---
@@ -2875,9 +2875,9 @@ setMethod("ifelse",
#' @details
#' \code{cume_dist}: Returns the
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18481
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18481
OK, docs are now updated as you suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user actuaryzhang opened a pull request:
https://github.com/apache/spark/pull/18495
[SPARK-21275][ML] Update GLM test to use supportedFamilyNames
## What changes were proposed in this pull request?
Update GLM test to use supportedFamilyNames as suggested here:
https
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18495
@yanboliang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18493
We are done for this doc update effort after this one :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user actuaryzhang opened a pull request:
https://github.com/apache/spark/pull/18493
[SPARK-20889][SparkR][Followup] Clean up grouped doc for column methods
## What changes were proposed in this pull request?
Add doc for methods that were left out, and fix various style
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18481#discussion_r125112816
--- Diff: R/pkg/R/generics.R ---
@@ -1013,9 +1013,9 @@ setGeneric("create_map", function(x, ...) {
standardGeneric("create_map") }
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18481#discussion_r125112517
--- Diff: R/pkg/R/functions.R ---
@@ -3083,11 +3011,10 @@ setMethod("rank",
column(jc)
})
-# E
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18481#discussion_r125112058
--- Diff: R/pkg/R/functions.R ---
@@ -2844,27 +2869,16 @@ setMethod("ifelse",
## Window
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18481#discussion_r125112069
--- Diff: R/pkg/R/functions.R ---
@@ -2903,34 +2907,16 @@ setMethod("dense_rank",
column(jc)
})
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18481#discussion_r125111820
--- Diff: R/pkg/R/functions.R ---
@@ -200,6 +200,31 @@ NULL
#' head(select(tmp, sort_array(tmp$v1, asc = FALSE)))}
NULL
+#' Window
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18481
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18481
Ahh, forgot about the window functions. This is actually the last set...
@felixcheung @HyukjinKwon
![image](https://user-images.githubusercontent.com/11082368/27724147-55154b52-5d25
GitHub user actuaryzhang opened a pull request:
https://github.com/apache/spark/pull/18481
[SPARK-20889][SparkR] Grouped documentation for WINDOW column methods
## What changes were proposed in this pull request?
Grouped documentation for column window methods.
You can
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18458
@felixcheung This is the last set of this doc update. Once it gets in, I
will do another pass to fix any styles or consistency issue.
---
If your project is set up for it, you can reply
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124869366
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -961,14 +1008,16 @@ class
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16699
Made a new commit that fixes the issues you pointed out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18422#discussion_r124719484
--- Diff: R/pkg/R/functions.R ---
@@ -3554,21 +3493,17 @@ setMethod("grouping_id",
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18422#discussion_r124719362
--- Diff: R/pkg/R/functions.R ---
@@ -824,32 +835,23 @@ setMethod("initcap",
column(jc)
})
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18422#discussion_r124719101
--- Diff: R/pkg/R/functions.R ---
@@ -132,23 +132,40 @@ NULL
#' df <- createDataFrame(as.data.frame(Titanic, stringsAsFactors = FALSE))}
N
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18422#discussion_r124719080
--- Diff: R/pkg/R/functions.R ---
@@ -2819,20 +2775,26 @@ setMethod("unix_timestamp", signature(x = "Column",
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18422#discussion_r124718828
--- Diff: R/pkg/R/functions.R ---
@@ -132,23 +132,40 @@ NULL
#' df <- createDataFrame(as.data.frame(Titanic, stringsAsFactors = FALSE))}
N
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18422#discussion_r124718755
--- Diff: R/pkg/R/functions.R ---
@@ -132,23 +132,40 @@ NULL
#' df <- createDataFrame(as.data.frame(Titanic, stringsAsFactors = FALSE))}
N
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18422#discussion_r124718681
--- Diff: R/pkg/R/functions.R ---
@@ -132,23 +132,40 @@ NULL
#' df <- createDataFrame(as.data.frame(Titanic, stringsAsFactors = FALSE))}
N
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18458#discussion_r124716253
--- Diff: R/pkg/R/functions.R ---
@@ -2156,28 +2178,23 @@ setMethod("date_format", signature(y = "Column", x
= "character&q
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18458#discussion_r124715019
--- Diff: R/pkg/R/functions.R ---
@@ -2156,28 +2178,23 @@ setMethod("date_format", signature(y = "Column", x
= "character&q
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18448#discussion_r124714226
--- Diff: R/pkg/R/functions.R ---
@@ -132,6 +132,27 @@ NULL
#' df <- createDataFrame(as.data.frame(Titanic, stringsAsFactors = FALSE))}
N
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18448#discussion_r124714065
--- Diff: R/pkg/R/functions.R ---
@@ -132,6 +132,27 @@ NULL
#' df <- createDataFrame(as.data.frame(Titanic, stringsAsFactors = FALSE))}
N
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18422
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18448
---
If your project is set up for it, you can reply to this email and have your
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18458
@felixcheung @HyukjinKwon
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18371#discussion_r124457521
--- Diff: R/pkg/R/functions.R ---
@@ -41,14 +41,21 @@ NULL
#' @param x Column to compute on. In \code{shiftLeft}, \code{shiftRight}
and \code
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
OK. Incorporated your suggested changes now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16699
Not sure what this error msg means, but it seems unrelated to this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16699
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/12414
LGTM once it clears Jenkins. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
@felixcheung @HyukjinKwon Anything else needed for this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/16699
@yanboliang Thanks much for the review. The new commit includes everything
you suggested except implementing `WeightLeastSquares` interface for
`OffsetInstance`. Please see my incline comments
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124403889
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -798,77 +798,184 @@ class
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124402141
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/optim/IterativelyReweightedLeastSquaresSuite.scala
---
@@ -169,29 +169,29 @@ class
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124399685
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -339,15 +364,16 @@ class
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18422
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18422
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18422
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18422
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18422
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user actuaryzhang opened a pull request:
https://github.com/apache/spark/pull/18422
[SPARK-20889][SparkR] Grouped documentation for NONAGGREGATE column methods
## What changes were proposed in this pull request?
Grouped documentation for nonaggregate column methods
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18371
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
jenkins, retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/17864
We can log a warning or issue an error if the input column is int and the
imputation is by mean.
Would like to know if that's OK with you? @hhbyyh @MLnick
---
If your project is set up
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
Thank you @HyukjinKwon for checking it.
@felixcheung Please let me know if there is anything else needed on this
one.
---
If your project is set up for it, you can reply to this email
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18371
Anything else needed for this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18366#discussion_r123934637
--- Diff: R/pkg/R/functions.R ---
@@ -1503,18 +1491,12 @@ setMethod("skewness",
column(jc)
})
-
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18366#discussion_r123934615
--- Diff: R/pkg/R/functions.R ---
@@ -635,20 +652,16 @@ setMethod("dayofyear",
column(jc)
})
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
@felixcheung Since there are only two methods with argument signature `(y,
x)`, I think it's best to document them together with the other string
methods. Also, not aiming to rename
GitHub user actuaryzhang reopened a pull request:
https://github.com/apache/spark/pull/18371
[SPARK-20889][SparkR] Grouped documentation for MATH column methods
## What changes were proposed in this pull request?
Grouped documentation for math column methods.
You can
Github user actuaryzhang closed the pull request at:
https://github.com/apache/spark/pull/18371
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18371
appveyor is not kicking off
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
@felixcheung appveyor has been queued for a long time
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/17864
Any committer has a chance to take another look at this PR? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user actuaryzhang commented on the issue:
https://github.com/apache/spark/pull/18366
@felixcheung Thanks much for the review. Made a new commit that addresses
all your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18366#discussion_r123757421
--- Diff: R/pkg/R/functions.R ---
@@ -635,20 +651,16 @@ setMethod("dayofyear",
column(jc)
})
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18366#discussion_r123758738
--- Diff: R/pkg/R/functions.R ---
@@ -833,21 +838,21 @@ setMethod("hour",
column(jc)
})
-
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18366#discussion_r123760642
--- Diff: R/pkg/R/functions.R ---
@@ -2700,19 +2656,14 @@ setMethod("expr", signature(x = "character"),
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18366#discussion_r123760974
--- Diff: R/pkg/R/functions.R ---
@@ -2976,19 +2918,12 @@ setMethod("regexp_replace",
column(jc)
})
Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18366#discussion_r123756917
--- Diff: R/pkg/R/functions.R ---
@@ -86,6 +86,22 @@ NULL
#' df <- createDataFrame(data.frame(time = as.POSIXct(dts), y = y))}
N
GitHub user actuaryzhang reopened a pull request:
https://github.com/apache/spark/pull/18371
[SPARK-20889][SparkR] Grouped documentation for MATH column methods
## What changes were proposed in this pull request?
Grouped documentation for math column methods.
You can
Github user actuaryzhang closed the pull request at:
https://github.com/apache/spark/pull/18371
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user actuaryzhang closed the pull request at:
https://github.com/apache/spark/pull/18366
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user actuaryzhang reopened a pull request:
https://github.com/apache/spark/pull/18366
[SPARK-20889][SparkR] Grouped documentation for STRING column methods
## What changes were proposed in this pull request?
Grouped documentation for string column methods.
You can
GitHub user actuaryzhang reopened a pull request:
https://github.com/apache/spark/pull/18366
[SPARK-20889][SparkR] Grouped documentation for STRING column methods
## What changes were proposed in this pull request?
Grouped documentation for string column methods.
You can
Github user actuaryzhang closed the pull request at:
https://github.com/apache/spark/pull/18366
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
1 - 100 of 513 matches
Mail list logo
