Github user bkrieger commented on a diff in the pull request:
https://github.com/apache/spark/pull/22995#discussion_r236775302
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -92,8 +95,15 @@ private[spark] class TorrentBroadcast[T: ClassTag
Github user bkrieger commented on a diff in the pull request:
https://github.com/apache/spark/pull/22995#discussion_r236724749
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -92,8 +95,15 @@ private[spark] class TorrentBroadcast[T: ClassTag
Github user bkrieger commented on a diff in the pull request:
https://github.com/apache/spark/pull/22995#discussion_r23671
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -92,8 +95,15 @@ private[spark] class TorrentBroadcast[T: ClassTag
Github user bkrieger commented on the issue:
https://github.com/apache/spark/pull/22995
@srowen @mridulm for some reason it looks like tests aren't being
triggered, can one of you trigger?
---
-
To unsubscribe, e
Github user bkrieger commented on a diff in the pull request:
https://github.com/apache/spark/pull/22995#discussion_r236391043
--- Diff:
core/src/main/scala/org/apache/spark/broadcast/TorrentBroadcast.scala ---
@@ -93,7 +96,14 @@ private[spark] class TorrentBroadcast[T: ClassTag
GitHub user bkrieger opened a pull request:
https://github.com/apache/spark/pull/22995
[SPARK-25998] [CORE] Change TorrentBroadcast to hold weak reference of
broadcast object
## What changes were proposed in this pull request?
This PR changes the broadcast object
Github user bkrieger commented on the issue:
https://github.com/apache/spark/pull/21508
@gatorsmile @hvanhovell any chance you can take a look at this?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user bkrieger commented on the issue:
https://github.com/apache/spark/pull/21508
@gatorsmile @hvanhovell can you take another look at this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user bkrieger commented on the issue:
https://github.com/apache/spark/pull/21508
@gatorsmile @hvanhovell Gentle ping. Let me know if there's someone else
who would be better to review.
---
-
To unsubscribe
Github user bkrieger commented on the issue:
https://github.com/apache/spark/pull/21508
@gatorsmile @hvanhovell can you take a last look at this? I think it's good
to merge.
---
-
To unsubscribe, e-mail: reviews
Github user bkrieger commented on the issue:
https://github.com/apache/spark/pull/21508
@gatorsmile @hvanhovell is this good to merge?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user bkrieger commented on the issue:
https://github.com/apache/spark/pull/21508
The test failure looks like a flake to me?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user bkrieger commented on a diff in the pull request:
https://github.com/apache/spark/pull/21508#discussion_r194539275
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1568,11 +1568,13 @@ class Analyzer
Github user bkrieger commented on a diff in the pull request:
https://github.com/apache/spark/pull/21508#discussion_r194539357
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1568,11 +1568,13 @@ class Analyzer
Github user bkrieger commented on a diff in the pull request:
https://github.com/apache/spark/pull/21508#discussion_r194467198
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1568,11 +1568,32 @@ class Analyzer
Github user bkrieger commented on a diff in the pull request:
https://github.com/apache/spark/pull/21508#discussion_r194436381
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1568,11 +1568,32 @@ class Analyzer
Github user bkrieger commented on a diff in the pull request:
https://github.com/apache/spark/pull/21508#discussion_r194274619
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1568,11 +1568,32 @@ class Analyzer
Github user bkrieger commented on a diff in the pull request:
https://github.com/apache/spark/pull/21508#discussion_r194274604
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1568,11 +1568,32 @@ class Analyzer
Github user bkrieger commented on a diff in the pull request:
https://github.com/apache/spark/pull/21508#discussion_r194082850
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1568,11 +1568,13 @@ class Analyzer
GitHub user bkrieger opened a pull request:
https://github.com/apache/spark/pull/21508
[SPARK-24488] [SQL] Fix issue when generator is aliased multiple times
## What changes were proposed in this pull request?
Currently, the Analyzer throws an exception if your try to nest
20 matches
Mail list logo
