Github user bsikander commented on the issue:
https://github.com/apache/spark/pull/21816
Thank you.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user bsikander commented on the issue:
https://github.com/apache/spark/pull/21816
@srowen Can you have another look?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user bsikander commented on a diff in the pull request:
https://github.com/apache/spark/pull/21816#discussion_r225553817
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/StandaloneRestSubmitSuite.scala
---
@@ -83,6 +83,26 @@ class StandaloneRestSubmitSuite
Github user bsikander commented on the issue:
https://github.com/apache/spark/pull/21816
Failing tests don't seem to be related to this change.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user bsikander commented on the issue:
https://github.com/apache/spark/pull/21816
>> So is there no behavior change if your master specifies only one master?
If user specifies only 1 master then there is no behavioral
Github user bsikander commented on the issue:
https://github.com/apache/spark/pull/21816
@srowen I removed the extra .toString.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user bsikander commented on the issue:
https://github.com/apache/spark/pull/21816
@srowen even though it is unlikely but it could happen. I have updated the
code.
---
-
To unsubscribe, e-mail: reviews
Github user bsikander commented on the issue:
https://github.com/apache/spark/pull/21816
>> What might break if we make this change? I think that's what any other
reviewer cares abou
To the best of my knowledge. Nothing should
Github user bsikander commented on a diff in the pull request:
https://github.com/apache/spark/pull/21816#discussion_r220119995
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/StandaloneRestServer.scala ---
@@ -138,6 +138,10 @@ private[rest] class
Github user bsikander commented on a diff in the pull request:
https://github.com/apache/spark/pull/21816#discussion_r220120052
--- Diff:
core/src/main/scala/org/apache/spark/deploy/rest/StandaloneRestServer.scala ---
@@ -138,6 +138,10 @@ private[rest] class
Github user bsikander commented on the issue:
https://github.com/apache/spark/pull/21816
@vanzin ok, how can I find the right reviewer for this change? Posting on
dev mailing list?
---
-
To unsubscribe, e-mail
Github user bsikander commented on the issue:
https://github.com/apache/spark/pull/21816
Could some please have a look at this?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user bsikander commented on the issue:
https://github.com/apache/spark/pull/21816
could someone please have a look at this change?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user bsikander commented on the issue:
https://github.com/apache/spark/pull/21816
Sorry for dropping message again, but could someone please have a look at
this change. This is a problem that I am having constantly and a validation
from senior committers will be really helpful
Github user bsikander commented on the issue:
https://github.com/apache/spark/pull/21816
@holdenk somehow, Jenkins didn't execute the tests.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user bsikander commented on the issue:
https://github.com/apache/spark/pull/21816
@vanzin Could you please have a look on this change?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user bsikander opened a pull request:
https://github.com/apache/spark/pull/21816
[SPARK-24794][CORE] Driver launched through rest should use all masters
## What changes were proposed in this pull request?
In standalone cluster mode, one could launch driver
17 matches
Mail list logo
