Github user c-horn commented on the issue:
https://github.com/apache/spark/pull/21746
Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user c-horn commented on the issue:
https://github.com/apache/spark/pull/21746
@tdas this will not be included in `2.4.0`? as indicated
[SPARK-24699](https://issues.apache.org/jira/browse/SPARK-24699
Github user c-horn closed the pull request at:
https://github.com/apache/spark/pull/21676
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user c-horn commented on the issue:
https://github.com/apache/spark/pull/21676
already resolved by https://github.com/apache/spark/pull/21746
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user c-horn commented on the issue:
https://github.com/apache/spark/pull/21676
Hi @tdas sorry for delay.
My email for github account: chorn4...@gmail.com
This looks fine to me, we can close this PR (and jira ticket) when yours is
merged
Github user c-horn commented on the issue:
https://github.com/apache/spark/pull/21752
Do I need to change anything else with this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user c-horn commented on the issue:
https://github.com/apache/spark/pull/21752
@maropu see changes and comments above ^
I updated the description as well.
---
-
To unsubscribe, e-mail: reviews
Github user c-horn commented on a diff in the pull request:
https://github.com/apache/spark/pull/21752#discussion_r202443782
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -717,4 +717,9 @@ class DataFrameAggregateSuite extends QueryTest
Github user c-horn commented on a diff in the pull request:
https://github.com/apache/spark/pull/21752#discussion_r202445344
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -717,4 +717,9 @@ class DataFrameAggregateSuite extends QueryTest
GitHub user c-horn opened a pull request:
https://github.com/apache/spark/pull/21752
Spark 24788
## What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/SPARK-24788
Add a special case for unresolved expressions when constructing
Github user c-horn commented on the issue:
https://github.com/apache/spark/pull/21676
@tdas I merged your changes into my branch, test passed, thank you ð
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user c-horn commented on the issue:
https://github.com/apache/spark/pull/21676
I was under the assumption that the offset log contained this data?
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming
Github user c-horn commented on the issue:
https://github.com/apache/spark/pull/21676
Changing `OneTimeExecutor` like this resolves this issue:
```
case class OneTimeExecutor() extends TriggerExecutor {
/**
* Execute a single batch using `batchRunner
Github user c-horn commented on the issue:
https://github.com/apache/spark/pull/21676
@tdas @marmbrus
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user c-horn opened a pull request:
https://github.com/apache/spark/pull/21676
[SPARK-24699][SQL][WIP] Watermark / Append mode should work with
Trigger.Once
## What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/SPARK-24699
15 matches
Mail list logo
