Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20070
@srowen Request for review when you get on this.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20070#discussion_r159192570
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/QuantileDiscretizerExample.scala
---
@@ -45,7 +45,7 @@ object QuantileDiscretizerExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20070#discussion_r159152519
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/LatentDirichletAllocationExample.scala
---
@@ -46,7 +46,10 @@ object
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20070#discussion_r159134529
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/LatentDirichletAllocationExample.scala
---
@@ -42,11 +42,11 @@ object
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20070#discussion_r159134489
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/HypothesisTestingExample.scala
---
@@ -68,7 +68,7 @@ object HypothesisTestingExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20070#discussion_r159134414
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/QuantileDiscretizerExample.scala
---
@@ -45,7 +45,7 @@ object QuantileDiscretizerExample
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20070
@srowen Okey. current status looks good
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20070#discussion_r159084968
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/VectorIndexerExample.scala
---
@@ -41,8 +41,8 @@ object VectorIndexerExample
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20070
@srowen please do re-run the build.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20070#discussion_r158978102
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/AssociationRulesExample.scala
---
@@ -42,14 +42,13 @@ object AssociationRulesExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20070#discussion_r158978648
--- Diff:
examples/src/main/scala/org/apache/spark/examples/streaming/CustomReceiver.scala
---
@@ -82,9 +82,9 @@ class CustomReceiver(host: String
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20070#discussion_r158976171
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/DeveloperApiExample.scala
---
@@ -169,10 +169,10 @@ private class
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20070#discussion_r158976219
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/QuantileDiscretizerExample.scala
---
@@ -31,12 +31,11 @@ object
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20070#discussion_r158976155
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/CorrelationExample.scala
---
@@ -51,10 +51,10 @@ object CorrelationExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20070#discussion_r158975980
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/ChiSquareTestExample.scala
---
@@ -52,9 +52,9 @@ object ChiSquareTestExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20070#discussion_r158974779
--- Diff:
examples/src/main/scala/org/apache/spark/examples/graphx/Analytics.scala ---
@@ -145,9 +145,9 @@ object Analytics extends Logging
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20070
@srowen I rechecked all scala examples and this is commulative PR for the
same.
---
-
To unsubscribe, e-mail: reviews
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20070
You're correct - I missed other packages. I will re-confirm soon. Thanks.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20070
In scala ? I don't think so. I am re-iterating and doing double check.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user chetkhatri closed the pull request at:
https://github.com/apache/spark/pull/20071
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20071
@srowen Thanks, Addressed and changes done.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20070
@srowen also i did merge another similiar PR with graphx to here. so Just
FYI - we are good.
---
-
To unsubscribe, e-mail
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20070
@srowen Absolutely correct, this all in one shot. I did changes in all.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20081
@cloud-fan @srowen I am good with changes proposed. please do merge.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20081
@cloud-fan spark.sql.files.maxRecordsPerFile didn't worked out when i was
working with mine 30 TB of Spark Hive workload whereas repartition and coalesce
made sense
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20081
@cloud-fan Thanks for PR
4. spark.sql.parquet.writeLegacyFormat - if you don't use this
configuration, hive external table won't be able to access parquet data.
5. repartition
GitHub user chetkhatri opened a pull request:
https://github.com/apache/spark/pull/20071
SPARK-22896 Improvement in String interpolation | Graphx
## What changes were proposed in this pull request?
* String interpolation in scala style corrected.
## How was this patch tested
GitHub user chetkhatri opened a pull request:
https://github.com/apache/spark/pull/20070
SPARK-22896 Improvement in String interpolation
## What changes were proposed in this pull request?
* String interpolation in ml pipeline example has been corrected as per
scala
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20018
Thanks @HyukjinKwon @wangyum
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20018
@srowen Apologize, i was not aware with that PMC member gets auto
notification for the same.
---
-
To unsubscribe, e-mail
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20018
@HyukjinKwon @srowen Kindly review now, if looks good do merge. Thanks
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158454282
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -102,8 +101,41 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158454291
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -102,8 +101,41 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158454275
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -102,8 +101,41 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158454240
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -102,8 +101,41 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158454252
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -102,8 +101,41 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158454265
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -102,8 +101,41 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158454218
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -102,8 +101,41 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158454228
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -102,8 +101,41 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158370581
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -102,8 +101,63 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158370509
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -102,8 +101,63 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158370168
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -102,8 +101,63 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158368719
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -102,8 +101,63 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158368554
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -102,8 +101,63 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158366994
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -102,8 +101,63 @@ object SparkHiveExample
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20016
@srowen I think, we can merge this now.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r158113948
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -104,6 +103,60 @@ object SparkHiveExample
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20016
@srowen Thank you for re-run, now it passes all.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20018
Adding other contributor of the same file for review. cc\
@cloud-fan
@aokolnychyi
@liancheng
@HyukjinKwon
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20016#discussion_r157941778
--- Diff: examples/src/main/scala/org/apache/spark/examples/HdfsTest.scala
---
@@ -39,7 +39,7 @@ object HdfsTest {
val start
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20016#discussion_r157941813
--- Diff: examples/src/main/scala/org/apache/spark/examples/SparkALS.scala
---
@@ -100,7 +100,7 @@ object SparkALS {
ITERATIONS
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20016#discussion_r157816044
--- Diff: examples/src/main/scala/org/apache/spark/examples/LocalALS.scala
---
@@ -95,7 +95,7 @@ object LocalALS {
def showWarning
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20016#discussion_r157794109
--- Diff:
examples/src/main/scala/org/apache/spark/examples/DFSReadWriteTest.scala ---
@@ -127,11 +125,11 @@ object DFSReadWriteTest
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20016#discussion_r157941808
--- Diff: examples/src/main/scala/org/apache/spark/examples/SparkALS.scala
---
@@ -80,7 +80,7 @@ object SparkALS {
def showWarning
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20016#discussion_r157816026
--- Diff:
examples/src/main/scala/org/apache/spark/examples/DFSReadWriteTest.scala ---
@@ -49,12 +49,10 @@ object DFSReadWriteTest
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20016#discussion_r157794196
--- Diff:
examples/src/main/scala/org/apache/spark/examples/LocalFileLR.scala ---
@@ -58,10 +58,10 @@ object LocalFileLR {
// Initialize
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20016
@srowen Thanks for response, correct - i went through error of jenkins and
found error
Online[https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4018/console]
which fixed
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20018
@srowen Can you please review and if everything seems correct then run test
build
---
-
To unsubscribe, e-mail: reviews
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20016
@srowen why only recent commit is going to merge, can't we get "squash
merge" ?
Please re-run test build. and let me know if still s
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20016
@HyukjinKwon @mgaido91 @srowen All the changes are addressed and committed,
please do review and needful
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r157973588
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -104,6 +103,60 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r157942866
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -104,6 +103,60 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20018#discussion_r157796580
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/hive/SparkHiveExample.scala
---
@@ -104,6 +103,60 @@ object SparkHiveExample
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20016#discussion_r157793283
--- Diff:
examples/src/main/scala/org/apache/spark/examples/DFSReadWriteTest.scala ---
@@ -97,22 +95,22 @@ object DFSReadWriteTest {
def main
Github user chetkhatri commented on a diff in the pull request:
https://github.com/apache/spark/pull/20016#discussion_r157792884
--- Diff:
examples/src/main/scala/org/apache/spark/examples/BroadcastTest.scala ---
@@ -42,7 +42,7 @@ object BroadcastTest {
val arr1 = (0
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20018
@holdenk @sameeragarwal Please do review and do needful .
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
GitHub user chetkhatri opened a pull request:
https://github.com/apache/spark/pull/20018
SPARK-22833 [Improvement] in SparkHive Scala Examples
## What changes were proposed in this pull request?
SparkHive Scala Examples Improvement made:
* Writing DataFrame / DataSet
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20016
+ @holdenk @sameeragarwal
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user chetkhatri commented on the issue:
https://github.com/apache/spark/pull/20016
@HyukjinKwon I agree with you ! But since Spark is scala project - A lot's
of developers refer examples available here and if those are Java Developers
they might don't understand
GitHub user chetkhatri opened a pull request:
https://github.com/apache/spark/pull/20016
SPARK-22830 Scala Coding style has been improved in Spark Examples
## What changes were proposed in this pull request?
* Under Spark Scala Examples: Some of the syntax were written like
70 matches
Mail list logo
