[GitHub] spark pull request #22031: [TODO][SPARK-23932][SQL] Higher order function zi...

2018-08-07 Thread crafty-coder
Github user crafty-coder commented on a diff in the pull request: https://github.com/apache/spark/pull/22031#discussion_r208387111 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/higherOrderFunctions.scala --- @@ -442,3 +442,93 @@ case class

[GitHub] spark issue #20949: [SPARK-19018][SQL] Add support for custom encoding on cs...

2018-07-25 Thread crafty-coder
Github user crafty-coder commented on the issue: https://github.com/apache/spark/pull/20949 @HyukjinKwon and @MaxGekk thanks for your help in this PR! My JIRA Id is also **crafty-coder

[GitHub] spark pull request #20949: [SPARK-19018][SQL] Add support for custom encodin...

2018-07-18 Thread crafty-coder
Github user crafty-coder commented on a diff in the pull request: https://github.com/apache/spark/pull/20949#discussion_r203306174 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -512,6 +513,43 @@ class CSVSuite extends

[GitHub] spark pull request #20949: [SPARK-19018][SQL] Add support for custom encodin...

2018-07-18 Thread crafty-coder
Github user crafty-coder commented on a diff in the pull request: https://github.com/apache/spark/pull/20949#discussion_r203286908 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -512,6 +513,43 @@ class CSVSuite extends

[GitHub] spark pull request #20949: [SPARK-19018][SQL] Add support for custom encodin...

2018-07-17 Thread crafty-coder
Github user crafty-coder commented on a diff in the pull request: https://github.com/apache/spark/pull/20949#discussion_r203023263 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala --- @@ -512,6 +512,43 @@ class CSVSuite extends

[GitHub] spark issue #21247: [SPARK-24190][SQL] Allow saving of JSON files in UTF-16 ...

2018-06-22 Thread crafty-coder
Github user crafty-coder commented on the issue: https://github.com/apache/spark/pull/21247 Hi @holdenk , I'm working on a similar PR (https://github.com/apache/spark/pull/20949) to allow setting up the encoding when writing csv files. It would be strange if you could set up

[GitHub] spark issue #20949: [SPARK-19018][SQL] Add support for custom encoding on cs...

2018-05-06 Thread crafty-coder
Github user crafty-coder commented on the issue: https://github.com/apache/spark/pull/20949 I would say this change has value on its own. At the moment the csv reader applies the charset config but the csv writer is ignoring it, which I think its a bit confusing

[GitHub] spark pull request #20949: [SPARK-19018][SQL] Add support for custom encodin...

2018-03-30 Thread crafty-coder
GitHub user crafty-coder opened a pull request: https://github.com/apache/spark/pull/20949 [SPARK-19018][SQL] Add support for custom encoding on csv writer ## What changes were proposed in this pull request? Add support for custom encoding on csv writer, see https