[GitHub] spark pull request #22109: [SPARK-25120][CORE][HistoryServer]Fix the problem...

2018-08-16 Thread deshanxiao
Github user deshanxiao closed the pull request at: https://github.com/apache/spark/pull/22109 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22109: [SPARK-25120][CORE][HistoryServer]Fix the problem of Eve...

2018-08-15 Thread deshanxiao
Github user deshanxiao commented on the issue: https://github.com/apache/spark/pull/22109 @vanzin Sorry..SPARK-22850 has fix the problem. Maybe I will track the executor lose problem next. Thank you! @vanzin @squito

[GitHub] spark issue #22109: [SPARK-25120][CORE][HistoryServer]Fix the problem of Eve...

2018-08-15 Thread deshanxiao
Github user deshanxiao commented on the issue: https://github.com/apache/spark/pull/22109 @squito @vanzin Thanks, the first time I find it in our cluster is Spark2.1. Spark2.1 has the method `setupAndStartListenerBus` too, but it still looks like wrong. The phenomenon of executor

[GitHub] spark issue #22093: [SPARK-25100][CORE] Fix no registering TaskCommitMessage...

2018-08-14 Thread deshanxiao
Github user deshanxiao commented on the issue: https://github.com/apache/spark/pull/22093 @xuanyuanking I think it carefully later. You are right. The UT just need to guarantee the KryoSerializer right not all. I will add it in `KryoSerializerSuite`. Should I delete current UT from

[GitHub] spark issue #22109: [SPARK-25120][CORE][HistoryServer]Fix the problem of Eve...

2018-08-14 Thread deshanxiao
Github user deshanxiao commented on the issue: https://github.com/apache/spark/pull/22109 please help me cc @HyukjinKwon --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark issue #22093: [SPARK-25100][CORE] Fix no registering TaskCommitMessage...

2018-08-14 Thread deshanxiao
Github user deshanxiao commented on the issue: https://github.com/apache/spark/pull/22093 @xuanyuanking Thanks for your suggestion. We could indeed test whether `TaskCommitMessage` can be serialized by `KryoSerializer`. But We could not explain why the framework must serialize

[GitHub] spark pull request #22109: [SPARK-25120][CORE][HistoryServer]Fix the problem...

2018-08-14 Thread deshanxiao
GitHub user deshanxiao opened a pull request: https://github.com/apache/spark/pull/22109 [SPARK-25120][CORE][HistoryServer]Fix the problem of EventLogListener may miss driver SparkListenerBloc… ## What changes were proposed in this pull request? Sometimes in spark

[GitHub] spark issue #22093: [SPARK-25100][CORE] Fix no registering TaskCommitMessage...

2018-08-13 Thread deshanxiao
Github user deshanxiao commented on the issue: https://github.com/apache/spark/pull/22093 @xuanyuanking I used place the test in it, but KryoSerializerSuite exteends SharedSparkContext where I could not create my own SparkContext

[GitHub] spark pull request #22093: [SPARK-25100][CORE] Fix no registering TaskCommit...

2018-08-13 Thread deshanxiao
Github user deshanxiao commented on a diff in the pull request: https://github.com/apache/spark/pull/22093#discussion_r209652992 --- Diff: core/src/test/scala/org/apache/spark/FileSuite.scala --- @@ -424,6 +425,39 @@ class FileSuite extends SparkFunSuite with LocalSparkContext

[GitHub] spark pull request #22093: [SPARK-25100][CORE] Fix no registering TaskCommit...

2018-08-13 Thread deshanxiao
GitHub user deshanxiao opened a pull request: https://github.com/apache/spark/pull/22093 [SPARK-25100][CORE] Fix no registering TaskCommitMessage bug ## What changes were proposed in this pull request? Fix the bug when invoking saveAsNewAPIHadoopDataset to store data

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-05 Thread deshanxiao
Github user deshanxiao commented on the issue: https://github.com/apache/spark/pull/21956 It's ok. Thank you for your suggestions! --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #21956: [MINOR][DOCS] Fix grammatical error in SortShuffleManage...

2018-08-04 Thread deshanxiao
Github user deshanxiao commented on the issue: https://github.com/apache/spark/pull/21956 Thanks a lot, I am sorry that I'm not able to find more clear errors. As a beginner, I am very glad to write more docs to help others understanding the spark core easier

[GitHub] spark pull request #21956: [MINOR][DOCS] Fix grammatical error in SortShuffl...

2018-08-01 Thread deshanxiao
GitHub user deshanxiao opened a pull request: https://github.com/apache/spark/pull/21956 [MINOR][DOCS] Fix grammatical error in SortShuffleManager ## What changes were proposed in this pull request? Fix a grammatical error in the comment of SortShuffleManager