Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22638#discussion_r222957505
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetCacheSuite.scala ---
@@ -127,16 +127,16 @@ class DatasetCacheSuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22638#discussion_r222946564
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DatasetCacheSuite.scala ---
@@ -127,16 +127,16 @@ class DatasetCacheSuite extends QueryTest
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22638
cc @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22638
[SPARK-25610][SQL][TEST] Improve execution time of DatasetCacheSuite: cache
UDF result correctly
## What changes were proposed in this pull request?
In this test case, we are verifying
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22622
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22047
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22619
@HyukjinKwon Sure :-)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22047
@gatorsmile First of all, thank you very much . Actually the added
aggregates weren't null filtering. I have fixed the issue and have added
additional test cases. Thank you
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22619
@HyukjinKwon Does this look okay now ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/20433#discussion_r222552685
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -335,6 +335,12 @@ object SQLConf {
.booleanConf
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/20433#discussion_r222550361
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -335,6 +335,12 @@ object SQLConf {
.booleanConf
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/20433#discussion_r222544245
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -335,6 +335,12 @@ object SQLConf {
.booleanConf
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22619#discussion_r222199535
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala
---
@@ -172,51 +172,35 @@ private[csv] object
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22619#discussion_r222198784
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala
---
@@ -172,51 +172,35 @@ private[csv] object
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22619#discussion_r222198591
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala
---
@@ -172,51 +172,35 @@ private[csv] object
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22619
@HyukjinKwon Okay.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22448
@HyukjinKwon Thanks for checking it out.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22619#discussion_r222195632
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala
---
@@ -172,51 +172,35 @@ private[csv] object
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22619
@ueshin
> Maybe this is related to #22448.
Yeah.. Actually @MaxGekk had pointed me to the presence of duplicate code
in one of his comment. I was trying to address it in h
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22619
@gatorsmile There should not be any behaviour change. I was thinking that
existing test cases should suffice. Basically we used to duplicate the code of
TypeCoercion.findTightestCommonType
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22619
cc @HyukjinKwon @MaxGekk
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22619
[SQL][MINOR] Make use of TypeCoercion.findTightestCommonType while
inferring CSV schema.
## What changes were proposed in this pull request?
Current the CSV's infer schema code inlines
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22047
@gatorsmile Thanks.. I will check.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22566
Thank you very much @gatorsmile @dongjoon-hyun @juliuszsompolski
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22566
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r221159987
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
@@ -653,6 +653,49 @@ class StatisticsSuite extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r221159433
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -48,9 +52,13 @@ case class
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22544
@cloud-fan Sounds good Wenchen. Thanks for the detailed analysis.
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r221029986
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -50,7 +52,26 @@ case class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r220986964
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -50,7 +52,26 @@ case class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r220985607
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -50,7 +52,26 @@ case class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22566#discussion_r220985491
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
---
@@ -33,11 +33,13 @@ import
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22566
[SPARK-25458][SQL] Support FOR ALL COLUMNS in ANALYZE TABLE
## What changes were proposed in this pull request?
**Description from the JIRA :**
Currently, to collect the statistics
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22563
@cloud-fan oops... sorry.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22563
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22561
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22562
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22558
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22544
@cloud-fan @ueshin @viirya Thank you very much.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22544
@cloud-fan Are we targeting this for 2.4 ? If so, i was wondering if we
should make a restricted fix that affects only this function by adding a case
in `FunctionArgumentConversion` for 2.4
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220766294
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -974,6 +974,25 @@ object TypeCoercion
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22560#discussion_r220757697
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtilsSuite.scala
---
@@ -65,4 +67,60 @@ class JdbcUtilsSuite
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22560#discussion_r220751466
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtilsSuite.scala
---
@@ -65,4 +67,60 @@ class JdbcUtilsSuite
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220746708
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -974,6 +974,33 @@ object TypeCoercion
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22556
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22326#discussion_r220463070
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -152,3 +153,56 @@ object EliminateOuterJoin extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220456613
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,38 @@ object TypeCoercion
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22326
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22326#discussion_r220440612
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -152,3 +153,56 @@ object EliminateOuterJoin extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22326#discussion_r220438880
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -152,3 +153,56 @@ object EliminateOuterJoin extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22326#discussion_r220436983
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
---
@@ -152,3 +153,56 @@ object EliminateOuterJoin extends
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22326
Does it make sense to have a test case where the PythonUDF referencing
attributes from both legs of join in disjunction with a regular predicate ? i.e
joinCond = pythonUDF(leftattr, rightattr
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22326#discussion_r220428377
--- Diff: python/pyspark/sql/tests.py ---
@@ -552,6 +552,92 @@ def test_udf_in_filter_on_top_of_join(self):
df = left.crossJoin(right
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22326#discussion_r220428290
--- Diff: python/pyspark/sql/tests.py ---
@@ -552,6 +552,92 @@ def test_udf_in_filter_on_top_of_join(self):
df = left.crossJoin(right
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22326#discussion_r220428332
--- Diff: python/pyspark/sql/tests.py ---
@@ -552,6 +552,92 @@ def test_udf_in_filter_on_top_of_join(self):
df = left.crossJoin(right
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220253485
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,36 @@ object TypeCoercion
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220250631
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,36 @@ object TypeCoercion
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220250338
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -2140,21 +2140,34 @@ case class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220232666
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -2140,21 +2140,34 @@ case class
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22544
[SPARK-25522] Improve type promotion for input arguments of elementAt
function
## What changes were proposed in this pull request?
In ElementAt, when first argument is MapType, we should
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22494
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22541
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22521
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22198
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22542
@cloud-fan Thanks a lot.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22542
@cloud-fan @ueshin I would like to ask a question here. There is one more
function i wanted to fix. Originally i wanted to do it as part of this PR..
then realized that its not as straight
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22542
cc @ueshin @cloud-fan
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22542
[SPARK-25519][SQL] ArrayRemove function may return incorrect result when
right expression is implicitly downcasted.
## What changes were proposed in this pull request?
In ArrayPosition, we
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22407
@cloud-fan @ueshin Thank you very much !!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22198
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22484
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22326
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22455
@adrian555 The changes look fine to me. Thank you.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22494
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22515
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22458
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22316
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22494
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22407
@ueshin Wenchen thought it may be risky to backport the fix to
tighestCommonType. Given this, can this be looked at now
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219388335
--- Diff: R/pkg/R/DataFrame.R ---
@@ -244,11 +245,15 @@ setMethod("showDF",
#' @note show(SparkDataFrame) since 1.4.0
setMe
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219356224
--- Diff: R/pkg/R/DataFrame.R ---
@@ -244,11 +245,15 @@ setMethod("showDF",
#' @note show(SparkDataFrame) since 1.4.0
setMe
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22494
@cloud-fan The change looks fine to me. I looked at the failure. Its
correctly switches to old behaviour when this config is set to off
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22455#discussion_r219330082
--- Diff: R/pkg/tests/fulltests/test_eager_execution.R ---
@@ -0,0 +1,58 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22450
@mgaido91
Again, this may be something to think about in 3.0 timeframe. I just
checked two databases, presto and db2. Both of them treat literals such as
`1e26` as double.
db2
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22408
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22481
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22408#discussion_r219039607
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
@@ -735,6 +735,60 @@ class DataFrameFunctionsSuite extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22408#discussion_r219037732
--- Diff: docs/sql-programming-guide.md ---
@@ -1879,6 +1879,66 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22408#discussion_r219028470
--- Diff: docs/sql-programming-guide.md ---
@@ -1879,6 +1879,80 @@ working with timestamps in `pandas_udf`s to get the
best performance, see
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22448#discussion_r219019347
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
---
@@ -366,7 +366,29 @@ class TypeCoercionSuite
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22448#discussion_r219019110
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -106,6 +107,22 @@ object TypeCoercion
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22448#discussion_r219018635
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -89,10 +90,10 @@ object TypeCoercion
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22448
@cloud-fan does this look okay now ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22470
@mgaido91 makes sense. Actually @cloud-fan had asked me to write some test
cases for decimal values with -ve scale in another PR. While i was playing
around, i found this issue. It seemed to me
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22470
@mgaido91 @cloud-fan On the other hand .. some use cases may work better
:-) , for example
Before
```
scala> spark.sql("create table dec as select (1e36 * 1)
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22448
@MaxGekk I was looking at CSVInferSchema. It seems like there is a copy of
`findTightestCommonType` in this file ? Do you know the reason for it ? Seems
like we may need to refactor to see
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22470
@cloud-fan Could you please check CSVinferSchema::tryParseDecimal() ? There
is a condition to check negative scale
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21632
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22462
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22447
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
101 - 200 of 1257 matches
Mail list logo
