Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22270
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22270
[SPARK-25267][SQL][TEST] Disable ConvertToLocalRelation in the test cases
of sql/core and sql/hive
## What changes were proposed in this pull request?
In SharedSparkSession and TestHive
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22198
@dongjoon-hyun Thanks for nicely summarizing. Actually i was not clear on
the semantics when i asked the question :-) and was wondering if we should
resolve it like a table identifier or just
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22198
@maropu @gatorsmile I do have a question on the semantics.
```SQL
use hint;
explain extended SELECT /*+ BROADCASTJOIN(hint.s2) */ * FROM s1, s2 where
s1.c1 = s2.c1
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22161
@HyukjinKwon Oh.. thank you. I was going to fix the style ? I will include
it when i fix something next
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22141#discussion_r211985537
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -137,13 +137,21 @@ object RewritePredicateSubquery
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22141#discussion_r211971929
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -137,13 +137,21 @@ object RewritePredicateSubquery
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22141#discussion_r211969009
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -137,13 +137,21 @@ object RewritePredicateSubquery
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22141#discussion_r211955605
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -137,13 +137,21 @@ object RewritePredicateSubquery
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22141
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22141#discussion_r211839392
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -137,13 +137,21 @@ object RewritePredicateSubquery
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22141#discussion_r211835129
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -137,13 +137,21 @@ object RewritePredicateSubquery
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22141#discussion_r211804802
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -137,13 +137,21 @@ object RewritePredicateSubquery
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22141#discussion_r211802296
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -137,13 +137,21 @@ object RewritePredicateSubquery
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22161#discussion_r211490349
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -3613,11 +3613,11 @@ test_that("Collect on DataFrame when NAs exists at
the top of a time
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22161
@HyukjinKwon Done.
[SPARK-25167](https://issues.apache.org/jira/browse/SPARK-25167)
---
-
To unsubscribe, e-mail: reviews
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22161
[SPARKR][TEST] Improve R sql tests
## What changes were proposed in this pull request?
A few SQL tests for R were failing in my development environment. In this
PR, i am attempting
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22144
@pgandhi999 I have a basic question. Setting this property will have a
global effect on all the aggregations
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22141
cc @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22141
[SPARK-25154] Support NOT IN sub-queries inside nested OR conditions.
## What changes were proposed in this pull request?
Currently NOT IN subqueries (predicated null aware subquery
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22107
Thank you very much @HyukjinKwon @felixcheung
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22108
Thank you very much @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22127
@bomeng There seems to be bit of history to this :-) . Please check
https://github.com/apache/spark/pull/15011
where we decided against silently switching to "default"
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22107
@felixcheung I have incorporated the comments.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210490145
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2848,6 +2848,35 @@ setMethod("intersect",
dataFrame(i
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210490166
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2876,6 +2905,37 @@ setMethod("except",
dataFram
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210490074
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2876,6 +2905,37 @@ setMethod("except",
dataFram
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17185
Good idea @gatorsmile . Thanks !!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22107#discussion_r210146526
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2848,6 +2848,35 @@ setMethod("intersect",
dataFrame(i
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22108
@gatorsmile We missed to add this rule. Please let me know what you think.
---
-
To unsubscribe, e-mail: reviews-unsubscr
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22108
[SPARK-25092][SQL][FOLLOWUP] Add RewriteCorrelatedScalarSubquery in list of
nonExcludableRules
## What changes were proposed in this pull request?
Add RewriteCorrelatedScalarSubquery
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22100#discussion_r210089160
--- Diff: python/pyspark/sql/functions.py ---
@@ -2927,7 +2927,7 @@ def pandas_udf(f=None, returnType=None,
functionType=None):
__all__ = [k for k
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22100
@kevinyu98 Can you please fix the description to "IncludeInclude
PandasUDFType in the import all of pyspark.sql.functions" or anyth
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22107
[SPARK-25117] Add EXEPT ALL and INTERSECT ALL support in R
## What changes were proposed in this pull request?
[SPARK-21274](https://issues.apache.org/jira/browse/SPARK-21274) added
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22080
Thanks a lot @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22080#discussion_r209434833
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -135,7 +135,7 @@ abstract class Optimizer
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22080
[SPARK-25092] Add RewriteExceptAll and RewriteIntersectAll in the list of
nonExcludableRules
## What changes were proposed in this pull request?
Add RewriteExceptAll
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22047
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22047#discussion_r209157977
--- Diff: python/pyspark/sql/functions.py ---
@@ -202,6 +202,12 @@ def _():
""",
}
+_functions_2_2
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22047#discussion_r209157855
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -88,7 +88,7 @@ class RelationalGroupedDataset protected
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22047#discussion_r209157799
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/RelationalGroupedDataset.scala ---
@@ -297,9 +318,44 @@ class RelationalGroupedDataset protected
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22047#discussion_r209157669
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1555,9 +1555,11 @@ case class Left(str
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22047
@gatorsmile I tried to implement the rewrites suggested in the original PR.
It does not seem very straightforward to me. The basic issue is, we are unable
to replace the aggregate expression
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22047
[SPARK-19851] Add support for EVERY and ANY (SOME) aggregates
## What changes were proposed in this pull request?
This PR is a rebased version of original work
[link](https://github.com
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17185
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22000
cc @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22000
[SPARK-25025][SQL] Remove the default value of isAll in INTERSECT/EXCEPT
## What changes were proposed in this pull request?
Having the default value of isAll in the logical plan nodes
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17185
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21941
Thanks a lot @gatorsmile
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21941
@gatorsmile rebasing in a hope that the test result changes :-)
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21941
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21963
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21941
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21963
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21941
@maropu Is this a transient failure ? Does not seem related to my change ?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21963
@maropu OK. I will create a new JIRA. Actually i missed it in original PR.
@gatorsmile had put a code review comment to add "MINUS" in the documentation
that got me to test th
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/21963
[SPARK-21274][FOLLOWUP] Enable support of MINUS ALL
## What changes were proposed in this pull request?
Enable support for MINUS ALL which was gated at AstBuilder.
## How
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21941
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21941#discussion_r206969310
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1451,6 +1451,15 @@ object SQLConf {
.intConf
Github user dilipbiswal closed the pull request at:
https://github.com/apache/spark/pull/15334
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/15334
@maropu Thanks.. closing it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21941#discussion_r206768063
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1451,6 +1451,15 @@ object SQLConf {
.intConf
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21941#discussion_r206764090
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -535,14 +535,14 @@ abstract class SparkStrategies extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21941#discussion_r206764069
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -535,14 +535,14 @@ abstract class SparkStrategies extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21941#discussion_r206764004
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -165,9 +165,9 @@ object
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/21941
[SPARK-24966][SQL] Implement precedence rules for set operations.
## What changes were proposed in this pull request?
Currently the set operations INTERSECT, UNION and EXCEPT
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21934#discussion_r206682497
--- Diff:
sql/core/src/test/resources/sql-tests/results/table-valued-functions.sql.out ---
@@ -83,8 +83,13 @@ select * from range(1, null
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21934#discussion_r206680796
--- Diff:
sql/core/src/test/resources/sql-tests/results/table-valued-functions.sql.out ---
@@ -83,8 +83,13 @@ select * from range(1, null
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17648
@gatorsmile Sure.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21403#discussion_r206322990
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1422,11 +1422,26 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21403#discussion_r206322597
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1422,11 +1422,26 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21403#discussion_r206304130
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1422,11 +1422,26 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21403#discussion_r206254993
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1422,11 +1422,26 @@ class Analyzer
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21886
@gatorsmile Ok Sean..
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21886#discussion_r205993347
--- Diff:
sql/core/src/test/resources/sql-tests/results/intersect-all.sql.out ---
@@ -0,0 +1,236 @@
+-- Automatically generated
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21886
@gatorsmile Thank you.. I will make the changes.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21886#discussion_r205933642
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1934,6 +1934,23 @@ class Dataset[T] private[sql](
Intersect
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21886
@gatorsmile Rebased.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21857
Thank you very much @gatorsmile @maropu @viirya @ueshin @HyukjinKwon @kiszk
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205667472
--- Diff: sql/core/src/test/resources/sql-tests/inputs/except-all.sql ---
@@ -0,0 +1,146 @@
+CREATE TEMPORARY VIEW tab1 AS SELECT * FROM VALUES
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21886
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21886
@gatorsmile I see this failure in other PRs as well. Is this introduced by
some recent changes ?
---
-
To unsubscribe, e
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21886#discussion_r205596431
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1407,6 +1408,87 @@ object
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21886#discussion_r205596360
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1475,6 +1475,28 @@ def intersect(self, other):
"""
return
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21886#discussion_r205596189
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1407,6 +1408,87 @@ object
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21886#discussion_r205596232
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1933,6 +1933,22 @@ class Dataset[T] private[sql](
Intersect
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205566658
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1400,13 +1401,71 @@ object
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205566676
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1947,6 +1947,21 @@ class Dataset[T] private[sql](
Except
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205566411
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -532,9 +532,13 @@ abstract class SparkStrategies extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205566097
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1400,13 +1401,71 @@ object
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205563598
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -532,9 +532,13 @@ abstract class SparkStrategies extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205563161
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1400,13 +1401,71 @@ object
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205554069
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1400,13 +1401,71 @@ object
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/21886
[SPARK-21274][SQL] Implement INTERSECT ALL clause
## What changes were proposed in this pull request?
Implements INTERSECT ALL clause through query rewrites using existing
operators
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205359199
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1275,6 +1276,64 @@ object
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205352189
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -52,7 +52,7 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21875
@maryannxue It looks good to me. As a minor comment, could we state the
default value for this parameter as well ? For some of the other parameters, we
specify the default value
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205331401
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -52,7 +52,7 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/21857#discussion_r205289050
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1275,6 +1276,64 @@ object
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/21875
@maryannxue We need to update the programming guide ?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
301 - 400 of 1257 matches
Mail list logo
