Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/18804
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/18804
cc @wzhfy @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/18804
[SPARK-21599] Collecting column statistics for datasource tables may fail
with java.util.NoSuchElementException
## What changes were proposed in this pull request?
In case of datasource
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17713
@gatorsmile Thank you very much !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17713
@gatorsmile Just rebased. Thanks !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17713
ping @hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17713
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115665978
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +350,272 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115154716
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -137,32 +137,46 @@ case class In(value
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115154718
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -386,16 +386,12 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17713
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17713
@gatorsmile Thanks a lot. Have addressed your comments. Please check when
you get a chance.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136439
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136422
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1462,7 +1253,7 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136432
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136441
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136427
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -142,27 +142,37 @@ case class In(value
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136437
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136440
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136438
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136429
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1196,206 +1195,6 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136434
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136417
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r115136424
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -142,27 +142,37 @@ case class In(value
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17713
ping @gatorsmile @hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/12646
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r112819365
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r112805110
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/negative-cases/subq-input-typecheck.sql
---
@@ -0,0 +1,47 @@
+-- The test file
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17713#discussion_r112804747
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -414,4 +352,269 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17713
cc @hvanhovell @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/17713
[SPARK-20417][SQL] Move subquery error handling to checkAnalysis from
Analyzer
## What changes were proposed in this pull request?
Currently we do a lot of validations for subquery
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17636
@hvanhovell Thanks a lot.
@gatorsmile Thank you for doing a very thorough review. Really appreciate
it !!
---
If your project is set up for it, you can reply to this email and have your
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r112341084
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
---
@@ -828,6 +828,19 @@ class SubquerySuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r112341135
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
---
@@ -815,7 +815,7 @@ class SubquerySuite extends QueryTest
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17636
@gatorsmile I have addressed the comments. Can you please look at this when
you get a chance. Thanks !!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17679
@viirya i see. Thanks :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17679
@viirya Isn't that a normal thing simon due to column pruning ? Is that
stuff tied to partitioning somehow ?
---
If your project is set up for it, you can reply to this email and have your
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17679
@viirya Ok.. thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17679
@viirya Thank you for a quick fix. The change looks good to me. I have a
question. Before the fix, we changed the output partitioning of relation's
child. But how come it was not reflected
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17636
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111849525
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1362,7 +1389,7 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111849384
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
---
@@ -367,6 +367,8 @@ case class
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17636
cc @gatorsmile @hvanhovell @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111552007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1219,7 +1241,8 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111551729
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1210,6 +1210,28 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111551674
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1219,7 +1241,8 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111551633
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1219,7 +1241,8 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111543471
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1219,7 +1241,8 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111543306
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1219,7 +1241,8 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111543112
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/negative-cases/invalid-correlation.sql
---
@@ -1,42 +1,72 @@
-- The test file
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111543062
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1219,7 +1241,8 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111532514
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1210,6 +1210,28 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111532011
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1210,6 +1210,29 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17636#discussion_r111532029
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1305,6 +1329,8 @@ class Analyzer
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/17636
[SPARK-20334][SQL] Return a better error message when correlated predicates
contain aggregate expression that has mixture of outer and local references.
## What changes were proposed
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17330
@cloud-fan Thanks a lot!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110977254
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -670,4 +677,139 @@ class CachedTableSuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110977330
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -670,4 +677,139 @@ class CachedTableSuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110976069
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -76,6 +76,13 @@ class CachedTableSuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110693397
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -59,6 +58,13 @@ abstract class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110590906
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -401,8 +401,9 @@ abstract class QueryPlan[PlanType
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r110590426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -236,6 +244,12 @@ case class ScalarSubquery
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17330
@cloud-fan Sure Wenchen.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17541
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17541#discussion_r110212520
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -359,9 +359,47 @@ abstract class QueryPlan[PlanType
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17541#discussion_r110091057
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -372,49 +410,19 @@ abstract class QueryPlan[PlanType
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17537
@viirya @cloud-fan @gatorsmile Thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17537#discussion_r109958292
--- Diff:
core/src/test/scala/org/apache/spark/internal/config/ConfigEntrySuite.scala ---
@@ -51,6 +52,26 @@ class ConfigEntrySuite extends
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17537
@cloud-fan Sure. I will add the unit test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/17537
[SPARK-20204][SQL][Followup][WIP] SQLConf should react to change in default
timezone settings
## What changes were proposed in this pull request?
Make sure SESSION_LOCAL_TIMEZONE reflects
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17521
@viirya Thanks !! Actually i assumed the problem is limited only to tests.
I thought changing the timezone on the fly is not a realistic scenario. Looks
like it is :-)
I will submit
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17521
@gatorsmile @cloud-fan @ueshin Sorry .. i was on transit from work. Sure, i
will make a try. However , i wanted to understand this a bit more. In my
understanding, the current problem we
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17521
@cloud-fan @nsyca A quick update.. I ran the problematic tests and they
pass with a change to move the time zone setting code to PlanTest.scala just
before we create the SQLConf like following
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17521
@cloud-fan @nsyca Changing to make it lazy works for the test cases i have
tried. I am running the full tests now.
---
If your project is set up for it, you can reply to this email and have
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/15332
Thanks a lot @ueshin @viirya @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17491#discussion_r109211310
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -90,11 +90,12 @@ trait PredicateHelper
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17491#discussion_r109203721
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -90,11 +90,12 @@ trait PredicateHelper
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17491#discussion_r109191711
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -498,3 +498,31 @@ object
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/15332#discussion_r108726983
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedColumnReader.java
---
@@ -362,7 +375,15 @@ private void
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/15332#discussion_r108604022
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -237,6 +238,30 @@ object DateTimeUtils
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/15332#discussion_r108603952
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaSuite.scala
---
@@ -965,6 +972,18 @@ class
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/15332
@saulshanabrook Hello, thanks for your comment. Currently, i am waiting for
feedback from @liancheng and @davies. Perhaps this is not a priority now. I
will try to resolve the conflicts
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107869502
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,20 @@ object SubqueryExpression
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107713751
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,20 @@ object SubqueryExpression
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107494062
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,20 @@ object SubqueryExpression
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107343122
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107332590
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r107077129
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106884365
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17354
@gatorsmile Thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17354
@gatorsmile Hi Sean, with this fix, do we still require the other fix in
OrcSourceSuite ? We know that it can't hurt.. but it helps expose problems like
this ?
---
If your project is set up
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106840346
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106795788
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -655,6 +663,148 @@ class CachedTableSuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106795772
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,19 @@ object SubqueryExpression
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106795763
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,37 @@ abstract class
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106795750
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -83,6 +116,19 @@ object SubqueryExpression
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17330
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17330#discussion_r106761010
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -61,6 +63,36 @@ abstract class
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17330
cc @hvanhovell @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/17330
[SPARK-19993][SQL] Caching logical plans containing subquery expressions
does not work.
## What changes were proposed in this pull request?
The sameResult() method does not work when
601 - 700 of 1257 matches
Mail list logo
