Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17191
@maropu We may want to implement this extension if mysql and postgres
support it. Just wanted to point you to the past discussions on this topic. Do
we know if hive allows this ?
---
If your
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17191
@maropu Hello, Perhaps you have already seen .. there have been PRs to fix
this in the past. Here are a few i could find -
https://github.com/apache/spark/pull/12794 by @dongjoon-hyun
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16954
@hvanhovell @gatorsmile @nsyca Thank you very much !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16954
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105831346
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -123,19 +123,36 @@ case class Not(child
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105830367
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -365,17 +368,73 @@ object TypeCoercion
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105779054
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -40,19 +43,189 @@ abstract class PlanExpression
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105778315
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -40,19 +43,189 @@ abstract class PlanExpression
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105778426
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1204,80 +1250,44 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105734975
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -40,19 +43,189 @@ abstract class PlanExpression
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r105732875
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -365,17 +368,73 @@ object TypeCoercion
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16954
@hvanhovell I am in the process of incorporating the comments. I will send
an update soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17214
Thank you @gatorsmile @cloud-fan @hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17214#discussion_r105047697
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -46,9 +46,13 @@ class QueryExecution(val sparkSession
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17214#discussion_r105046388
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -46,9 +46,13 @@ class QueryExecution(val sparkSession
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17214#discussion_r105044269
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -46,9 +46,13 @@ class QueryExecution(val sparkSession
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17214#discussion_r105033548
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -46,9 +46,13 @@ class QueryExecution(val sparkSession
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17214#discussion_r105027190
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -46,9 +46,13 @@ class QueryExecution(val sparkSession
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17214#discussion_r105000659
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala ---
@@ -46,9 +46,13 @@ class QueryExecution(val sparkSession
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17214
cc @gatorsmile @cloud-fan Please let me know your thoughts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/17214
[SQL][MINOR] The analyzer rules are fired twice for cases when
AnalysisException is raised from analyzer.
## What changes were proposed in this pull request?
In general we have
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r104301109
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -109,6 +109,26 @@ object TypeCoercion
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103995282
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -21,12 +21,13 @@ import scala.annotation.tailrec
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16954
@gatorsmile Thank you. I have addressed the comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103881081
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1172,20 +1226,11 @@ class Analyzer
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16954
@hvanhovell Hello Herman, I have addressed all your comments except one
where you are suggesting an optimization to failOnOuterReferenceInSubTree(). I
am trying to see how i can improve
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103600773
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -40,19 +42,179 @@ abstract class PlanExpression
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103426702
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1110,31 +1184,24 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103415750
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1398,42 +1399,46 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103411993
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -40,19 +42,179 @@ abstract class PlanExpression
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103398818
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -707,13 +709,85 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103384302
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1398,42 +1399,46 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103363226
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -707,13 +709,85 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103363171
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -40,19 +42,179 @@ abstract class PlanExpression
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103362319
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -123,19 +123,36 @@ case class Not(child
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103359052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -109,6 +109,26 @@ object TypeCoercion
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103354299
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala
---
@@ -40,19 +42,179 @@ abstract class PlanExpression
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103353840
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2512,3 +2522,67 @@ object ResolveCreateNamedStruct
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103347540
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -2332,6 +2337,11 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r103346762
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1110,31 +1184,24 @@ class Analyzer
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17060
Thank you @srowen @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/17060
cc @srowen addressed your comments. Could you please check again ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17060#discussion_r103071356
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -241,7 +243,8 @@ class SQLQueryTestSuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17060#discussion_r103070909
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -98,7 +98,9 @@ class SQLQueryTestSuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17060#discussion_r103070711
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -241,7 +243,8 @@ class SQLQueryTestSuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17060#discussion_r103070622
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala ---
@@ -121,7 +123,7 @@ class SQLQueryTestSuite extends QueryTest
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/17060
[SQL] Duplicate test exception in SQLQueryTestSuite due to meta
files(.DS_Store) on Mac
## What changes were proposed in this pull request?
After adding the tests for subquery, we now have
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16954
@hvanhovell Hi Herman, was wondering if you had some time to look into this
PR ? Please let me know your thoughts.
---
If your project is set up for it, you can reply to this email and have
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r101618763
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -158,17 +160,7 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16246#discussion_r101618460
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -136,24 +140,35 @@ trait CheckAnalysis extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r101598818
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -365,17 +385,66 @@ object TypeCoercion
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r101597685
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
---
@@ -83,29 +95,150 @@ object RewritePredicateSubquery
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16954#discussion_r101597000
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
---
@@ -622,7 +622,12 @@ class SubquerySuite extends QueryTest
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16954
cc @hvanhovell @gatorsmile @nsyca
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/16954
[SPARK-18874][SQL] First phase: Deferring the correlated predicate pull up
to Optimizer phase
## What changes were proposed in this pull request?
Currently Analyzer as part
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16802
@hvanhovell Thank you very much Herman !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16802
cc @hvanhovell @gatorsmile
Thanks @nsyca @dongjoon-hyun for reviewing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16847
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16847
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16760
Many thanks @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16760
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16760
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16760
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16760
@gatorsmile Yeah Sean. Actually most likely i will need to work out a
different schema than what i have currently for the generator tests. So i was
planning to add the negative scenarios
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16760
@gatorsmile Currently for exists we are missing 1) Negative scenarios 2)
Generators (there is one test case in subquerysuite) for it.
---
If your project is set up for it, you can reply
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16802#discussion_r99499014
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/exists-subquery/exists-joins-and-set-ops.sql
---
@@ -0,0 +1,206 @@
+-- Tests EXISTS
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16760
@gatorsmile Thanks a lot for reviewing. @nsyca and i had a brief discussion
about this. Yeah, we will remove the duplicate test cases from
SubquerySuite.scala. However , we wanted to keep all
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/16802
[SPARK-18872][SQL][TESTS] New test cases for EXISTS subquery (Joins + CTE)
## What changes were proposed in this pull request?
This PR adds the third and final set of tests for EXISTS
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16798#discussion_r99454377
--- Diff:
sql/core/src/test/resources/sql-tests/results/subquery/scalar-subquery/scalar-subquery-predicate.sql.out
---
@@ -0,0 +1,407
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16759#discussion_r98807968
--- Diff:
sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/in-limit.sql.out
---
@@ -0,0 +1,147 @@
+-- Automatically generated
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16759#discussion_r98807939
--- Diff:
sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/in-order-by.sql.out
---
@@ -0,0 +1,328 @@
+-- Automatically generated
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16759#discussion_r98807908
--- Diff:
sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/not-in-group-by.sql.out
---
@@ -0,0 +1,150 @@
+-- Automatically
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16760
cc @hvanhovell @gatorsmile @nsyca
@nsyca Thanks for reviewing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/16760
[SPARK-18872][SQL][TESTS] New test cases for EXISTS subquery (Aggregate,
Having, Orderby, Limit)
## What changes were proposed in this pull request?
This PR adds the second set
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16710
Thank you very much @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16710
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16710#discussion_r98346290
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/subquery/exists-subquery/exists-basic.sql
---
@@ -0,0 +1,115 @@
+-- Tests EXISTS subquery
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16710
cc @hvanhovell @gatorsmile @nsyca
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/16710
[SPARK-18872] New test cases for EXISTS subquery
## What changes were proposed in this pull request?
This PR adds the first set of tests for EXISTS subquery.
- exists-basic.sql
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16688
@gatorsmile @srowen @viirya Thank you very much !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16688#discussion_r97864526
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -39,6 +39,8 @@ private case class BigData(s: String)
class
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16688
@gatorsmile Sure Sean. Will do
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16688
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16688
cc @cloud-fan @gatorsmile Could you please trigger a test for this. Not
sure why the last run didn't succeed. Thanks a lot.
---
If your project is set up for it, you can reply to this email
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/16688
[TESTS][SQL] Setup testdata at the beginning for tests to run independently
## What changes were proposed in this pull request?
In CachedTableSuite, we are not setting up the test data
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16493
Thank you very much @gatorsmile @hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/16493
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16493#discussion_r95052038
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -565,4 +567,82 @@ class CachedTableSuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16493#discussion_r95051398
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -131,6 +132,12 @@ class CacheManager extends Logging
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16493#discussion_r95050805
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala ---
@@ -131,6 +132,12 @@ class CacheManager extends Logging
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/16493#discussion_r95050799
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
@@ -565,4 +567,82 @@ class CachedTableSuite extends QueryTest
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/16493
[SPARK-19093][SQL] Cached tables are not used in SubqueryExpression
## What changes were proposed in this pull request?
Consider the plans inside subquery expressions while looking up cache
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/15958
@gatorsmile Thank you for cc'ing me. Overall it looks good to me.
I have a few observations/comments that i would list below which hopefully
should help us
decide.
1) Hive
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/15968
@gatorsmile Thanks .. updated !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/15968#discussion_r89164848
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -322,7 +322,26 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/15968#discussion_r89158685
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -71,11 +71,7 @@ statement
| createTableHeader
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/15968
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/15968#discussion_r89054853
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/CreateTableAsSelectSuite.scala
---
@@ -249,4 +249,13 @@ class CreateTableAsSelectSuite
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/15968
[SPARK-18533] Raise correct error upon specification of schema for
datasource tables created using CTAS
## What changes were proposed in this pull request?
Fixes the inconsistency of error
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/15642
Thank you so much @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
701 - 800 of 1257 matches
Mail list logo
