Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-214939215
@liancheng Thank you very much Lian !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12703#discussion_r61180561
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -112,3 +116,107 @@ case class ExplainCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12703#discussion_r61179510
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -112,3 +116,107 @@ case class ExplainCommand
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/12460#issuecomment-214852703
@liancheng Hi Lian, can you please look over this PR and give some
comments. Thanks !!
---
If your project is set up for it, you can reply to this email and have
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-214847459
@liancheng Hi Lian, i just pushed my branch which has the new test case for
your reference. It also has all your comments addressed :-)
---
If your project is set
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12703#discussion_r61129992
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -112,3 +116,107 @@ case class ExplainCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12703#discussion_r61126850
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -247,4 +259,105 @@ class HiveCommandSuite extends
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-214815027
@liancheng I had all the comments addressed and had left the tests running
last night was about to push today :-). Anyways thanks !! I will take a look at
your PR
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r61027608
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -122,4 +134,105 @@ class HiveCommandSuite extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r61006959
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/PartitioningUtils.scala
---
@@ -424,7 +424,7 @@ private[sql] object
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r61004951
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +426,102 @@ case class ShowTablePropertiesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r61004685
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +426,102 @@ case class ShowTablePropertiesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r61003756
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -277,9 +277,18 @@ class InMemoryCatalog
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/12460#issuecomment-212557057
rebased..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12460#discussion_r60357946
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -254,6 +251,21 @@ class SparkSqlAstBuilder extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12460#discussion_r60347793
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -254,6 +251,21 @@ class SparkSqlAstBuilder extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12460#discussion_r60335414
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -254,6 +251,21 @@ class SparkSqlAstBuilder extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12460#discussion_r60180497
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -254,6 +251,21 @@ class SparkSqlAstBuilder extends
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/12460#issuecomment-211169665
@gatorsmile Thank you. I have resolved the conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/12460#issuecomment-211163482
@andrewor14 Looking for some early feedback on this as i was thinking to
do the same for show table extended. I did have a brief discussion with
@gatorsmile
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/12460
[SPARK-14127] Describe table
## What changes were proposed in this pull request?
This PR adds .support for describing partitions and columns. Support for
describing
tables were already
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-210294481
@andrewor14 Thank you for a detailed review. I have implemented your
comments. A few points/questions.
1) Currently InMemoryCatalog does not make use
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59791626
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59781546
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59688027
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
---
@@ -404,6 +404,28 @@ private[hive] class HiveClientImpl
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59687762
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -409,6 +409,25 @@ class SessionCatalog
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59687495
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59687465
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59687345
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59687188
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59687220
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -423,6 +424,100 @@ case class ShowTablePropertiesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59686964
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -122,4 +133,103 @@ class HiveCommandSuite extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/1#discussion_r59686977
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -122,4 +133,103 @@ class HiveCommandSuite extends
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-206636426
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/1#issuecomment-206625534
Currently i throw an exception for data source tables as in my
understanding the
partition spec metadata is not available in the hive meta store. I saw a
[PR
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/1
[SPARK-14445][SQL] Support native execution of SHOW COLUMNS and SHOW
PARTITIONS
## What changes were proposed in this pull request?
This PR adds Native execution of SHOW COLUMNS and SHOW
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/12133#issuecomment-205475281
cc @hvanhovell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58315301
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,54 @@ case class ShowDatabasesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58308812
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,52 @@ case class ShowDatabasesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58308134
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -0,0 +1,127 @@
+/*
+ * Licensed
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58308056
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,52 @@ case class ShowDatabasesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307650
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,52 @@ case class ShowDatabasesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307599
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,52 @@ case class ShowDatabasesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307554
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -0,0 +1,127 @@
+/*
+ * Licensed
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307532
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,52 @@ case class ShowDatabasesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307516
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,52 @@ case class ShowDatabasesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307464
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -374,6 +374,52 @@ case class ShowDatabasesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307452
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -238,16 +238,20 @@ class SparkSqlAstBuilder extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58307447
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -93,6 +93,23 @@ class SparkSqlAstBuilder extends AstBuilder
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58300131
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -93,6 +93,23 @@ class SparkSqlAstBuilder extends AstBuilder
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/12133#discussion_r58299837
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -272,6 +272,22 @@ class SessionCatalog
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/12133
[SPARK-14348][SQL] Support native execution of SHOW TBLPROPERTIES command
## What changes were proposed in this pull request?
This PR adds Native execution of SHOW TBLPROPERTIES
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/12125#issuecomment-204796981
@hvanhovell @bomeng I see that we hit the same error for other PRs as well.
- FYI
---
If your project is set up for it, you can reply to this email and have your
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11991#issuecomment-204474413
@hvanhovell Thank you, Herman.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11991#issuecomment-204127378
cc @andrewor14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11991#issuecomment-204064015
@andrewor14 Hi Andrew, just rebased. - FYI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57977077
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -370,13 +370,33 @@ private[sql] class SparkQl(conf: ParserConf
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57970378
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -370,13 +370,33 @@ private[sql] class SparkQl(conf: ParserConf
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57970436
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -322,18 +322,17 @@ case class DescribeCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57970312
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -70,12 +70,26 @@ class SparkSqlAstBuilder extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57955257
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -838,6 +839,8 @@ OUTPUTFORMAT: 'OUTPUTFORMAT
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57929969
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -31,9 +31,11 @@ class DDLSuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57918497
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -31,9 +31,11 @@ class DDLSuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57907320
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -31,9 +31,11 @@ class DDLSuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57907169
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2376,4 +2376,47 @@ class SQLQuerySuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57841828
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ng/ParserUtils.scala
---
@@ -24,6 +24,7 @@ import
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57802500
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -70,12 +70,28 @@ class SparkSqlAstBuilder extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57800444
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -107,7 +107,8 @@ statement
| DROP TEMPORARY
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57799009
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -350,6 +354,34 @@ case class ShowTablesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57795477
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/commands.scala
---
@@ -350,6 +354,34 @@ case class ShowTablesCommand
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57795331
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -70,12 +70,28 @@ class SparkSqlAstBuilder extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57793590
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -70,12 +70,28 @@ class SparkSqlAstBuilder extends
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57793412
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -107,7 +107,8 @@ statement
| DROP TEMPORARY
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57793349
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/ng/SqlBase.g4
---
@@ -107,7 +107,8 @@ statement
| DROP TEMPORARY
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11991#issuecomment-202769968
@rxin Yes.. I am working on using the new ANTLR4 parser. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11991#issuecomment-202638668
@hvanhovell Sure Herman. I will give it a try and get back to you with
questions :-)
---
If your project is set up for it, you can reply to this email and have
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11991#discussion_r57646589
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkQl.scala ---
@@ -369,13 +369,33 @@ private[sql] class SparkQl(conf: ParserConf
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11991#issuecomment-202239700
@gatorsmile Thanks for your review. I have addressed most of your comments
except the last one. Currently create/drop database commands are not supported
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11991#issuecomment-202211555
cc @gatorsmile @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/11991
[SPARK-14184][SQL] Support native execution of SHOW DATABASE command and
fix SHOW TABLE to use table identifier pattern
## What changes were proposed in this pull request?
This PR
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-197560109
cc @marmbrus
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-197978987
@marmbrus Thank you very much Michael !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56459052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1329,48 +1329,72 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56101664
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1339,43 +1339,68 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56101632
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala ---
@@ -458,43 +458,14 @@ class DataFrame private[sql](
Join
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56101653
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1339,43 +1339,68 @@ class Analyzer
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r56101613
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2178,4 +2178,62 @@ class SQLQuerySuite extends QueryTest
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11696#discussion_r56101117
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -316,31 +345,73 @@ class SQLBuilder(logicalPlan: LogicalPlan
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11563#issuecomment-196558236
Closing this in favor of
[#11696] (http://github.com/apache/spark/pull/11696)
---
If your project is set up for it, you can reply to this email and have your
Github user dilipbiswal closed the pull request at:
https://github.com/apache/spark/pull/11563
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11596#issuecomment-196557733
Closing this in favor of
[#11696] (http://github.com/apache/spark/pull/11696)
---
If your project is set up for it, you can reply to this email and have your
Github user dilipbiswal closed the pull request at:
https://github.com/apache/spark/pull/11596
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11696#discussion_r56057620
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -316,31 +345,73 @@ class SQLBuilder(logicalPlan: LogicalPlan
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11696#issuecomment-196477766
@cloud-fan Thank you. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11596#issuecomment-195435909
@cloud-fan Can you please help trigger a retest ? This does not seem
related to my changes.
---
If your project is set up for it, you can reply to this email
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11596#discussion_r55791864
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -94,6 +94,12 @@ class SQLBuilder(logicalPlan: LogicalPlan
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-195015526
@gatorsmile Thanks !! I have rebased the code now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/11297#issuecomment-195014561
@marmbrus Hi Michael, i have changed the code per your feedback. As part of
this change, i have also cleaned up dataframe's using join to make use of the
new code
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11297#discussion_r55589677
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -72,6 +72,19 @@ case class UnresolvedAttribute
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/11596#discussion_r55484267
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -297,6 +303,65 @@ class SQLBuilder(logicalPlan: LogicalPlan
901 - 1000 of 1257 matches
Mail list logo
