Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/13706
cc @gatorsmile could you take a look at the way this interacts with the
session catalog and the function registry?
---
If your project is set up for it, you can reply to this email and have
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118846647
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r11884
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118844341
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118844463
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118844485
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -716,6 +716,37 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118845133
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1516,6 +1516,35 @@ abstract class DDLSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118845109
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1516,6 +1516,35 @@ abstract class DDLSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118844675
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
---
@@ -107,6 +110,14 @@ class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118844322
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -1516,6 +1516,35 @@ abstract class DDLSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118844357
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118844274
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118845638
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -1090,6 +1090,24 @@ class SessionCatalog
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118846490
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118844406
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13706#discussion_r118844209
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/macros.scala ---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118842688
--- Diff: sql/core/src/test/resources/sql-tests/inputs/aliases.sql ---
@@ -0,0 +1,17 @@
+-- Test data.
--- End diff --
How about we name
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118842345
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -676,9 +676,12 @@ class AstBuilder(conf: SQLConf
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118842292
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -676,9 +676,12 @@ class AstBuilder(conf: SQLConf
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18079#discussion_r118842186
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -711,7 +711,7 @@ nonReserved
| ADD
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18072
LGTM - pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18069
I don't think this makes any sense:
- The parser is not the place where you should make this change. This
should be done in `TypeCoercion`. Now we create different semantics between SQL
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18023#discussion_r117813681
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1188,6 +1188,12 @@ class Dataset[T] private[sql](
def col(colName
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18057
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18054
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18005
LGTM - merging to master/2.2. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18030
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18023#discussion_r117367232
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -84,6 +84,33 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18023#discussion_r117379878
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1230,24 +1230,49 @@ class AstBuilder(conf: SQLConf
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18023#discussion_r117367155
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -84,6 +84,33 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18023#discussion_r117380037
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1230,24 +1230,49 @@ class AstBuilder(conf: SQLConf
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18023#discussion_r117366828
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -84,6 +84,33 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18023#discussion_r117368022
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1230,24 +1230,49 @@ class AstBuilder(conf: SQLConf
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18023#discussion_r117380055
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1230,24 +1230,49 @@ class AstBuilder(conf: SQLConf
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18023#discussion_r117367722
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1230,24 +1230,49 @@ class AstBuilder(conf: SQLConf
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18019#discussion_r117289000
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1268,6 +1268,59 @@ case class Ascii
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18019#discussion_r117378356
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1268,6 +1268,59 @@ case class Ascii
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18019#discussion_r117378811
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala ---
@@ -117,6 +117,41 @@ class StringFunctionsSuite extends QueryTest
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18019#discussion_r117375988
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1268,6 +1268,59 @@ case class Ascii
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18019#discussion_r117378749
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2138,6 +2138,40 @@ object functions {
def ascii(e: Column): Column
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18019#discussion_r117250411
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1268,6 +1268,59 @@ case class Ascii
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18019#discussion_r117376928
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1268,6 +1268,59 @@ case class Ascii
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18019#discussion_r117375494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1268,6 +1268,59 @@ case class Ascii
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18019#discussion_r117376367
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1268,6 +1268,59 @@ case class Ascii
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18019#discussion_r117250008
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1268,6 +1268,59 @@ case class Ascii
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18030
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18030
LGTM - pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18012
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18012
(let's see if jenkins picks this up)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18019#discussion_r117076510
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -1268,6 +1268,59 @@ case class Ascii
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18005
What do you mean by catalyst blew up?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18005
LGTM pending jenkins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18005#discussion_r117029865
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetWriteSupport.scala
---
@@ -90,7 +90,7 @@ private[parquet
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/18005#discussion_r117029723
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetWriteSupport.scala
---
@@ -90,7 +90,7 @@ private[parquet
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18016
+1 on Sean's comment. This is **not** a parser issue. Can you just fix this
by adding `LongType` to `Ceil.inputTypes`?
---
If your project is set up for it, you can reply to this email and have
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18005
Can you also make sure that we do not use a `Seq` for struct writing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/18005
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17935#discussion_r116851595
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -473,7 +473,7 @@ identifierComment
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/18006
[SQL][TRIVIAL] Lower parser log level to debug
## What changes were proposed in this pull request?
Currently the parser logs the query it is parsing at `info` level. This is
too high
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17993#discussion_r116794140
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -54,6 +54,59 @@ object ConstantFolding extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17993#discussion_r116793889
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -54,6 +54,59 @@ object ConstantFolding extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17993#discussion_r116792863
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -54,6 +54,59 @@ object ConstantFolding extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17993#discussion_r116792029
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -54,6 +54,59 @@ object ConstantFolding extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17993#discussion_r116790844
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -54,6 +54,59 @@ object ConstantFolding extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17993#discussion_r116790653
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
---
@@ -54,6 +54,59 @@ object ConstantFolding extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17998
@shaneknapp is amplap jenkins down?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17935#discussion_r116756100
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -473,7 +473,7 @@ identifierComment
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17899#discussion_r116719332
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/TransposeWindowSuite.scala
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17899#discussion_r116719142
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/TransposeWindowSuite.scala
---
@@ -0,0 +1,101 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17899#discussion_r116718934
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFunctionsSuite.scala
---
@@ -423,4 +423,25 @@ class DataFrameWindowFunctionsSuite
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17899#discussion_r116718847
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -609,6 +610,19 @@ object CollapseWindow extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17899#discussion_r116696350
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -609,6 +610,19 @@ object CollapseWindow extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17899#discussion_r116693306
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -609,6 +610,19 @@ object CollapseWindow extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17899
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17993
it is weird that jenkins is not kicking off
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17993
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17935#discussion_r116561216
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala
---
@@ -868,6 +868,29 @@ class SubquerySuite extends QueryTest
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17964
@cloud-fan can you backport this to 2.1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17964
LGTM - merging to master/2.2/2.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17964
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17960
LGTM - merging to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17964#discussion_r116306324
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -429,17 +429,13 @@ object QueryPlan
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17960#discussion_r116300475
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -279,7 +279,12 @@ class AstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17953#discussion_r116138305
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -1504,6 +1504,7 @@ class AstBuilder extends
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17953
@LantaoJin Can you add a description and a test case for this? You can take
a look at the OrcSourceSuite to get an idea how to work with Hive.
---
If your project is set up for it, you can
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17953
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17939
LGTM - merging to master/2.2. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17920
LGTM - merging to master/2.2. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17921
LGTM - merging to master/2.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17899#discussion_r115370303
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -609,6 +610,19 @@ object CollapseWindow extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115361494
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -57,19 +57,21 @@ object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115361167
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -57,19 +57,21 @@ object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115358211
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -441,4 +440,15 @@ class AnalysisSuite extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/17666#discussion_r115357687
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -498,12 +498,16 @@ case class Sort
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17736
For some reference. In 1.6 we used the Catalyst SqlParser to parse the
expression in `Dataframe.filter()`, and we used the Hive (ANTLR based) parser
for parsing for SQL commands. In Spark 2.0 we
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17770
I am not a giant fan of the `resolveOperators*` approach, is is yet another
code path that does something similar to the `transfrom*` code path, it
introduces some mutable state, and I have been
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17836
cc @michal-databricks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17838
LGTM - merging to master/2.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17823
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/17784
Yes, it can. Merging to master/2.2. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
701 - 800 of 4165 matches
Mail list logo
