[GitHub] spark pull request #22624: [SPARK-23781][CORE] Add base class for token rene...

2018-10-08 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22624#discussion_r223472701 --- Diff: core/src/main/scala/org/apache/spark/deploy/security/AbstractCredentialRenewer.scala --- @@ -0,0 +1,224 @@ +/* + * Licensed

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-10-08 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r223467868 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala --- @@ -0,0 +1,161

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-10-08 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r223461972 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/HadoopConfExecutorFeatureStep.scala --- @@ -0,0 +1,51

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-10-08 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r223461492 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/KerberosConfDriverFeatureStep.scala --- @@ -0,0 +1,161

[GitHub] spark issue #22608: [SPARK-23257][K8S][TESTS] Kerberos Support Integration T...

2018-10-06 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22608 > for now it's probably ok, but is there a solution before the next release? This integration-test suite works seemlessly and is quite robust when rebased on-top of the Kerberos PR.

[GitHub] spark issue #22624: [SPARK-23781][CORE] Add base class for token renewal fun...

2018-10-06 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22624 If we are talking about the token renewal functionality, could we possibly refactor the `HadoopFSDelegationTokenProvider` as well. I found that within the function `obtainDelegationTokens

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-10-06 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r223198885 --- Diff: docs/security.md --- @@ -722,6 +722,67 @@ with encryption, at least. The Kerberos login will be periodically renewed using the provided

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-10-06 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/21669 Thank you for all of your reviews @mccheah @liyinan926 @vanzin . I have resolved the comments and am wondering if there are any further comments before this is in a state that is ready to merge

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-10-06 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r223198790 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/HadoopGlobalFeatureDriverStep.scala --- @@ -0,0 +1,151

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-10-06 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r223198761 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/HadoopGlobalFeatureDriverStep.scala --- @@ -0,0 +1,151

[GitHub] spark issue #22608: [SPARK-23257][K8S][TESTS] Kerberos Support Integration T...

2018-10-06 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22608 @erikerlandson the clusterrolebinding is something the user testing should set up. As such, we may disregard that bullet-point from the conversation. However, I am wondering what are thoughts

[GitHub] spark issue #22608: [SPARK-23257][K8S][TESTS] Kerberos Support Integration T...

2018-10-02 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22608 @mccheah @liyinan926 @erikerlandson for review Things to note: - [ ] `clusterrolebindings` might be needed to ensure driver can setup necessary resources. - [ ] Any way

[GitHub] spark pull request #22608: [SPARK-23257][K8S][TESTS] Kerberos Support Integr...

2018-10-02 Thread ifilonenko
GitHub user ifilonenko opened a pull request: https://github.com/apache/spark/pull/22608 [SPARK-23257][K8S][TESTS] Kerberos Support Integration Tests ## What changes were proposed in this pull request? This fix includes just the integration tests for Kerberos Support

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-10-01 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r221735293 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/HadoopGlobalFeatureDriverStep.scala --- @@ -0,0 +1,151

[GitHub] spark issue #22588: [SPARK-25262][DOC][FOLLOWUP] Fix link tags in html table

2018-09-29 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22588 LGTM --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-26 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/21669 This PR is now ready for another round of review as the login logic has been refactored and simplified and docs have been added

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-09-26 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r220770479 --- Diff: docs/security.md --- @@ -722,6 +722,62 @@ with encryption, at least. The Kerberos login will be periodically renewed using the provided

[GitHub] spark issue #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize keytab...

2018-09-26 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22362 Thank you for the speedy review @vanzin! I appreciate it :) --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #19045: [WIP][SPARK-20628][CORE] Keep track of nodes (/ s...

2018-09-26 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/19045#discussion_r220672041 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DecommissionSuite.scala --- @@ -0,0

[GitHub] spark issue #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize keytab...

2018-09-25 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22362 @vanzin and @felixcheung can you please merge --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-25 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22362#discussion_r220364426 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -726,7 +726,11 @@ private[spark] object SparkConf extends Logging

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-25 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22362#discussion_r220356187 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -726,7 +726,11 @@ private[spark] object SparkConf extends Logging

[GitHub] spark issue #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize keytab...

2018-09-25 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22362 @vanzin any further comments? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-21 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22362#discussion_r219638207 --- Diff: R/pkg/R/sparkR.R --- @@ -624,8 +624,8 @@ sparkConfToSubmitOps[["spark.driver.extraClassPath"]] <- "-

[GitHub] spark issue #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize keytab...

2018-09-21 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22362 @vanzin @felixcheung another review please could you also run a YarnSecureHDFS test with old configs to test backporting capabilities. I am blocked on this PR before doing a slight

[GitHub] spark issue #22376: [SPARK-25021][K8S][BACKPORT] Add spark.executor.pyspark....

2018-09-20 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22376 Closing as PR has been merged --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #22376: [SPARK-25021][K8S][BACKPORT] Add spark.executor.p...

2018-09-20 Thread ifilonenko
Github user ifilonenko closed the pull request at: https://github.com/apache/spark/pull/22376 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark issue #22376: [SPARK-25021][K8S][BACKPORT] Add spark.executor.pyspark....

2018-09-20 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22376 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22376: [SPARK-25021][K8S][BACKPORT] Add spark.executor.pyspark....

2018-09-18 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22376 @holdenk @liyinan926 ready for merge --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22376: [SPARK-25021][K8S][BACKPORT] Add spark.executor.pyspark....

2018-09-18 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22376 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor Pod test...

2018-09-17 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22415 @holdenk @felixcheung @liyinan926 further thoughts before merging? --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #22433: Support STS to run in k8s deployments with spark deploym...

2018-09-15 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22433 test this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark pull request #22416: [SPARK-25291][K8S][BACKPORT] Fixing Flakiness of ...

2018-09-14 Thread ifilonenko
Github user ifilonenko closed the pull request at: https://github.com/apache/spark/pull/22416 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h

[GitHub] spark pull request #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor P...

2018-09-14 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22415#discussion_r217609720 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala

[GitHub] spark pull request #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor P...

2018-09-13 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22415#discussion_r217561045 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala

[GitHub] spark pull request #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor P...

2018-09-13 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22415#discussion_r217560220 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala

[GitHub] spark issue #22416: [SPARK-25291][K8S][BACKPORT] Fixing Flakiness of Executo...

2018-09-13 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22416 Yes @linyinan926 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews

[GitHub] spark issue #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor Pod test...

2018-09-13 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22415 @holdenk @liyinan926 @felixcheung for merge since @mccheah is out --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #22416: [SPARK-25291][K8S][BACKPORT] Fixing Flakiness of Executo...

2018-09-13 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22416 @holdenk @liyinan926 @felixcheung for merge since @mccheah is on vacation --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark issue #22376: [SPARK-25021][K8S][BACKPORT] Add spark.executor.pyspark....

2018-09-13 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22376 This PR is waiting on https://github.com/apache/spark/pull/22416. And should then be stable on the K8s end for merging

[GitHub] spark pull request #22416: [SPARK-25291][K8S][BACKPORT] Fixing Flakiness of ...

2018-09-13 Thread ifilonenko
GitHub user ifilonenko opened a pull request: https://github.com/apache/spark/pull/22416 [SPARK-25291][K8S][BACKPORT] Fixing Flakiness of Executor Pod tests ## What changes were proposed in this pull request? Added fix to flakiness that was present in PySpark tests w.r.t

[GitHub] spark issue #22416: [SPARK-25291][K8S][BACKPORT] Fixing Flakiness of Executo...

2018-09-13 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22416 @mccheah for merge --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor Pod test...

2018-09-13 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22415 @mccheah for merge --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #22415: [SPARK-25291][K8S] Fixing Flakiness of Executor P...

2018-09-13 Thread ifilonenko
GitHub user ifilonenko opened a pull request: https://github.com/apache/spark/pull/22415 [SPARK-25291][K8S] Fixing Flakiness of Executor Pod tests ## What changes were proposed in this pull request? Added fix to flakiness that was present in PySpark tests w.r.t Executors

[GitHub] spark issue #22376: [SPARK-25021][K8S][BACKPORT] Add spark.executor.pyspark....

2018-09-11 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22376 This flakiness of integration tests seems in relation to the executor issue logged by [SPARK-25291]. Will require a separate PR to master and `2.4`. Still not related to this PR however. (Odd

[GitHub] spark issue #22376: [SPARK-25021][K8S][BACKPORT] Add spark.executor.pyspark....

2018-09-11 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22376 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22376: [SPARK-25021][K8S][BACKPORT] Add spark.executor.pyspark....

2018-09-10 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22376 @holdenk @felixcheung can this be merged as error isn't related to the features presented in this PR? --- - To unsubscribe

[GitHub] spark issue #22376: [SPARK-25021][K8S][BACKPORT] Add spark.executor.pyspark....

2018-09-10 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22376 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22376: [SPARK-25021][K8S][BACKPORT] Add spark.executor.pyspark....

2018-09-10 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22376 the unit test flakiness is unrelated --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional

[GitHub] spark issue #22376: [SPARK-25021][K8S][BACKPORT] Add spark.executor.pyspark....

2018-09-09 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22376 @felixcheung @holdenk --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #22376: [SPARK-25021][K8S][BACKPORT] Add spark.executor.p...

2018-09-09 Thread ifilonenko
GitHub user ifilonenko opened a pull request: https://github.com/apache/spark/pull/22376 [SPARK-25021][K8S][BACKPORT] Add spark.executor.pyspark.memory limit for K8S ## What changes were proposed in this pull request? Add spark.executor.pyspark.memory limit for K8S

[GitHub] spark issue #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.memory lim...

2018-09-07 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22298 @holdenk or @mccheah for merge --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-09-07 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r216103359 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadoopsteps/HadoopKerberosKeytabResolverStep.scala

[GitHub] spark pull request #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize...

2018-09-07 Thread ifilonenko
GitHub user ifilonenko opened a pull request: https://github.com/apache/spark/pull/22362 [SPARK-25372][YARN][K8S] Deprecate and generalize keytab / principal config ## What changes were proposed in this pull request? SparkSubmit already logs in the user if a keytab

[GitHub] spark issue #22362: [SPARK-25372][YARN][K8S] Deprecate and generalize keytab...

2018-09-07 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22362 @vanzin for review --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-09-05 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r215471255 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesConf.scala --- @@ -60,7 +62,23 @@ private[spark] case

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-09-05 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r215471079 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala --- @@ -225,6 +225,60 @@ private[spark] object

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-09-05 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r215470727 --- Diff: docs/security.md --- @@ -722,6 +722,62 @@ with encryption, at least. The Kerberos login will be periodically renewed using the provided

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-09-05 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r215470379 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadoopsteps/HadoopStepsOrchestrator.scala --- @@ -0,0

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-09-05 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r215470115 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadoopsteps/HadoopKerberosSecretResolverStep.scala

[GitHub] spark pull request #21669: [SPARK-23257][K8S] Kerberos Support for Spark on ...

2018-09-05 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r215469488 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadoopsteps/HadoopKerberosKeytabResolverStep.scala

[GitHub] spark issue #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.memory lim...

2018-09-04 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22298 @felixcheung @holdenk I have moved the PySpark example files to a more appropriate location. Any other comments before merge

[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

2018-09-04 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22145 this PR is waiting on @shaneknapp to migrate to ubuntu and have R setup in the node responsible for distribution building. This was planning on being done right after the 2.4 cut

[GitHub] spark issue #21669: [SPARK-23257][K8S] Kerberos Support for Spark on K8S

2018-09-04 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/21669 This PR has been tested and passed on a local cluster with an integration test that will be merged in a follow-up PR. It passes all three configuration options. It is now in a state

[GitHub] spark pull request #21669: [SPARK-23257][K8S][WIP] Kerberos Support for Spar...

2018-09-04 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r215057079 --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala --- @@ -164,7 +164,15 @@ private[spark] class SparkSubmit extends Logging

[GitHub] spark pull request #21669: [SPARK-23257][K8S][WIP] Kerberos Support for Spar...

2018-09-04 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r214981406 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/hadoopsteps/HadoopBootstrapUtil.scala --- @@ -0,0

[GitHub] spark pull request #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.mem...

2018-09-02 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22298#discussion_r214543937 --- Diff: examples/src/main/python/worker_memory_check.py --- @@ -0,0 +1,47 @@ +# --- End diff -- That might be a good place

[GitHub] spark issue #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.memory lim...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22298 @mccheah as such, that should be a followup PR and this should be good to merge as long as @holdenk gives a LGTM

[GitHub] spark issue #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.memory lim...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22298 @holdenk and @mccheah any other comments before merge? --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

[GitHub] spark pull request #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.mem...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22298#discussion_r214495391 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala --- @@ -51,6 +51,7

[GitHub] spark issue #21669: [SPARK-23257][K8S][WIP] Kerberos Support for Spark on K8...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/21669 @vanzin This PR does not include the renew service pod as that will live as a separate micro-service. But the current design has the `KubernetesClient` creating the delegation tokens and storing

[GitHub] spark pull request #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.mem...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22298#discussion_r214416261 --- Diff: examples/src/main/python/worker_memory_check.py --- @@ -0,0 +1,47 @@ +# --- End diff -- Easiest place to put to be trivially

[GitHub] spark pull request #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.mem...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22298#discussion_r214415839 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala

[GitHub] spark pull request #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.mem...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22298#discussion_r214411915 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala

[GitHub] spark pull request #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.mem...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22298#discussion_r214411462 --- Diff: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/python/Dockerfile --- @@ -33,6 +32,7 @@ RUN apk add --no-cache python

[GitHub] spark pull request #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.mem...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22298#discussion_r214411589 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PythonTestsSuite.scala

[GitHub] spark pull request #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.mem...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22298#discussion_r214411403 --- Diff: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings/R/Dockerfile --- @@ -19,10 +19,10 @@ ARG base_img FROM $base_img

[GitHub] spark pull request #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.mem...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22298#discussion_r214411255 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala --- @@ -58,6 +58,15

[GitHub] spark pull request #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.mem...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22298#discussion_r214411102 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala --- @@ -51,6 +51,7

[GitHub] spark pull request #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.mem...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22298#discussion_r214410560 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala --- @@ -225,6 +225,13 @@ private[spark] object

[GitHub] spark pull request #22256: [SPARK-25262][K8S] Better support configurability...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22256#discussion_r214395067 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/LocalDirsFeatureStep.scala --- @@ -37,41 +40,99

[GitHub] spark pull request #22289: [SPARK-25200][YARN] Allow specifying HADOOP_CONF_...

2018-08-31 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22289#discussion_r214381467 --- Diff: launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java --- @@ -200,6 +200,7 @@ void addOptionString(List cmd, String

[GitHub] spark pull request #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.mem...

2018-08-30 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22298#discussion_r214243652 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/SecretsTestsSuite.scala

[GitHub] spark issue #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.memory lim...

2018-08-30 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22298 @rdblue @holdenk for review. This contains both unit and integration tests that verify [SPARK-25004] for K8S

[GitHub] spark pull request #22298: [SPARK-25021][K8S] Add spark.executor.pyspark.mem...

2018-08-30 Thread ifilonenko
GitHub user ifilonenko opened a pull request: https://github.com/apache/spark/pull/22298 [SPARK-25021][K8S] Add spark.executor.pyspark.memory limit for K8S ## What changes were proposed in this pull request? Add spark.executor.pyspark.memory limit for K8S ## How

[GitHub] spark pull request #22256: [SPARK-25262][K8S] Better support configurability...

2018-08-29 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22256#discussion_r213768267 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/LocalDirsFeatureStep.scala --- @@ -37,41 +40,99

[GitHub] spark issue #22257: [SPARK-25264][K8S] Fix comma-delineated arguments passed...

2018-08-28 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22257 Ready for merge @holdenk @mccheah --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands

[GitHub] spark issue #22257: [SPARK-25264][K8S] Fix comma-delineated arguments passed...

2018-08-28 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22257 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark issue #22257: [SPARK-25264][K8S] Fix comma-delineated arguments passed...

2018-08-28 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22257 @shaneknapp we seem to be having some minikube issues with the testing env :( --- - To unsubscribe, e-mail: reviews

[GitHub] spark issue #22257: [SPARK-25264][K8S] Fix comma-delineated arguments passed...

2018-08-28 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22257 @liyinan926 @u2takey for review @mccheah for merge --- - To unsubscribe, e-mail: reviews-unsubscr

[GitHub] spark pull request #22257: [SPARK-25264][K8S] Fix comma-delineated arguments...

2018-08-28 Thread ifilonenko
GitHub user ifilonenko opened a pull request: https://github.com/apache/spark/pull/22257 [SPARK-25264][K8S] Fix comma-delineated arguments passed into PythonRunner and RRunner ## What changes were proposed in this pull request? Fixes the issue brought up in https

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-08-27 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r213064784 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala --- @@ -81,9 +95,12

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-08-27 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r213064103 --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesDriverSpec.scala --- @@ -24,8 +24,9 @@ private[spark

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-08-27 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r213061625 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PodTemplateSuite.scala --- @@ -0,0

[GitHub] spark pull request #22146: [SPARK-24434][K8S] pod template files

2018-08-27 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/22146#discussion_r213060443 --- Diff: resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/PodTemplateSuite.scala --- @@ -0,0

[GitHub] spark issue #22146: [SPARK-24434][K8S] pod template files

2018-08-26 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22146 retest this please --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail

[GitHub] spark pull request #21669: [SPARK-23257][K8S][WIP] Kerberos Support for Spar...

2018-08-25 Thread ifilonenko
Github user ifilonenko commented on a diff in the pull request: https://github.com/apache/spark/pull/21669#discussion_r212812762 --- Diff: resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile --- @@ -43,6 +43,10 @@ COPY sbin /opt/spark/sbin COPY

[GitHub] spark issue #22145: [SPARK-25152][K8S] Enable SparkR Integration Tests for K...

2018-08-19 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/22145 This PR should fail integration tests rn, until the Jenkins OS is updated, but error right now is in terms of the minikube environment: `Error creating VM: virError(Code=55, Domain=19

[GitHub] spark pull request #22145: [SPARK-25152][K8S] Enable SparkR Integration Test...

2018-08-19 Thread ifilonenko
GitHub user ifilonenko opened a pull request: https://github.com/apache/spark/pull/22145 [SPARK-25152][K8S] Enable SparkR Integration Tests for Kubernetes ## What changes were proposed in this pull request? Re-introduced SparkR integration tests as part of the SparkR

[GitHub] spark issue #21584: [SPARK-24433][K8S] Initial R Bindings for SparkR on K8s

2018-08-16 Thread ifilonenko
Github user ifilonenko commented on the issue: https://github.com/apache/spark/pull/21584 This PR has been updated to pass Jenkins by removing the `with RTestsSuite` line in `KubernetesSuite`. As such, this feature may be merged and the `with RTestsSuite` will be re-included

<    1   2   3   4   >