GitHub user janewangfb opened a pull request:
https://github.com/apache/spark/pull/19221
[SPARK-4131] Merge HiveTmpFile.scala to SaveAsHiveFile.scala
## What changes were proposed in this pull request?
The code is already merged to master:
https://github.com/apache
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r138681313
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137929328
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137929284
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1512,4 +1512,81 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137929108
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
---
@@ -0,0 +1,82
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137929091
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1512,4 +1512,81 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137929053
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -360,6 +360,31 @@ case class
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137929022
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -192,12 +245,23 @@ class AstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137929025
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -192,12 +245,23 @@ class AstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137929001
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -192,12 +245,23 @@ class AstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137918600
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,131 @@
+/*
+ * Licensed
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137916528
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -534,4 +534,176 @@ class InsertIntoHiveTableSuite extends QueryTest
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137916510
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -360,6 +360,31 @@ case class
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137629284
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -534,4 +534,150 @@ class InsertIntoHiveTableSuite extends QueryTest
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137607929
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
---
@@ -0,0 +1,81
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137607749
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
---
@@ -0,0 +1,81
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137607545
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137607475
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137606401
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137605940
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTmpPath.scala
---
@@ -0,0 +1,202 @@
+/*
+ * Licensed to the Apache
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137605602
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala ---
@@ -366,4 +367,43 @@ class InsertSuite extends DataSourceTest
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137605509
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -140,6 +143,14 @@ case class
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137605311
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala
---
@@ -524,6 +525,50 @@ class DDLParserSuite extends
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137601757
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala
---
@@ -524,6 +525,50 @@ class DDLParserSuite extends
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137601572
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala
---
@@ -524,6 +525,50 @@ class DDLParserSuite extends
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137601380
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala
---
@@ -32,7 +32,8 @@ import
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137406552
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -2346,6 +2347,45 @@ abstract class DDLSuite extends
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137406502
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala
---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137401720
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala
---
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137401187
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -234,12 +82,8 @@ case class InsertIntoHiveTable
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137399408
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTmpPath.scala
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137398917
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -360,6 +360,27 @@ case class
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137398869
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -360,6 +360,27 @@ case class
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137398776
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveTmpPath.scala
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137398299
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -178,11 +179,60 @@ class AstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137397811
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -178,11 +179,60 @@ class AstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137106989
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -241,11 +241,21 @@ query
: ctes? queryNoWith
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r13706
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -534,4 +534,132 @@ class InsertIntoHiveTableSuite extends QueryTest
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137063137
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -534,4 +534,132 @@ class InsertIntoHiveTableSuite extends QueryTest
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137063179
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -534,4 +534,132 @@ class InsertIntoHiveTableSuite extends QueryTest
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137063033
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -534,4 +534,132 @@ class InsertIntoHiveTableSuite extends QueryTest
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137062047
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137061444
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137060998
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
---
@@ -0,0 +1,81
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137060557
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1509,4 +1509,86 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137058514
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1509,4 +1509,86 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r137057860
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -178,11 +179,50 @@ class AstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136724258
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -178,11 +179,50 @@ class AstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136724143
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -178,11 +179,50 @@ class AstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136685529
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,134 @@
+/*
+ * Licensed
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136682501
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -241,11 +241,21 @@ query
: ctes? queryNoWith
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136681607
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
---
@@ -0,0 +1,73
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136681131
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,134 @@
+/*
+ * Licensed
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136680981
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,134 @@
+/*
+ * Licensed
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136680384
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -534,4 +534,115 @@ class InsertIntoHiveTableSuite extends QueryTest
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136680298
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -140,6 +141,10 @@ case class
Github user janewangfb commented on the issue:
https://github.com/apache/spark/pull/18975
Jenkin test please!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136443263
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
---
@@ -0,0 +1,68
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136439466
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -534,4 +534,83 @@ class InsertIntoHiveTableSuite extends QueryTest
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136436585
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala ---
@@ -534,4 +534,83 @@ class InsertIntoHiveTableSuite extends QueryTest
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136421034
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
---
@@ -0,0 +1,65
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136419843
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,118 @@
+/*
+ * Licensed
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136418390
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -155,6 +156,9 @@ object HiveAnalysis extends Rule[LogicalPlan
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136418037
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -140,6 +141,9 @@ case class
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r136417593
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1509,4 +1509,84 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user janewangfb commented on the issue:
https://github.com/apache/spark/pull/18975
@gatorsmile can you please review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134905838
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1509,4 +1509,84 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134847542
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -2040,4 +2040,83 @@ class SQLQuerySuite extends
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134845802
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -2040,4 +2040,83 @@ class SQLQuerySuite extends
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134845628
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1509,4 +1509,84 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134844461
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
---
@@ -0,0 +1,67
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134843683
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
---
@@ -0,0 +1,67
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134842881
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1509,4 +1509,84 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134842831
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1509,4 +1509,84 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134842420
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -359,6 +359,18 @@ case class
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18492#discussion_r134637603
--- Diff:
core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala ---
@@ -188,6 +188,40 @@ class ExecutorAllocationManagerSuite
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18492#discussion_r134574304
--- Diff:
core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala ---
@@ -188,6 +188,40 @@ class ExecutorAllocationManagerSuite
Github user janewangfb commented on the issue:
https://github.com/apache/spark/pull/18975
Jenkin test please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user janewangfb commented on the issue:
https://github.com/apache/spark/pull/18975
@gatorsmile plan-pasring unittests are already added in DDLCommandSuite.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134383117
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -142,10 +142,14 @@ object
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134382990
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
---
@@ -0,0 +1,65
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134383033
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1509,4 +1509,84 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134382855
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -2040,4 +2040,80 @@ class SQLQuerySuite extends
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134382822
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -2040,4 +2040,80 @@ class SQLQuerySuite extends
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134382831
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
@@ -2040,4 +2040,80 @@ class SQLQuerySuite extends
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134382724
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134382590
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveDirCommand.scala
---
@@ -0,0 +1,109 @@
+/*
+ * Licensed
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134382618
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/InsertIntoDataSourceDirCommand.scala
---
@@ -0,0 +1,65
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134381632
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -359,6 +359,17 @@ case class
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134381489
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -740,6 +750,7 @@ nonReserved
| AND | CASE | CAST
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18492#discussion_r134336371
--- Diff:
core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala ---
@@ -188,6 +188,40 @@ class ExecutorAllocationManagerSuite
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18492#discussion_r134334889
--- Diff:
core/src/test/scala/org/apache/spark/ExecutorAllocationManagerSuite.scala ---
@@ -188,6 +188,40 @@ class ExecutorAllocationManagerSuite
Github user janewangfb commented on the issue:
https://github.com/apache/spark/pull/18975
Added the support for write out data source format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user janewangfb reopened a pull request:
https://github.com/apache/spark/pull/18975
[SPARK-4131] Support "Writing data into the filesystem from queries"
## What changes were proposed in this pull request?
This PR implements the sql feature:
INSERT
Github user janewangfb commented on the issue:
https://github.com/apache/spark/pull/18975
still need to implement the data source table portion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user janewangfb closed the pull request at:
https://github.com/apache/spark/pull/18975
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18975#discussion_r134030622
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -1499,4 +1500,34 @@ class SparkSqlAstBuilder(conf: SQLConf
Github user janewangfb commented on the issue:
https://github.com/apache/spark/pull/18975
@gatorsmile Originally, because we have alot of hive sqls that we wanted to
support in spark, I implemented hive syntax for this command:
https://cwiki.apache.org/confluence/display/Hive
GitHub user janewangfb opened a pull request:
https://github.com/apache/spark/pull/18975
[SPARK-4131] Support "Writing data into the filesystem from queries"
## What changes were proposed in this pull request?
This PR implements the sql feature:
INSERT OVERWR
Github user janewangfb commented on a diff in the pull request:
https://github.com/apache/spark/pull/18492#discussion_r133786071
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/SparkListener.scala ---
@@ -291,6 +294,11 @@ private[spark] trait SparkListenerInterface
1 - 100 of 189 matches
Mail list logo
